Re: [openstack-dev] patches for simple typo fixes

2017-09-26 Thread Jay S Bryant
On 9/25/2017 7:24 AM, Sean Dague wrote: On 09/25/2017 07:56 AM, Chris Dent wrote: On Fri, 22 Sep 2017, Paul Belanger wrote: This is not a good example of encouraging anybody to contribute to the project. Yes. This entire thread was a bit disturbing to read. Yes, I totally agree that mass

Re: [openstack-dev] patches for simple typo fixes

2017-09-26 Thread Joshua Harlow
Sean Dague wrote: I think the concern is the ascribed motive for why people are putting these up. That's fine to feel that people are stat padding (and that too many things are driven off metrics). But, honestly, that's only important if we make it important. Contributor stats are always going

Re: [openstack-dev] patches for simple typo fixes

2017-09-26 Thread Amrith Kumar
Sean, Each fix is a valid change, in and of itself. But what kind of lazy person would fix (in three patches) the exact same thing, in three places in a single project? Or which person would submit the exact same kind of patch multiple times to change URL's from http:// to https:// in places

Re: [openstack-dev] patches for simple typo fixes

2017-09-26 Thread Amrith Kumar
Sean, I quantified it in 2016 for some of the patches that came in to Trove; approximately 130 hours of CI time per patch given the number of hacks that the person took before even getting pep8 to run. Close to a release boundary, that had very bad results on an already fragile Trove gate.

Re: [openstack-dev] patches for simple typo fixes

2017-09-25 Thread Flavio Percoco
On 25/09/17 09:28 -0400, Doug Hellmann wrote: Excerpts from Sean Dague's message of 2017-09-25 08:24:18 -0400: On 09/25/2017 07:56 AM, Chris Dent wrote: > On Fri, 22 Sep 2017, Paul Belanger wrote: > >> This is not a good example of encouraging anybody to contribute to the >> project. > > Yes.

Re: [openstack-dev] patches for simple typo fixes

2017-09-25 Thread Julien Danjou
On Mon, Sep 25 2017, Doug Hellmann wrote: >> I was trying to ignore the thread in the hopes it would die out quick. >> But torches and pitchforks all came out from the far corners, so I'm >> going to push back on that a bit. >> >> I'm not super clear why there is always so much outrage about

Re: [openstack-dev] patches for simple typo fixes

2017-09-25 Thread Doug Hellmann
Excerpts from Sean Dague's message of 2017-09-25 09:42:08 -0400: > On 09/25/2017 09:28 AM, Doug Hellmann wrote: > > > I'm less concerned with the motivation of someone submitting the > > patches than I am with their effect. Just like the situation we had > > with the bug squash days a year or so

Re: [openstack-dev] patches for simple typo fixes

2017-09-25 Thread Sean Dague
On 09/25/2017 09:28 AM, Doug Hellmann wrote: > I'm less concerned with the motivation of someone submitting the > patches than I am with their effect. Just like the situation we had > with the bug squash days a year or so ago, if we had a poorly timed > set of these trivial patches coming in at

Re: [openstack-dev] patches for simple typo fixes

2017-09-25 Thread Doug Hellmann
Excerpts from Sean Dague's message of 2017-09-25 08:24:18 -0400: > On 09/25/2017 07:56 AM, Chris Dent wrote: > > On Fri, 22 Sep 2017, Paul Belanger wrote: > > > >> This is not a good example of encouraging anybody to contribute to the > >> project. > > > > Yes. This entire thread was a bit

Re: [openstack-dev] patches for simple typo fixes

2017-09-25 Thread Sean Dague
On 09/25/2017 07:56 AM, Chris Dent wrote: > On Fri, 22 Sep 2017, Paul Belanger wrote: > >> This is not a good example of encouraging anybody to contribute to the >> project. > > Yes. This entire thread was a bit disturbing to read. Yes, I totally > agree that mass patches that do very little are