So after over 20 messages in this thread, now what?
From my count we have 3 -, and 12 +1s. Is that enough for consensus? Do we
move modelines lines to the bottom? Put them in every file? Or just remove
them?
On 28 October 2013 23:54, Joe Gordon joe.gord...@gmail.com wrote:
We don't just gate without telling people, the first two items in hacking
are read pep8
http://docs.openstack.org/developer/hacking/
The gate is super useful, but it's reactive, not proactive. And good
documentation isn't a
On Tue, Oct 29, 2013 at 11:17 AM, Robert Collins
robe...@robertcollins.netwrote:
On 28 October 2013 23:54, Joe Gordon joe.gord...@gmail.com wrote:
We don't just gate without telling people, the first two items in hacking
are read pep8
http://docs.openstack.org/developer/hacking/
The
On 10/29/13 at 10:53am, Joe Gordon wrote:
So after over 20 messages in this thread, now what?
From my count we have 3 -, and 12 +1s. Is that enough for consensus? Do we
move modelines lines to the bottom? Put them in every file? Or just remove
them?
I have no strong feeling either way on
On Thu, Oct 24, 2013 at 2:48 PM, Robert Collins
robe...@robertcollins.netwrote:
*) They help casual contributors *more* than long time core
contributors : and those are the folk that are most likely to give up
and walk away. Keeping barriers to entry low is an important part of
making
As a new OpenStack contributor, +1 for lower barriers to entry. It's
helpful for OS to inform editor style and I don't believe in the
arguments to remove them.
Why remove them?
* we could shrink our codebase by a little bit.
Why do you want to shrink it? Simplify, sure, but modelines are not
If someone takes effort to learn Vim to the point when he/she develops code
in it, they most definitely have their preferred settings already, why
overwrite them? If those settings conflict with the style guide -- it has
been said, pep8 and hacking check will notify.
I always thought that leaving
-1
Slight preference for keeping them. I personally would go the other way and
just add them everywhere.
- Original Message -
From: Joe Gordon joe.gord...@gmail.com
To: OpenStack Development Mailing List openstack-dev@lists.openstack.org
Sent: Thursday, October 24, 2013 8:38:57 AM
On Oct 25, 2013 12:24 PM, Dan Prince dpri...@redhat.com wrote:
-1
Slight preference for keeping them. I personally would go the other way
and just add them everywhere.
May I ask why? Do you use the modeline?
- Original Message -
From: Joe Gordon joe.gord...@gmail.com
To:
After reading the article Joe linked https://wiki.python.org/moin/Vim I
created a python.vim in my ~/.vim/ftplugin directory. I also have tabstop
defaults set in my .vimrc for global defaults that are different from
python preferences. So I get to keep my preferences for other stuff while
making
On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins
robe...@robertcollins.netwrote:
*) They help casual contributors *more* than long time core
contributors : and those are the folk that are most likely to give up
and walk away. Keeping barriers to entry low is an important part of
making
On Fri, Oct 25, 2013 at 2:43 PM, Robert Collins
robe...@robertcollins.netwrote:
On 26 October 2013 08:40, Dolph Mathews dolph.math...@gmail.com wrote:
On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins
robe...@robertcollins.net
wrote:
*) They help casual contributors *more* than long
On Fri, Oct 25, 2013 at 2:43 PM, Robert Collins
robe...@robertcollins.netwrote:
On 26 October 2013 08:40, Dolph Mathews dolph.math...@gmail.com wrote:
I'm all for low barriers of entry, so if there's
any evidence that this is true, I'd want to make them more prolific.
I'm not sure how to
On 10/25/2013 03:43 PM, Robert Collins wrote:
On 26 October 2013 08:40, Dolph Mathews dolph.math...@gmail.com wrote:
On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins robe...@robertcollins.net
wrote:
*) They help casual contributors *more* than long time core
contributors : and those are the
Interesting Background Information:
Why do we have modelines?
Termie put them in all the files of the first version of nova
Why did he put in modelines instead of configuring his editor?
Termie does a lot of python coding and he prefers a tabstop of 2 on all his
personal projects[1]
I really
On 10/24/2013 08:38 AM, Joe Gordon wrote:
Since the beginning of OpenStack we have had vim modelines all over the
codebase, but after seeing this
patch https://review.opeenstack.org/#/c/50891/
https://review.openstack.org/#/c/50891/ I took a further look into vim
modelines and think we
+1 to remove them.
-- dims
On Thu, Oct 24, 2013 at 8:44 AM, Monty Taylor mord...@inaugust.com wrote:
On 10/24/2013 08:38 AM, Joe Gordon wrote:
Since the beginning of OpenStack we have had vim modelines all over the
codebase, but after seeing this
patch
On 24/10/13 13:38 +0100, Joe Gordon wrote:
Since the beginning of OpenStack we have had vim modelines all over the
codebase, but after seeing this patch https://review.opeenstack.org/#/c/50891/
I took a further look into vim modelines and think we should remove them.
Before going any further, I
+1 on the topic
How about we catch them in hacking so that they won't ever come back?
On Thu, Oct 24, 2013 at 4:53 PM, Davanum Srinivas dava...@gmail.com wrote:
+1 to remove them.
-- dims
On Thu, Oct 24, 2013 at 8:44 AM, Monty Taylor mord...@inaugust.com
wrote:
On 10/24/2013 08:38
On 10/24/2013 08:38 AM, Joe Gordon wrote:
Why remove them?
* Modelines aren't supported by default in debian or ubuntu due to
security reasons: https://wiki.python.org/moin/Vim
* Having modelines for vim means if someone wants we should support
modelines for emacs
+1 and likely this should be added to hacking so they don't sneak back in
by accident / reviewers missing the line since we've had them for do long.
On Thursday, October 24, 2013, Flavio Percoco wrote:
On 24/10/13 13:38 +0100, Joe Gordon wrote:
Since the beginning of OpenStack we have had vim
I guess I get to buck the trend :).
On 25 October 2013 01:38, Joe Gordon joe.gord...@gmail.com wrote:
Since the beginning of OpenStack we have had vim modelines all over the
codebase, but after seeing this patch
https://review.opeenstack.org/#/c/50891/ I took a further look into vim
modelines
22 matches
Mail list logo
