Re: [openstack-dev] [nova][ironic] what to do with unit test failures from ironic api contract

2014-06-16 Thread Day, Phil
From: David Shrewsbury [mailto:shrewsbury.d...@gmail.com] Sent: 14 June 2014 02:10 To: OpenStack Development Mailing List (not for usage questions) Cc: Shrewsbury, David; Van Der Veen, Devananda Subject: Re: [openstack-dev] [nova][ironic] what to do with unit test failures from ironic api

[openstack-dev] [nova][ironic] what to do with unit test failures from ironic api contract

2014-06-13 Thread Day, Phil
Hi Folks, A recent change introduced a unit test to warn/notify developers when they make a change which will break the out of tree Ironic virt driver: https://review.openstack.org/#/c/98201 Ok - so my change (https://review.openstack.org/#/c/68942) broke it as it adds some extra parameters

Re: [openstack-dev] [nova][ironic] what to do with unit test failures from ironic api contract

2014-06-13 Thread David Shrewsbury
Hi! On Fri, Jun 13, 2014 at 9:30 AM, Day, Phil philip@hp.com wrote: Hi Folks, A recent change introduced a unit test to “warn/notify developers” when they make a change which will break the out of tree Ironic virt driver: https://review.openstack.org/#/c/98201 Ok – so my change