Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

Not only Mark is usable, there is also TOS, MSS and other flags that may be interesting. So having separate parameter for each makes configuration more complex. On Wed, Aug 31, 2011 at 9:38 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash:

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/08/11 20:27, Alon Bar-Lev wrote: > Maybe should extend the usage of parameter "socket-flags"? I considered that too, but that would require a bigger rewrite of the - --socket-flags parser. Currently it only is doing "boolean flags". And as -

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

Maybe should extend the usage of parameter "socket-flags"? On Wed, Aug 31, 2011 at 9:05 PM, Heiko Hund wrote: > Signed-off-by: Heiko Hund > --- >  init.c    |    1 + >  openvpn.8 |    6 ++ >  options.c |   14 ++ >  options.h |    3

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/08/11 20:05, Heiko Hund wrote: > Signed-off-by: Heiko Hund > --- > init.c|1 + > openvpn.8 |6 ++ > options.c | 14 ++ > options.h |3 +++ > socket.c | 13 + > socket.h |

[Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

Signed-off-by: Heiko Hund --- init.c|1 + openvpn.8 |6 ++ options.c | 14 ++ options.h |3 +++ socket.c | 13 + socket.h |1 + 6 files changed, 38 insertions(+), 0 deletions(-) diff --git a/init.c b/init.c index

Re: [Openvpn-devel] [PATCH] lowercase include header name in syshead.h

Hi, On Wed, Aug 31, 2011 at 02:38:08PM +, Heiko Hund wrote: > Cross compiling for Windows is broken since commit > 739fa9881f12e67dc8b9cadc7230e59e7fe42423 added the mixed > case header name "NtDDNdis.h" to the file. While this header > exists in a MinGW build environment it's lowercase

Re: [Openvpn-devel] [PATCH] lowercase include header name in syshead.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/08/11 16:38, Heiko Hund wrote: > Cross compiling for Windows is broken since commit > 739fa9881f12e67dc8b9cadc7230e59e7fe42423 added the mixed > case header name "NtDDNdis.h" to the file. While this header > exists in a MinGW build environment

[Openvpn-devel] [PATCH] lowercase include header name in syshead.h

Cross compiling for Windows is broken since commit 739fa9881f12e67dc8b9cadc7230e59e7fe42423 added the mixed case header name "NtDDNdis.h" to the file. While this header exists in a MinGW build environment it's lowercase there. Windows doesn't mind the case of a file name, but Linux does. So,

[Openvpn-devel] [PATCH-UPDATE] define IN6_ARE_ADDR_EQUAL macro for WIN32

Windows headers do not define the IN6_ARE_ADDR_EQUAL macro. It needs to be defined locally when building for WIN32. Signed-off-by: Heiko Hund Update: remove check for USE_PF_INET6 since commit eb23089183745853fac9414d45a559a478ef51d6 removed the definition of this macro.

Re: [Openvpn-devel] [PATCH] Added whitespace handling for $KEY_CONFIG variable in easy-rsa/2.0/vars

> ACK! That makes sense to me. But it needs to be clearly visible in some > kind of requirements list. If we don't have that, that's probably > something we should have. You could even start your shell scripts with something like: test "x$(pwd)" = "x`pwd`" || (echo "This shell is not good

Re: [Openvpn-devel] [PATCH] Added whitespace handling for $KEY_CONFIG variable in easy-rsa/2.0/vars

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/08/11 07:58, Samuli Seppänen wrote: > >> Hi, >> >> On Fri, Aug 26, 2011 at 10:07:00AM -0400, Stefan Monnier wrote: >>> POSIX mandates $() so any posix shell will support it. The issue is >>> with non-POSIX shells, if you do want to support

Re: [Openvpn-devel] [PATCH] Added whitespace handling for $KEY_CONFIG variable in easy-rsa/2.0/vars

> Hi, > > On Fri, Aug 26, 2011 at 10:07:00AM -0400, Stefan Monnier wrote: >> POSIX mandates $() so any posix shell will support it. The issue is >> with non-POSIX shells, if you do want to support them (e.g. Solaris's >> /bin/sh). > I'd rather not go down that rat-hole. Even Solaris has