Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Gert Doering
Hi, On Wed, Dec 04, 2013 at 06:22:04PM +0600, ??? wrote: > I've looked through the code and I do not understand why do we need > that temporary directory on windows platfrom ? > anyone can explain idea behind initializing tmp-dir ? especially on > Windows platform. tmp-dir is used to cre

[Openvpn-devel] uninitialized handle fix (serious issue on Win 8.1)

2013-12-04 Thread Илья Шипицин
Hello! I confirm issue described here: https://forums.openvpn.net/topic13246.html also, I confirm that it is due to random handle value (which somehow was null before Win 8.1 was released) also, I do not understand why we should check "err" handle on INVALID_HANDLE_VALUE, it will fail anyway on W

Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Илья Шипицин
I've looked through the code and I do not understand why do we need that temporary directory on windows platfrom ? anyone can explain idea behind initializing tmp-dir ? especially on Windows platform. 2013/12/4 Jonathan K. Bullard : > On Wed, Dec 4, 2013 at 4:35 AM, Matthias Andree > wrote: >> >>

Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Jonathan K. Bullard
On Wed, Dec 4, 2013 at 4:35 AM, Matthias Andree wrote: > Am 19.11.2013 18:36, schrieb Heiko Hund: > > + msg (M_WARN, "Could not get temporary directory. Path is too > long." > > + " Consider to use --tmp-dir"); > > I think when touching the code, we ought to change all occurrences t

Re: [Openvpn-devel] [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Matthias Andree
I also found http://moser-isi.ethz.ch/docs/english_verb_inf_ing.pdf after my earlier post.

[Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Matthias Andree
Am 19.11.2013 18:36, schrieb Heiko Hund: > Get the temporary path from the system as UCS-2 and convert it to > UTF-8 and return that for internal use. > > Signed-off-by: Heiko Hund > + msg (M_WARN, "Could not find a suitable temporary directory." > + " (GetTempPath() failed). Con

Re: [Openvpn-devel] [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Gert Doering
Hi, On Wed, Dec 04, 2013 at 02:19:20PM +0600, ??? wrote: > I confirm such a bug. Patch resolves it. > still not commited to https://github.com/openvpn/openvpn ? Waiting for an ACK from Samuli, tbh... gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Илья Шипицин
I confirm such a bug. Patch resolves it. still not commited to https://github.com/openvpn/openvpn ? 2013/11/19 Heiko Hund : > Get the temporary path from the system as UCS-2 and convert it to > UTF-8 and return that for internal use. > > Signed-off-by: Heiko Hund > --- > src/openvpn/win32.c |