Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Gert Doering
Hi, On Sat, Aug 28, 2021 at 10:49:42AM -0400, Selva Nair wrote: > On Sat, Aug 28, 2021 at 9:29 AM Gert Doering wrote: > > > On Sat, Aug 28, 2021 at 10:51:58AM +0200, Matthias Andree wrote: > > > Do we need to maintain C89 compatibility these days? > > No. C99 is fully acceptable. > > But our c

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Selva Nair
Hi On Sat, Aug 28, 2021 at 9:29 AM Gert Doering wrote: > Hi, > > On Sat, Aug 28, 2021 at 10:51:58AM +0200, Matthias Andree wrote: > > Do we need to maintain C89 compatibility these days? > > No. C99 is fully acceptable. > But our coding style still has to be followed. That means /* */ comments

[Openvpn-devel] [PATCH applied] Re: man/protocol-options: add missing ending metachar

2021-08-28 Thread Gert Doering
Acked-by: Gert Doering "obviously correct" :-) Your patch has been applied to the master branch. commit 5a5d11a0dea51e709b44dfabc1ec97b5f3c5b222 (master) Author: Antonio Quartulli Date: Fri Aug 27 16:56:56 2021 +0200 man/protocol-options: add missing ending metachar Signed-off-by:

[Openvpn-devel] [PATCH applied] Re: route.c: pass the right parameter to IN6_IS_ADDR_UNSPECIFIED

2021-08-28 Thread Gert Doering
I have not tested this beyond "openvpn --show-gateway", and that one still works :-) - also, we've discussed this on IRC before. Your patch has been applied to the master and release/2.5 branch (bugfix). 2.4 does not contain the offending code. commit aa0e44e235f7bee0e12707b6899d00bad85195fc (ma

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Gert Doering
Hi, On Sat, Aug 28, 2021 at 10:51:58AM +0200, Matthias Andree wrote: > Do we need to maintain C89 compatibility these days? No. C99 is fully acceptable. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Matthias Andree
Am 27.08.21 um 21:00 schrieb Antonio Quartulli: > OpenVPN shipped a small packet filtering tool called PF. It has never > been straightforward as it required a plugin to work. On top of that, > keeping PF support, makes the code more complicated and increases the > maintenance cost of OpenVPN. > >