[Openvpn-devel] [PATCH] cipher-negotiation.rst missing from doc/Makefile.am

From: Jan Mikkelsen Signed-off-by: Jan Mikkelsen Acked-by: Frank Lichtenheld --- doc/Makefile.am | 1 + 1 file changed, 1 insertion(+) I have reformatted this with git-format-patch to make the patch easier to apply. Also checked that this is indeed the only missing file currently. diff

[Openvpn-devel] [PATCH] cipher-negotiation.rst missing from doc/Makefile.am

Hi, The file doc/man-sections/cipher-negotiation.rst is missing from the from the openvpn-2.5.6 source tarball, making it hard to rebuild the openvpn(8) man page from source. That file is also missing from the "openvpn_sections" assignment in doc/Makefile, meaning that the openvpn(8) man page

Re: [Openvpn-devel] [PATCH] uncrustify: have exactly one newline at the end of files

Hi, On 18/05/2022 12:51, Frank Lichtenheld wrote: Avoid the ugly "No newline at end of file" in git diffs. Signed-off-by: Frank Lichtenheld It does what we want. Acked-by: Antonio Quartulli --- dev-tools/uncrustify.conf | 2 ++ src/compat/compat-daemon.c | 1 -

Re: [Openvpn-devel] [PATCH] pre-commit: uncrustify based on staged changes

Hi, On 18/05/2022 15:51, Heiko Hund wrote: [CUT] Hope that explains it. Thanks, it makes sense. Acked-by: Antonio Quartulli -- Antonio Quartulli ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

Re: [Openvpn-devel] [PATCH] pre-commit: uncrustify based on staged changes

Hi On Mittwoch, 18. Mai 2022 15:35:58 CEST Antonio Quartulli wrote: > > -# does not match any of the extensions specified in $FILE_EXTS > > +# does not match the extensions .c or .h > > is this unrelated? Yes, it is. The original script (collection) has a config file where $FILE_EXTS

Re: [Openvpn-devel] [PATCH] pre-commit: uncrustify based on staged changes

Hi, On 17/05/2022 23:01, Heiko Hund wrote: Previously the generated patch was based on the file(s) in the working directory. This is a problem if you have not to be commited changes there and these changes fix formatting issues that exist in the staging area. This effectively circumventes the

[Openvpn-devel] Summary of the community meeting (18th May 2022)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 18th May 2022 Time: 10:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local meeting

Re: [Openvpn-devel] [PATCH 3/4] Implement AUTH_FAIL, TEMP message support

Documentation-only review. > Arne Schwabe hat am 18.05.2022 11:32 geschrieben: > This allows a server to indicate a temporary problem on the server and > allows the server to indicate how to proceed (i.e. move to the next server, > retry the same server, wait a certain time,...) > > This adds

[Openvpn-devel] [PATCH] uncrustify: have exactly one newline at the end of files

Avoid the ugly "No newline at end of file" in git diffs. Signed-off-by: Frank Lichtenheld --- dev-tools/uncrustify.conf | 2 ++ src/compat/compat-daemon.c | 1 - src/openvpn/ssl_ncp.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dev-tools/uncrustify.conf

Re: [Openvpn-devel] [PATCH 2/4] Cleanup receive_auth_failed and simplify method

Patch looks reasonable when looking at it with -w. But I have some suggestions to further simplify the function. See below. > Arne Schwabe hat am 18.05.2022 11:32 geschrieben: > This simplifies the buffer handling in the method and adds a quick > return instead of wrapping the whole method in a

Re: [Openvpn-devel] [PATCH 1/4] Implement exit notification via control channel

> Arne Schwabe hat am 18.05.2022 11:32 geschrieben: > Current exit notification relies on data channel messages with specific > prefix. Adding these to new data channel modules (DCO) adds uncessary "unnecessary" > complexity for the data for messages that from their idea belong to the > control

Re: [Openvpn-devel] [PATCH] pre-commit: uncrustify based on staged changes

Acked-By: Frank Lichtenheld Tested various combinations of workspace changes and index changes and it seems to do what it should do. > Heiko Hund hat am 17.05.2022 23:01 geschrieben: > > > Previously the generated patch was based on the file(s) in the working > directory. This is a problem

Re: [Openvpn-devel] [PATCH applied] Re: Add message when decoding PKCS12 file fails.

Hi, decided in the community meeting today that this should also be cherry-picked to 2.5 - I have not actually tested with a pkcs12 file, just run the basic compile/client test cycle (and the patch is trivial enough). commit 1f54811e92c89fe07d7cea8339e928980bfe0536 (HEAD -> release/2.5) Author:

[Openvpn-devel] [PATCH 3/4] Implement AUTH_FAIL, TEMP message support

This allows a server to indicate a temporary problem on the server and allows the server to indicate how to proceed (i.e. move to the next server, retry the same server, wait a certain time,...) This adds options_utils.c/h to be able to unit test the new function. ---

[Openvpn-devel] [PATCH 4/4] Allow scripts and plugins to set a custom AUTH_FAILED message

This is currently only possible when using the management interface and the client-deny functionality. --- src/openvpn/ssl_common.h | 1 + src/openvpn/ssl_verify.c | 74 ++-- 2 files changed, 73 insertions(+), 2 deletions(-) diff --git

[Openvpn-devel] [PATCH 1/4] Implement exit notification via control channel

Current exit notification relies on data channel messages with specific prefix. Adding these to new data channel modules (DCO) adds uncessary complexity for the data for messages that from their idea belong to the control channel anyway. This patch adds announcing support for control channel and

[Openvpn-devel] [PATCH 0/4] Implement exit notifcation via control channel and temporary AUTH_FAIL

This patchset consts of three patches and one small clean up patches. The first patch deals with exit notification via control channel instead of using OCC data message if both peers support it. This is need to avoid implementing OCC exit messages in DCO implementation. In p2p mode this is also