Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback

2023-09-04 Thread Jeremy Fleischman
> I have a feeling we're missing a check here. Got it! You're right, I've added that in the v2 version of this patch (see below). diff --git a/src/python/openvpn3/SessionManager.py b/src/python/openvpn3/SessionManager.py index 3632790..a175015 100644 --- a/src/python/openvpn3/SessionManager.py

Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback

2023-09-04 Thread David Sommerseth
On 04/09/2023 23:27, Jeremy Fleischman wrote: elif (cbfnc is not None and self.__log_callback is not None): # In this case, the program must first disable the # current LogCallback() before setting a new one. raise RuntimeError('LogCallback() is already

Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback

2023-09-04 Thread Jeremy Fleischman
> elif (cbfnc is not None and self.__log_callback is not None): > # In this case, the program must first disable the > # current LogCallback() before setting a new one. > raise RuntimeError('LogCallback() is already enabled') > > This should enforce only one

Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback

2023-09-04 Thread David Sommerseth
[re-sent to ML] On 04/09/2023 19:51, Jeremy Fleischman wrote: diff --git a/src/python/openvpn3/SessionManager.py b/src/python/openvpn3/SessionManager.py index 3632790..1a567be 100644 --- a/src/python/openvpn3/SessionManager.py +++ b/src/python/openvpn3/SessionManager.py @@ -114,6 +114,7 @@ def

Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback

2023-09-04 Thread Jeremy Fleischman
> diff --git a/src/python/openvpn3/SessionManager.py > b/src/python/openvpn3/SessionManager.py > index 3632790..1a567be 100644 > --- a/src/python/openvpn3/SessionManager.py > +++ b/src/python/openvpn3/SessionManager.py > @@ -114,6 +114,7 @@ def __init__(self, dbuscon, objpath): >

Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback

2023-09-04 Thread Jeremy Fleischman
Hey David, On Sun, Sep 3, 2023 at 3:56 PM David Sommerseth wrote: > > First of all; sorry it's taken so long time to get back to you. GH > issue #171 has unfortunately taken most of my time, so this patch went > on the side burner. No worries, thanks for getting around to this! > I've looked

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-04 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email ) Change subject: Support for long INFO/INFO_PRE messages .. Patch Set 2: (1

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-04 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, stipa. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/327?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-04 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email ) Change subject: Support for long INFO/INFO_PRE messages .. Patch Set 1:

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-04 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/327?usp=email to review the following change. Change subject: Support for long INFO/INFO_PRE messages