cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/558?usp=email )
Change subject: configure: update old copy of pkg.m4
..
configure: update old copy of pkg.m4
If we copy this code, let's at least make
cron2 has uploaded a new patch set (#3) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/558?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: configure: update old copy of pkg.m4
Arne and the buildbots say "this is fine", so, in it goes :-)
Your patch has been applied to the master branch.
commit bccb22ab44d7e5a60bece286c9daf8b676f2b7c3 (master)
Author: Frank Lichtenheld
Date: Mon May 6 18:04:07 2024 +0200
configure: update old copy of pkg.m4
Signed-off-by:
From: Frank Lichtenheld
If we copy this code, let's at least make sure we update
it every decade ;)
I also considered removing it. However, then autoconf
can't be run on systems without pkg-config installed
anymore. While that is very unusual, didn't see a good
reason to break that.
Change-Id:
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/583?usp=email )
Change subject: Only run coverity scan in OpenVPN/OpenVPN repository
..
Only run coverity scan in OpenVPN/OpenVPN repository
This avoids
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/583?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Only run coverity scan in OpenVPN/OpenVPN
Your patch has been applied to the master and release/2.6 branch.
commit 815df21d389bf70dbe98cb89f2c60b6e6e816faa (master)
commit 56fc48e87decfa16a15ab0293853c473bf56703f (release/2.6)
Author: Arne Schwabe
Date: Mon May 6 17:58:31 2024 +0200
Only run coverity scan in OpenVPN/OpenVPN
From: Arne Schwabe
This avoids the error message triggering every night that the run
failed in forked repositories
Change-Id: Id95e0124d943912439c6ec6f562c0eb40d434163
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/583?usp=email )
Change subject: Only run coverity scan in OpenVPN/OpenVPN repository
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/584?usp=email )
Change subject: Repeat the unknown command in errors from management interface
..
Repeat the unknown command in errors from management
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/584?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Repeat the unknown command in errors from
Not tested, but trivial enough, and the actual format of the ERROR:
message is not guaranteed so GUIs shouldn't be surprised if it
changes.
Your patch has been applied to the master branch.
commit b90a6e56250ccb18b4913bb115e5dcf4905dbfb1
Author: Arne Schwabe
Date: Mon May 6 16:23:03 2024 +0200
Stared a bit at the difference of v2 and v5 (windows pipe cast plus
clang pragma). All the rest is identical to v2, and trivial in itself
("git show -w -I snprintf").
Self test passes, and compilation / GHA also passes.
I have adapted the "We know that the results truncated" comment
(added
From: Arne Schwabe
This help pinpointing errors in logs from my app
Change-Id: Ie2b62bc95371daf7e1eb58e0323835f169399910
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/584?usp=email )
Change subject: Repeat the unknown command in errors from management interface
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/533?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/584?usp=email
to review the following change.
Change subject: Repeat the unknown command in errors from management interface
From: Arne Schwabe
Old Microsoft versions did strange behaviour but according to the
newly added unit test and
https://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating
this is now standard conforming and we can use the normal snprintf
method.
Microsoft own documentation
Attention is currently required from: cron2, ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/547?usp=email )
Change subject: Remove openvpn_snprintf and similar functions
Attention is currently required from: cron2, ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/547?usp=email )
Change subject: Remove openvpn_snprintf and similar functions
20 matches
Mail list logo
