[Openvpn-devel] [M] Change in openvpn[master]: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-15 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email ) Change subject: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL .. Remove custom TLS 1.0 PRF implementation only

[Openvpn-devel] [M] Change in openvpn[master]: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-15 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#6) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Remove custom TLS 1.0 PRF implementation only used by

[Openvpn-devel] [PATCH applied] Re: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-15 Thread Gert Doering
Tested on the buildbots and on GHA, so does not break mbedtls/openssl builds & self-tests anywhere. Will break compat of LibreSSL/WolFSSL builds with pre-2.6 peers that can not do TLS EKM. Yes. Your patch has been applied to the master branch. commit 763b35f652b1913ddd01e6c548b3e6a57076ba42

[Openvpn-devel] [PATCH v5] Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-15 Thread Gert Doering
From: Arne Schwabe After the removal of the OpenSSL 1.0.2 support, LibreSSL/wolfSSL are the only libraries that still needs the custom implementation. Since our LibreSSL/wolfSSL support is always best effort, we can afford to limit LibreSSL support in this way. If they want to support this,

[Openvpn-devel] [M] Change in openvpn[master]: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-15 Thread cron2 (Code Review)
Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email ) Change subject: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

[Openvpn-devel] [M] Change in openvpn[master]: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-15 Thread cron2 (Code Review)
Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email ) Change subject: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

[Openvpn-devel] [S] Change in openvpn[master]: Remove check for anonymous unions from configure and cmake config

2024-05-15 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/588?usp=email to review the following change. Change subject: Remove check for anonymous unions from configure and cmake config