[Openvpn-devel] [PATCH applied] Re: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror

2023-12-02 Thread Gert Doering
up -Werror Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20231128111447.64445-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27581.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: Add check for nice in cmake config

2023-12-02 Thread Gert Doering
Add check for nice in cmake config Acked-by: Frank Lichtenheld Signed-off-by: Arne Schwabe Message-Id: <20231128104129.62761-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27574.html Signed-off-by: Gert D

[Openvpn-devel] [PATCH applied] Re: configure.ac: Remove unused AC_TYPE_SIGNAL macro

2023-12-02 Thread Gert Doering
.sourceforge.net/msg27572.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Add missing check for nl_socket_alloc failure

2023-12-02 Thread Gert Doering
-devel@lists.sourceforge.net/msg27541.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Fix check_session_buf_not_used using wrong index

2023-12-02 Thread Gert Doering
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27576.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net

[Openvpn-devel] [PATCH applied] Re: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

2023-12-02 Thread Gert Doering
Message-Id: <2023120717.14940-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27624.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailin

[Openvpn-devel] [PATCH applied] Re: Replace character_class_debug with proper unit test

2023-12-02 Thread Gert Doering
541-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27628.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourcefor

[Openvpn-devel] [PATCH applied] Re: Remove dead remains of extract_x509_field_test

2023-12-02 Thread Gert Doering
Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Document tls-exit option mainly as test option

2023-12-02 Thread Gert Doering
-exit option mainly as test option Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <2023120937.15214-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27626.html Signed-off-by: Gert Doering -

[Openvpn-devel] [PATCH applied] Re: Remove unused/unneeded/add missing defines from configure/cmake

2023-12-02 Thread Gert Doering
11.17619-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27634.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourc

[Openvpn-devel] [PATCH applied] Re: GHA: clean up libressl builds with newer libressl

2023-12-02 Thread Gert Doering
ge.net/msg27635.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH release/2.6] Remove --tls-export-cert

2023-11-22 Thread Gert Doering
me out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature __

[Openvpn-devel] [PATCH applied] Re: Log SSL alerts more prominently

2023-11-21 Thread Gert Doering
: <20231121103930.15175-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27523.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH applied] Re: Introduce report_command_status helper function

2023-11-21 Thread Gert Doering
d.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27525.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sour

[Openvpn-devel] [PATCH applied] Re: sample-keys: renew for the next 10 years

2023-11-21 Thread Gert Doering
Signed-off-by: Frank Lichtenheld Message-Id: <20231121110430.16893-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27530.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: Remove unused function prototype crypto_adjust_frame_parameters

2023-11-21 Thread Gert Doering
-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27524.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

[Openvpn-devel] [PATCH applied] Re: protocol_dump: tls-crypt support

2023-11-20 Thread Gert Doering
023 +0200 protocol_dump: tls-crypt support Signed-off-by: Reynir Björnsson Acked-by: Arne Schwabe Message-Id: <8237adde-2523-9e48-5cd4-070463887...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27310.html Signed-off-by:

[Openvpn-devel] [PATCH applied] Re: Enable key export with mbed TLS 3.x.y

2023-11-17 Thread Gert Doering
-off-by: Max Fillinger Acked-by: Frank Lichtenheld Message-Id: <20231117091401.25793-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27458.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH v5] Enable key export with mbed TLS 3.x.y

2023-11-17 Thread Gert Doering
From: Max Fillinger Change-Id: I8e90530726b7f7ba3cee0438f2d81a1ac42e821b Signed-off-by: Max Fillinger Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [PATCH applied] Re: Disable TLS 1.3 support with mbed TLS

2023-11-15 Thread Gert Doering
: <20231115151740.23948-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27453.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH v5] Disable TLS 1.3 support with mbed TLS

2023-11-15 Thread Gert Doering
From: Max Fillinger As of version 3.5.0 the TLS-Exporter function is not yet implemented in mbed TLS, and the exporter_master_secret is not exposed to the application either. Falling back to an older PRF when claiming to use TLS1.3 seems like false advertising. Change-Id:

[Openvpn-devel] [PATCH applied] Re: Warn if pushed options require DHCP

2023-11-15 Thread Gert Doering
require DHCP Signed-off-by: Lev Stipakov Acked-by: Frank Lichtenheld Message-Id: <20231115120656.6825-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27403.html Signed-off-by: Gert Doeri

[Openvpn-devel] [PATCH applied] Re: Make --dns options apply for tap-windows6 driver

2023-11-15 Thread Gert Doering
ndows6 driver Signed-off-by: Lev Stipakov Acked-by: Frank Lichtenheld Message-Id: <20231115120623.6442-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27402.html Signed-off-by: Gert Doering -- kind reg

[Openvpn-devel] [PATCH applied] Re: Do not check key_state buffers that are in S_UNDEF state

2023-11-15 Thread Gert Doering
Author: Arne Schwabe Date: Wed Nov 15 11:33:31 2023 +0100 Do not check key_state buffers that are in S_UNDEF state Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20231115103331.18050-1-g...@greenie.muc.de> URL: https://www.mail

[Openvpn-devel] [PATCH v1] Warn if pushed options require DHCP

2023-11-15 Thread Gert Doering
From: Lev Stipakov Some pushed options (such as DOMAIN-SEARCH) require DHCP server to work. Warn user that some options will not work if the current driver (such as dco-win) doesn't support DHCP. Change-Id: Ie512544329a91fae15409cb18f29d8be617051a1 Signed-off-by: Lev Stipakov Acked-by: Frank

[Openvpn-devel] [PATCH v1] Make --dns options apply for tap-windows6 driver

2023-11-15 Thread Gert Doering
From: Lev Stipakov When tap-windows6 driver is used, both --dhcp-option and --dns options are applied with DHCP. When processing --dns options, we don't set "tuntap_options.dhcp_options" member, which is required for DHCP string to be sent to the driver. As a result, --dns options are not

[Openvpn-devel] [PATCH v2] Do not check key_state buffers that are in S_UNDEF state

2023-11-15 Thread Gert Doering
and message] Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/426 This mail reflects revision 2 of this Change. Acked-by according to Gerrit

[Openvpn-devel] [PATCH applied] Re: config.h: fix incorrect defines for _wopen()

2023-11-14 Thread Gert Doering
er) commit 0c174e4e7b6caafbf4773acdfbbcf122489d (release/2.6) Author: Lev Stipakov Date: Tue Nov 14 15:16:53 2023 +0100 config.h: fix incorrect defines for _wopen() Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20231114141653.10486-1-g...@greenie.muc.de> URL: https://www.

[Openvpn-devel] [PATCH v1] config.h: fix incorrect defines for _wopen()

2023-11-14 Thread Gert Doering
ot;) Those are used as permission mode when opening a file. Passing zero makes file read-only, which break for example --status-file functionality. Github: fixes OpenVPN/openvpn#454 Trac: #1430 Change-Id: I53eaee85d7b284af6bc63da5f6d8f310ddd96c47 Signed-off-by: Lev Stipakov Acked-by: Gert Doeri

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-13 Thread Gert Doering
ill I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-12 Thread Gert Doering
Hi, On Sun, Nov 12, 2023 at 07:22:45PM +0100, Gert Doering wrote: > (If you feel like debugging a bit more - could you compile an instance > without optimization, run from gdb, and when it segfaults print all > local variables of interest? i, j, ks, *ks, ks->send_reliable?

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-12 Thread Gert Doering
ot; Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists

[Openvpn-devel] [PATCH applied] Re: doc: Correct typos in multiple documentation files

2023-11-11 Thread Gert Doering
documentation files Signed-off-by: Aquila Macedo Acked-by: Frank Lichtenheld Message-Id: <4a3a9f1d691704f25f07653bb0de2...@riseup.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27320.html Signed-off-by: Gert Doering -- kind regards,

[Openvpn-devel] [PATCH applied] Re: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-11 Thread Gert Doering
uc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27362.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sour

[Openvpn-devel] [PATCH v1] platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-11 Thread Gert Doering
From: Frank Lichtenheld This broke in the CMake build since previously we just always set HAVE_CHDIR to 1 in the MSVC build. But actually the code should just not check HAVE_CHDIR on Windows. Change-Id: I0c78ce452135fe2c80275da449215ba926471018 Signed-off-by: Frank Lichtenheld Acked-by: Lev

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-10 Thread Gert Doering
Hi, On Fri, Nov 10, 2023 at 10:51:34AM +0100, Gert Doering wrote: > I'll see if I can reproduce this case here and we'll fix it ASAP. We couldn't reproduce it yet, but we have a crash dump in GH issue #449, which hints at the commit cd4d819c99266 getting this double-extra-check wrong. So if

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-10 Thread Gert Doering
ook for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-09 Thread Gert Doering
Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-09 Thread Gert Doering
a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-deve

[Openvpn-devel] [PATCH applied] Re: Remove CMake custom compiler flags for RELEASE and DEBUG build

2023-11-09 Thread Gert Doering
: <20231107141755.30559-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/search?l=mid=20231107141755.30559-1-fr...@lichtenheld.com Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH applied] Re: Fix using to_link buffer after freed

2023-11-09 Thread Gert Doering
: <20231108124947.76816-3-g...@greenie.muc.de> URL: https://www.mail-archive.com/search?l=mid=20231108124947.76816-3-g...@greenie.muc.de Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH applied] Re: Double check that we do not use a freed buffer when freeing a session

2023-11-09 Thread Gert Doering
947.76816-2-g...@greenie.muc.de> URL: https://www.mail-archive.com/search?l=mid=20231108124947.76816-2-g...@greenie.muc.de Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourc

[Openvpn-devel] [PATCH applied] Re: Remove saving initial frame code

2023-11-09 Thread Gert Doering
?l=mid=20231108124947.76816-1-g...@greenie.muc.de Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH 3/3] Fix using to_link buffer after freed

2023-11-09 Thread Gert Doering
From: Arne Schwabe When I refactored the tls_state_change method in 9a7b95fda5 I accidentally changed a break into a return true while it should return a false. The code here is extremely fragile in the sense that it assumes that settings a keystate to S_ERROR cannot have any outgoing buffer or

[Openvpn-devel] [PATCH 1/3] Remove saving initial frame code

2023-11-09 Thread Gert Doering
From: Arne Schwabe This code was necessary before the frame/buffer refactoring as we always did relative adjustment to the frame. This also fixes also that previously initial_frame was initialised too early before the fragment related options were initialised and contained 0 for the maximum

[Openvpn-devel] [PATCH 2/3] Double check that we do not use a freed buffer when freeing a session

2023-11-09 Thread Gert Doering
From: Arne Schwabe This is a find cases where the session already has planned to send out a packet but encounters some other errors that invalidate the session, setting it to S_ERROR and leaving the buffer behind. This will detect and clear that to_link buffer in that case. Change-Id:

[Openvpn-devel] [PATCH applied] Re: Update README.mbedtls

2023-10-31 Thread Gert Doering
109-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27295.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourcefor

[Openvpn-devel] [PATCH applied] Re: Add mbedtls3 GHA build

2023-10-31 Thread Gert Doering
Acked-by: Gert Doering Looks reasonable and succeeds in my GH test repo. Your patch has been applied to the master branch. commit 5af57e348ed3a5f451aca1bba5ba57b3a34e5d11 Author: Frank Lichtenheld Date: Mon Oct 30 18:13:15 2023 +0100 Add mbedtls3 GHA build Signed-off-by: Frank

[Openvpn-devel] [PATCH applied] Re: Add support for mbedtls 3.X.Y

2023-10-29 Thread Gert Doering
14:18:30 2023 +0200 Add support for mbedtls 3.X.Y Signed-off-by: Max Fillinger Acked-by: Frank Lichtenheld Message-Id: <20231025121830.1030959-1-fr...@lichtenheld.com> URL: Signed-off-by: Gert Doering -- kind regards, Gert Doering ___

[Openvpn-devel] [PATCH applied] Re: Add --enable-werror to all platforms in Github Actions

2023-10-29 Thread Gert Doering
Message-Id: <20231025121710.1030736-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27293.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailin

[Openvpn-devel] [PATCH applied] Re: gerrit-send-mail.py: Add patch version to subject

2023-10-29 Thread Gert Doering
Acked-by: Gert Doering Thanks, this is useful :-) - I haven't actually tested it yet, just looked at the change (and the results of you using it on mbedtls v7...). Your patch has been applied to the master branch. commit ba5ed490d3844705cc950dc2eae8c6a92938e757 (master) Author: Frank

Re: [Openvpn-devel] [PATCH applied] Re: Add undefined and abort on error to clang sanitize builds

2023-10-22 Thread Gert Doering
Hi, On Sun, Oct 22, 2023 at 01:03:17PM +0200, Gert Doering wrote: > Your patch has been applied to the master branch. > > commit 44d5cd038cb5b62dafc4aa784cfa2ccb7d670df7 (master) ... and github actions is a bit unappy about the result... seems we are missing a cleanup patch... 2023-10

[Openvpn-devel] [PATCH applied] Re: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

2023-10-22 Thread Gert Doering
Oct 22 12:59:19 2023 +0200 dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20231022105919.21779-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@list

[Openvpn-devel] [PATCH applied] Re: Add undefined and abort on error to clang sanitize builds

2023-10-22 Thread Gert Doering
: <20231022105756.21080-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27278.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH v5] dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

2023-10-22 Thread Gert Doering
: - handle missing display_name and email fields for reviewers gracefully - handle missing Signed-off-by line gracefully v4: - use formatted string consistently Change-Id: If4e9c2e58441efb3fd00872cd62d1cc6c607f160 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change

[Openvpn-devel] [PATCH] Add undefined and abort on error to clang sanaitize builds

2023-10-22 Thread Gert Doering
From: Arne Schwabe The -fno-sanitize-recover=all flag ensures that for all errors we actually abort the tests in the automated testing and not just print some errors in red that nobody sess. Also add the undefined tests to catch more bugs. For libreSSL we do not add the udefined behaviour as we

[Openvpn-devel] [PATCH applied] Re: dco: warn if DATA_V1 packets are sent to userspace

2023-10-22 Thread Gert Doering
lease/2.6) Author: Lev Stipakov Date: Sun Oct 22 10:27:40 2023 +0200 dco: warn if DATA_V1 packets are sent to userspace Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20231022082751.8868-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/op

[Openvpn-devel] [PATCH] dco: warn if DATA_V1 packets are sent to userspace

2023-10-22 Thread Gert Doering
: I8cb2cb083e3cdadf187b7874979d79af3974e759 Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/368 This mail reflects revision 3

[Openvpn-devel] [PATCH applied] Re: mss/mtu: make all size calculations use size_t

2023-10-19 Thread Gert Doering
-fr...@lichtenheld.com> URL: https://www.mail-archive.com/search?l=mid=20231008104022.20200-1-fr...@lichtenheld.com Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourcefor

[Openvpn-devel] [PATCH applied] Re: Remove last uses of inet_ntoa

2023-10-18 Thread Gert Doering
ld Date: Sun Oct 8 12:34:15 2023 +0200 Remove last uses of inet_ntoa Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20231008103415.19625-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/search?l=mid=20231008103415.19625-1-fr...@li

[Openvpn-devel] [PATCH applied] Re: Remove openssl engine method for loading the key

2023-10-18 Thread Gert Doering
ine method for loading the key Signed-off-by: Arne Schwabe Message-Id: <20231006111910.3541180-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27133.html Signed-off-by: Gert Doering -- kind regard

[Openvpn-devel] [PATCH applied] Re: Change type of frame.mss_fix to uint16_t

2023-10-18 Thread Gert Doering
Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20231009105151.34074-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/search?l=mid=20231009105151.34074-1-fr...@lichtenheld.com Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: Add warning if a p2p NCP client connects to a p2mp server

2023-10-18 Thread Gert Doering
d.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27191.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.

[Openvpn-devel] [PATCH applied] Re: dco-win: get driver version

2023-10-15 Thread Gert Doering
.sourceforge.net/msg27174.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] dco: warn if DATA_V1 packets are sent to userspace

2023-10-15 Thread Gert Doering
floated, _start)) what do you think? gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor."

[Openvpn-devel] sf.net repository

2023-10-15 Thread Gert Doering
honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.

[Openvpn-devel] [PATCH applied] Re: Print peer temporary key details

2023-10-14 Thread Gert Doering
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27192.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/

[Openvpn-devel] [PATCH applied] Re: Add warning for the --show-groups command that some groups are missing

2023-10-13 Thread Gert Doering
: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Remove ability to use configurations without TLS by default

2023-10-13 Thread Gert Doering
Message-Id: <20231009105832.34762-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27194.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailin

[Openvpn-devel] [PATCH applied] Re: doc: fix argument name in --route-delay documentation

2023-10-13 Thread Gert Doering
documentation Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20231013102316.330086-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27197.html Signed-off-by: Gert Doering -- kind regards,

Re: [Openvpn-devel] [PATCH] Remove openssl engine method for loading the key

2023-10-07 Thread Gert Doering
honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signa

[Openvpn-devel] [PATCH applied] Re: Log OpenSSL errors on failure to set certificate

2023-10-02 Thread Gert Doering
l.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27122.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.

[Openvpn-devel] [PATCH applied] Re: Remove all traces of the previous MSVC build system

2023-09-26 Thread Gert Doering
d=20230926095118.29924-1-fr...@lichtenheld.com Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: CMake: backport CMake buildsystem from master to release/2.6

2023-09-26 Thread Gert Doering
nvpn-devel@lists.sourceforge.net/msg27107.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6

2023-09-25 Thread Gert Doering
chtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27083.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists

[Openvpn-devel] [PATCH applied] Re: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-25 Thread Gert Doering
ichtenheld Message-Id: <20230925094409.40429-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27097.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mail

[Openvpn-devel] [PATCH applied] Re: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-23 Thread Gert Doering
: <20230922160405.167057-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27084.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH applied] Re: buffer: use memcpy in buf_catrunc

2023-09-23 Thread Gert Doering
-by: Frank Lichtenheld Acked-by: Antonio Quartulli Acked-by: Heiko Hund Acked-by: Gert Doering Message-Id: <20230922160441.167168-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27085.html Signed-off-by: Gert D

[Openvpn-devel] [PATCH applied] Re: GHA: new workflow to submit scan to Coverity Scan service

2023-09-22 Thread Gert Doering
Acked-by: Gert Doering I'm not sure how that works, and how to test it - but the description matches what we agreed as being useful ("run the test each night, but only if something new was pushed this day"). Your patch has been applied to the master and release/2.6 branc

Re: [Openvpn-devel] [PATCH] Improve description of compat-mode

2023-09-22 Thread Gert Doering
hat if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

[Openvpn-devel] [PATCH applied] Re: dns option: remove support for exclude-domains

2023-09-22 Thread Gert Doering
tps://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27008.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Remove --no-replay option

2023-09-22 Thread Gert Doering
w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27059.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: CMake: fix HAVE_DAEMON detection on Linux

2023-09-22 Thread Gert Doering
r: Lev Stipakov Date: Fri Sep 22 12:39:00 2023 +0200 CMake: fix HAVE_DAEMON detection on Linux Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20230922103900.37205-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sou

[Openvpn-devel] [PATCH applied] Re: GHA: do not trigger builds in openvpn-build anymore

2023-09-22 Thread Gert Doering
/www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27060.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: GHA: do not trigger builds in openvpn-build anymore

2023-09-22 Thread Gert Doering
Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Warn user if INFO control command is too long

2023-09-22 Thread Gert Doering
-archive.com/openvpn-devel@lists.sourceforge.net/msg27062.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: CMake: various small non-functional improvements

2023-09-21 Thread Gert Doering
-devel@lists.sourceforge.net/msg27043.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: CMake: fix broken daemonization and syslog functionality

2023-09-20 Thread Gert Doering
-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27045.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.

[Openvpn-devel] [PATCH applied] Re: dco: fix crash when --multihome is used with --proto tcp

2023-09-10 Thread Gert Doering
Acked-by: Gert Doering Code looks good. Done a quick test on a Linux/DCO server, with TCP and --multihome. Without the patch: 2023-09-10 17:15:20 us=552871 freebsd-14-amd64/194.97.140.5:33293 MULTI: primary virtual IPv6 for freebsd-14-amd64/194.97.140.5:33293: fd00:abcd:220:1::1002

[Openvpn-devel] [PATCH applied] Re: configure: disable engines if OPENSSL_NO_ENGINE is defined

2023-09-10 Thread Gert Doering
Acked-by: Gert Doering Compile-tested on our GH Actions farm (OpenSSL 1.1 and 3.0, on various OSes). Not tested against LibreSSL. Your patch has been applied to the master and release/2.6 branch (compat). commit 34bf473e19118eecf525e7401ef37b1cbf661e67 (master) commit

Re: [Openvpn-devel] [PATCH] configure: disable engines if OPENSSL_NO_ENGINE is defined

2023-09-08 Thread Gert Doering
gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon

Re: [Openvpn-devel] [S] Change in openvpn[master]: GHA: do not trigger builds in openvpn-build anymore

2023-09-05 Thread Gert Doering
ith a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel m

Re: [Openvpn-devel] [PATCH] configure: disable engines if OPENSSL_NO_ENGINE is defined

2023-09-03 Thread Gert Doering
ne thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress G

Re: [Openvpn-devel] [PATCH] configure: disable engines if OPENSSL_NO_ENGINE is defined

2023-09-03 Thread Gert Doering
took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich,

[Openvpn-devel] [PATCH applied] Re: Make received OCC exit messages more visible in log.

2023-08-14 Thread Gert Doering
code path "clean up client instance, done") Patch has been applied to the master and release/2.6 branch. commit 5f910a42b86e90f1893a668ee280422b6587ada1 (master) commit 6e68d8c5d5304d56de588f4584e2dc6266d2f129 (HEAD -> release/2.6) Author: Gert Doering Date: Mon Aug 14 08:04:

[Openvpn-devel] [PATCH] Make received OCC exit messages more visible in log.

2023-08-14 Thread Gert Doering
ssage came in. Signed-off-by: Gert Doering --- src/openvpn/occ.c | 2 +- src/openvpn/push.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/occ.c b/src/openvpn/occ.c index 8541f6ec..2871449e 100644 --- a/src/openvpn/occ.c +++ b/src/openvpn/occ.c @@ -42

[Openvpn-devel] [PATCH applied] Re: show extra info for OpenSSL errors

2023-08-11 Thread Gert Doering
-Id: <20230811121503.4159089-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26929.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openv

[Openvpn-devel] [PATCH applied] Re: route: Fix overriding return value of add_route3

2023-08-11 Thread Gert Doering
Acked-by: Gert Doering Yep, Coverity is right :-) - silly code. Fix is in the same style we use elsewhere, so fine. (The whole error handling on route addition is a bit wonky, but even then we should not forget about errors) Test compiled on Linux, just to be sure I did not overlook anything

[Openvpn-devel] [PATCH applied] Re: ntlm: Clarify details on NTLM phase 3 decoding

2023-08-11 Thread Gert Doering
Acked-by: Gert Doering No functional change, just clarifying "yes we know that this could happen, but if it does, this is still well-defined". Test compiled on Linux, just in case I overlooked something. Your patch has been applied to the master and release/2.6 branc

[Openvpn-devel] [PATCH applied] Re: signal_reset(): combine check and reset operations

2023-08-11 Thread Gert Doering
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26088.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net

<    1   2   3   4   5   6   7   8   9   10   >