[Openvpn-devel] [PATCH applied] Re: Make error in setting metric for IPv6 interface non-fatal

2023-03-22 Thread Gert Doering
Acked-by: Gert Doering "Trivially correct" according to #294 - same code, just ignoring errors. I have MinGW-build-tested this, but didn't feel like disabling IPv6 on one of my dear machines to test for real (plus, I currently do not have a working "MinGW build with iservice&q

Re: [Openvpn-devel] [PATCH] Print DCO client stats on SIGUSR2

2023-03-22 Thread Gert Doering
re nice. (Yes, I know, good intentions and all that) gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor."

[Openvpn-devel] [PATCH applied] Re: Fix '--inactive 0' behavior for DCO

2023-03-22 Thread Gert Doering
Acked-by: Gert Doering Thanks. I have not actually tested this, but we've discussed this at length before - so this is "obviously correct". The problem here (for readers of the list only) is that "a single packet" is sufficient to keep the connection active if "

Re: [Openvpn-devel] [PATCH] dco_freebsd: use m->instances[] instead of m->hash

2023-03-22 Thread Gert Doering
st figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de s

[Openvpn-devel] [PATCH applied] Re: dns option: allow up to eight addresses per server

2023-03-21 Thread Gert Doering
llow up to eight addresses per server Signed-off-by: Heiko Hund Acked-by: Arne Schwabe Message-Id: <20230310050814.67246-1-he...@ist.eigentlich.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26386.html Signe

[Openvpn-devel] [PATCH applied] Re: multi: don't call DCO APIs if DCO is disabled

2023-03-21 Thread Gert Doering
d Signed-off-by: Antonio Quartulli Acked-by: Lev Stipakov Message-Id: <20230321102842.10780-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26458.html Signed-off-by: Gert Doeri

[Openvpn-devel] [PATCH applied] Re: Improve description of compat-mode

2023-03-21 Thread Gert Doering
of compat-mode Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20230320165538.902965-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26445.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: dco-linux: remove M_ERRNO flag when printing netlink error message

2023-03-21 Thread Gert Doering
Acked-by: Gert Doering "Trivially correct" :-) - compile-tested on a DCO enabled linux. Your patch has been applied to the master and release/2.6 branch. commit 23903fd579353c9892415a750f17a9832a79cced (master) commit 047f772b84843344b6131e9e915472d14adcea2b (release/2.6) Autho

Re: [Openvpn-devel] [PATCH applied] Re: Improve error message on short read from socks proxy

2023-03-20 Thread Gert Doering
s into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signatur

[Openvpn-devel] [PATCH applied] Re: Improve error message on short read from socks proxy

2023-03-20 Thread Gert Doering
Acked-by: Gert Doering Thanks, this change makes sense. I have not actively tried to provoke it (like, by connecting to a "fake SOCKS server" that will trigger it), but the change is obviously an improvement to "if it's not ==1, it must be a TCP error!"). I do test

[Openvpn-devel] [PATCH applied] Re: Unit tests: add test for SSL_CTX_use_Cryptoapi_certificate()

2023-03-20 Thread Gert Doering
Acked-by: Gert Doering Unit tests are goood :-) Stare-at-code looks good, and Github is happy with the result... (both 32 and 64 bit) [==] Running 7 test(s). [ RUN ] test_parse_hexstring [ OK ] test_parse_hexstring [ RUN ] import_certs [ OK

[Openvpn-devel] [PATCH applied] Re: Only update frame calculation if we have a valid link sockets

2023-03-20 Thread Gert Doering
Acked-by: Gert Doering This is not really "high priority critical NULL pointer crash bug" important, because due to lucky circumstances the result from get_link_socket_info(c) on a NULL pointer is still NULL (because &->info is the first member of the struct) - so later

[Openvpn-devel] [PATCH applied] Re: Make sending plain text control message session aware

2023-03-20 Thread Gert Doering
Acked-by: Gert Doering Discussed this at length with Arne - the change looks very big, but most of it is "change of calling conventions", passing in "session" instead of "multi" (session being c2.tls_multi->session[$key], TM_ACTIVE for most of the invocations).

[Openvpn-devel] [PATCH applied] Re: Use key_state instead of multi for tls_send_payload parameter

2023-03-20 Thread Gert Doering
Acked-by: Gert Doering This one is fairly trivial refactoring - moving the "ks = get_key_scan()" part out of tls_send_payload(), passing in "ks" instead of "multi". Stared-at-code (straightforward), fed to GH for "maybe it is not?" and local client

[Openvpn-devel] [PATCH applied] Re: using OpenSSL3 API for EVP PKEY type name reporting

2023-03-20 Thread Gert Doering
Baentsch Acked-by: Arne Schwabe Message-Id: <20230319075441.13021-1-i...@baentsch.ch> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26439.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: Support --inactive option for DCO

2023-03-17 Thread Gert Doering
kov Acked-by: Heiko Hund Message-Id: <20230315133808.1550-1-lstipa...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26421.html Signed-off-by: Gert Doering -- kind regards, Gert Doering __

Re: [Openvpn-devel] [PATCH] dns option: allow up to two addresses per family

2023-03-16 Thread Gert Doering
ple took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

Re: [Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Gert Doering
ne thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering

[Openvpn-devel] [PATCH applied] Re: Add a test for signing with certificates in Windows store

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering More tests are always welcome :-) - stared at the code (looks good), tested on MinGW->W10 and GHA. [==] Running 6 test(s). [ RUN ] test_parse_hexstring [ OK ] test_parse_hexstring [ RUN ] import_certs [ OK ] import_ce

[Openvpn-devel] [PATCH applied] Re: Refactor SSL_CTX_use_CryptoAPI_certificate()

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code, looks all reasonable. Tested on local MinGW->W10 build (of cryptoapi_testdriver.exe) and GHA (to get all 32/64 bit and OpenSSL 1/3 combinations built), everything passes. Your patch has been applied to the master and release/2.6 branch. com

[Openvpn-devel] [PATCH applied] Re: Add tests for finding certificates in Windows cert store

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering Code looks reasonable and tests what we want tested. Tested with a local MinGW build -> copied to windows10, and with GHA. [==] Running 5 test(s). [ RUN ] test_parse_hexstring [ OK ] test_parse_hexstring [ RUN ] import_ce

[Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering This is a welcome addition so we can have actual cryptoapi unit tests. The code looks reasonable, and GHA says "it passes"... Run ./unittests/cryptoapi_testdriver.exe [==] Running 2 test(s). [ RUN ] test_parse

[Openvpn-devel] [PATCH applied] Re: Fix memory leaks in HMAC initial packet id

2023-03-15 Thread Gert Doering
Acked-by: Gert Doering Stared at the code, and the current version looks good - the change is now bigger than "just add a free_buf()", but since that did not work, the new approach of putting all buffers into the per-session gc_arena should stop the leaking (it might use a bit more me

Re: [Openvpn-devel] [PATCH v2] Fix memory leaks in HMAC initial packet id

2023-03-15 Thread Gert Doering
on session exit (mmmh, which session, anyway?) - but it's still "too many bufs", plus "readers of that code will get confused". gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest fig

[Openvpn-devel] [PATCH applied] Re: Bugfix: Convert ECDSA signature form pkcs11-helper to DER encoded form

2023-03-15 Thread Gert Doering
d-by: Arne Schwabe Message-Id: <20230314122134.1248576-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26406.html Signed-off-by: Gert Doering -- kind regards, Gert Doering _

Re: [Openvpn-devel] [PATCH 0/4] Add some tests for cryptoapi.c functions

2023-03-15 Thread Gert Doering
igures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signa

[Openvpn-devel] [PATCH applied] Re: Fix memory leaks in dco open tun

2023-03-14 Thread Gert Doering
Acked-by: Gert Doering This one is fairly straightforward (and the leak is small) - I've re-read all the code involved for v2 of the patch (set) and the change is correct. The device name involved stays unchanged in the current iterations of open_tun_dco(), so there is no need to save

Re: [Openvpn-devel] [PATCH v3] Fix memory leaks in HMAC initial packet id and dco open tun

2023-03-14 Thread Gert Doering
s into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.mu

Re: [Openvpn-devel] [PATCH v2] Fix memory leaks in HMAC initial packet id and dco open tun

2023-03-13 Thread Gert Doering
"naked" and "tls-auth". gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor."

[Openvpn-devel] [PATCH applied] Re: dco: print FreeBSD version

2023-03-13 Thread Gert Doering
Acked-by: Gert Doering Tested on FreeBSD 14 DCO version: FreeBSD 14.0-CURRENT #10 main-n259930-e898a3af97f9: Wed Jan 4 13:33:06 CET 2023 r...@fbsd14.ov.greenie.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC and on 12 (nothing, as expected). Learned about $UNAME_v today :-) I have

[Openvpn-devel] [PATCH applied] Re: dco: print version to log if available

2023-03-13 Thread Gert Doering
14:19 2023 +0100 dco: print version to log if available Signed-off-by: Antonio Quartulli Acked-by: Arne Schwabe Message-Id: <20230309131419.29157-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26370.html Signed-off-

[Openvpn-devel] [PATCH applied] Re: dco: don't use NetLink to exchange control packets

2023-03-13 Thread Gert Doering
d-by: Arne Schwabe Message-Id: <20230309210344.5763-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26384.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-d

[Openvpn-devel] [PATCH applied] Re: tests/unit_tests: Fix 'make distcheck' with subdir-objects enabled

2023-03-09 Thread Gert Doering
d.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26352.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.

[Openvpn-devel] [PATCH applied] Re: Ensure n = 2 is set in key2 struct in tls_crypt_v2_unwrap_client_key

2023-03-09 Thread Gert Doering
-Id: <20230309120031.3780130-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26363.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openv

[Openvpn-devel] [PATCH applied] Re: Set netlink socket to be non-blocking

2023-03-09 Thread Gert Doering
org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26353.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net

Re: [Openvpn-devel] [PATCH applied] Re: Conditionally add subdir-objects option to automake

2023-03-08 Thread Gert Doering
Hi, On Fri, Feb 10, 2023 at 07:59:03PM +0100, Gert Doering wrote: > This warning has been quite an annoyance for some time - thanks for > taking care of it, and also figuring out what caveats apply. I do > not understand autoconf intricacies, but I have fed this to github and > to t

[Openvpn-devel] [PATCH applied] Re: Avoid warning about missing braces when initialising key struct

2023-03-08 Thread Gert Doering
Acked-by: Gert Doering Confirmed that it pacifies github, and tests still pass. Your patch has been applied to the master and release/2.6 branch. commit 5a14a5ea572ec88e2a9e7bfdad9d5fe31025c021 (master) commit 26417824ff81ba1dd18b03a40822da533018a892 (release/2.6) Author: Antonio Quartulli

[Openvpn-devel] [PATCH applied] Re: FreeBSD 12.x workaround for IPv6 ifconfig is needed on 12.4 as well

2023-03-08 Thread Gert Doering
Patch has been applied to the master and release/2.6 branch. commit 549fbd83f9d445863cc62b3a658a406afacdaeac (master) commit b48298ac510abd000f65fe935a2d1cf7c25ecbf3 (release/2.6) Author: Gert Doering Date: Mon Mar 6 09:07:44 2023 +0100 FreeBSD 12.x workaround for IPv6 ifconfig is needed

[Openvpn-devel] [PATCH applied] Re: Dynamic tls-crypt for secure soft_reset/session renegotiation

2023-03-07 Thread Gert Doering
y: Heiko Hund Message-Id: <20230307150233.3551436-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26341.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Open

[Openvpn-devel] [PATCH applied] Re: Do not save pointer to 'struct passwd' returned by getpwnam etc.

2023-03-06 Thread Gert Doering
Acked-by: Gert Doering Well spotted. Whatever we decide to do with 2/2, this is the correct way to deal with getpw*() returns. I have not tested every possible combination of options, but I have stared-at-code (looks good), had the buildbots test it, and ran a "--user nobody" DC

Re: [Openvpn-devel] [PATCH v7] Dynamic tls-crypt for secure soft_reset/session renegotiation

2023-03-06 Thread Gert Doering
Hi, On Mon, Mar 06, 2023 at 10:24:24AM +0100, Gert Doering wrote: > 2023-03-06 10:20:04 Assertion failed at tls_crypt.c:83 (key->n == 2 && > other->n == 2) Splitting these into two ASSERT()s, it says key->n is fine, while other->n is not 2023-03-06 11:24:00 Assertio

Re: [Openvpn-devel] [PATCH v7] Dynamic tls-crypt for secure soft_reset/session renegotiation

2023-03-06 Thread Gert Doering
ou feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

[Openvpn-devel] [PATCH] FreeBSD 12.x workaround for IPv6 ifconfig is needed on 12.4 as well

2023-03-06 Thread Gert Doering
, which is the real source of the problematic code if checkyesno ipv6_activate_all_interfaces; then _ipv6_opts="-ifdisabled" elif [ "$1" != "lo0" ]; then <<<< _ipv6_opts="ifdisabled"

Re: [Openvpn-devel] [PATCH 2/2] Include supplementary groups when checking management-client-group

2023-03-06 Thread Gert Doering
e thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich

[Openvpn-devel] [PATCH applied] Re: Reduce initialisation spam from verb <= 3 and print summary instead

2023-03-03 Thread Gert Doering
Acked-by: Gert Doering This is a useful change. I have stared a bit at the code, and it does what it wants to achieve. I do not exactly like the "add_delim_if_non_empty()" approach, but this seems to be an ever-recurring topic ("how to build a string with lots of optional parts

[Openvpn-devel] [PATCH applied] Re: dco: define OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT on FreeBSD

2023-03-03 Thread Gert Doering
y: Antonio Quartulli Message-Id: <20230303110511.9569-1-kprov...@netgate.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26324.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-de

Re: [Openvpn-devel] [PATCH] dco: define OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT on FreeBSD

2023-03-03 Thread Gert Doering
you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de

[Openvpn-devel] [PATCH applied] Re: configure: improve FreeBSD DCO check

2023-03-02 Thread Gert Doering
Acked-by: Gert Doering Thanks for spotting & fixing this, and apologies for still not having a FreeBSD 14 buildslave. Indeed, the existing configure.ac hard breaks my FreeBSD 14 setup (which I didn't look at for a while, "because it works")... checking for nvlist_

[Openvpn-devel] [PATCH applied] Re: options.c: enforce a minimal fragment size

2023-03-02 Thread Gert Doering
Acked-by: Gert Doering Straightforward :-) - and we really shouldn't divide by zero.. I have adjusted the message to read "--fragment ..." (with dashes), because that's what we seem to do in other option-related error messages. Your patch has been applied to the master and release/

[Openvpn-devel] [PATCH applied] Re: Use proper print format/casting when converting msg_channel handle

2023-03-01 Thread Gert Doering
Message-Id: <20230214134323.1033590-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26255.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourc

[Openvpn-devel] [PATCH applied] Re: Avoid management log loop with verb >= 6

2023-02-26 Thread Gert Doering
with verb >= 6 Signed-off-by: Lev Stipakov Acked-by: Antonio Quartulli Message-Id: <20230217122156.541-1-lstipa...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26284.html Signed-off-by: Gert Doering -- kind regards, Ger

[Openvpn-devel] [PATCH applied] Re: Update issue templates

2023-02-26 Thread Gert Doering
Acked-by: Gert Doering Your patch has been applied to the master branch. (I'm not sure what GH considers the source for issue templates, but I assume "master branch only") commit 4bdd04f7d308b8018fd9a90882a20a2a1e12472e Author: Antonio Quartulli Date: Sun Feb 26 22:34:20

Re: [Openvpn-devel] [PATCH 2/5] Fix unaligned access in macOS/Solaris hwaddr

2023-02-26 Thread Gert Doering
took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

Re: [Openvpn-devel] [PATCH 2/5] Fix unaligned access in macOS/Solaris hwaddr

2023-02-26 Thread Gert Doering
Hi, On Sun, Feb 26, 2023 at 11:02:16AM +0100, Gert Doering wrote: > I'll check the other BSDs if LL_IFADDR() is available everywhere, but > if not, we can just do the same thing (struct ifr is aligned) and > get rid of the "sdl" and the first memcpy(). Of course neither Solar

Re: [Openvpn-devel] [PATCH 2/5] Fix unaligned access in macOS/Solaris hwaddr

2023-02-26 Thread Gert Doering
ple took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doer

Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c

2023-02-25 Thread Gert Doering
mputer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

[Openvpn-devel] [PATCH applied] Re: configure: fix formatting of --disable-lz4 and --enable-comp-stub

2023-02-25 Thread Gert Doering
Acked-by: Gert Doering "Makes sense". Before: --disable-lzo disable LZO compression support [default=yes] --disable-lz4 Disable LZ4 compression support --enable-comp-stub Don't compile compression support but still allow limited interoperability with c

[Openvpn-devel] [PATCH applied] Re: Windows: fix signedness errors with recv/send

2023-02-25 Thread Gert Doering
Acked-by: Gert Doering I'm not a big fan of adding (cast) to silence compiler warnings, but this signed/unsigned char * nonsense is really hard to avoid - casting to (void *) is the right fix here. I have only test compiled on MinGW - and my MinGW did not warn about these anyway (maybe

[Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c

2023-02-25 Thread Gert Doering
Acked-by: Gert Doering Thanks for the v4. This enabled me to just push to GH to have to build and run the tests, without having to bother myself with copying binaries around :-) OTOH, there might be a bit of polishing needed - the other tests print out what they are doing ("Running 7 t

[Openvpn-devel] [PATCH applied] Re: Add logging for windows driver selection process

2023-02-25 Thread Gert Doering
Acked-by: Gert Doering While I do have no idea about windows drivers and such, having some helpful debug output for "adapter not found" issues is good. I have stared at the code for a bit, and it's all fairly trivial msg()'ing of strings and integers (plus an M_ERRNO added in one of

[Openvpn-devel] [PATCH applied] Re: configure: enable DCO by default on FreeBSD/Linux

2023-02-25 Thread Gert Doering
chive.com/openvpn-devel@lists.sourceforge.net/msg26272.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Disable DCO if proxy is set via management

2023-02-20 Thread Gert Doering
et/msg26287.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Exit if a proper message instead of segfault on Android without management

2023-02-20 Thread Gert Doering
Acked-by: Gert Doering This code is all inside #ifdef TARGET_ANDROID, so I didn't test anything - but it looks all reasonable. Your patch has been applied to the master and release/2.6 branch. commit 3132bead497deca24dc638e151bf7194df6f4884 (master) commit

Re: [Openvpn-devel] OpenVPN 2.5.9 released

2023-02-16 Thread Gert Doering
ok for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany

Re: [Openvpn-devel] [PATCH v3] configure: enable DCO by default on FreeBSD/Linux

2023-02-14 Thread Gert Doering
Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Option --cryptoapicert: support issuer name as a selector

2023-02-14 Thread Gert Doering
Acked-by: Gert Doering I did hope that someone else would report back and say "I have tested this and it works great!". Nobody volunteered and I wanted this out of the way (and I think it's a useful addition with very little code needed). Code looks good according to doc

[Openvpn-devel] [PATCH applied] Re: cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-14 Thread Gert Doering
Acked-by: Gert Doering Patch looks reasonable, and compiles fine :-) - looking forward to merge the unit test patch for it. There is a similar code piece in options.c::parse_hash_fingerprint(), but it has slightly different semantics wrt length and separators, so merging these (my initial

[Openvpn-devel] [PATCH applied] Re: cryptoapi.c: remove pre OpenSSL-3.01 support

2023-02-14 Thread Gert Doering
Acked-by: Gert Doering This patch looks large and complex, but all it does do is "rip out code parts that are inside #ifndef HAVE_XKEY_PROVIDER" (plus add a message as replacement). This is a welcome change, and in line with what we discussed some time ago regarding OpenSSL support f

Re: [Openvpn-devel] [PATCH applied] Re: cyryptapi.c: log the selected certificate's name

2023-02-14 Thread Gert Doering
Hi, On Tue, Feb 14, 2023 at 03:00:33PM +0100, Gert Doering wrote: > The 3 new gc_free() are a bit ugly, but unavoidable without either > having "gc_free() in the middle of the function" (which we don't do) or > restructure more & add "ret = 1 ; goto end" code...

Re: [Openvpn-devel] [PATCH applied] Re: cyryptapi.c: log the selected certificate's name

2023-02-14 Thread Gert Doering
into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Descri

Re: [Openvpn-devel] [PATCH] Add missing check for nl_socket_alloc failure

2023-02-14 Thread Gert Doering
me out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature __

[Openvpn-devel] [PATCH applied] Re: cyryptapi.c: log the selected certificate's name

2023-02-14 Thread Gert Doering
Acked-by: Gert Doering I think this is a useful addition. Code looks good according to the documentation for CertGetNameStringW() and WideCharToMultiByte(). Tested on a MinGW compile (yes, compiles :-) ). Not actually tested on a life windows system, as my "have p12 certs imported, refe

Re: [Openvpn-devel] [PATCH v2 3/3] Add a unit test for functions in cryptoapi.c

2023-02-14 Thread Gert Doering
nest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@gre

[Openvpn-devel] [PATCH applied] Re: Revise the cipher negotiation about OpenVPN3 in the man page

2023-02-14 Thread Gert Doering
Acked-by: Gert Doering "Seems to make sense". Language fixes from Frank included. Your patch has been applied to the master and release/2.6 branch. commit 4da513d584b4e7521de5a47a95cc27fa8a342fd3 (master) commit cfbfb801e6432382edbbec758335d7c142707206 (release/2.6) Author: Arne Sc

[Openvpn-devel] [PATCH applied] Re: Add building unit tests with mingw to github actions

2023-02-14 Thread Gert Doering
6204.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Improve format specifier for socket handle in Windows

2023-02-14 Thread Gert Doering
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26220.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/o

[Openvpn-devel] [PATCH applied] Re: Update the last sections in the man page to a be a bit less outdated

2023-02-14 Thread Gert Doering
rge.net/msg26224.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Combine extra_tun/frame parameter of frame_calculate_payload_overhead

2023-02-14 Thread Gert Doering
-devel@lists.sourceforge.net/msg26223.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-14 Thread Gert Doering
Hi, On Sat, Feb 11, 2023 at 01:44:04PM -0500, Selva Nair wrote: > On Sat, Feb 11, 2023 at 1:32 PM Gert Doering wrote: > > > /bin/bash ../../../libtool --tag=CC --mode=link i686-w64-mingw32-gcc > > This is a 32 bit build which I never tried. Maybe cmocka is not built

[Openvpn-devel] [PATCH applied] Re: dco-win: use proper calling convention on x86

2023-02-13 Thread Gert Doering
Acked-by: Gert Doering I'm no windows expert, but googling says "this is what you do for windows function calls". MinGW compiles without complaints, as does GHA. The GetOverlappedResultEx() can be cleaned up as soon as we drop Windows 7 support, not sure about the IsWow64Process2() t

[Openvpn-devel] [PATCH applied] Re: Build unit tests in mingw Windows build

2023-02-13 Thread Gert Doering
Message-Id: <20230208005925.393200-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26188.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing li

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-11 Thread Gert Doering
nges... *scratch head* Need to debug this more tonight... gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor."

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-10 Thread Gert Doering
all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Do

[Openvpn-devel] [PATCH applied] Re: Add missing stdint.h includes in unit tests files

2023-02-10 Thread Gert Doering
9.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26182.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sour

[Openvpn-devel] [PATCH applied] Re: Get rid of unused 'bool tuntap_buffer' arguments.

2023-02-10 Thread Gert Doering
This time, it actually compiles on Linux *and* Windows... (GH says so :-) ). Patch has been applied to the master and release/2.6 branch. commit 092ceadb762a42a50191e38bd7cf0fe9f6528a59 (master) commit eca101ac4426442c1ad17e6a706d84c7960a8262 (release/2.6) Author: Gert Doering Date: Wed Feb 1

[Openvpn-devel] [PATCH applied] Re: Conditionally add subdir-objects option to automake

2023-02-10 Thread Gert Doering
20230204004512.250271-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26147.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@l

[Openvpn-devel] [PATCH applied] Re: Allow certain DHCP options to be used without DHCP server

2023-02-10 Thread Gert Doering
-devel@lists.sourceforge.net/msg26169.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] get_addr_generic: fix server crash in freeaddrinfo on musl libc

2023-02-09 Thread Gert Doering
Hi, On Thu, Feb 09, 2023 at 10:09:45PM +0200, Mykhailo Mishchenko wrote: > On 09.02.23 21:38, Gert Doering wrote: > > (There is an old Trac ticket about it, but nobody went out and fixed > > the code yet - which is tricky, as you can't just change the format > > of ifconfig

Re: [Openvpn-devel] [PATCH] get_addr_generic: fix server crash in freeaddrinfo on musl libc

2023-02-09 Thread Gert Doering
omputer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description

[Openvpn-devel] [PATCH applied] Re: Fix LibreSSL not building in Github Actions

2023-02-09 Thread Gert Doering
Acked-by: Gert Doering Arne has said I should not look at this patch. So I'm despearately looking elsewhere. I do not want to know. (Github says "it builds with this change") Your patch has been applied to the master branch. commit 589cca156357e05c6c3f07517184157585c8e9fc (mast

Re: [Openvpn-devel] [PATCH] get_addr_generic: fix server crash in freeaddrinfo on musl libc

2023-02-09 Thread Gert Doering
es come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

[Openvpn-devel] [PATCH applied] Re: Windows: fix unused variable in win32_get_arch

2023-02-07 Thread Gert Doering
Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Windows: fix wrong printf format in x_check_status

2023-02-07 Thread Gert Doering
kov Message-Id: <20230207134333.52221-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26166.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Windows: fix unused variables in delete_route_ipv6

2023-02-07 Thread Gert Doering
ws: fix unused variables in delete_route_ipv6 Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov Message-Id: <20230203191440.136050-3-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26140.html Signed-off-by: Gert Doerin

[Openvpn-devel] [PATCH applied] Re: Windows: fix unused function setenv_foreign_option

2023-02-07 Thread Gert Doering
w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26145.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-04 Thread Gert Doering
nlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: block-dns using iservice: fix a potential double free

2023-02-02 Thread Gert Doering
w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26130.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Changes.rst: document removal of --keysize

2023-02-01 Thread Gert Doering
Acked-by: Gert Doering Does what it says on the lid, not much to test here :-) Your patch has been applied to the master branch. commit b2e49465e6b837d97ecb3a4edbc06aba00584381 (master) commit c8e94242e31cf94a12f6e897191548be5c4893fe (release/2.6) Author: Frank Lichtenheld Date: Wed Feb 1 14

[Openvpn-devel] [PATCH applied] Re: Add printing USAN stack trace on github actions

2023-02-01 Thread Gert Doering
Lichtenheld Message-Id: <20230130172936.3444840-4-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26102.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel m

[Openvpn-devel] [PATCH applied] Re: Update LibreSSL to 3.7.0 in Github actions

2023-02-01 Thread Gert Doering
Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20230130172936.3444840-3-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26105.html Signed-off-by: Gert Doering -- kind regards, Gert D

<    1   2   3   4   5   6   7   8   9   10   >