Re: [Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Max Fillinger
On 07/11/2021 13:29, Arne Schwabe wrote: The patch removes checking for weak keys and making DES just like any other CBC cipher and not doing extra checks for this. It basically removes the special treatment of DES. After this, do we have any DES functionality left in OpenVPN? If so, we

Re: [Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Arne Schwabe
The patch removes checking for weak keys and making DES just like any other CBC cipher and not doing extra checks for this. It basically removes the special treatment of DES. After this, do we have any DES functionality left in OpenVPN? If so, we should remove it. After this patch, no

Re: [Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Matthias Andree
Am 07.11.21 um 13:13 schrieb Arne Schwabe: Am 07.11.21 um 12:57 schrieb Matthias Andree: Am 07.11.21 um 10:01 schrieb Arne Schwabe: We already removed the check in d67658fee for OpenSSL 3.0. This removes the checks entirely for all crypto libraries. Signed-off-by: Arne Schwabe ---  

Re: [Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Arne Schwabe
Am 07.11.21 um 12:57 schrieb Matthias Andree: Am 07.11.21 um 10:01 schrieb Arne Schwabe: We already removed the check in d67658fee for OpenSSL 3.0. This removes the checks entirely for all crypto libraries. Signed-off-by: Arne Schwabe ---   src/openvpn/crypto.c | 15  

Re: [Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Matthias Andree
Am 07.11.21 um 10:01 schrieb Arne Schwabe: We already removed the check in d67658fee for OpenSSL 3.0. This removes the checks entirely for all crypto libraries. Signed-off-by: Arne Schwabe --- src/openvpn/crypto.c | 15 src/openvpn/crypto_backend.h | 28 ---

Re: [Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Max Fillinger
On 07/11/2021 10:01, Arne Schwabe wrote: We already removed the check in d67658fee for OpenSSL 3.0. This removes the checks entirely for all crypto libraries. Signed-off-by: Arne Schwabe Acked-by: Max Fillinger Looks good to me! Compiled and ran --test-crypto for DES/DES3, with mbedtls

[Openvpn-devel] [PATCH] Completely remove DES checks

2021-11-07 Thread Arne Schwabe
We already removed the check in d67658fee for OpenSSL 3.0. This removes the checks entirely for all crypto libraries. Signed-off-by: Arne Schwabe --- src/openvpn/crypto.c | 15 src/openvpn/crypto_backend.h | 28 --- src/openvpn/crypto_mbedtls.c | 56