Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-30 Thread Gert Doering
Hi, to followup on this: On Fri, Nov 21, 2014 at 08:40:35PM +0100, Yegor Yefremov wrote: > Set enable_password_save to "yes", if the option is not given, > as stated in the description. For now, I have committed David's patch that just corrects the help text in configure, without changing the ac

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-24 Thread Matthias Andree
Am 22.11.2014 um 10:43 schrieb Steffan Karger: > Hi Yegor, > > On 21-11-14 20:43, Yegor Yefremov wrote: >> This patch is a result of our IRC discussion with Arne. Alternative >> approach were to always build with password-save functionality without >> configure option at all. > > Thanks for the p

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-24 Thread David Sommerseth
On 23/11/14 20:49, Yegor Yefremov wrote: > On Sat, Nov 22, 2014 at 12:57 PM, Gert Doering wrote: >> Hiya, >> >> On Sat, Nov 22, 2014 at 11:47:05AM +0100, Arne Schwabe wrote: >>> Almost anybody always turns this feature on, at least all distribution >>> have it on. >> >> Which is indeed a strong ar

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-23 Thread Yegor Yefremov
On Sat, Nov 22, 2014 at 12:57 PM, Gert Doering wrote: > Hiya, > > On Sat, Nov 22, 2014 at 11:47:05AM +0100, Arne Schwabe wrote: >> Almost anybody always turns this feature on, at least all distribution >> have it on. > > Which is indeed a strong argument for removing the conditional... maybe > qui

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Gert Doering
Hiya, On Sat, Nov 22, 2014 at 11:47:05AM +0100, Arne Schwabe wrote: > Almost anybody always turns this feature on, at least all distribution > have it on. Which is indeed a strong argument for removing the conditional... maybe quickly discuss this ("anyone strongly opposed?") at the next meeting?

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Arne Schwabe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22.11.2014 11:21, Gert Doering wrote: > Hi, > > On Sat, Nov 22, 2014 at 10:43:00AM +0100, Steffan Karger wrote: >> On 21-11-14 20:43, Yegor Yefremov wrote: >>> This patch is a result of our IRC discussion with Arne. Alternative >>> approach were to

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Arne Schwabe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22.11.2014 11:21, Gert Doering wrote: Almost anybody always turns this feature on, at least all distribution have it on. Arne -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (MingW32) iEYEARECAAYFAlRwaacACgkQe8+cMNS4zReyrwCgq1gUP6AYs99pGV3M

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Gert Doering
Hi, On Sat, Nov 22, 2014 at 10:43:00AM +0100, Steffan Karger wrote: > On 21-11-14 20:43, Yegor Yefremov wrote: > > This patch is a result of our IRC discussion with Arne. Alternative > > approach were to always build with password-save functionality without > > configure option at all. > > Thanks

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-22 Thread Steffan Karger
Hi Yegor, On 21-11-14 20:43, Yegor Yefremov wrote: > This patch is a result of our IRC discussion with Arne. Alternative > approach were to always build with password-save functionality without > configure option at all. Thanks for the patch. But this explanation doesn't help me much in understan

Re: [Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-21 Thread Yegor Yefremov
On Fri, Nov 21, 2014 at 8:40 PM, Yegor Yefremov wrote: > Set enable_password_save to "yes", if the option is not given, > as stated in the description. > > Signed-off-by: Yegor Yefremov > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/c

[Openvpn-devel] [PATCH] configure.ac: fix default behavior

2014-11-21 Thread Yegor Yefremov
Set enable_password_save to "yes", if the option is not given, as stated in the description. Signed-off-by: Yegor Yefremov --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 608ab6d..9dcd2ab 100644 --- a/configure.ac +++ b/confi