Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-27 Thread Matthias Andree
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 27.04.2015 um 16:48 schrieb David Sommerseth: > Having this said, if you do builds on systems with a more modern > automake, I do want to encourage people to run 'make V=0' or use > ./configure --enable-silent-rules. This will ensure we can

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-27 Thread Gert Doering
Hi, On Mon, Apr 27, 2015 at 04:48:38PM +0200, David Sommerseth wrote: > Just tested a ./configure (used automake 1.13.4 on RHEL7) with > - --enable-silent-rules. That worked like a charm out-of-the-box > without any patching. David, thanks for testing and reporting. With this, I think we can

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-27 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15/04/15 14:07, Gert Doering wrote: > Hi, > > On Wed, Apr 15, 2015 at 09:19:45AM +0200, Matthias Andree wrote: >> - it changes policy through the [yes] argument to >> AM_SILENT_RULES(). This flips the switch for the default without >> good reason,

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-15 Thread Gert Doering
Hi, On Wed, Apr 15, 2015 at 09:19:45AM +0200, Matthias Andree wrote: > - it changes policy through the [yes] argument to AM_SILENT_RULES(). > This flips the switch for the default without good reason, and that > makes debugging harder - this is a policy decision, not mechanism. Indeed, this we

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-15 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15/04/15 09:19, Matthias Andree wrote: > If the oldest distro we need to support (James? Samuli?) offers > "silent-rules" through AM_INIT_AUTOMAKE, we should just add it > there, but we should not touch the default. Then still anyone can > call

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-15 Thread Matthias Andree
Am 14.04.2015 um 20:34 schrieb Yegor Yefremov: > Signed-off-by: Yegor Yefremov > --- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 9132468..ca0d9c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-14 Thread Yegor Yefremov
On Tue, Apr 14, 2015 at 10:48 PM, Gert Doering wrote: > Hi, > > On Tue, Apr 14, 2015 at 08:34:05PM +0200, Yegor Yefremov wrote: >> +# enable silent build >> +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes]])) >> + > > I don't understand autoconf magic well enough to

Re: [Openvpn-devel] [PATCH] m4: enable silent build

2015-04-14 Thread Gert Doering
Hi, On Tue, Apr 14, 2015 at 08:34:05PM +0200, Yegor Yefremov wrote: > +# enable silent build > +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes]])) > + I don't understand autoconf magic well enough to understand what that does - do you have a pointer for me which would explain it? thanks

[Openvpn-devel] [PATCH] m4: enable silent build

2015-04-14 Thread Yegor Yefremov
Signed-off-by: Yegor Yefremov --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 9132468..ca0d9c3 100644 --- a/configure.ac +++ b/configure.ac @@ -374,6 +374,9 @@ AC_DEFINE_UNQUOTED([IPROUTE_PATH], ["$IPROUTE"],