Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-31 Thread Antonio Quartulli
Arne just reminded me that we also need some text for Changes.rst. How about this? 68 PF (Packet Filtering) support has been removed 69 The built-in PF functionality has been definitely removed from the code 70 base. This feature wasn't really easy to use and was long unmaintained. 71

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-30 Thread Arne Schwabe
Am 27.08.21 um 21:00 schrieb Antonio Quartulli: > OpenVPN shipped a small packet filtering tool called PF. It has never > been straightforward as it required a plugin to work. On top of that, > keeping PF support, makes the code more complicated and increases the > maintenance cost of OpenVPN. > >

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Gert Doering
Hi, On Sat, Aug 28, 2021 at 10:49:42AM -0400, Selva Nair wrote: > On Sat, Aug 28, 2021 at 9:29 AM Gert Doering wrote: > > > On Sat, Aug 28, 2021 at 10:51:58AM +0200, Matthias Andree wrote: > > > Do we need to maintain C89 compatibility these days? > > No. C99 is fully acceptable. > > But our c

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Selva Nair
Hi On Sat, Aug 28, 2021 at 9:29 AM Gert Doering wrote: > Hi, > > On Sat, Aug 28, 2021 at 10:51:58AM +0200, Matthias Andree wrote: > > Do we need to maintain C89 compatibility these days? > > No. C99 is fully acceptable. > But our coding style still has to be followed. That means /* */ comments

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Gert Doering
Hi, On Sat, Aug 28, 2021 at 10:51:58AM +0200, Matthias Andree wrote: > Do we need to maintain C89 compatibility these days? No. C99 is fully acceptable. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come

Re: [Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-28 Thread Matthias Andree
Am 27.08.21 um 21:00 schrieb Antonio Quartulli: > OpenVPN shipped a small packet filtering tool called PF. It has never > been straightforward as it required a plugin to work. On top of that, > keeping PF support, makes the code more complicated and increases the > maintenance cost of OpenVPN. > >

[Openvpn-devel] [PATCH v2] Remove support for PF (Packet Filter)

2021-08-27 Thread Antonio Quartulli
OpenVPN shipped a small packet filtering tool called PF. It has never been straightforward as it required a plugin to work. On top of that, keeping PF support, makes the code more complicated and increases the maintenance cost of OpenVPN. PF itself is not actually maintained at all and there is li