[Openvpn-devel] [PATCH v2 2/3] use new pkcs11-helper interface to add providers

2022-12-11 Thread Marc Becker via Openvpn-devel
The new interface in pkcs11-helper 1.28 allows decoupling of provider registration and initialization. This allows modifying more (and future) properties apart from the 6 fixed ones supported as arguments to pkcs11h_addProvider(). With the new interface it is easier to see (from a code

[Openvpn-devel] [PATCH v3 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Marc Becker via Openvpn-devel
Change win32 dynamic loader behavior when supplying an absolute path. The DLL location is considered/preferred to resolve dependencies. Support in pkcs11-helper for loader flag is detected at compile time. 3rd party DLLs and additional dependencies do no longer need to be moved to the OpenVPN

Re: [Openvpn-devel] [PATCH v2 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Selva Nair
Hi, On Sun, Dec 11, 2022 at 2:22 PM Marc Becker via Openvpn-devel < openvpn-devel@lists.sourceforge.net> wrote: > Change win32 dynamic loader behavior when supplying an absolute path. > The DLL location is considered/preferred to resolve dependencies. > Support in pkcs11-helper for loader flag

Re: [Openvpn-devel] [PATCH v2 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Marc Becker via Openvpn-devel
Hi, my suggestion would be to decide if we want v2 or v3 of 3/3 depending on the pkcs11-helper state immediately before next beta. OpenVPN 2.6 changing behavior shortly after release would be something to avoid in any case. Having the patch around in 2.6 branch only and dropping it in 2.6.1 may

[Openvpn-devel] [PATCH v2 1/3] unify code path for adding PKCS#11 providers

2022-12-11 Thread Marc Becker via Openvpn-devel
Use existing wrapper for pkcs11h_addProvider to have arguments with "magic values" for pkcs11-helper call in a central place. Slot event argument to pkcs11h_addProvider has NOT been a boolean for at least 15 years. Luckily the default is PKCS11H_SLOTEVENT_METHOD_AUTO=0=FALSE. Signed-off-by: Marc

[Openvpn-devel] [PATCH v2 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Marc Becker via Openvpn-devel
Change win32 dynamic loader behavior when supplying an absolute path. The DLL location is considered/preferred to resolve dependencies. Support in pkcs11-helper for loader flag is detected at compile time. 3rd party DLLs and additional dependencies do not need to be moved to the OpenVPN directory