Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/551?usp=email )
Change subject: Match ifdef for get_sigtype function with if ifdef of caller
From: Arne Schwabe
These two ifdef needs to be the same otherwise the compiler will
break with a undefined function.
Change-Id: I5b14bf90bb07935f0bb84373ec4e62352752c03f
Signed-off-by: Arne Schwabe
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/551?usp=email )
Change subject: Match ifdef for get_sigtype function with if ifdef of caller
..
Match ifdef for get_sigtype function with if ifdef of
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/551?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Match ifdef for get_sigtype function with if ifdef of
ACK, verified that it fixes the GHA build fails we've seen since the
recent LibreSSL upgrade on the MacOS builders.
Your patch has been applied to the master branch.
Not applicable to release/2.6 as the offending code is not in there.
commit ff402c7c2fbc49ff6d352ebdc3cdc4c27c2bbcbb (master)
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/552?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/552?usp=email
to look at the new patch set (#2).
Change subject: Remove redundant call of EVP_CipherInit before
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/552?usp=email )
Change subject: Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex
Looking at the OpenSSL implementation for the EVP_CipherInit*() functions
makes it really clear that this is, basically, dead code. Of course the
"kt" init needs to go to the second call now, because otherwise it will
bomb with OpenSSL 3.x ("no default cipher").
Tested with various OpenSSL (and
cron2 has uploaded a new patch set (#4) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/552?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Remove/combine redundant call of EVP_CipherInit before
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/552?usp=email )
Change subject: Remove/combine redundant call of EVP_CipherInit before
EVP_CipherInit_Ex
..
Remove/combine redundant call of
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/552?usp=email )
Change subject: Remove/combine redundant call of EVP_CipherInit before
EVP_CipherInit_Ex
From: Arne Schwabe
EVP_CipherInit basically is the same EVP_CipherInit_ex except that it
in some instances it resets/inits the ctx parameter first. We already
call EVP_CIPHER_CTX_reset to reset/init the ctx before. Also ensure that
EVP_CipherInit_Ex gets the cipher to actually be able to
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/552?usp=email )
Change subject: Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex
From: Arne Schwabe
EVP_CipherInit basically is the same EVP_CipherInit_ex except that it
in some instances it resets/inits the ctx parameter first. We already
call EVP_CIPHER_CTX_reset to reset/init the ctx before so this call does
not do anything useful.
OpenSSL 1.0.2:
15 matches
Mail list logo
