Re: [Openvpn-devel] [PATCH] Add new openssl.cnf to easy-rsa/Windows

2011-06-20 Thread David Sommerseth
ferent. Can we please unite them? JJK: Do you know which differences are needed between Windows and non-Windows? kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [Openvpn-devel] [PATCH] Add new openssl.cnf to easy-rsa/Windows

2011-06-20 Thread David Sommerseth
Windows build, package a statically linked openssl.exe t... 4030142 The easy-rsa directory installed by the windows installer c... 6fbf66f This is the start of the BETA21 branch. It includes the --t... kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG

Re: [Openvpn-devel] [PATCH] Fixes to easy-rsa/2.0

2011-07-01 Thread David Sommerseth
evelopers meeting to remove 0.9.6 support. However we found it better to remove that support first in OpenVPN 2.3, as we will then go through the source code and remove all 0.9.6 related stuff in the same go. We don't want to change this in a stable release. kind regards, David Sommerseth -BEGI

Re: [Openvpn-devel] Bug: extended x509-username-field broken in git

2011-07-05 Thread David Sommerseth
isect good Or if it failed, then you do: $ git bisect bad Do this good/bad thing until git have located the commit which changes the behaviour. You will get a result similar to what you see here: <https://community.openvpn.net/openvpn/ticket/108#comment:1> kind regards, David Sommerseth

Re: [Openvpn-devel] [PATCH 1/8] Added Doxygen doxyfile

2011-07-05 Thread David Sommerseth
eletions(-) > create mode 100644 openvpn.doxyfile > ACK. Wondering if we should enable SEARCHENGINE, for convenience, but that can be done later on. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora -

Re: [Openvpn-devel] [PATCH 3/8] Added control channel crypto docs

2011-07-05 Thread David Sommerseth
ed, all message types are > - * protected with an HMAC signature, even the initial packets > - * of the TLS handshake. This makes it easy for OpenVPN to > - * throw away bogus packets quickly, without wasting resources > - * on attempting a TLS handshake which wil

Re: [Openvpn-devel] [PATCH 2/8] Added data channel crypto docs

2011-07-06 Thread David Sommerseth
further understanding. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk4T+lUACgkQDC186MBRfroZYgCePU+IbsXzR7POcDVgPjFgojIU SSQAn2TsnXB+9mNZmrqgp2o5ZVngwDUD =erwT -END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH 9/9] Moved doxygen-specific files to a separate directory

2011-07-06 Thread David Sommerseth
xygen/doc_protocol_overview.h > create mode 100644 doxygen/doc_reliable.h > create mode 100644 doxygen/doc_tunnel_state.h > create mode 100644 doxygen/openvpn.doxyfile > delete mode 100644 openvpn.doxyfile As this is a pure file move, moving all doc files into doxygen, this gets an ACK.

Re: [Openvpn-devel] PolarSSL patches

2011-07-07 Thread David Sommerseth
in time) than to have SSL implementation aware plug-ins. And it might give far more challenges in regards to supported features. So for now, I recommend plug-ins to support OpenSSL and/or PolarSSL natively. If someone can come up with a sensible X509 API layer which can be used instead, lets review

Re: [Openvpn-devel] OpenVPN with PKCS11 support

2011-07-14 Thread David Sommerseth
on is here [2]. kind regards, David Sommerseth [1] <https://community.openvpn.net/openvpn/ticket/145> [2] <http://thread.gmane.org/gmane.network.openvpn.user/32383/focus=32394> -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuP

Re: [Openvpn-devel] [PATCH 0/8] OpenVPN Doxygen patches

2011-07-28 Thread David Sommerseth
and all have the proper credit to Adriaan de Jong. So unless there are any objections or Adriaan insists on having his name as the patch authors, I will leave it how it is now. Otherwise, I'll need to reset the git tree and push out a new one. But I'm willing to do that if people wants it

Re: [Openvpn-devel] [PATCH] remove function is_proto_tcp()

2011-08-24 Thread David Sommerseth
proto_is_tcp() instead. | | Signed-off-by: Heiko Hund<heiko.h...@sophos.com> Applied to testing and stable master branches. commit 834eba7597e2582c44f69e03a762b838308c8df0 kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with

Re: [Openvpn-devel] [PATCH] add .gitignore to official repository

2011-08-24 Thread David Sommerseth
sam...@openvpn.ne> | Signed-off-by: Heiko Hund<heiko.h...@sophos.com> ACK. Applied to testing and stable master branches. Commit 98054a0744d1e228341cf2d8e1b1f9f2650c2775 Kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with F

Re: [Openvpn-devel] [PATCH] Merged TODO.IPv6 with TODO.ipv6 and README.IPv6 with README.ipv6

2011-08-24 Thread David Sommerseth
ches. Commit c1f25b6644efaa74c069c20d9a008e1786209a88 kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk5U9tYACgkQDC186MBRfroYugCfbQMcBOsAYfotc/Q6JHSTYTv4 aioAnR6WSmAN1uLURUeLIyOww

Re: [Openvpn-devel] [PATCH] Skip rather than fail test in addressless FreeBSD jails.

2011-08-24 Thread David Sommerseth
Commit 3f1745666bac31458b33f09c888769cc8c1c829b kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk5VFaUACgkQDC186MBRfro5LgCfZA0rZa1nsYjgEM9u03UpH03F NE4An1LRahZyf7y8Y7NsfK6U8/

Re: [Openvpn-devel] [PATCH] Added whitespace handling for $KEY_CONFIG variable in easy-rsa/2.0/vars

2011-08-26 Thread David Sommerseth
rsa. > -export KEY_CONFIG=`$EASY_RSA/whichopensslcnf $EASY_RSA` > +export KEY_CONFIG=$("$EASY_RSA"/whichopensslcnf "$EASY_RSA") Even though I personally like this syntax better, isn't it better to use the `` syntax instead of $() due to portability? Or are we sure that $() functi

[Openvpn-devel] [PATCH] Define SOL_IP if compiling on OSX

2011-08-26 Thread David Sommerseth
OSX Lion does not have SOL_IP defined. If compiling on TARGET_DARWIN and SOL_IP is not defined, make it the same as IPPROTO_IP. This patch is based upon a patch in the MacPorts bug tracker. Reference: https://trac.macports.org/ticket/30253 Signed-off-by: David Sommerseth <dav...@redhat.

Re: [Openvpn-devel] [PATCH] Added whitespace handling for $KEY_CONFIG variable in easy-rsa/2.0/vars

2011-08-31 Thread David Sommerseth
ble in some kind of requirements list. If we don't have that, that's probably something we should have. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk5d/4YACgkQDC186MBRfrohGACgoQFXyVf3n653bcAfNgPKssg0 K4MAnjYSnGkMxY1Fa64sNqR1MSU6B7L0 =tpDb -END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH] lowercase include header name in syshead.h

2011-08-31 Thread David Sommerseth
to testing and stable master branches. Commit a18c2b025c851a50bd2df33af5bad99b467da595 kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk5ecbsACgkQDC186MBRfrodcwCggiac4FmGOzLpHbO87fO1PzXZ TicAn

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

2011-08-31 Thread David Sommerseth
e636086fe0 [1] contains this feature. Applied to master braches in testing and stable. Commit d90428d141102a646a20b1310de1716621e32bd6 kind regards, David Sommerseth [1] <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4a19ec5800fc3bb64e2d87c4d9fdd9e636086fe0&

Re: [Openvpn-devel] [PATCH] add --mark option to set SO_MARK sockopt

2011-08-31 Thread David Sommerseth
warning in 2.3, though - and be removed in 2.4. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk5ef5UACgkQDC186MBRfrrlswCeO8AgU4L58h9sL1XE358dQ2Tb yO8An0zfR+jb2ci

Re: [Openvpn-devel] First Windows snapshot installer of "master" branch now available

2011-09-09 Thread David Sommerseth
want to get involved, changing OpenVPN, please get in touch! If you don't know where to start, please have a look at our bug tracker: <https://community.openvpn.net/openvpn/report/3> And if you don't feel like writing docs or code, please test our snapshots as much as possible and please

Re: [Openvpn-devel] First Windows snapshot installer of "master" branch now available

2011-09-13 Thread David Sommerseth
ill contain these updates. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk5vbqUACgkQDC186MBRfrr0PACeM6YIshWod7LAdIp80MkBx+i+ pXoAn3hYqLqd8DknpcIdSOZs795IYoZ/ =AzNw -END PGP SIGNATURE-

Re: [Openvpn-devel] hello

2011-09-14 Thread David Sommerseth
ttempt of harvesting our mailing list for mail addresses, used by spam. If you look at the senders mail address, you should get more sceptical. kind regards, David Sommerseth

Re: [Openvpn-devel] Incorrect instructions in tester documentation

2011-09-19 Thread David Sommerseth
eed a review again. That configure option was obsoleted when James resolved this in a complete different way a while ago. Nowadays, you don't need to use this argument at all. That's the only change AFAIR. Please feel free to update the docs! kind regards, David Sommerseth -BEGIN PGP SIG

Re: [Openvpn-devel] NetBSD platform cleanup

2011-09-21 Thread David Sommerseth
l investigating). > > David, please ACK and merge :-) > ACK. Applied to testing and stable master branches. commit 8ca19c014c149cf69257798afa6c75d1ff8f11a7 kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Usi

Re: [Openvpn-devel] [PATCH] Client's routes ageing timer

2011-09-30 Thread David Sommerseth
_reap_range(). We're running a very large connectivity infrastructure based on openVPN (more than 4000 different clients connected per day per server), so we can throughly check this patch (or, of course, any variant of it). Signed-off-by: Davide Guerri <d.gue...@caspur.it>

Re: [Openvpn-devel] [PATCH] Client's routes ageing timer

2011-10-09 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/11 12:31, Gert Doering wrote: | Hi, | | On Fri, Sep 30, 2011 at 11:12:12AM +0200, David Sommerseth wrote: |> On 15/09/11 23:42, Davide Guerri wrote: |>> Please find attached a patch for a new stale-routes-check (and remove) |

[Openvpn-devel] [PATCH] Fix plugin_call() struct env_set corruption

2011-10-23 Thread David Sommerseth
ssl() keep all its arguments - no matter if SSL is enabled or not. This issues appeared first in commit 1876ccd012e9e2ca6f8e1cd9e7e9bb4bf24ccecb, which does modify the plugin system. Signed-off-by: David Sommerseth <dav...@redhat.com> --- plugin.c |5 + plugin

Re: [Openvpn-devel] PolarSSL 1.0.0 support

2011-10-23 Thread David Sommerseth
. For more info about commits applied, see this URL: <https://community.openvpn.net/openvpn/wiki/PolarSSLintegration> kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://en

[Openvpn-devel] [PATCH] Fix PolarSSL and --pkcs12 option issues

2011-10-23 Thread David Sommerseth
PolarSSL does not support PKCS#12 certificate/key bundles, but had a typo where #ifdef USE_POLARSSL was used, and it should have been #ifndef instead. Also added a few extra exclusions of PKCS#12 messages where appropriate, to avoid confusing users. Signed-off-by: David Sommerseth <

Re: [Openvpn-devel] Rebased SSL patches

2011-10-23 Thread David Sommerseth
ction is here using MD5_DIGEST_LENGTH instead of MD4_DIGEST_LENGTH+5 notice the MD4 vs MD5 prefix. Is this correct? I have not had time to dig too much into if there are more such issues in this patch yet. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG

Re: [Openvpn-devel] Fix PolarSSL and --pkcs12 option issues

2011-10-24 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/10/11 17:33, Nathan Stratton Treadway wrote: > On Sun, Oct 23, 2011 at 12:35:13 +0200, David Sommerseth wrote: >> diff --git a/options.c b/options.c index 39e7a57..4fd6933 100644 --- >> a/options.c +++ b/options.c @@ -559,7 +

[Openvpn-devel] [PATCH v2] Fix PolarSSL and --pkcs12 option issues

2011-10-24 Thread David Sommerseth
PolarSSL does not support PKCS#12 certificate/key bundles, but had a typo where #ifdef USE_POLARSSL was used, and it should have been #ifndef instead. Also added a few extra exclusions of PKCS#12 messages where appropriate, to avoid confusing users. Signed-off-by: David Sommerseth <

Re: [Openvpn-devel] [PATCH 3/3] Changed default algorithm for PolarSSL to AES-128, as BF is not supported

2011-10-24 Thread David Sommerseth
probably not a clever idea - to change the default encryption algorithm. What about to enforce the use of --cipher when OpenVPN is compiled with PolarSSL support? Stating that blowfish isn't supported and another cipher must explicit be set. kind regards, David Sommerseth >> -Ori

Re: [Openvpn-devel] [PATCH] When using multihome, create environment variables for target IP and interface on the server

2011-10-24 Thread David Sommerseth
the challenge here is that --multihome is only suitable in UDP mode, iirc. So most likely many of these multihome code paths are avoided when running in TCP mode. Maybe in the areas around multo_process_* functions would be a better place to implement this then ... not sure, just thinking aloud. kind

Re: [Openvpn-devel] [PATCH] Added missing #ifdef to allow --disable-managent to work again

2011-10-24 Thread David Sommerseth
it.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Oct 24 11:39:05 2011 +0200 Added missing #ifdef to allow --disable-managent to work again Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by: Gert Doering <g...@greenie.muc.de> Signed-of

Re: [Openvpn-devel] [PATCH 2/3] Fixed disabling crypto and SSL

2011-10-24 Thread David Sommerseth
4ca642a4d8bbdac3dadb44eca11f52e35 Author: Adriaan de Jong <dej...@fox-it.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Oct 24 10:46:01 2011 +0200 Fixed disabling crypto and SSL Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by: David Sommerseth

Re: [Openvpn-devel] [PATCH 3/3] Changed default algorithm for PolarSSL to AES-128, as BF is not supported

2011-10-24 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 24/10/11 12:39, Adriaan de Jong wrote: > On 10/24/2011 11:50 AM, David Sommerseth wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 24/10/11 10:58, Adriaan de Jong wrote: >>> Unfortunately BF isn'

Re: [Openvpn-devel] [PATCH 1/3] Got rid of a few magic numbers in ntlm.c

2011-10-24 Thread David Sommerseth
m> List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Oct 24 10:46:00 2011 +0200 Got rid of a few magic numbers in ntlm.c Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by: James Yonan <ja...@openvpn.net> Acked-by: David Sommerseth <dav...@redhat.com> Si

Re: [Openvpn-devel] [PATCH] Removed obsolete des_cblock and des_keyschedule

2011-10-24 Thread David Sommerseth
8bcb5783 kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6lb84ACgkQDC186MBRfrpJjACgibrV+mZDECZVOQNvDqWqfDHK /OAAn1H91PyM1dyQk6dBWDA8i85gTWkP =E4w5 -END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH] Further removal of des_old.h based calls

2011-10-25 Thread David Sommerseth
-it.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Oct 24 16:11:14 2011 +0200 Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by: Gert Doering <g...@greenie.muc.de> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth ---

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2011-10-31 Thread David Sommerseth
y) reduce the variety in new patches. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6vDvoACgkQDC186MBRfrr6PwCdGFh7VKA9nRN05ommWCnAe9CH xJIAoJRW8+pjM7ipFeQW4nHgBY7S1Ty7 =0kja -END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH 3/8] Fixed missing comma in plugin.h

2011-11-07 Thread David Sommerseth
: openvpn-devel@lists.sourceforge.net Date: Mon Oct 31 16:29:16 2011 +0100 Fixed missing comma in plugin.h Fixed a bug where the wrong value was being passed to plugin_call_ssl, due to a missing comma. Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by:

Re: [Openvpn-devel] [PATCH] Fix plugin_call() struct env_set corruption

2011-11-07 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/10/11 13:15, David Sommerseth wrote: > For some odd reasons, the static inline plugin_call() function > managed to corrupt the struct env_set *es pointer. The result was > that es->list pointed at an invalid address, which again

Re: [Openvpn-devel] [PATCH v2] Fix PolarSSL and --pkcs12 option issues

2011-11-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 24/10/11 08:53, David Sommerseth wrote: > PolarSSL does not support PKCS#12 certificate/key bundles, but had a > typo where #ifdef USE_POLARSSL was used, and it should have been > #ifndef instead. > > Also added a few extra exclus

Re: [Openvpn-devel] patch to windows tap driver

2011-11-10 Thread David Sommerseth
List-Post: openvpn-devel@lists.sourceforge.net Date: Thu Nov 10 20:15:44 2011 +0100 Signed-off-by: Christian Niessner <bug-rep...@secadm.de> Acked-by: Gert Doering <g...@greenie.muc.de> Signed-off-by: Gert Doering <g...@greenie.muc.de> Signed-off-by: David Sommerseth <dav...@

[Openvpn-devel] [PATCH] Make '--win-sys env' default

2011-11-18 Thread David Sommerseth
removes the hard coded approach and uses the --win-sys env approach by default instead. Trac-ticket: 66 URL: http://thread.gmane.org/gmane.network.openvpn.user/32508 Signed-off-by: David Sommerseth <dav...@redhat.com> Tested-by: Samuli Seppänen <sam...@openvpn.net> --- open

Re: [Openvpn-devel] Series of patches to fix Windows builds and other errors

2011-11-21 Thread David Sommerseth
le master branches. > [PATCH 1/8] Moved prng_uninit out of crypto_uninit_lib commit 54628d1ac10675d4554b58500341e35e8ac4fcbb Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat

[Openvpn-devel] [PATCH] Fix FreeBSD/OpenBSD/NetBSD compiler warnings in get_default_gateway()

2011-11-21 Thread David Sommerseth
On these platforms (including DragonFly), get_default_gateway() would in some cases return false. As get_default_gateway() is defined as a void function, and none of the callers expect a return value -> just return without any value. Signed-off-by: David Sommerseth <dav...@redh

Re: [Openvpn-devel] [PATCH] Clean-up: check_subnet_conflict() function was #if 0 -> remove it

2011-11-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 21/11/11 13:07, Gert Doering wrote: > hi, > > On Mon, Nov 21, 2011 at 12:59:25PM +0100, David Sommerseth wrote: >> As the body of the check_subnet_conflict() function was disabled >> with an #if 0 clause, remove this func

Re: [Openvpn-devel] [PATCH] Fix FreeBSD/OpenBSD/NetBSD compiler warnings in get_default_gateway()

2011-11-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 21/11/11 12:59, David Sommerseth wrote: > On these platforms (including DragonFly), get_default_gateway() would > in some cases return false. As get_default_gateway() is defined as a > void function, and none of the callers expect a ret

[Openvpn-devel] [PATCH] Fix compilation errors on Linux platforms without SO_MARK

2011-11-21 Thread David Sommerseth
or not. Signed-off-by: David Sommerseth <dav...@redhat.com> --- configure.ac |3 +++ options.c|6 +++--- socket.c |4 ++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index a4d68e6..02382a8 100644 --- a/configure.ac +++ b/config

Re: [Openvpn-devel] [PATCH] Make '--win-sys env' default

2011-11-23 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18/11/11 13:39, David Sommerseth wrote: > Without this patch, the default path used by OpenVPN is hard coded to > C:\WINDOWS. As users might install Windows in a different directory, > this approach will cause OpenVPN to malfunctio

Re: [Openvpn-devel] extra patches needed for tap driver bugfix

2011-11-23 Thread David Sommerseth
ert Doering <g...@greenie.muc.de> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com> commit 1523d1101222340b7ef305020ed7eba0dd1676cf (master) commit 066df6aa44c154bb94403b364f585c4ed569bf47 (release/2.2) Author

[Openvpn-devel] [PATCH] Fix bug after removing Linux 2.2 support

2011-11-24 Thread David Sommerseth
From: David Sommerseth <d...@users.sourceforge.net> In commit ce637abdafdc19547fc97192033a4d1703ecaf23 the Linux 2.2 support was removed. When this happened an extra error check was avoided which would normally kicked in if the tun/tap device would not be available. Instead the followin

[Openvpn-devel] [PATCH] RFC: Improve file checking during start-up

2011-11-24 Thread David Sommerseth
From: David Sommerseth <d...@users.sourceforge.net> The following patch has been laying in my repository for some time, unsure why it's been there for so long. I can't see nor recall if I posted it to this -devel list either. If there are things I should have fixed up before re-p

[Openvpn-devel] [PATCH] Do some file/directory tests before really starting openvpn

2011-11-24 Thread David Sommerseth
at this late point might even be difficult to relate to a configuration option. This patch tries to catch as many of these files as soon as possible, kind of to "smoke-test" the files and directories to avoid the most likely errors. Trac-ticket: 73 Signed-off-by: David Somme

[Openvpn-devel] [PATCH v2] Fix bug after removing Linux 2.2 support

2011-11-25 Thread David Sommerseth
From: David Sommerseth <d...@users.sourceforge.net> In commit ce637abdafdc19547fc97192033a4d1703ecaf23 the Linux 2.2 support was removed. When this happened an extra error check was avoided which would normally kicked in if the tun/tap device would not be available. Instead the followin

Re: [Openvpn-devel] [PATCH] Do some file/directory tests before really starting openvpn

2011-11-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 24/11/11 23:10, David Sommerseth wrote: > OpenVPN can handle over 30 different files and directories, and it is > easy to misconfigure some of them. In many situations OpenVPN will > even start running, even with a wrong file path o

Re: [Openvpn-devel] Snapshot openvpn-2.x-20110909-master-install.exe fails

2011-11-25 Thread David Sommerseth
g binary will then fail on WinXP. Signed-off-by: Gert Doering <g...@greenie.muc.de> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuP

Re: [Openvpn-devel] [PATCH v2] Fix bug after removing Linux 2.2 support

2011-11-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 25/11/11 11:57, David Sommerseth wrote: > From: David Sommerseth <d...@users.sourceforge.net> > > In commit ce637abdafdc19547fc97192033a4d1703ecaf23 the Linux 2.2 > support was removed. When this happened an extra error ch

[Openvpn-devel] [PATCH] Windows does not have dirname() - reimplement a portable version

2011-12-02 Thread David Sommerseth
already available in openvpn_basename(). The POSIX variant of dirname() will modify the input data. Signed-off-by: David Sommerseth <dav...@redhat.com> Cc: Heiko Hund <heiko.h...@sophos.com> --- misc.c| 36 misc.h|3 +++ options.c |3

[Openvpn-devel] [PATCH] Provide an access() wrapper for Windows

2011-12-02 Thread David Sommerseth
Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds extra file and directory checks at startup. However, this patch makes use of some features not directly available in Windows. This patch avoids #include on Windows and provides a wrapper for the needed access() function. Signed-off-by: David

[Openvpn-devel] [PATCH v2] Provide an access() wrapper for Windows

2011-12-02 Thread David Sommerseth
which is global for all platforms is called openvpn_access() Signed-off-by: David Sommerseth <dav...@redhat.com> Cc: Heiko Hund <heiko.h...@sophos.com> --- misc.h| 12 options.c |9 - syshead.h |3 +++ win32.h | 20 4 files

Re: [Openvpn-devel] [PATCH] Windows does not have dirname() - reimplement a portable version

2011-12-02 Thread David Sommerseth
approach is found. But that will happen earliest after the 2.3 release is shipped. kind regards, David Sommerseth > On Fri, Dec 2, 2011 at 1:02 PM, David Sommerseth <dav...@redhat.com> > wrote: >> >> Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds some ext

Re: [Openvpn-devel] [PATCH v2] Provide an access() wrapper for Windows

2011-12-02 Thread David Sommerseth
ess() function in win32.h instead. But that didn't compile so well in Visual Studio. As it is a wrapper function for platform neutrality, prefixing it with openvpn_ makes that much clearer when reading the code. kind regards, David Sommerseth > On Fri, Dec 2, 2011 at 2:17 PM, David Somm

[Openvpn-devel] Suggesting a new patch review approach

2011-12-02 Thread David Sommerseth
in the community, I'd like to start using this new outline asap. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7Yx0EACgkQDC186MBRfrrBLgCfe07JKnrHEzqCVUsWcN/8QiEF

Re: [Openvpn-devel] Suggesting a new patch review approach

2011-12-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/12/11 13:35, Samuli Seppänen wrote: > >>> -Original Message- From: Samuli Seppänen >>> [mailto:sam...@openvpn.net] Sent: maandag 5 december 2011 11:47 >>> To: David Sommerseth Cc: openvpn-devel@lists.so

[Openvpn-devel] [Windows] Malware and OpenVPN GUI installer from CNET's download.com service

2011-12-07 Thread David Sommerseth
via PGP or GnuPG in Windows as well. Thanks goes to hyper_ch on #openvpn at FreeNode (IRC) for notifying us about this issue. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

[Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

2011-12-07 Thread David Sommerseth
(), openvpn won't build in Visual Studio. Signed-off-by: David Sommerseth <dav...@redhat.com> --- Makefile.am |1 + compat.c | 58 ++ compat.h | 57 + configure.ac

[Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

2011-12-08 Thread David Sommerseth
the usage of access() - despite it is being redefinded as _access(). Signed-off-by: David Sommerseth <dav...@redhat.com> --- configure.ac|2 +- options.c |1 - win/config.h.in | 29 + 3 files changed, 30 insertions(+), 2 deletions(-) diff

Re: [Openvpn-devel] [PATCH] Don't look for 'stdin' file when using --auth-user-pass

2011-12-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/11 16:34, David Sommerseth wrote: > This argument allows the keyword 'stdin' to indicate that the input is > to be read from the stdin. Don't check for file existence if the file > name is set to 'stdin' > > Signed-off-by: D

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

2011-12-08 Thread David Sommerseth
/beta releases), or if we will take it in the next round with v2.4. But I will bring that up for discussion soonish. kind regards, David Sommerseth On 08/12/11 09:33, michael-dev wrote: > This patch adds an option to disable the creation of tagged priority > packets with

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 08:42, Alon Bar-Lev wrote: > On Thu, Dec 8, 2011 at 1:46 AM, David Sommerseth <dav...@redhat.com> > wrote: >> >> This kicks out the openvpn_basename() function from misc.[ch] >> andputs it into compat.[ch]

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

2011-12-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 08:44, Alon Bar-Lev wrote: > On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth <dav...@redhat.com> > wrote: >> +/* The POSIX access() function is called via _access() on Windows, >> + * defined in io.h + */ +#defin

[Openvpn-devel] [PATCH v2] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread David Sommerseth
(), openvpn won't build in Visual Studio. v2: Move all functions from compat.h to compat.c Signed-off-by: David Sommerseth <dav...@redhat.com> --- Makefile.am |1 + compat.c | 82 ++ compat.h

Re: [Openvpn-devel] [PATCH v2] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 14:01, David Sommerseth wrote: > This kicks out the openvpn_basename() function from misc.[ch] andputs > it into compat.[ch]. This is to provide the same functionality on > platforms not having a native basename() function

[Openvpn-devel] [PATCH v3] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread David Sommerseth
. Without dirname(), openvpn won't build in Visual Studio. v2: Move all functions from compat.h to compat.c v3: Use glibc versions of basename() and dirname() instead Signed-off-by: David Sommerseth <dav...@redhat.com> --- Makefile.am |1 + compat.c

[Openvpn-devel] [PATCH v2] Move away from openvpn_basename() over to platform provided basename()

2011-12-08 Thread David Sommerseth
(), openvpn won't build in Visual Studio. v2: Move all functions from compat.h to compat.c Signed-off-by: David Sommerseth <dav...@redhat.com> --- Makefile.am |1 + compat.c | 82 ++ compat.h

Re: [Openvpn-devel] [PATCH v3] Move away from openvpn_basename() over to platform provided basename()

2011-12-09 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 (resent - go get it into the mailing list too) On 09/12/11 09:02, Gert Doering wrote: > Hi, > > On Thu, Dec 08, 2011 at 04:24:20PM +0100, David Sommerseth wrote: >> This kicks out the openvpn_basename() function from misc.[ch] and

Re: [Openvpn-devel] Problem with alloc_buf_gc function

2011-12-12 Thread David Sommerseth
uld even recommend you to move up to the 2.2 releases. But yes, there are some configurations which are not 2.0/2.1 compatible. But we don't pay attention to that any more. We rather encourage everyone to move up to the 2.2 release. <http://openvpn.net/index.php/open-source/downloads.html>

[Openvpn-devel] [PATCH] Only warn about non-tackled IPv6 packets once

2011-12-13 Thread David Sommerseth
This patch modifies this message to state that IPv6 packets are not tackled in tun mode, and prints it only once. Trac: 147 Signed-off-by: David Sommerseth <dav...@redhat.com> --- mroute.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/mroute.c b/mroute.c

Re: [Openvpn-devel] [PATCH] Only warn about non-tackled IPv6 packets once

2011-12-13 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13/12/11 18:14, David Sommerseth wrote: > When using OpenVPN 2.2 on clients and server with Windows based > clients, it will try to push IPv6 packets through the tunnel. This > causes the server log to be filled up with log ent

Re: [Openvpn-devel] [PATCH] Backported pkcs11-related parts of 7a8d707237bb18 to 2.2 branch

2011-12-14 Thread David Sommerseth
in/settings.in |4 3 files changed, 15 insertions(+), 4 > deletions(-) > Applied to the release/2.2 branch on stable. commit 81ce1d45f88bec701fd477fa061acd0f0033fdf9 kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Usin

Re: [Openvpn-devel] [PATCH] Fix compiling with --disable-crypto and/or --disable-ssl

2011-12-15 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/12/11 18:15, David Sommerseth wrote: > The checks introduced in commit > 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 didn't properly remove checks > if crypto or SSL was disabled at compile time. > > Signed-off-by: David

Re: [Openvpn-devel] Problems with add_route_ipv6()

2012-01-04 Thread David Sommerseth
reconnect. options.c: extend pre_pull_save() and pre_pull_restore() to save/restore options->routes_ipv6 as well options.h: add routes_ipv6 to "struct options_pre_pull" route.h, route.c: add clone_route_ipv6_option_list() and copy_route_ipv6_option_l

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/12/11 18:57, Frederic Crozat wrote: > Le lundi 31 octobre 2011 à 22:11 +0100, David Sommerseth a écrit : >> On 31/10/11 16:30, Frederic Crozat wrote: [...snip...] Hey again, and thanks for this great rework! I've looke

[Openvpn-devel] [PATCH] Fix a couple of issues in openvpn_execve()

2012-01-09 Thread David Sommerseth
serious issue (or programming error) somewhere else in the code. Thus, abort execution to get these issues flushed out as quickly as possible. Signed-off-by: David Sommerseth <dav...@redhat.com> --- misc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mi

Re: [Openvpn-devel] [PATCH] adding support for systemd tty console wrapper

2012-01-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/12 15:32, Frederic Crozat wrote: > Le vendredi 06 janvier 2012 à 18:19 +0100, David Sommerseth a écrit : >> On 06/01/12 17:40, Frederic Crozat wrote: >>> Le vendredi 06 janvier 2012 à 17:22 +0100, David Sommerseth a >>

Re: [Openvpn-devel] [PATCH] Fix a couple of issues in openvpn_execve()

2012-01-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/12 18:11, David Sommerseth wrote: > If openvpn_execve() is not able to fork(), it would make any noise > about it. So this patch adds a log notification if this happens. > > In addition, if openvpn_execve() is called with a

Re: [Openvpn-devel] [PATCH v3] Move away from openvpn_basename() over to platform provided basename()

2012-01-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 16:24, David Sommerseth wrote: > This kicks out the openvpn_basename() function from misc.[ch] and puts > glibc equivalents into compat.[ch]. This is to provide the same > functionality on platforms not having a native

Re: [Openvpn-devel] [PATCH] Enable access() when building in Visual Studio

2012-01-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 12:38, David Sommerseth wrote: > Visual Studio does not enable certiain standard Unix functions, such > as access(). By defining _CRT_NONSTDC_NO_WARNINGS and > _CRT_SECURE_NO_WARNINGS, these functions are enabled. > >

[Openvpn-devel] [PATCH] autotools ./configure don't like compat.h

2012-01-11 Thread David Sommerseth
PACKAGE_NAME check if config.h should be included. This looks like a check if syshead.h is loaded via ./configure or if it is a more normal compilation. Moving the compat.h inclusion into this #ifndef block. Signed-off-by: David Sommerseth <dav...@redhat.com> --- syshead.h |2 +- 1

Re: [Openvpn-devel] [PATCH] autotools ./configure don't like compat.h

2012-01-11 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/01/12 14:57, David Sommerseth wrote: > The compat.h include file cannot be loaded when ./configure runs, as > many of the HAVE_* declarations are not set. This makes test > compilations when looking for features fail. > >

[Openvpn-devel] [PATCH] Fix pool logging when IPv6 is not enabled

2012-01-14 Thread David Sommerseth
message, and nothing seems to be pushed to the client. This site is now running with this patch applied, and it behaves better. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

Re: [Openvpn-devel] [PATCH] Fix pool logging when IPv6 is not enabled

2012-01-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/01/12 12:47, David Sommerseth wrote: | | Hi, | | I'm running the master branch (commit 330baf2aee70b35) on a site where IPv6 | tunnelling is not enabled. I found some odd IPv6 addresses in the log file | when clients connected. Attached

Re: [Openvpn-devel] [PATCH] Fix pool logging when IPv6 is not enabled

2012-01-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/01/12 12:52, David Sommerseth wrote: > On 14/01/12 12:47, David Sommerseth wrote: | | Hi, | | I'm running > the master branch (commit 330baf2aee70b35) on a site where IPv6 | > tunnelling is not enabled. I found some odd IPv6

[Openvpn-devel] [PATCH] Don't check for file presence on inline files

2012-01-16 Thread David Sommerseth
check_file_access(). Signed-off-by: David Sommerseth <dav...@redhat.com> --- options.c | 37 ++--- 1 files changed, 26 insertions(+), 11 deletions(-) diff --git a/options.c b/options.c index 562c6f6..573bde5 100644 --- a/options.c +++ b/options.c @@ -2653,24 +2

[Openvpn-devel] [PATCH v2] Don't check for file presence on inline files

2012-01-16 Thread David Sommerseth
check_file_access(). [v2 Simplify the code, using a flag to check_file_access()] Signed-off-by: David Sommerseth <dav...@redhat.com> --- options.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/options.c b/options.c index 562c6f6..e7e6565 100644 --- a/opt

<    1   2   3   4   5   6   7   8   9   10   >