Re: [Openvpn-devel] [PATCH v2] Don't check for file presence on inline files

2012-01-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/01/12 12:04, David Sommerseth wrote: > The configuration file supports inline files for --ca, --cert, --dh, > --extra-certs, --key, --pkcs12, --secret and --tls-auth. When this > is used, the filename is set to [[INLINE]]

Re: [Openvpn-devel] FreeBSD platform cleanup

2012-01-23 Thread David Sommerseth
lied to master branch on - -testing/-stable. commit 62c613d46dc495d747074ca030d2cbdfd255c386 Author: Gert Doering <g...@fbsd74.ov.greenie.net> List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Jan 22 23:21:22 2012 +0200 Platform cleanup for FreeBSD Signed-off-by: Gert D

[Openvpn-devel] [PATCH] Add --route-pre-down/OPENVPN_PLUGIN_ROUTE_PREDOWN script/plug-in hook

2012-01-24 Thread David Sommerseth
. And then to unmount this file system via --route-pre-down Signed-off-by: David Sommerseth <dav...@redhat.com> --- init.c | 21 +++-- openvpn-plugin.h |3 ++- openvpn.8|4 options.c| 11 +++ options.h|1 + 5

Re: [Openvpn-devel] [PATCH] Add --route-pre-down/OPENVPN_PLUGIN_ROUTE_PREDOWN script/plug-in hook

2012-01-27 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 24/01/12 12:38, David Sommerseth wrote: > This patchs adds a script/plug-in hook which is called right before > the network routes are taken down. This is give external processes a > possibility to tear down communication over the V

Re: [Openvpn-devel] [PATCH] Add --route-pre-down/OPENVPN_PLUGIN_ROUTE_PREDOWN script/plug-in hook

2012-01-31 Thread David Sommerseth
any useful information. What you brought up is pretty much valuable feedback ... and if it even results in more man page patches coming in, it'll be even more worth than gold to us :) So I'm hoping for man page patches now .. *hint*hint* ;-) kind r

Re: [Openvpn-devel] more t_client.sh fixes

2012-02-04 Thread David Sommerseth
g...@greenie.muc.de> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth

Re: [Openvpn-devel] IPv6 enhancement: non-/64 prefix lengths for IPv6 [v2]

2012-02-04 Thread David Sommerseth
...@greenie.muc.de> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth

Re: [Openvpn-devel] [PATCH 1/2] Moved out of memory prototype to error.h, as the definition is in error.c

2012-02-05 Thread David Sommerseth
<dej...@fox-it.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Feb 5 12:51:24 2012 +0100 Moved out of memory prototype to error.h, as the definition is in error.c Signed-off-by: Adriaan de Jong <dej...@fox-it.com> Acked-by: David Sommerseth <dav...

Re: [Openvpn-devel] add ipv6 related env variables to openvpn.8

2012-02-05 Thread David Sommerseth
penvpn-devel@lists.sourceforge.net Date: Sat Feb 4 18:18:45 2012 +0100 Document IPv6-related environment variables. Signed-off-by: Gert Doering <g...@greenie.muc.de> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com>

Re: [Openvpn-devel] [PATCH 2/2] Removed support for calling gc_malloc with a NULL gc_arena struct

2012-02-05 Thread David Sommerseth
es where env_set_create() is called with NULL. Let's rather see if we can provide a gc_arena pointer those places instead. Or do something which is more clear in regards to memory allocation in env_set_create(). kind regards, David Sommerseth

[Openvpn-devel] [PATCH] Fix assert() situations where gc_malloc() is called without a gc_arena object

2012-02-07 Thread David Sommerseth
to not use gc_malloc() at all. Signed-off-by: David Sommerseth <dav...@redhat.com> --- buffer.c | 25 ++--- init.c |2 +- openvpn.c|2 +- options.c|2 ++ pf.c |2 +- ssl_verify.c |2 ++ 6 files changed, 29 insertions(+), 6 del

Re: [Openvpn-devel] [PATCH v2] Fix assert() situations where gc_malloc() is called without a gc_arena object

2012-02-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/02/12 14:31, David Sommerseth wrote: > In commit bee92b479414d12035b0422f81ac5fcfe14fa645 the gc_malloc() > was hardened to always require a gc_arena object for garbage > collection. Some places in the code expected the old

Re: [Openvpn-devel] OpenBSD platform cleanup

2012-02-08 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/02/12 16:48, Gert Doering wrote: > Hi, > > On Sun, Feb 05, 2012 at 03:02:40PM +0100, David Sommerseth wrote: >>> as promised :-) - it now passes all my t_client.rc tests, and >>> smells a lot less funny. We n

Re: [Openvpn-devel] [PATCH] Check for ENABLE_MANAGEMENT for ENABLE_CLIENT_CR

2012-02-13 Thread David Sommerseth
nt and --enable-small ... And I could not manage to trigger this one. Our buildbot (even though, not testing all combinations) have also not triggered this one. Could you provide more version information and the configure arguments you use? kind regards, David Sommerseth -BEGIN PGP SIGNATUR

Re: [Openvpn-devel] [PATCH] Check for ENABLE_MANAGEMENT for ENABLE_CLIENT_CR

2012-02-13 Thread David Sommerseth
for review. If this is acked, please consider using this one instead (patch 0001). > And another is that i'm talking about. I'm giving your patch an ACK, so that will go into the tree. But even one more fix is needed, which is in the second patch I attached. kind regards, David Sommer

Re: [Openvpn-devel] [PATCHv2] handle Windows unicode paths

2012-02-13 Thread David Sommerseth
hos.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Feb 10 15:13:42 2012 +0100 handle Windows unicode paths Signed-off-by: Heiko Hund <heiko.h...@sophos.com> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...

Re: [Openvpn-devel] [PATCHv2] Windows UTF-8 input/output

2012-02-13 Thread David Sommerseth
;heiko.h...@sophos.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Wed Nov 23 19:08:34 2011 +0100 Windows UTF-8 input/output Signed-off-by: Heiko Hund <heiko.h...@sophos.com> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <d

Re: [Openvpn-devel] [PATCH] Made some options connection-entry specific

2012-02-13 Thread David Sommerseth
ist-Post: openvpn-devel@lists.sourceforge.net Date: Tue Feb 7 16:29:47 2012 +0100 Made some options connection-entry specific Signed-off-by: Jan Just Keijser <janj...@nikhef.nl> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...

Re: [Openvpn-devel] [PATCH] Check for ENABLE_MANAGEMENT for ENABLE_CLIENT_CR

2012-02-13 Thread David Sommerseth
agement If the management interface is not enabled, it makes no sense in including the ENABLE_CLIENT_CR #ifdef blocks. This will also in some configurations cause build issues if these blocks are enabled. Signed-off-by: Igor Novgorodov <i...@novg.net> Acked-by: David Sommerset

Re: [Openvpn-devel] Cipher problem on Mac OS X

2012-02-16 Thread David Sommerseth
hould be int. On some platforms like OS X, any returned value larger than one will be converted to 1. Signed-off-by: Frank de Brabander <braban...@fox-it.com> Acked-by: Adriaan de Jong <dej...@fox-it.com> Signed-off-by: David Sommerseth <dav...@redhat.com> K

[Openvpn-devel] [PATCH v2] use the underscore version of stat on Windows

2012-02-16 Thread David Sommerseth
From: Heiko Hund <heiko.h...@sophos.com> MSVC does not know wstat(). Instead _wstat() must be used here. Unfortunately _wstat() takes a 'struct _stat'. A type 'stat_t' is introduced to handle this situation in a portable way. [v2: Use openvpn_stat_t instead of stat_t (David Sommerseth)]

Re: [Openvpn-devel] MSVC fixes

2012-02-17 Thread David Sommerseth
as it is only defined for mingw builds done with the autotools buildsystem. Signed-off-by: Heiko Hund <heiko.h...@sophos.com> Acked-by: Gert Doering <g...@greenie.muc.de> Signed-off-by: David Sommerseth <dav...@redhat.com> commit d0109cbf459409a84963668c78f444c97e

Re: [Openvpn-devel] [PATCH] move variable declaration to top of function

2012-02-17 Thread David Sommerseth
is as it's not according to C89. Signed-off-by: Heiko Hund <heiko.h...@sophos.com> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GN

[Openvpn-devel] [PATCH] Makefile.am referenced a now non-existing config-win32.h

2012-02-17 Thread David Sommerseth
This file was moved to win/config.h.in and is the template used by the Python build tools in win/. This happened in commit 4b312378e9e7084a0699ca6d4b895bdadb7540db For all other autotools based environments, ./configure will take care of creating the proper config.h Signed-off-by: David

[Openvpn-devel] [PATCH] Makefile.am was missing ssl_common.h

2012-02-17 Thread David Sommerseth
In commit 9a160b796e1a40f9635231e5533ce40d46dba25f ssl_common.h was introduced, but never listed as a source file in Makefile.am Signed-off-by: David Sommerseth <dav...@redhat.com> --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makef

Re: [Openvpn-devel] [PATCH] Makefile.am was missing ssl_common.h

2012-02-17 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/02/12 12:30, David Sommerseth wrote: > In commit 9a160b796e1a40f9635231e5533ce40d46dba25f ssl_common.h was > introduced, but never listed as a source file in Makefile.am > > Signed-off-by: David Sommerseth <dav...@redhat.com&g

Re: [Openvpn-devel] [PATCH] Makefile.am referenced a now non-existing config-win32.h

2012-02-17 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/02/12 12:13, David Sommerseth wrote: > This file was moved to win/config.h.in and is the template used by the > Python build tools in win/. This happened in commit > 4b312378e9e7084a0699ca6d4b895bdadb7540db > > For all other

Re: [Openvpn-devel] [DEVELOPER REQUESTED] Repackage TAP-Win32

2012-02-18 Thread David Sommerseth
OpenVPN project, please contact Samuli Seppänen <sam...@openvpn.net> or me (d...@users.sourceforge.net) and we will answer as best as we can. Kind regards, David Sommerseth > [1] https://github.com/alonbl/openvpn branch build. [2] > https://github.com/alonbl/openvpn/blob/build/include/

Re: [Openvpn-devel] [DEVELOPER REQUESTED] Repackage TAP-Win32

2012-02-19 Thread David Sommerseth
lve these things. But for now, I'd like to see more focus on the steps before the packaging method. We first need to have something to package. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

[Openvpn-devel] [PATCH] Revamp check_file_access() checks in stdin scenarios

2012-02-20 Thread David Sommerseth
is also modified to use this flag instead. Signed-off-by: David Sommerseth <dav...@redhat.com> --- options.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/options.c b/options.c index 43e9e27..a596ffe 100644 --- a/options.c +++ b/options.c @@ -2605,6 +

Re: [Openvpn-devel] [PATCH] define access mode flag X_OK as 0 on Windows

2012-02-20 Thread David Sommerseth
.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Feb 18 20:44:12 2012 +0100 define access mode flag X_OK as 0 on Windows Signed-off-by: Heiko Hund <heiko.h...@sophos.com> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerse

Re: [Openvpn-devel] [PATCH] Revamp check_file_access() checks in stdin scenarios

2012-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/02/12 10:37, David Sommerseth wrote: > It was discovered that --management also can take stdin as argument > instead of a file. Enabled this by revamping the check_file_access() > flags by adding CHKACC_ACPTSTDIN. Setting

Re: [Openvpn-devel] Better use ip -batch on adding/removing server pushed routes on Linux

2012-02-20 Thread David Sommerseth
had some time available, I would have looked into it directly. Using capabilities in Linux, it should even be possible for a non-root process to even modify the routing table. (it would have to be started as root, though, but after dropping privileges) kind regards, David Sommerseth -BEGIN

Re: [Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread David Sommerseth
re free to choose between which approach fits you best. But I will not accept patches into the tree unless it has been clearly ACKed publicly. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mo

Re: [Openvpn-devel] [PATCH] windows: do not use X_OK as it is unsupported

2012-02-20 Thread David Sommerseth
go through commit by commit on a web site. Doing it this way we document the review in an e-mail with a summary of the discussions plus the chatlog itself to the mailing list. This approach was used for the PolarSSL patches. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version:

Re: [Openvpn-devel] [PATCH] fix warnings in event.c when building for win32-64

2012-02-21 Thread David Sommerseth
for win32-64 Signed-off-by: Heiko Hund <heiko.h...@sophos.com> Acked-by: James Yonan <ja...@openvpn.net> URL: http://article.gmane.org/gmane.network.openvpn.devel/4979 Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth -BEGIN PGP

Re: [Openvpn-devel] [PATCH] remove wrapper code for Windows CryptoAPI function

2012-02-21 Thread David Sommerseth
Yonan <ja...@openvpn.net> URL: http://article.gmane.org/gmane.network.openvpn.devel/4979 Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://e

Re: [Openvpn-devel] [RFC] openssl minimum supported version

2012-02-21 Thread David Sommerseth
slaves running too. We have CentOS6 which should be good enough for the RHEL6 base. Otherwise, I presume most of the *BSD versions have more recent versions. kind regards, David Sommerseth [1] <https://access.redhat.com/support/policy/updates/errata/> (Side note: RHEL4 does have an e

Re: [Openvpn-devel] [RFC] openssl minimum supported version

2012-02-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 21/02/12 17:12, Alon Bar-Lev wrote: > On Tue, Feb 21, 2012 at 5:56 PM, David Sommerseth > <openvpn.l...@topphemmelig.net> wrote: >> There might be similar restrictions related to autoconf/automake >> tools too. As J

Re: [Openvpn-devel] OpenVPN 2.3-alpha1 preview 1 installer now available

2012-02-22 Thread David Sommerseth
re. But I don't have any OSX boxes available and lack some knowledge about the OSX build environment, so it's really hard to figure out immediately. I hope others with OSX can have a look at what's causing this. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: Gnu

Re: [Openvpn-devel] [RFC][windows] gettimeofday()

2012-02-22 Thread David Sommerseth
ate middle-road? I too would like to see MSVC go away. Very much. But again, let's not decide that without James approval for it. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEA

Re: [Openvpn-devel] [RFC] openssl minimum supported version

2012-02-22 Thread David Sommerseth
OpenVPN 2.2 and older. I would even say that if nobody rejects this idea within the next 72 hours, then it is decided. If James can reply and give it an ACK, it will be valid instantly. Is that fine with everyone? kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1

Re: [Openvpn-devel] [RFC][windows] gettimeofday()

2012-02-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/02/12 17:40, Alon Bar-Lev wrote: > On Wed, Feb 22, 2012 at 6:37 PM, David Sommerseth > <openvpn.l...@topphemmelig.net> wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 22/02/12 17:27, Heiko H

Re: [Openvpn-devel] [RFC] openssl minimum supported version

2012-02-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/02/12 17:46, David Sommerseth wrote: > On 22/02/12 17:13, Alon Bar-Lev wrote: >> Dear project managers. I need a decision regarding the minimum >> supported openssl. > > I'd say we support these libraries and tools as

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 preview 1 installer now available

2012-02-23 Thread David Sommerseth
specific, I didn't dare touching the OSX code more as I don't have access to that platform at all. kind regards, David Sommerseth From a01f6ff9fb8901048cd9aacdd665affef082084a Mon Sep 17 00:00:00 2001 From: David Sommerseth <dav...@redhat.com> List-Post: openvpn-devel@lists.sourceforge.net Da

Re: [Openvpn-devel] OpenVPN 2.3-alpha1 preview 1 installer now available

2012-02-24 Thread David Sommerseth
d to figure out how to make --multihome work too. JJO, please have a look at this. kind regards David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9H4XMACgkQDC186MBRfrqpVwCfdX8B62YecoVSdXUQ17K0Ra4o FC8AoKn+1eI3NNtAFrEs71TjSWXFf2Po =yRcC -END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH 03/35] cleanup: tun.c: fix incorrect option in message (ip-win32)

2012-02-27 Thread David Sommerseth
AL, "ERROR: --tap-win32 dynamic [offset] : offset is outside > of --ifconfig subnet"); > +msg (M_FATAL, "ERROR: --ip-win32 dynamic [offset] : offset is outside of > --ifconfig subnet"); > >gc_free (); >return htonl(dsa); ACK. Kind regards,

Re: [Openvpn-devel] [PATCH 04/35] cleanup: memcmp.c: remove unused source

2012-02-27 Thread David Sommerseth
ar *p1 = s1, *p2 = s2; - int d; - - if (n) - > while (n-- > 0) - { -d = *p1++ - *p2++; -if (d != 0) - return > d; - } - return 0; -} ACK. Kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mo

Re: [Openvpn-devel] [PATCH 05/35] build: correct place to alter WINVER is at build system

2012-02-27 Thread David Sommerseth
-D_CONSOLE -D_MBCS -D_CRT_SECURE_NO_DEPRECATE > -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS $(INCLUDE_DIRS) > /FD /c +CPP_ARG_COMMON=/nologo /W3 -DWIN32 -DWIN32_LEAN_AND_MEAN > -DWINVER=0x0501 -D_CONSOLE -D_MBCS -D_CRT_SECURE_NO_DEPRECATE > -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNING

Re: [Openvpn-devel] [PATCH 06/35] Update .gitignore

2012-02-27 Thread David Sommerseth
12f5d..8cc07de 100644 --- > a/.gitignore +++ b/.gitignore @@ -5,6 +5,7 @@ *.obj *.pyc *.so +*~ > .deps Makefile Makefile.in ACK. Kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECA

Re: [Openvpn-devel] [PATCH 07/35] build: tests do not work disable

2012-02-27 Thread David Sommerseth
o runs this test in his development repos. So it's rather odd to hear that these tests fail. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9LRl4ACgkQDC186MBRfrrWcQCgklcEZ8

Re: [Openvpn-devel] [PATCH 08/35] build: handle printf style format in mingw

2012-02-27 Thread David Sommerseth
> bool status_close (struct status_output *so); > void status_printf (struct status_output *so, const char *format, ...) > #ifdef __GNUC__ > -__attribute__ ((format (printf, 2, 3))) > +#if __USE_MINGW_ANSI_STDIO > + __attribute__ ((format (gnu_printf, 2, 3))) >

Re: [Openvpn-devel] [PATCH 09/35] build: rename plugin directory to plugins

2012-02-27 Thread David Sommerseth
plugins/examples/log.c create mode 100644 > plugins/examples/log_v3.c create mode 100644 > plugins/examples/simple.c create mode 100755 > plugins/examples/simple.def create mode 100755 > plugins/examples/winbuild ACK. I've not checked that files are not modified, bu

Re: [Openvpn-devel] [PATCH 10/35] build: plugins: properly use CFLAGS and LDFLAGS

2012-02-27 Thread David Sommerseth
gins/examples/build @@ -8,7 +8,7 @@ > # This directory is where we will look for openvpn-plugin.h > INCLUDE="-I../.." > > -CC_FLAGS="-O2 -Wall -g" +CFLAGS="${CFLAGS:--O2 -Wall -g}" > > -gcc $CC_FLAGS -fPIC -c $INCLUDE $1.c && \ -gcc $C

Re: [Openvpn-devel] [PATCH 11/35] Remove install-win32

2012-02-27 Thread David Sommerseth
install-win32/openssl/openssl097.patch delete mode 100644 > install-win32/openssl/openssl098.patch delete mode 100755 > install-win32/openvpn.nsi delete mode 100755 > install-win32/sample.ovpn delete mode 100755 > install-win32/setpath.nsi delete mode 100644 > install-win32/settings.in dele

Re: [Openvpn-devel] [PATCH 12/35] Remove easy-rsa

2012-02-27 Thread David Sommerseth
.txt.start delete mode 100755 > easy-rsa/Windows/init-config.bat delete mode 100644 > easy-rsa/Windows/revoke-full.bat delete mode 100644 > easy-rsa/Windows/serial.start delete mode 100644 > easy-rsa/Windows/vars.bat.sample > ACK. These files will be pulled into a separate git rep

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-02-27 Thread David Sommerseth
i installers, that would just be smooth! Where a "global" installer bundles it into a single package for OpenVPN. Which means other projects which needs a TAP driver on Windows can just pull down our MSI installer and bundle that one. Upgrades could also be handled much smoother than now.

Re: [Openvpn-devel] OpenVPN 2.3-alpha1 preview 1 installer now available

2012-02-27 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 24/02/12 20:13, David Sommerseth wrote: > On 22/02/12 20:49, debrabander wrote: >> This is not the a problem when building using the latest Mac OS X >> SDK. I've did a quick search and it seems to be a more common issue >>

Re: [Openvpn-devel] [PATCH 02/02] Remove calls to OpenSSL when building with --disable-ssl

2012-02-28 Thread David Sommerseth
sted encryption layer. There are people located in not so democratic countries who use OpenVPN to access a not-restricted/censored Internet - and their safety may rely on the security OpenVPN provides. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux)

Re: [Openvpn-devel] [PATCH 02/02] Remove calls to OpenSSL when building with --disable-ssl

2012-02-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/02/12 12:16, Igor Novgorodov wrote: > On 28.02.2012 14:39, David Sommerseth wrote: >> On 28/02/12 06:54, Igor Novgorodov wrote: >>> Then maybe we should move these calls to crypto_openssl.c into >>> crypto_init_lib(

Re: [Openvpn-devel] [PATCH 02/02] Remove calls to OpenSSL when building with --disable-ssl

2012-02-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/02/12 12:40, Igor Novgorodov wrote: > On 28.02.2012 15:34, David Sommerseth wrote: >> On 28/02/12 12:16, Igor Novgorodov wrote: >>> On 28.02.2012 14:39, David Sommerseth wrote: >>>> On 28/02/12 06:54, I

[Openvpn-devel] Temporarily delaying patch acceptances

2012-02-28 Thread David Sommerseth
on this mail when things starts to get moving forward. If you notice that some of your patches have not been applied at that point, you may poke me about it. But until Alon's work is completed, they will be in my little patch queue. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version

Re: [Openvpn-devel] OpenVPN 2.3-alpha1 released

2012-02-28 Thread David Sommerseth
in_open_v3() and openvpn_plugin_func_v3(). If fact, most of the openvpn-plugin.h is a pretty comprehensive reference for the plugin API. For a working example, look at plugin/examples/log_v3.c. For the --client-nat ... look at the man new page. <http://openvpn.net/index.php/manuals/523-openvpn-

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-02-28 Thread David Sommerseth
e to complete his code. But there are so many requesting this feature, we really can't ignore it any more. And Heiko is free to flog me if I've said and/or promised too much :) kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG wit

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-02-28 Thread David Sommerseth
ouldn't necessarily need to know much about how to configure the TUN/TAP device and routes for all different platforms. Rather write platform specific "service helpers" which does that job via the the communication pipe. This would make the OpenVPN code base simpler and perhaps even easier t

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-02-28 Thread David Sommerseth
h=cf69617bbea45a15423c4188daa9386debcbe1ec> So things are happening here too. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9NHVwACgkQDC186MBRfrr/qgCdF2BT+TqE+h2x/Aqoin2

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-02-28 Thread David Sommerseth
in theory; it has not been tested yet) handle more users simultaneously. However, the management interface will be used in addition too, at least in the very beginning, where the logging is transferred back to the GUI and so on. I don't recall now all the GUI would do via this interface. kind regards

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-02-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/02/12 19:42, Alon Bar-Lev wrote: > 2012/2/28 David Sommerseth <openvpn.l...@topphemmelig.net>: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 28/02/12 19:17, Carsten Krüger wrote: >>> Hello Alon,

Re: [Openvpn-devel] OpenVPN 2.3-alpha1 released

2012-02-29 Thread David Sommerseth
nctions, only the newest version will be used. So you can write a plug-in which can make advantage of the new API and features with the latest OpenVPN, while having a fall-back for older OpenVPN versions. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version:

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-02-29 Thread David Sommerseth
his. Please do that ... and report back any issues you find! It would be great to have this verified, tested and reviewed in the next coming week or so. Then I'll have things applied to the upstream tree. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-02-29 Thread David Sommerseth
rver side, for each OS/platform connecting. And you would also need to go even further, to also make --plugin only pushable too. Which makes the /usr/lib vs /usr/lib64 scenario a real pain for sure. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comme

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-03-01 Thread David Sommerseth
e TAP device gets into "initialising mode", Windows makes the device send DHCP requests. The TAP driver and OpenVPN client then fakes a DHCP server which sends the IP address together with the DNS resolver info as DHCP packets back to Windows via the TAP device. kind regards, David Sommerse

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-03-01 Thread David Sommerseth
client should try to lock down things locally, to reduce the impact from local exploits. The server side should restrict the server side, and what is being passed via the tunnel. There's no real way you can make the server enforce restrictions on the client. kin

Re: [Openvpn-devel] setting common-name from plugin

2012-03-02 Thread David Sommerseth
u do, reject again. If you don't have a match, save this identity and report OPENVPN_PLUGIN_FUNC_SUCCESS. You would also need to add an extra plug-in hook, OPENVPN_PLUGIN_CLIENT_DISCONNECT. This hook need to remove the user from this lookup table, to allow the user to connect again later on.

Re: [Openvpn-devel] [PATCH 02/52] package: rpm: strip should be handled by package management

2012-03-06 Thread David Sommerseth
ng the binaries in the .spec file, there won't be any debuginfo files either. The Fedora packaging rules also applies to EPEL, which then (kind of) hits RHEL, CentOS and ScientificLinux as well. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Lin

Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

2012-03-06 Thread David Sommerseth
. Agreed, and I also ACKed this one in the first round. This is basically dead code in the vast majority of platforms. Bear in mind that OpenVPN was released about a decade ago, "a few" things have changed since then ;-) This patch goes in. kind regards, David Sommerseth > 2012/3/

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread David Sommerseth
oach in most cases. The management interface is probably just more interesting where configuration files cannot easily be modified by the user. And this would most likely be used in a targeted attack too. kind regards, David Sommerseth > On Tue, 03/06/2012 11:12 AM, Alon Bar-Lev <alon.b

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread David Sommerseth
be a unprivileged process accessing the management interface, just like the GUI, right? I'm just thinking this would be an interesting approach in some less open countries, where OpenVPN is used to get access to the real free Internet. Distributing a suitable malware on computers with this kind

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

2012-03-07 Thread David Sommerseth
quot;)' it should find the file. However, it isn't as easy to just skip through the string and "terminate it" on the first space (0x20) value, as it might have been escaped. Which can make quite typical paths like this fail: "C:\Program Files\OpenVPN\bin\up-script.bat" I

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-03-14 Thread David Sommerseth
isions, especially not without involving him in the discussion. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9gYIYACgkQDC186MBRfrrm0QCgnIAV0X9WAhA/wua6Dk

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

2012-03-16 Thread David Sommerseth
Alon's work. So this is the current situation. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9jNm0ACgkQDC186MBRfrru9wCfY0VBkGpuxlkQYgTRm8XUwY0V /CIAnjDzRMAMZuJUghW/e+KSfGk6JgRO =l3kb -END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH 30/52] build: add libtool + windows resources for executables

2012-03-16 Thread David Sommerseth
jects solve this in Windows builds? Not sure about anything concrete, but maybe virtio drivers for Windows is a place worth checking out? (virtio drivers in Windows are used for paravirt enabling when running as guest on a KVM host; I believe these drivers are developed with a communit

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

2012-03-19 Thread David Sommerseth
ery long time, and is superior net-tools in very many ways. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9m9esACgkQDC186MBRfrpkYACgmsg0QcAH1QXtqTQE8IihQGfF /rMAoJuiM7i6V9ugXBJpyBGd6SZ/ZA3F =kLgH -END PGP SIGNATURE-

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

2012-03-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/03/12 10:01, David Sommerseth wrote: [...snip...] > > On a related note: --enable-iproute2 > > Should we also expect this to be available on all *nix platforms? > iproute2 has been available on most platforms I know of for a v

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

2012-03-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/03/12 10:42, Gert Doering wrote: > Hi, > > On Mon, Mar 19, 2012 at 10:38:32AM +0100, David Sommerseth wrote: >> On 19/03/12 10:01, David Sommerseth wrote: [...snip...] >>> >>> On a related note: --enable-iprout

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

2012-03-22 Thread David Sommerseth
dd such a patch on top of everything when the merging is completed. The patch will be submitted to the mailing list when it's ready to be implemented. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enig

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

2012-03-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/03/12 12:47, Alon Bar-Lev wrote: > On Thu, Mar 22, 2012 at 1:45 PM, David Sommerseth > <openvpn.l...@topphemmelig.net> wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 19/03/12 16:16, Alon Bar-Lev

Re: [Openvpn-devel] [openvpn-devel] OpenVPN 2.1.4/Linux: route-gatewy not working

2012-03-23 Thread David Sommerseth
y more. So if you could try the latest git master branch [1], that'd be great ... And if that still fails, try to apply your patch to see if that improves it. There has been some fixes to the whole routing part in 2.2 and 2.3, so we need to be sure we're not fixing something which is

Re: [Openvpn-devel] [PATCH 00/52] build revolution

2012-03-24 Thread David Sommerseth
he near future too. Many improvements are to come on top of this. kind regards, David Sommerseth commit 0e4b6c455e0236a4eb45eb1df869b5ce0b97518a Author: Alon Bar-Lev <alon.bar...@gmail.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Wed Feb 29 22:12:22 2012 +0200

Re: [Openvpn-devel] [PATCH 3/6] tree: ChangeLog: add ident attribute

2012-03-26 Thread David Sommerseth
gt; Inc. <sa...@openvpn.net> > > +$Id$ + What is the purpose of this change? kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9wNWEACgkQ

Re: [Openvpn-devel] [PATCH 3/6] tree: ChangeLog: add ident attribute

2012-03-26 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 12:25, Alon Bar-Lev wrote: > On Mon, Mar 26, 2012 at 11:22 AM, David Sommerseth > <openvpn.l...@topphemmelig.net> wrote: >> >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> O

Re: [Openvpn-devel] [PATCH 5/6] build: enable lzo by default

2012-03-26 Thread David Sommerseth
stable. commit 40a56e79d5d45c8e40c599f52349007155f7e475 Author: Alon Bar-Lev <alon.bar...@gmail.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Mar 24 09:58:37 2012 +0200 Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> Acked-by: Gert Doering <g...@greenie.muc.de>

Re: [Openvpn-devel] [PATCH 2/6] build: autoconf: misc sockets fixups

2012-03-26 Thread David Sommerseth
com> Acked-by: David Sommerseth <dav...@redhat.com> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [Openvpn-devel] build problems on FreeBSD of latest openvpn git

2012-03-26 Thread David Sommerseth
error anymore. > > Gentoo stable libtool is sys-devel/libtool-2.4, it contains some > fixes for mingw which I use. Why did you chose 2.2.10? Remember we need to support the RHEL5 platform. That ships with libtool-1.5.22. EL6 ships with 2.2.10. kind regards, David Sommerseth -BEGI

Re: [Openvpn-devel] build problems on FreeBSD of latest openvpn git

2012-03-26 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 20:55, Gert Doering wrote: > Hi, > > On Mon, Mar 26, 2012 at 08:50:20PM +0200, David Sommerseth wrote: >> On 26/03/12 20:38, Alon Bar-Lev wrote: >>> On Mon, Mar 26, 2012 at 11:50 AM, Gert Doering >>> &l

Re: [Openvpn-devel] build problems on FreeBSD of latest openvpn git

2012-03-26 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 20:52, Alon Bar-Lev wrote: > On Mon, Mar 26, 2012 at 8:50 PM, David Sommerseth > <d...@users.sourceforge.net> wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 26/03/12 20:38, Alon Bar-Lev w

Re: [Openvpn-devel] [PATCH 6/6] cleanup: ~0 is too large for 32bit ipv4 address

2012-03-28 Thread David Sommerseth
like to see some consistency, rather to just fix warnings which appears on some platform(s). In general, if you can provide a more verbose description why the patch is written in the commit messages, it will also help the review process. Most of us are not that skilled in reading others mind ;

Re: [Openvpn-devel] [PATCH 3/6] cleanup: warnings at src/openvpn/httpdigest.c

2012-03-28 Thread David Sommerseth
assword)); My remark here goes to all these type-cast patches [1,2,3]. Wouldn't it be way cleaner to rather fix the function declarations and do the proper type-casting in the {crypto,ssl}_{open,polar}ssl.[ch] and {crypto,ssl}_backend.h files? Instead of type-casting the whole source code where such wa

Re: [Openvpn-devel] [PATCH 1/6] build: openbsd: detect netinet/ip.h correctly

2012-03-28 Thread David Sommerseth
c.de> Signed-off-by: David Sommerseth <dav...@redhat.com> kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9y0VUACgkQDC186MBRfrppLwCgn8MB7/81KoZlWorHYVpYOcRC QQQAnjdi

Re: [Openvpn-devel] [PATCH 2/6] build: tap: search for tap header

2012-03-28 Thread David Sommerseth
-testing and -stable trees. commit 7cacdfd4b7f221139e0d2a0334f1f1cd8f2a1b75 Author: Alon Bar-Lev <alon.bar...@gmail.com> List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Mar 26 23:26:36 2012 +0200 Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> Acked-by: David Sommerseth <dav...@r

<    1   2   3   4   5   6   7   8   9   10   >