[Openvpn-devel] [PATCH v2 2/3] use new pkcs11-helper interface to add providers

2022-12-11 Thread Marc Becker via Openvpn-devel
The new interface in pkcs11-helper 1.28 allows decoupling of provider registration and initialization. This allows modifying more (and future) properties apart from the 6 fixed ones supported as arguments to pkcs11h_addProvider(). With the new interface it is easier to see (from a code

[Openvpn-devel] [PATCH v3 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Marc Becker via Openvpn-devel
Change win32 dynamic loader behavior when supplying an absolute path. The DLL location is considered/preferred to resolve dependencies. Support in pkcs11-helper for loader flag is detected at compile time. 3rd party DLLs and additional dependencies do no longer need to be moved to the OpenVPN

Re: [Openvpn-devel] [PATCH v2 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Marc Becker via Openvpn-devel
Hi, my suggestion would be to decide if we want v2 or v3 of 3/3 depending on the pkcs11-helper state immediately before next beta. OpenVPN 2.6 changing behavior shortly after release would be something to avoid in any case. Having the patch around in 2.6 branch only and dropping it in 2.6.1 may

[Openvpn-devel] [PATCH v2 1/3] unify code path for adding PKCS#11 providers

2022-12-11 Thread Marc Becker via Openvpn-devel
Use existing wrapper for pkcs11h_addProvider to have arguments with "magic values" for pkcs11-helper call in a central place. Slot event argument to pkcs11h_addProvider has NOT been a boolean for at least 15 years. Luckily the default is PKCS11H_SLOTEVENT_METHOD_AUTO=0=FALSE. Signed-off-by: Marc

[Openvpn-devel] [PATCH v2 3/3] special handling for PKCS11 providers on win32

2022-12-11 Thread Marc Becker via Openvpn-devel
Change win32 dynamic loader behavior when supplying an absolute path. The DLL location is considered/preferred to resolve dependencies. Support in pkcs11-helper for loader flag is detected at compile time. 3rd party DLLs and additional dependencies do not need to be moved to the OpenVPN directory

[Openvpn-devel] [PATCH] support PKCS11 lib dependencies

2022-12-06 Thread Marc Becker via Openvpn-devel
Modify the Win32-PE search path to find dependencies in shared object origin location. Needs https://github.com/OpenSC/pkcs11-helper/pull/59 to work. Would be nice if this could still be included for v2.6, an additional pkcs11-helper patch may be added to preempt the PR.

[Openvpn-devel] [PATCH 3/3] special handling for PKCS11 providers on win32

2022-12-06 Thread Marc Becker via Openvpn-devel
in case of absolute library path, search origin for dependencies --- src/openvpn/pkcs11.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) needs https://github.com/OpenSC/pkcs11-helper/pull/59 diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c index

[Openvpn-devel] [PATCH 2/3] use new pkcs11-helper provider interface

2022-12-06 Thread Marc Becker via Openvpn-devel
split provider creation, property modifications and initialization. new interface available since pkcs11-helper v1.28 --- src/openvpn/pkcs11.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c index

[Openvpn-devel] [PATCH 1/3] unify code paths for loading PKCS11

2022-12-06 Thread Marc Becker via Openvpn-devel
--- src/openvpn/pkcs11.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c index 507af17c..b6ceb582 100644 --- a/src/openvpn/pkcs11.c +++ b/src/openvpn/pkcs11.c @@ -853,17 +853,7 @@ show_pkcs11_ids( goto cleanup;

[Openvpn-devel] [PATCH] vcpkg-ports/pkcs11-helper: support loader flags

2022-12-14 Thread Marc Becker via Openvpn-devel
Add dynamic loader flag feature to bundled pkcs11-helper. Required to allow special handling for PKCS11 providers on win32. Signed-off-by: Marc Becker --- Part 2 of [PATCH v3 3/3] special handling for PKCS11 providers on win32 - split contrib patch from OpenVPN change See

[Openvpn-devel] [Openvpn-Devel] [PATCH] vcpkg-ports/pkcs11-helper: bump to version 1.30

2023-12-04 Thread Marc Becker via Openvpn-devel
update metadata references for pkcs11-helper v1.30 remove local patches incorporated in new upstream --- .../Fix-build-with-disable-shared.patch | 48 ...cs11-helper-002-dynamic_loader_flags.patch | 104 -- .../vcpkg-ports/pkcs11-helper/portfile.cmake | 6 +-