Re: [Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

Hi, On Thu, Jan 19, 2017 at 2:36 PM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > > So currently its just a preprocessor define that provides a solution > > waiting for a problem. If the consensus is not to define it, fine with > me. > > I have no issues adding such an

Re: [Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

On 19/01/17 16:32, Selva Nair wrote: > Hi, > > Thanks for the comments. > > On Thu, Jan 19, 2017 at 9:41 AM, David Sommerseth > > wrote: > > Any reason to have this AC_DEFINE? That puts HAVE_LD_WRAP_SUPPORT into

Re: [Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

Hi, Thanks for the comments. On Thu, Jan 19, 2017 at 9:41 AM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > Any reason to have this AC_DEFINE? That puts HAVE_LD_WRAP_SUPPORT into > config.h, which I don't think makes much sense. If we don't have --wrap > support, would we

Re: [Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

On 18/01/17 21:42, selva.n...@gmail.com wrote: > From: Selva Nair > > - Also make tests that require --wrap option to be > conditional on this support > > Signed-off-by: Selva Nair > --- > configure.ac | 26

Re: [Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

Hi, On Wed, Jan 18, 2017 at 03:42:52PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > - Also make tests that require --wrap option to be > conditional on this support > > Signed-off-by: Selva Nair I said so in the PR already, but for

[Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

From: Selva Nair - Also make tests that require --wrap option to be conditional on this support Signed-off-by: Selva Nair --- configure.ac | 26 ++ tests/unit_tests/openvpn/Makefile.am | 6 +- 2