Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-14 Thread Steffan Karger
On 12-12-16 12:47, Lev Stipakov wrote: > Async push functionality makes sense only with deferred authentication, > which requires plugins. > > Trac #783 > > Signed-off-by: Lev Stipakov > --- > configure.ac | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-13 Thread David Sommerseth
On 13/12/16 09:33, Gert Doering wrote: > Hi, > > On Tue, Dec 13, 2016 at 01:15:03AM +0100, David Sommerseth wrote: >> But I am wondering if it would be better to just do this in syshead.h >> instead: >> >> #if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) >> #undef ENABLE_ASYNC_PUSH

Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-13 Thread Steffan Karger
Hi, On 13-12-16 09:33, Gert Doering wrote: > On Tue, Dec 13, 2016 at 01:15:03AM +0100, David Sommerseth wrote: >> My point is that there's no real point of screaming about missing >> --enable-plugins if you have added --enable-auth-push. > > Someone added --enable-async-push to the configure

Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-13 Thread Gert Doering
Hi, On Tue, Dec 13, 2016 at 01:15:03AM +0100, David Sommerseth wrote: > But I am wondering if it would be better to just do this in syshead.h > instead: > > #if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) > #undef ENABLE_ASYNC_PUSH > #endif We discussed this on IRC yesterday,

Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-13 Thread Lev Stipakov
13.12.2016, 02:15, David Sommerseth kirjoitti: > Coupling --enable-async-push with --enable-plugins makes a lot of sense. > By the way, there is a typo in the errror message though > (--enable_async_push should be --enable-async-push). Yes :( I wonder if actual committer could fix it or should

Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-12 Thread David Sommerseth
On 12/12/16 12:47, Lev Stipakov wrote: > Async push functionality makes sense only with deferred authentication, > which requires plugins. > > Trac #783 > > Signed-off-by: Lev Stipakov > --- > configure.ac | 4 > 1 file changed, 4 insertions(+) > > diff --git

[Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

2016-12-12 Thread Lev Stipakov
Async push functionality makes sense only with deferred authentication, which requires plugins. Trac #783 Signed-off-by: Lev Stipakov --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 27bdcc3..946f3db 100644 ---