Re: [Openvpn-devel] [PATCH v2] Disable async_push if plugins are disabled

Hi, On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote: > +/* > + * Disable async-push if plugins are disabled > + */ > +#if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) > +#undef ENABLE_ASYNC_PUSH > +#endif > + That one gets a NAK from me, for the reasons given. As long as

[Openvpn-devel] [PATCH v2] Disable async_push if plugins are disabled

Async push is a sub-feature of plugins. Trac #783 Signed-off-by: Lev Stipakov --- src/openvpn/syshead.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index f5008b7..c7c3259 100644 --- a/src/openvpn/syshead.h +++

Re: [Openvpn-devel] [PATCH] Further enhance async-push feature description

On 14-12-16 13:23, David Sommerseth wrote: > Signed-off-by: David Sommerseth > --- > Changes.rst | 9 + > configure.ac | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Changes.rst b/Changes.rst > index a5002dd..7da1119 100644 > ---

Re: [Openvpn-devel] [PATCH applied] Changes.rst: Mainatiner update on C99

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch commit a7acb6b48e31c5b83983f7eb9caf308adb7b76f1 Author: David Sommerseth Date: Tue Dec 13 13:16:56 2016 +0100 Changes.rst: Mainatiner update on C99 Acked-by: Gert Doering

Re: [Openvpn-devel] [PATCH applied] man: mention that --ecdh-curve does not work on mbed TLS builds

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK. Your patch has been applied to the master branch commit 07d0d73a38326c0e935ea35eb12452b69abafada Author: Steffan Karger Date: Tue Dec 13 20:51:12 2016 +0100 man: mention that --ecdh-curve does not work on mbed TLS builds Trac:

Re: [Openvpn-devel] [PATCH applied] Unhide a line in man page by fixing a typo

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch commit c22428fb609a0f4ec451200a421b5d1090a962a5 Author: Selva Nair Date: Tue Dec 13 11:11:38 2016 -0500 Unhide a line in man page by fixing a typo Signed-off-by: Selva Nair

Re: [Openvpn-devel] [PATCH] Make --enable-async-push depend on --enable-plugins

On 12-12-16 12:47, Lev Stipakov wrote: > Async push functionality makes sense only with deferred authentication, > which requires plugins. > > Trac #783 > > Signed-off-by: Lev Stipakov > --- > configure.ac | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Openvpn-devel] [PATCH applied] Further enhance async-push feature description

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch commit 1a8f6b9159708a943ebdb64404de4c5fc887303b Author: David Sommerseth Date: Wed Dec 14 13:23:30 2016 +0100 Further enhance async-push feature description Signed-off-by: David

Re: [Openvpn-devel] [PATCH v2] Disable async_push if plugins are disabled

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/12/16 10:09, Gert Doering wrote: > Hi, > > On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote: >> +/* + * Disable async-push if plugins are disabled + */ +#if >> !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) +#undef >>

Re: [Openvpn-devel] [PATCH v2] Disable async_push if plugins are disabled

On Wed, Dec 14, 2016 at 10:39 AM, David Sommerseth wrote: > > That one gets a NAK from me, for the reasons given. > > > > As long as we *have* --enable/--disable options in configure, they > > should be validated *there* and not silently ignored. > > > >

Re: [Openvpn-devel] Coding style clean-up ... phase 1

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13/12/16 22:42, David Sommerseth wrote: > > Hi all, > > So the first phase of the great reformatting is on its way. I have > just pushed out a reformatting branch to the following > repositories: > > https://github.com:OpenVPN/openvpn.git >

Re: [Openvpn-devel] [PATCH] auth-gen-token: Hardening memory cleanup on auth-token failuers

Hi, On 14-12-16 16:12, David Sommerseth wrote: > Further improve the memory management when a clients --auth-token > fails the server side token authentication enabled via --auth-gen-token. > > Signed-off-by: David Sommerseth > --- > src/openvpn/ssl_verify.c | 22

Re: [Openvpn-devel] [PATCH v3] dev-tools: Add reformat-all.sh for code style unification

Hi, On 14-12-16 22:05, David Sommerseth wrote: > This script will run all files related to the currently checked out > git branch through uncrustify using a standardized style configuration. > > Due to a bug in uncrustify 0.64, it is needed to add a special treatment > to one of the files at the

Re: [Openvpn-devel] [PATCH applied] dev-tools: Add reformat-all.sh for code style unification

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Did a quick change at commit time, changing from bash to sh Your patch has been applied to the master branch. commit 2417d55c4945d491e528dd0e4cf24047da5ceae9 Author: David Sommerseth Date: Wed Dec 14 22:05:00 2016 +0100 dev-tools: Add

[Openvpn-devel] Summary of today's (Wed, 14th Dec 2016) community meeting

Hi, Here's the summary of today's IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wednesday 14th Dec 2016 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this meeting were here: The

Re: [Openvpn-devel] [PATCH] dev-tools: Add reformat-all.sh for code style unification

Hi, On 14-12-16 21:07, David Sommerseth wrote: > Due to a bug in uncrustify 0.63 Should be 0.64. > diff --git a/dev-tools/reformat-all.sh b/dev-tools/reformat-all.sh > new file mode 100755 > index 000..11a6eca > --- /dev/null > +++ b/dev-tools/reformat-all.sh > @@ -0,0 +1,136 @@ >

[Openvpn-devel] [PATCH v3] dev-tools: Add reformat-all.sh for code style unification

This script will run all files related to the currently checked out git branch through uncrustify using a standardized style configuration. Due to a bug in uncrustify 0.64, it is needed to add a special treatment to one of the files at the moment. So this both pre- and post-patched before/after

Re: [Openvpn-devel] [PATCH] dev-tools: Add reformat-all.sh for code style unification

On Wed, Dec 14, 2016 at 3:07 PM, David Sommerseth wrote: > +++ b/dev-tools/uncrustify.conf > @@ -0,0 +1,64 @@ > +# Use Allman-style > +indent_columns=4 > +indent_braces=false > +indent_else_if=false > +indent_switch_case=4 > +indent_label=1nl_if_brace=add > What happened

Re: [Openvpn-devel] [PATCH v2] Disable async_push if plugins are disabled

On 14/12/16 17:23, Steffan Karger wrote: > On 14-12-16 16:39, David Sommerseth wrote: >> On 14/12/16 10:09, Gert Doering wrote: >>> Hi, >> >>> On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote: +/* + * Disable async-push if plugins are disabled + */ +#if

Re: [Openvpn-devel] Coding style clean-up ... phase 1

Hi, On 14-12-16 22:18, David Sommerseth wrote: > On 13/12/16 22:42, David Sommerseth wrote: >> So the first phase of the great reformatting is on its way. I have >> just pushed out a reformatting branch to the following >> repositories: > >> https://github.com:OpenVPN/openvpn.git >>

Re: [Openvpn-devel] Coding style clean-up ... phase 1

On Wed, Dec 14, 2016 at 4:18 PM, David Sommerseth wrote: > On 13/12/16 22:42, David Sommerseth wrote: > > > > Hi all, > > > > So the first phase of the great reformatting is on its way. I have > > just pushed out a reformatting branch to the following > >

Re: [Openvpn-devel] [PATCH v2] Disable async_push if plugins are disabled

On 14-12-16 16:39, David Sommerseth wrote: > On 14/12/16 10:09, Gert Doering wrote: >> Hi, > >> On Wed, Dec 14, 2016 at 10:51:18AM +0200, Lev Stipakov wrote: >>> +/* + * Disable async-push if plugins are disabled + */ +#if >>> !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) +#undef >>>

[Openvpn-devel] [PATCH] auth-gen-token: Hardening memory cleanup on auth-token failuers

Further improve the memory management when a clients --auth-token fails the server side token authentication enabled via --auth-gen-token. Signed-off-by: David Sommerseth --- src/openvpn/ssl_verify.c | 22 ++ 1 file changed, 18 insertions(+), 4