[OpenWrt-Devel] [PATCH 00/12] uci: fix issues caused by newly-added multiline option value support.

2014-12-15 Thread Yousong Zhou
This patch set mainly tries to - Add test more cases with multiline option value and quotes in mind. - Fix issues of uci show, revert, add_list, del_list, batch commands. My previous patch set for adding support for multiline option value support to UCI parser was not complete causing many

[OpenWrt-Devel] [PATCH 03/12] tests: add more test coverage for `uci show' command.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- test/references/show_parsing_multiline.data| 20 + .../show_parsing_multiline_option.result | 12 .../show_parsing_multiline_package.result | 18

[OpenWrt-Devel] [PATCH 04/12] tests: add test coverage for `uci batch' command.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- test/references/batch_set.result |9 + test/tests.d/060_batch | 17 + 2 files changed, 26 insertions(+) create mode 100644 test/references/batch_set.result create mode 100644 test/tests.d/060_batch

[OpenWrt-Devel] [PATCH 02/12] tests: remove straying echo in 020_get.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- test/tests.d/020_get |1 - 1 file changed, 1 deletion(-) diff --git a/test/tests.d/020_get b/test/tests.d/020_get index 7fd30ba..630d84d 100644 --- a/test/tests.d/020_get +++ b/test/tests.d/020_get @@ -35,7 +35,6 @@

[OpenWrt-Devel] [PATCH 05/12] tests: add test coverage for `uci revert' command.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- test/references/revert_option.result |3 +++ test/references/revert_option_multiline.result |2 ++ test/tests.d/070_revert| 28 3 files changed, 33 insertions(+) create

[OpenWrt-Devel] [PATCH 06/12] tests: add test coverage for uci list related commands.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- test/references/add_list_changes.result |4 ++ test/references/add_list_config.result |6 +++ test/references/add_list_show.result |3 ++ test/references/del_list_config.result |5 +++

[OpenWrt-Devel] [PATCH 07/12] cli: fix printing option values occupying multiple lines.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- cli.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/cli.c b/cli.c index 6fbbfe9..85a24d8 100644 --- a/cli.c +++ b/cli.c @@ -168,18 +168,36 @@ static void cli_perror(void)

[OpenWrt-Devel] [PATCH 09/12] delta: preprocess delta line with uci_parse_argument().

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- delta.c | 25 ++--- file.c |9 +++-- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/delta.c b/delta.c index b56df5b..2eb2ae7 100644 --- a/delta.c +++ b/delta.c @@ -95,11 +95,14 @@ int

[OpenWrt-Devel] [PATCH 12/12] uci_internal: use comma expression for UCI_INTERNAL() call.

2014-12-15 Thread Yousong Zhou
Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- uci_internal.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uci_internal.h b/uci_internal.h index 89863f1..cb8f86c 100644 --- a/uci_internal.h +++ b/uci_internal.h @@ -227,10 +227,10 @@ struct uci_backend

Re: [OpenWrt-Devel] [PATCH v4 4/4] kernel: 3.18: Strip off all the useless options

2014-12-15 Thread Maxime Ripard
On Sat, Dec 13, 2014 at 07:50:52PM +0100, Jonas Gorski wrote: Ok, I think most of it is because of options enabled by default. I wonder why that happens, but I also wonder why it hasn't been picked up by my tests. I already somewhat expected that. So make savedefconfig then likely

Re: [OpenWrt-Devel] [PATCH v4 4/4] kernel: 3.18: Strip off all the useless options

2014-12-15 Thread Jonas Gorski
On Mon, Dec 15, 2014 at 11:09 AM, Maxime Ripard wrote: On Sat, Dec 13, 2014 at 07:50:52PM +0100, Jonas Gorski wrote: One other thing I just noticed: this currently makes make kernel_*config unusable. make kernel_oldconfig will ask about about everything that is at its defaultvalue, while

Re: [OpenWrt-Devel] [PATCH] add preinit_regular diag.sh set_state argument

2014-12-15 Thread Rafał Miłecki
On 14 December 2014 at 23:00, Rafał Miłecki zaj...@gmail.com wrote: This new argument is used right after starting regular preinit (which happens if failsafe wasn't triggered). The main purpose of preinit argument is to indicate that failsafe can be triggered, however we were missing a way to

[OpenWrt-Devel] [PATCH RFC] brcm47xx: support for flashing CHK and CyberTAN images

2014-12-15 Thread Rafał Miłecki
This will allow simple sysupgrade-s including simpler reverting to the original firmware. Signed-off-by: Rafał Miłecki zaj...@gmail.com --- .../brcm47xx/base-files/lib/upgrade/platform.sh| 33 ++ 1 file changed, 28 insertions(+), 5 deletions(-) diff --git

Re: [OpenWrt-Devel] [PATCH v4 4/4] kernel: 3.18: Strip off all the useless options

2014-12-15 Thread Maxime Ripard
On Sat, Dec 13, 2014 at 07:50:52PM +0100, Jonas Gorski wrote: Ok, I think most of it is because of options enabled by default. I wonder why that happens, but I also wonder why it hasn't been picked up by my tests. I already somewhat expected that. So make savedefconfig then likely

[OpenWrt-Devel] UCI usage table missing entries for del_list and reorder

2014-12-15 Thread Robert P. J. Day
Yes, it's a wiki but I'll let someone higher up the food chain fix this: http://wiki.openwrt.org/doc/uci#usage wherein neither the command usage output nor the table of UCI subcommands mentions either del_list or reorder. rday ___ openwrt-devel

[OpenWrt-Devel] [PATCH v2 1/4] brcm63xx: add bcm6345-gpio driver

2014-12-15 Thread Álvaro Fernández Rojas
Signed-off-by: Álvaro Fernández Rojas nolt...@gmail.com --- v2: use vendor for DT properties. diff --git a/target/linux/brcm63xx/config-3.14 b/target/linux/brcm63xx/config-3.14 index dd27f47..f94c567 100644 --- a/target/linux/brcm63xx/config-3.14 +++ b/target/linux/brcm63xx/config-3.14 @@ -76,6

[OpenWrt-Devel] [PATCH v2 2/4] brcm63xx: use bcm6345-gpio over legacy

2014-12-15 Thread Álvaro Fernández Rojas
Signed-off-by: Álvaro Fernández Rojas nolt...@gmail.com --- v2: keep changes minimal as suggested by Jonas diff --git a/target/linux/brcm63xx/patches-3.14/375-DT-GPIO-over-legacy.patch b/target/linux/brcm63xx/patches-3.14/375-DT-GPIO-over-legacy.patch new file mode 100644 index 000..8c9bfc8

[OpenWrt-Devel] [PATCH v2 3/4] brcm63xx: backport spi-gpio no cs

2014-12-15 Thread Álvaro Fernández Rojas
Signed-off-by: Álvaro Fernández Rojas nolt...@gmail.com --- diff --git a/target/linux/brcm63xx/patches-3.14/376-DT-SPI-GPIO-no-cs-backport.patch b/target/linux/brcm63xx/patches-3.14/376-DT-SPI-GPIO-no-cs-backport.patch new file mode 100644 index 000..b289d5c --- /dev/null +++

[OpenWrt-Devel] [PATCH v2 4/4] brcm63xx: add GPIOs to DT

2014-12-15 Thread Álvaro Fernández Rojas
Signed-off-by: Álvaro Fernández Rojas nolt...@gmail.com --- v2: remove dummy CS for devices with 74HC164 and fix HG520v inet LED diff --git a/target/linux/brcm63xx/dts/a226g.dts b/target/linux/brcm63xx/dts/a226g.dts index 9aff81b..0c26c7b 100644 --- a/target/linux/brcm63xx/dts/a226g.dts +++

Re: [OpenWrt-Devel] [PATCH 1/3] brcm63xx: add bcm6345-gpio driver

2014-12-15 Thread Florian Fainelli
2014-12-12 6:33 GMT-08:00 Jonas Gorski j...@openwrt.org: On Fri, Dec 12, 2014 at 3:17 PM, John Crispin blo...@openwrt.org wrote: On 12/12/2014 15:12, Jonas Gorski wrote: or the gpio-base problem, we should be able to register appropriate platform data for it as OF_DEV_AUXDATA() in

Re: [OpenWrt-Devel] kirkwood gcc/binutils woe?

2014-12-15 Thread Felix Fietkau
On 2014-12-14 12:02, Harald Geyer wrote: nwf writes: $ gcc -v -o hello hello.c [...] /usr/lib/gcc/arm-openwrt-linux-uclibcgnueabi/4.8.3/collect2 --eh-frame-hdr -dynamic-linker /lib/ld-uClibc.so.0 -X -m armelf_linux_eabi -o hello /usr/lib/gcc/arm-openwrt-linux-uclibcgnueabi/4.8.3/crt1.o

Re: [OpenWrt-Devel] kirkwood gcc/binutils woe?

2014-12-15 Thread John Crispin
On 15/12/2014 16:16, Felix Fietkau wrote: On 2014-12-14 12:02, Harald Geyer wrote: nwf writes: $ gcc -v -o hello hello.c [...] /usr/lib/gcc/arm-openwrt-linux-uclibcgnueabi/4.8.3/collect2 --eh-frame-hdr -dynamic-linker /lib/ld-uClibc.so.0 -X -m armelf_linux_eabi -o hello

Re: [OpenWrt-Devel] [PATCH] ar8216: Use IGMP Join and Fast Leave functions

2014-12-15 Thread Cristian Morales Vega
On 12 December 2014 at 16:16, Felix Fietkau n...@openwrt.org wrote: On 2014-12-05 15:36, Cristian Morales Vega wrote: Avoids flooding the network with multicast data. Signed-off-by: Cristian Morales Vega crist...@samknows.com --- Since I guess not all the switches support this... Good

Re: [OpenWrt-Devel] nftables development and support in openwrt

2014-12-15 Thread Tomer Eliyahu
Hi Steven, afaik - and please correct me if I'm wrong - that works only for the iptables CLI command, however our firewall tool currently uses libiptables directly so I don't think it would work easily. You are right. I asked it in the netfilter-devel mailing list - libipct was never meant to

Re: [OpenWrt-Devel] nftables development and support in openwrt

2014-12-15 Thread Steven Barth
You are right. I asked it in the netfilter-devel mailing list - libipct was never meant to be used as a public interface: http://www.netfilter.org/documentation/FAQ/netfilter-faq-4.html#ss4.5 Meh, absent of anything else it de-facto is anyway, see e.g. squid, miniupnpd and others using it as

[OpenWrt-Devel] Need to add kmod-usb2-pci to Intel ixp4xx and AMD Geode devices

2014-12-15 Thread Ted Hess
Recent builds for NSLU2 and my Alix3d2 platforms did not have a USB controller recognized! Turns out the latest usb2 driver structure requires the addition of kmod-usb2-pci to be added to the target config. See patch below... I believe this issue exists for any platform that has a USB

Re: [OpenWrt-Devel] [procd] How to redirect STDOUT/STDERR of a started service ?

2014-12-15 Thread Christian Schoenebeck
Am 14.12.2014 um 19:42 schrieb John Crispin: On 14/12/2014 19:27, Christian Schoenebeck wrote: Hi, I provided privoxy 3.0.22 package with scripts using procd to run the service. When privoxy runs in foreground it never writes to logfile. So it's required to redirect stdout and/or stderr of

[OpenWrt-Devel] [PATCH][modules] Add support for Realtek r8712 and RTL8192SU.

2014-12-15 Thread José Vázquez Fernández
Add support for Realtek r8712 and RTL8192SU family. This patch adds support for Realtek r8712 and RTL8188SU/RTL8191SU/RTL8192SU family of fullmac usb wireless cards. The r8712u staging driver only supports WEXT but works with no problems in OpenWRT. Signed off by: José Vázquez Fernández

[OpenWrt-Devel] [Fwd: [PATCH][modules][V2] Add support for Realtek r8712 and RTL8192SU.]

2014-12-15 Thread José Vázquez Fernández
Add support for Realtek r8712 and RTL8192SU family. This patch adds support for Realtek r8712 and RTL8188SU/RTL8191SU/RTL8192SU family of fullmac usb wireless cards. The r8712u staging driver only supports WEXT but works with no problems in OpenWRT. V2: added md5sum and fixed the patch. Signed

[OpenWrt-Devel] [PATCH v2] iproute2: add VLAN filtering + bridge control.

2014-12-15 Thread Jonathan Thibault
Made changes suggested by Felix. I'll try to put together a preliminary report on how much bloat this add to the kernel Though this might not be that needed for home use, I think it really adds to OpenWRT's usefulness as a set-and-forget network wonder-appliance. diff --git

Re: [OpenWrt-Devel] rootfs_data on separated flash

2014-12-15 Thread Rafał Miłecki
On 15 December 2014 at 06:29, John Crispin blo...@openwrt.org wrote: On 14/12/2014 21:37, Rafał Miłecki wrote: 1) I've modified DT to create ubi MTD partition on NAND 2) Wrote a simple preinit_main script creating rootfs_data2 UBI volume 3) Modified fstools to prefer rootfs_data2 over

Re: [OpenWrt-Devel] Subject: [PATCH] [package] Check port state on new call to avoid previous call ending

2014-12-15 Thread Jiri Slachta
Hello Roberto, thank you for your contribution. You seem to have swapped the original and modified source file while diffing it, but this is a not a big deal. I will test your change during this week and merge it if it works. Next time please create pull request against the github telephony

[OpenWrt-Devel] [PATCH 0/5] ar8216: patch series with more smaller improvements

2014-12-15 Thread Heiner Kallweit
1/5 Remove unused function parameter in ar8327_led_register 2/5 Factor out chip-specific parameters from ar8xxx_probe_switch 3/5 Create helpers mii_read32 / mii_write32 for 32 bit MII ops. 4/5 Remove read/write/rmw member functions from ar8xxx_priv 5/5 Inline function ar8xxx_create_mii

[OpenWrt-Devel] [PATCH 1/5] ar8216: remove unused function parameter in ar8327_led_register

2014-12-15 Thread Heiner Kallweit
Remove unused function parameter in ar8327_led_register. Signed-off-by: Heiner Kallweit hkallwe...@gmail.com --- target/linux/generic/files/drivers/net/phy/ar8216.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/generic/files/drivers/net/phy/ar8216.c

[OpenWrt-Devel] [PATCH 2/5] ar8216: Factor out chip-specific parameters from ar8xxx_probe_switch

2014-12-15 Thread Heiner Kallweit
Factor out chip-specific parameters from ar8xxx_probe_switch. Move the ar8xxx_chip definitions after the swops definitions. Signed-off-by: Heiner Kallweit hkallwe...@gmail.com --- .../linux/generic/files/drivers/net/phy/ar8216.c | 268 - 1 file changed, 151 insertions(+),

[OpenWrt-Devel] [PATCH 3/5] ar8216: Create helpers mii_read32 / mii_write32 for 32 bit MII ops

2014-12-15 Thread Heiner Kallweit
Create helpers mii_read32 / mii_write32 for 32 bit MII ops. Rename r3 variable to page in ar8xxx_mii_write to make it consistent with the other ar8xxx_mii_ functions. Signed-off-by: Heiner Kallweit hkallwe...@gmail.com --- .../linux/generic/files/drivers/net/phy/ar8216.c | 74

[OpenWrt-Devel] [PATCH 4/5] ar8216: Remove read/write/rmw member functions from ar8xxx_priv

2014-12-15 Thread Heiner Kallweit
Remove read/write/rmw member functions from ar8xxx_priv There seems to be no real benefit of the ar8xxx_priv member functions read/write/rmw as one implementation exists for each of them only. Especially ar8xxx_mii_rmw is assigned to priv-rmw first and then mapped to ar8xxx_rmw. Rename the

[OpenWrt-Devel] [PATCH 5/5] ar8216: Inline function ar8xxx_create_mii

2014-12-15 Thread Heiner Kallweit
Inline function ar8xxx_create_mii. Signed-off-by: Heiner Kallweit hkallwe...@gmail.com --- target/linux/generic/files/drivers/net/phy/ar8216.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/target/linux/generic/files/drivers/net/phy/ar8216.c