Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Robert, I've just created a LaurensVoerman account on github and cloned the osg repro there. That would probably have been a better starting point than a direct local clone. still struggling with git. Regards, Laurens. On 6/6/2016 6:43 PM, Robert Osfield wrote: Hi Laurens, Do you

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi, Compiling master on msys2/mingw (gcc 5.3.0) gives these warnings: Code: D:/MINGW-packages/mingw-w64-openscenegraph-git/src/OpenSceneGraph/src/osgPlugins/zip/unzip.cpp: In function 'int unzlocal_getShort(LUFILE*, uLong*)':

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Bjorn, I have just checked in a fix for these warnings. Robert. On 6 June 2016 at 22:28, Björn Blissing wrote: > Hi, > > Tried compiling my own project with the latest master got some more warnings > coming from included header files in OSG: > > > Code: >

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi, Tried compiling my own project with the latest master got some more warnings coming from included header files in OSG: Code: OpenSceneGraph\include\osgShadow/ViewDependentShadowTechnique(209): warning C4100: 'maxSize': unreferenced formal parameter

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Laurens, Do you have a githib account that you'd like me to credit with this submissions? Where possible I've been utilizing the git commit --author feature where I have the email address used on github. Robert. On 6 June 2016 at 15:21, Voerman, L. wrote: > Hi Robbert,

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Björn, On 6 June 2016 at 13:55, Björn Blissing wrote: > In the LUA-plugin: > > > Code: > > d:\code\github\openscenegraph\src\osgplugins\lua\lua-5.2.3\src\lapi.c(1110): > warning C4702: unreachable code Removing the return statement that the warning is complaining

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

robertosfield wrote: > The HORROR!!! :-) What? Don't you approve of using the variable name 'c' throughout the entire codebase and in pretty much every scope? :-) With these warnings out of the way I only get these warnings: In the LUA-plugin: Code:

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

The HORROR!!! :-) OK, merged the disabling of the warning for the 3ds plugin. Thanks. On 6 June 2016 at 13:02, Björn Blissing wrote: > > robertosfield wrote: >> Hi Bjorn, >> >> Could you post a log of the warnings that this CMakeLists.txt works >> around? If there aren't

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

robertosfield wrote: > Hi Bjorn, > > Could you post a log of the warnings that this CMakeLists.txt works > around? If there aren't too many we could just fix them. > > Robert. There are quite many, so IMHO we should just disable this warning for this subproject. But I is your call. Here

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

eld <robert.osfi...@gmail.com> > Skickat: den 4 juni 2016 19:42:10 > Till: OpenSceneGraph Users > Ämne: Re: [osg-users] Preparing to make 3.5.3 dev release, please test > > Hi François, > > I have removed the register keyword usage from > Matrix_implementation.cpp

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

sfield <robert.osfi...@gmail.com> Skickat: den 4 juni 2016 19:42:10 Till: OpenSceneGraph Users Ämne: Re: [osg-users] Preparing to make 3.5.3 dev release, please test Hi François, I have removed the register keyword usage from Matrix_implementation.cpp and added the "" to the CMakeLi

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi François, I have removed the register keyword usage from Matrix_implementation.cpp and added the "" to the CMakeLists.txt. These changes are now checked into git mater. Robert. On 4 June 2016 at 16:23, François Bérard wrote: > Hi Robert, > > On 3/6/16 18:46, Robert

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi François, On 3 June 2016 at 17:13, François Bérard wrote: >> I can seen anywhere where the OSG Cmake build system is adding >> -Wdeprecated-register. Are you adding this manually? > > > nope. unzip, cmake, make. This must be a new default on my Clang (Apple LLVM >

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Message- >>From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On >>Behalf Of Björn Blissing >>Sent: Friday, June 3, 2016 3:35 PM >>To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org> >>Subject: Re: [osg-users] Preparing to make 3.5.3 dev releas

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

gt; > Regards > Björn > >>-Original Message- >>From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On >>Behalf Of Björn Blissing >>Sent: Friday, June 3, 2016 2:39 PM >>To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org> >>Subject:

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

rs [mailto:osg-users-boun...@lists.openscenegraph.org] On >>Behalf Of Robert Osfield >>Sent: Friday, June 3, 2016 1:46 PM >>To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org> >>Subject: Re: [osg-users] Preparing to make 3.5.3 dev release, please test >> >

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Robert, On 03/06/16 12:43, Robert Osfield wrote: Hi François, I have installed Clang 3.8 on my Linux dev machine and got it to reproduce the same typeid error. As far as I can tell this warning is pretty bogus, effectively enforcing a personal preference of the compiler developers rather

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

robertosfield wrote: > Hi Bjorn, > Unfortunately I don't see these warnings with the compiler I have > available with the settings that are currently available. Do you know > of what to enable these warnings in gcc or Clang? > > The nature of these warnings are such that I really need to be

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

penscenegraph.org] On >>Behalf Of Björn Blissing >>Sent: Friday, June 3, 2016 2:39 PM >>To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org> >>Subject: Re: [osg-users] Preparing to make 3.5.3 dev release, please test >> >>Hi Robert, >> >&g

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

ne 3, 2016 2:39 PM >To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org> >Subject: Re: [osg-users] Preparing to make 3.5.3 dev release, please test > >Hi Robert, > >The warnings relating the Operation class comes from the two protected >constructors. S

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

s-boun...@lists.openscenegraph.org] On >Behalf Of Robert Osfield >Sent: Friday, June 3, 2016 1:46 PM >To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org> >Subject: Re: [osg-users] Preparing to make 3.5.3 dev release, please test > >Hi Bjorn, > >On 3 June 2016 at 09:48, B

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Bjorn, On 3 June 2016 at 09:48, Björn Blissing wrote: > > I compiled the latest master with Visual Studio 2015. > > I got a couple of warnings. First of all I got a ton of these, which all > originates from the same origin: > > > Code: > > ... >

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi François, I have installed Clang 3.8 on my Linux dev machine and got it to reproduce the same typeid error. As far as I can tell this warning is pretty bogus, effectively enforcing a personal preference of the compiler developers rather than highlighting anything that is ambiguous or

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Robert, Since you introduced the osg::PI_2f value, maybe you should replace the two osg::PIf*0.5f found in ShapeDrawable at line 1405 and 1479. Regards Björn -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=67380#67380

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Laurens, I've merged Bjorn's changes to GraphicsWindowWin32.cpp. Also rather than merge your changes to ShapeDrawable I have added to the include/osg/Math header float variants to osg::PI etc. in the form osg::PIf. I then replaced the osg::PI usage in ShapeDrawable.cpp to osg::PIf which

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

eGraph Users <osg-users@lists.openscenegraph.org> > Subject: Re: [osg-users] Preparing to make 3.5.3 dev release, please test > > > > Hi all, > > After updating to visual studio 2015 I fixed a few of those (minor) > warnings, > > attached are the modified vers

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi, I compiled the latest master with Visual Studio 2015. I got a couple of warnings. First of all I got a ton of these, which all originates from the same origin: Code: ... OpenSceneGraph\include\osg/OperationThread(80): warning C4589: Constructor of abstract class 'osg::Operation'

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi François, On 3 June 2016 at 06:01, François Bérard wrote: > There are tons of warnings such as: > > In file included from > /Users/fberard/Downloads/osg_git/OpenSceneGraph-master/include/osg/NodeVisitor:21: >

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Yup, compiles and executes fine now. But: There are tons of warnings such as: In file included from /Users/fberard/Downloads/osg_git/OpenSceneGraph-master/include/osg/NodeVisitor:21: /Users/fberard/Downloads/osg_git/OpenSceneGraph-master/include/osg/ValueMap:53:51: warning: expression with

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Robert, Thanks for fixing the warning. Just let you know, I did a build of OpenMW against OSG 3.5.3 and did not encounter any build- or runtime problems. Cheers, Jannik -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=67368#67368

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

On 2 June 2016 at 20:03, Robert Osfield wrote: > IF(${CMAKE_MAJOR_VERSION} GREATER 2 AND CMAKE_CXX_COMPILER_VERSION > VERSION_GREATER 4.9) > SET(OSG_AGGRESSIVE_WARNING_FLAGS > ${OSG_AGGRESSIVE_WARNING_FLAGS} -Wshadow) > ENDIF() > > Works for me under

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Jannik, I have done some more searching online and come across a compile version variable that exist in Cmake 2.8 and later, I've just added then follow to the root CMakeLists.txt: IF(${CMAKE_MAJOR_VERSION} GREATER 2 AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.9)

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Jannik, I've noticed this same issue with a Kubuntu 14.04 install I have, I don't recall the gcc version but it's below 5 like yours. It seems the addition of -Wshadow to the OSG_AGGRESSIVE_WARNING_FLAGS causes mahem with the compile kick out lots of ridiculous shadows reports, all these

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi Robert, I haven't finished building yet, but right off the bat I get about a million of these warnings: Code: /home/scrawl/Dev/osg/include/osg/Vec3us:34:58: warning: declaration of ‘g’ shadows a member of 'this' [-Wshadow] /home/scrawl/Dev/osg/include/osg/Vec4f:46:9: warning: declaration

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hi François, I suspect the build error is down to the osgViewer:: in the REGISTER_WINDOWINGSYSTEMINTERFACE line that is affecting the macro expansion. I have just checked in removal of the osgViewer:: so the line now looks like: REGISTER_WINDOWINGSYSTEMINTERFACE(IOS,

Re: [osg-users] Preparing to make 3.5.3 dev release, please test

Hello, I just downloaded a zip from the git web site, expanded, cmake, make, and stopped on an error (see below). This is on OSX 10.11.5, using XCode command line tools v7.3 (Apple LLVM version 7.3.0 (clang-703.0.29)) Hope this helps. [ 19%] Building CXX object

[osg-users] Preparing to make 3.5.3 dev release, please test

Hi All, I spent the majority of May catching up with submissions and bug fixes and now in June I'd like to start moving towards getting a stable release out the door - this will 3.6.0. The first step along this way is the 3.5.3 dev release which wraps up all the recent work that been checked