Re: [PATCH] virtio-rng: don't hang while waiting for entropy

2016-11-17 Thread Nadav Har'El
On Thu, Nov 17, 2016 at 10:57 AM, Pekka Enberg wrote: > > The virtio-rng part looks correct: > > Reviewed-by: Pekka Enberg > > However, perhaps we ought to also fix live_entropy_sources_feed() > _not_ to feed events to entropy_processor() if entropy

Re: [PATCH] virtio-rng: don't hang while waiting for entropy

2016-11-17 Thread Pekka Enberg
On Thu, Nov 17, 2016 at 10:39 AM, Nadav Har'El wrote: > random_kthread() has a loop, where it tries to get some entropy from > all sources (including the ring of internal events), feeds it into the > entropy pool, and then sleeps a bit and tries again, ad infinitum. > > If the

Re: [PATCH] virtio-rng: don't hang while waiting for entropy

2016-11-17 Thread Nadav Har'El
Gregor, can you please test if this patch really makes your /dev/urandom hang go away? Tomek and/or Pekka, can you please review this patch? (its comment is much longer than the actual patch ;-) ). Thanks. -- Nadav Har'El n...@scylladb.com On Thu, Nov 17, 2016 at 10:39 AM, Nadav Har'El

[PATCH] virtio-rng: don't hang while waiting for entropy

2016-11-17 Thread Nadav Har'El
random_kthread() has a loop, where it tries to get some entropy from all sources (including the ring of internal events), feeds it into the entropy pool, and then sleeps a bit and tries again, ad infinitum. If the read function of *one* of the entropy sources blocks, the entire random_kthread()