Re: Test.pm does not return false on failed tests.

2006-11-01 Thread Michael G Schwern
Jos Boumans wrote: Hmm, I hope this doesn't mean you plan on removing the 'non-zero exit status on failed make test'.. that's be a real PITA for automated installers... No, that is done by Test::Harness dying on test failure. Neither CPAN nor CPANPLUS are under any obligation to parse their

Re: Test.pm does not return false on failed tests.

2006-11-01 Thread Michael G Schwern
David Golden wrote: On 11/1/06, Michael G Schwern [EMAIL PROTECTED] wrote: Contact all the authors making use of it and suggest they switch to .t files. Maybe I could throw a warning into MakeMaker. Also a kwalitee check sounds like a good idea not_only_test.pl or something. It shouldn't

CPAN code searches

2006-11-01 Thread Michael G Schwern
A few people have asked how I do my CPAN scans. I keep a minicpan handy and have a little script called grep_cpan which reads the index file, unpacks each distribution, does a find | grep and then cleans up. It allows you to search for a given pattern in a given set of files. # search

Integrating Test::Run into an ExtUtils::MakeMaker+Test::Manifest Setup

2006-11-01 Thread Shlomi Fish
Hi all! See http://xrl.us/sw5o for a recipe for integrating make runtest and make distruntest targets into a Makefile.PL-generated Makefile that makes use of Test::Manifest. I needed that when working on XML::RSS, so I wrote it. Enjoy! Regards, Shlomi Fish

Re: Frequency of test.pl

2006-11-01 Thread Michael G Schwern
Steffen Mueller wrote: { name='no_test_pl', error=q{This distribution contains a file called 'test.pl' in its main distribution directory. This indicates that it uses the old style of creating test suites. Nowadays, tests belong into one or more *.t files in the t/

Re: CPAN code searches

2006-11-01 Thread Andy Lester
On Nov 1, 2006, at 1:38 PM, Michael G Schwern wrote: A few people have asked how I do my CPAN scans. Code search engine Krugle will be at the Hackathon on Nov 11 to talk to us about code searching. See http://rakudo.org/hackathon-chicago/index.cgi?krugle_presentation Maybe someone who

Re: Frequency of test.pl

2006-11-01 Thread Steffen Mueller
Hi again, Michael G Schwern schrieb: So making no_test_pl a kwalitee test is a good idea. of course, adding a mention in the docs helps, too. So I should have made it a patch. Sorry. I didn't have the svn sources. Hence: =item * has_test_pl And if people decide that this should be

Re: Frequency of test.pl

2006-11-01 Thread Steffen Mueller
Hi, Michael G Schwern schrieb: So making no_test_pl a kwalitee test is a good idea. So adding this to Module::CPANTS::Kwalitee::Files in the obvious place should do exactly that. Perhaps we should call it old_testing_scheme or so instead, but I'll go with your suggestion: {

Re: Integrating Test::Run into an ExtUtils::MakeMaker+Test::Manifest Setup

2006-11-01 Thread Michael G Schwern
Shlomi Fish wrote: Hi all! See http://xrl.us/sw5o for a recipe for integrating make runtest and make distruntest targets into a Makefile.PL-generated Makefile that makes use of Test::Manifest. I needed that when working on XML::RSS, so I wrote it. What has me scratching my head here

Re: Frequency of test.pl

2006-11-01 Thread demerphq
On 11/1/06, Michael G Schwern [EMAIL PROTECTED] wrote: This distribution uses 'test.pl' for its tests. The output of 'test.pl' is not parsed. When make test is run by automated installers (for example, the CPAN shell) your tests will always appear to have passed no matter what the output of

Re: Frequency of test.pl

2006-11-01 Thread Steffen Mueller
Michael G Schwern schrieb: This doesn't really explain why test.pl is bad. [...] Agreed! This distribution uses 'test.pl' for its tests. The output of 'test.pl' is not parsed. When make test is run by automated installers (for example, the CPAN shell) your tests will always appear to

Re: Frequency of test.pl

2006-11-01 Thread Michael G Schwern
demerphq wrote: On 11/1/06, Michael G Schwern [EMAIL PROTECTED] wrote: This distribution uses 'test.pl' for its tests. The output of 'test.pl' is not parsed. When make test is run by automated installers (for example, the CPAN shell) your tests will always appear to have passed no matter