Re: TAPx::Harness support for EUMM

2007-01-30 Thread Andy Armstrong
On 30 Jan 2007, at 02:24, Michael G Schwern wrote: That's one way, though I'd rather it be a Makefile.PL argument. [1] Yup, OK. The way I was thinking was to make it easier for users to write MY::test_harness() so they can plug in any testing system, not just Test::Harness compatible

Re: TAPx::Harness support for EUMM

2007-01-30 Thread Adam Kennedy
I for one would rather it wasn't. Remembering that NOBODY ever passes Makefile.PL params manually, you need every build system capable of supporting those params, and ever CPAN client to be capable of passing them. An environment variable is a direct line from the user/system to EUMM for

Re: TAPx::Harness support for EUMM

2007-01-30 Thread Andy Armstrong
On 30 Jan 2007, at 11:34, Adam Kennedy wrote: I for one would rather it wasn't. Remembering that NOBODY ever passes Makefile.PL params manually, you need every build system capable of supporting those params, and ever CPAN client to be capable of passing them. An environment variable is a

Re: TAPx::Harness support for EUMM

2007-01-30 Thread Michael G Schwern
Adam Kennedy wrote: I for one would rather it wasn't. Remembering that NOBODY ever passes Makefile.PL params manually, you need every build system capable of supporting those params, and ever CPAN client to be capable of passing them. An environment variable is a direct line from the

Re: TAPx::Harness support for EUMM

2007-01-29 Thread Michael G Schwern
Andy Armstrong wrote: On 27 Jan 2007, at 19:10, Andy Armstrong wrote: I've just committed a patch against ExtUtils::MakeMaker 6.31 that makes test_harness use TAPx::Harness instead of Test::Harness if the env variable PERL_EUMM_USE_TAPX is set to a true value and TAPx::Harness is installed.

Re: TAPx::Harness support for EUMM

2007-01-29 Thread Michael G Schwern
Andy Armstrong wrote: I've just committed a patch against ExtUtils::MakeMaker 6.31 that makes test_harness use TAPx::Harness instead of Test::Harness if the env variable PERL_EUMM_USE_TAPX is set to a true value and TAPx::Harness is installed. EUMM Patch:

Re: TAPx::Harness support for EUMM

2007-01-29 Thread Andy Armstrong
On 29 Jan 2007, at 12:41, Michael G Schwern wrote: Umm, yeah. I was wondering about that. Sorry for the confusion. The patch serves two purposes: 1) It makes it possible for people to try TAPx::Harness and easily disable it if they run into problems 2) It's part of me working out the

Re: TAPx::Harness support for EUMM

2007-01-29 Thread Andy Armstrong
On 29 Jan 2007, at 12:57, Michael G Schwern wrote: EUMM Patch: http://svn.hexten.net/tapx/patches/ExtUtils- MakeMaker-6.31.patch I couldn't accept this patch to MM. This would lead to MM's environment being littered with PERL_EUMM_USE_FLAVOR_OF_THE_WEEK. And if TAPx::Harness is

Re: TAPx::Harness support for EUMM

2007-01-29 Thread Ovid
--- Andy Armstrong [EMAIL PROTECTED] wrote: Or if the condition for checking to use TAPx::Harness were more complex you can figure it out beforehand and roll the decision up into $use_tapx. Yes indeed. But as you say it'd be nicer still to be able to plug in any alternative

Re: TAPx::Harness support for EUMM

2007-01-29 Thread Michael G Schwern
Andy Armstrong wrote: Sure - I'm open to suggestions. Do you mean something like this?: $ export PERL_EUMM_HARNESS_CLASS=TAPx::Harness::Compatible $ make test That's one way, though I'd rather it be a Makefile.PL argument. [1] The way I was thinking was to make it easier for users to write

TAPx::Harness support for EUMM

2007-01-27 Thread Andy Armstrong
I've just committed a patch against ExtUtils::MakeMaker 6.31 that makes test_harness use TAPx::Harness instead of Test::Harness if the env variable PERL_EUMM_USE_TAPX is set to a true value and TAPx::Harness is installed. Which this patch applied make test for any EUMM based module will

Re: TAPx::Harness support for EUMM

2007-01-27 Thread Andy Armstrong
On 27 Jan 2007, at 19:10, Andy Armstrong wrote: I've just committed a patch against ExtUtils::MakeMaker 6.31 that makes test_harness use TAPx::Harness instead of Test::Harness if the env variable PERL_EUMM_USE_TAPX is set to a true value and TAPx::Harness is installed. I should clarify: I