In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/9e4d7a131094a5a13132dec091678f488e28bdbc?hp=04525552b9f8bed5bc2f29117ac3486763a1343d>
- Log ----------------------------------------------------------------- commit 9e4d7a131094a5a13132dec091678f488e28bdbc Author: Nicholas Clark <n...@ccl4.org> Date: Tue Sep 4 23:05:09 2012 +0200 Terser fix to avoid warning about an empty body for Slab_to_rw(). Slab_to_rw() is only defined as a function with -DPERL_DEBUG_READONLY_OPS. This approach to silencing the warning feels more robust, because it ensures that Slab_to_rw() acts as a single statement whatever compile-time options are used. ----------------------------------------------------------------------- Summary of changes: op.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/op.c b/op.c index fc0306a..84d38cd 100644 --- a/op.c +++ b/op.c @@ -311,7 +311,7 @@ Perl_Slab_to_rw(pTHX_ OPSLAB *const slab) } #else -# define Slab_to_rw(op) +# define Slab_to_rw(op) NOOP #endif /* This cannot possibly be right, but it was copied from the old slab @@ -741,9 +741,8 @@ Perl_op_free(pTHX_ OP *o) if (type == OP_NULL) type = (OPCODE)o->op_targ; - if (o->op_slabbed) { - Slab_to_rw(OpSLAB(o)); - } + if (o->op_slabbed) + Slab_to_rw(OpSLAB(o)); /* COP* is not cleared by op_clear() so that we may track line * numbers etc even after null() */ -- Perl5 Master Repository