Change 30711 by [EMAIL PROTECTED] on 2007/03/23 03:36:47 Upgrade to Test-Simple-0.70
Affected files ... ... //depot/perl/lib/Test/Builder.pm#23 edit ... //depot/perl/lib/Test/More.pm#34 edit ... //depot/perl/lib/Test/Simple.pm#28 edit ... //depot/perl/lib/Test/Simple/Changes#23 edit ... //depot/perl/lib/Test/Simple/t/is_fh.t#5 edit Differences ... ==== //depot/perl/lib/Test/Builder.pm#23 (text) ==== Index: perl/lib/Test/Builder.pm --- perl/lib/Test/Builder.pm#22~30578~ 2007-03-14 06:17:42.000000000 -0700 +++ perl/lib/Test/Builder.pm 2007-03-22 20:36:47.000000000 -0700 @@ -8,7 +8,7 @@ use strict; use vars qw($VERSION); -$VERSION = '0.68'; +$VERSION = '0.70'; $VERSION = eval $VERSION; # make the alpha version come out as a number # Make Test::Builder thread-safe for ithreads. @@ -1025,10 +1025,10 @@ my $maybe_fh = shift; return 0 unless defined $maybe_fh; - return 1 if ref \$maybe_fh eq 'GLOB'; # its a glob + return 1 if ref $maybe_fh eq 'GLOB'; # its a glob + return 1 if ref \$maybe_fh eq 'GLOB'; # its a glob ref - return eval { $maybe_fh->isa("GLOB") } || - eval { $maybe_fh->isa("IO::Handle") } || + return eval { $maybe_fh->isa("IO::Handle") } || # 5.5.4's tied() and can() doesn't like getting undef eval { (tied($maybe_fh) || '')->can('TIEHANDLE') }; } ==== //depot/perl/lib/Test/More.pm#34 (text) ==== Index: perl/lib/Test/More.pm --- perl/lib/Test/More.pm#33~30578~ 2007-03-14 06:17:42.000000000 -0700 +++ perl/lib/Test/More.pm 2007-03-22 20:36:47.000000000 -0700 @@ -16,7 +16,7 @@ use vars qw($VERSION @ISA @EXPORT %EXPORT_TAGS $TODO); -$VERSION = '0.68'; +$VERSION = '0.70'; $VERSION = eval $VERSION; # make the alpha version come out as a number use Test::Builder::Module; ==== //depot/perl/lib/Test/Simple.pm#28 (text) ==== Index: perl/lib/Test/Simple.pm --- perl/lib/Test/Simple.pm#27~30578~ 2007-03-14 06:17:42.000000000 -0700 +++ perl/lib/Test/Simple.pm 2007-03-22 20:36:47.000000000 -0700 @@ -4,7 +4,7 @@ use strict 'vars'; use vars qw($VERSION @ISA @EXPORT); -$VERSION = '0.68'; +$VERSION = '0.70'; $VERSION = eval $VERSION; # make the alpha version come out as a number use Test::Builder::Module; ==== //depot/perl/lib/Test/Simple/Changes#23 (text) ==== Index: perl/lib/Test/Simple/Changes --- perl/lib/Test/Simple/Changes#22~30578~ 2007-03-14 06:17:42.000000000 -0700 +++ perl/lib/Test/Simple/Changes 2007-03-22 20:36:47.000000000 -0700 @@ -1,3 +1,13 @@ +0.70 Thu Mar 15 15:53:05 PDT 2007 + Bug Fixes + * The change to is_fh() in 0.68 broke the case where a reference to + a tied filehandle is used for perl 5.6 and back. This made the tests + puke their guts out. + +0.69 Wed Mar 14 06:43:35 PDT 2007 + Test fixes + - Minor filename compatibility fix to t/fail-more.t [rt.cpan.org 25428] + 0.68 Tue Mar 13 17:27:26 PDT 2007 Bug fixes * If your code has a $SIG{__DIE__} handler in some cases functions like ==== //depot/perl/lib/Test/Simple/t/is_fh.t#5 (text) ==== Index: perl/lib/Test/Simple/t/is_fh.t --- perl/lib/Test/Simple/t/is_fh.t#4~30578~ 2007-03-14 06:17:42.000000000 -0700 +++ perl/lib/Test/Simple/t/is_fh.t 2007-03-22 20:36:47.000000000 -0700 @@ -11,7 +11,7 @@ } use strict; -use Test::More tests => 8; +use Test::More tests => 10; use TieOut; ok( !Test::Builder->is_fh("foo"), 'string is not a filehandle' ); @@ -27,3 +27,10 @@ tie *OUT, 'TieOut'; ok( Test::Builder->is_fh(*OUT) ); +ok( Test::Builder->is_fh(\*OUT) ); + +SKIP: { + skip "*TIED_HANDLE{IO} doesn't work in this perl", 1 + unless defined *OUT{IO}; + ok( Test::Builder->is_fh(*OUT{IO}) ); +} End of Patch.