Re: [svn:parrot] r31570 - trunk/src/ops

2008-10-03 Thread NotFound
On Thu, Oct 2, 2008 at 11:00 PM, chromatic [EMAIL PROTECTED] wrote: Can anything in the PIO_open() path throw an exception? If so, these strings will leak. In a first look, it does not throw, but given that it calls layer functions, one never can be sure. But I don't see a better solution

Re: [perl #59576] [PATCH] 'property' scope for PAST::Var

2008-10-03 Thread Patrick R. Michaud
On Thu, Oct 02, 2008 at 02:16:01PM -0700, I Sop wrote: I just copied the 'attribute' method, renamed everything, and changed the parameter order for the 'getprop' op. Why should this be a PAST::Var node as opposed to simply using a PAST::Op node with :pirop('getprop') and/or

Re: [svn:parrot] r31581 - in branches/hllmagic: runtime/parrot/library t/library

2008-10-03 Thread Patrick R. Michaud
On Fri, Oct 03, 2008 at 01:23:14AM -0700, [EMAIL PROTECTED] wrote: +parrotclass = split '::', $S0 +$P0 = getinterp +$P0 = $P0['namespace';1] +$P0 = $P0.get_name() +$P0 = shift $P0 +unshift parrotclass, $P0 +parrotclass = get_root_namespace [parrotclass] The

[perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread via RT
# New Ticket Created by Will Coleda # Please include the string: [perl #59600] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59600 This is a patch-response to r31585, which required a particular version of Storable

Re: [perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread Geoffrey Broadwell
On Fri, 2008-10-03 at 08:55 -0700, Will Coleda wrote: Index: Makefile.PL === -BEGIN { require 5.008 } +BEGIN { require 5.8.6 } Index: Configure.pl === -use 5.008;

Re: [perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread Will Coleda
On Fri, Oct 3, 2008 at 12:13 PM, Geoffrey Broadwell [EMAIL PROTECTED] wrote: On Fri, 2008-10-03 at 08:55 -0700, Will Coleda wrote: Index: Makefile.PL === -BEGIN { require 5.008 } +BEGIN { require 5.8.6 } Index: Configure.pl

Re: [perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread chromatic
On Friday 03 October 2008 11:19:34 Will Coleda wrote: On Fri, Oct 3, 2008 at 12:13 PM, Geoffrey Broadwell Fair enough. For these two files, I recommend something more like: use 5.008; # get nice error on older perls use 5.8.6; # our actual requirement Which is from the slightly

Re: [perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread Will Coleda
On Fri, Oct 3, 2008 at 2:37 PM, chromatic [EMAIL PROTECTED] wrote: On Friday 03 October 2008 11:19:34 Will Coleda wrote: On Fri, Oct 3, 2008 at 12:13 PM, Geoffrey Broadwell Fair enough. For these two files, I recommend something more like: use 5.008; # get nice error on older perls use

[perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread James Keenan via RT
On Fri Oct 03 08:55:12 2008, coke wrote: This is a patch-response to r31585, which required a particular version of Storable in one file. Attached, find a patch which bumps our core perl requirement to 5.8.6, the first time this particular version of Storable was included as a core module

Re: [perl #59600] [PATCH] Require Storable 2.13 indirectly by requiring perl 5.8.6

2008-10-03 Thread Will Coleda
On Fri, Oct 3, 2008 at 9:28 PM, James Keenan via RT [EMAIL PROTECTED] wrote: On Fri Oct 03 08:55:12 2008, coke wrote: This is a patch-response to r31585, which required a particular version of Storable in one file. Attached, find a patch which bumps our core perl requirement to 5.8.6, the

Re: [svn:parrot] r31604 - in trunk/languages/pipp: src/pmc t/pmc

2008-10-03 Thread chromatic
On Friday 03 October 2008 18:14:19 [EMAIL PROTECTED] wrote: Log: [pipp] implement clone, add, i_add and assign_pmc and enable associated tests Modified: trunk/languages/pipp/src/pmc/phparray.pmc === === ---