Re: [GENERAL] Bug in pg_dump in 7.4.6?

2005-01-12 Thread Marco Colombo
On Tue, 11 Jan 2005, Tom Lane wrote: Greg Stark [EMAIL PROTECTED] writes: 7.4.6 pg_dump seems to be inserting a lot more SET SESSION AUTHORIZATION lines than previously. By previously do you mean 7.4.5 or thereabouts? I can't recall any late-7.4.* changes that might affect this. pg_dump is

Re: [GENERAL] Bug in pg_dump in 7.4.6?

2005-01-12 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: It seems the spurious SET SESSION AUTHORIZATION commands appear after any REVOKE/GRANT pair. Oh, right. In order to handle grants with GRANT OPTION, the dump data may need to include SET SESSION AUTHORIZATION commands; so the code assumes that it doesn't

Re: [GENERAL] Bug in pg_dump in 7.4.6?

2005-01-12 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Greg Stark [EMAIL PROTECTED] writes: It seems the spurious SET SESSION AUTHORIZATION commands appear after any REVOKE/GRANT pair. Oh, right. In order to handle grants with GRANT OPTION, the dump data may need to include SET SESSION AUTHORIZATION

Re: [GENERAL] Bug in pg_dump in 7.4.6?

2005-01-12 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: but since that's not the default mode anymore anyway, I'm not very concerned. What's not the default mode? I'm just running pg_dump -U postgresql -s db As of 8.0, I meant. regards, tom lane ---(end of

[GENERAL] Bug in pg_dump in 7.4.6?

2005-01-11 Thread Greg Stark
I regularly do a pg_dump -s and store the file in CVS. Normally I briefly look over the diff before committing so I can describe the changes. This latest time I observed a strange behaviour. 7.4.6 pg_dump seems to be inserting a lot more SET SESSION AUTHORIZATION lines than previously. Before

Re: [GENERAL] Bug in pg_dump in 7.4.6?

2005-01-11 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: 7.4.6 pg_dump seems to be inserting a lot more SET SESSION AUTHORIZATION lines than previously. By previously do you mean 7.4.5 or thereabouts? I can't recall any late-7.4.* changes that might affect this. pg_dump is supposed to optimize away redundant SET

Re: [GENERAL] Bug in pg_dump in 7.4.6?

2005-01-11 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Greg Stark [EMAIL PROTECTED] writes: 7.4.6 pg_dump seems to be inserting a lot more SET SESSION AUTHORIZATION lines than previously. By previously do you mean 7.4.5 or thereabouts? I think I went from 7.4.2 to 7.4.6. But I'm having trouble finding any