čt 27. 4. 2023 v 7:39 odesílatel Pavel Stehule
napsal:
> Hi
>
> rebased version + fix warning possibly uninitialized variable
>
fix not unique function id
Regards
Pavel
> Regards
>
> Pavel
>
>
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index b11d9a6ba3..f774ffa310
Hello Amit and Zhijie,
28.04.2023 05:51, Amit Kapila wrote:
On Wed, Apr 26, 2023 at 4:11 PM Zhijie Hou (Fujitsu)
wrote:
I think the problem is that it tried to release locks in
logicalrep_worker_onexit() before the initialization of the process is complete
because this callback function was
John Naylor writes:
> On Thu, Apr 27, 2023 at 9:12 PM Daniel Gustafsson wrote:
>> Is there a risk that the background psql will time out on slow systems during
>> the consumption of 2B xid's? Since you mainly want to hold it open for the
>> duration of testing you might want to bump it to avoid
On Wed, Apr 26, 2023 at 7:53 PM Drouvot, Bertrand
wrote:
>
> > Besides, would it be better to wait for the cascading standby? If the wal
> > log
> > file needed for cascading standby is removed on the standby, the subsequent
> > test
> > will fail.
>
> Good catch! I agree that we have to wait
On Thu, Apr 27, 2023 at 9:12 PM Daniel Gustafsson wrote:
>
> > On 27 Apr 2023, at 16:06, Masahiko Sawada wrote:
> > On Fri, Apr 21, 2023 at 12:02 PM John Naylor
> > wrote:
>
> >> ...that call to background_psql doesn't look like other ones that have
"key => value". Is there something I'm
On Wed, Apr 26, 2023 at 4:11 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, April 26, 2023 5:00 PM Alexander Lakhin
> wrote:
> >
> > IIUC, that assert will fail in case of any error raised between
> > ApplyWorkerMain()->logicalrep_worker_attach()->before_shmem_exit() and
> >
At Fri, 28 Apr 2023 11:15:51 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Thu, 27 Apr 2023 17:30:40 -0400, Melanie Plageman
> wrote in
> > After a quick example implementation of this, I found that it seemed to
> > try and flush the stats less often on an idle standby (good) than using
> >
At Thu, 27 Apr 2023 17:30:40 -0400, Melanie Plageman
wrote in
> On Wed, Apr 26, 2023 at 2:53 PM Melih Mutlu wrote:
> >
> > Hi all,
> >
> > Robert Haas , 26 Nis 2023 Çar, 15:34 tarihinde şunu
> > yazdı:
> >>
> >> On Wed, Apr 26, 2023 at 5:47 AM Kyotaro Horiguchi
> >> wrote:
> >> > 3. When
On Thu, Apr 27, 2023 9:53 PM Amit Kapila wrote:
>
> On Thu, Apr 27, 2023 at 4:07 PM Drouvot, Bertrand
> wrote:
> >
> > On 4/27/23 11:53 AM, Amit Kapila wrote:
> > > On Thu, Apr 27, 2023 at 2:16 PM Drouvot, Bertrand
> > > wrote:
> > >>
> > >> On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
> > >>>
(I find the misspelled subject makes it difficult to find the thread..)
At Thu, 27 Apr 2023 14:47:41 +0200, Jakub Wartak
wrote in
> On Tue, Apr 25, 2023 at 9:55 AM Kyotaro Horiguchi
> wrote:
> >
> > Rebased.
> >
> > I fixed some code comments and commit messages. I fixed the wrong
> >
On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov wrote:
> Additionally, I think if we start recording role OID, then we need a
> full set of management clauses for each individual option ownership.
> Otherwise, we would leave this new role OID without necessarily
> management facilities. But
On Fri, Apr 28, 2023 at 1:38 AM Tom Lane wrote:
> Nathan Bossart writes:
> > On Thu, Apr 27, 2023 at 03:22:04PM -0400, Tom Lane wrote:
> >> The right way to do this was not to add some
> >> poorly-explained option to ALTER ROLE, but to record the role OID that
> >> issued the ALTER ROLE, and
Nathan Bossart writes:
> On Thu, Apr 27, 2023 at 03:22:04PM -0400, Tom Lane wrote:
>> The right way to do this was not to add some
>> poorly-explained option to ALTER ROLE, but to record the role OID that
>> issued the ALTER ROLE, and then to check when loading the ALTER ROLE
>> setting whether
Hi,
On 2023-04-26 09:59:05 -0400, Andrew Dunstan wrote:
> Still running into this, and I am rather stumped. This is a blocker for
> buildfarm support for meson:
>
> Here's a simple illustration of the problem. If I do the identical test with
> a non-meson build there is no problem:
This happens
On Thu, Apr 27, 2023 at 03:22:04PM -0400, Tom Lane wrote:
> The right way to do this was not to add some
> poorly-explained option to ALTER ROLE, but to record the role OID that
> issued the ALTER ROLE, and then to check when loading the ALTER ROLE
> setting whether that role (still) has the right
On Wed, Apr 26, 2023 at 2:53 PM Melih Mutlu wrote:
>
> Hi all,
>
> Robert Haas , 26 Nis 2023 Çar, 15:34 tarihinde şunu
> yazdı:
>>
>> On Wed, Apr 26, 2023 at 5:47 AM Kyotaro Horiguchi
>> wrote:
>> > 3. When should we call pgstat_report_stats on the startup process?
>> >
>> > During recovery, I
> On 27 Apr 2023, at 16:53, Melanie Plageman wrote:
> On Thu, Apr 27, 2023 at 8:55 AM Daniel Gustafsson wrote:
>>
>>> On 27 Apr 2023, at 14:10, Masahiko Sawada wrote:
>>> Good catch. I think the problem is that vacuum_rel() is called
>>> recursively and we don't reset VacuumFailsafeActive
Nathan Bossart writes:
> I suspect the problem is that GUCArrayDelete() is using the wrong Datum:
> -newUsersetArray = construct_array_builtin(, 1, BOOLOID);
> +newUsersetArray = construct_array_builtin(, 1,
> BOOLOID);
Ah, should have checked my mail earlier.
David Steele writes:
> On 4/27/23 21:16, Tom Lane wrote:
>> I tried to replicate this per that recipe, but it works for me:
> I included the errors in the expect log so I could link to them. So test
> success means the error is happening.
Ah, got it.
I added some debug output to the test, and
.On Thu, Apr 27, 2023 at 9:55 PM Nathan Bossart
wrote:
> On Thu, Apr 27, 2023 at 09:53:23PM +0300, Alexander Korotkov wrote:
> > Thanks to everybody for catching and investigating this.
> > Nathan, I'd like to push it myself. I'm also going to check the code
> > for similar errors.
>
> Sounds
On Thu, Apr 27, 2023 at 09:53:23PM +0300, Alexander Korotkov wrote:
> Thanks to everybody for catching and investigating this.
> Nathan, I'd like to push it myself. I'm also going to check the code
> for similar errors.
Sounds good!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hi!
On Thu, Apr 27, 2023 at 9:51 PM Nathan Bossart wrote:
> On Thu, Apr 27, 2023 at 09:47:33PM +0300, David Steele wrote:
> > That seems to work. The errors are now gone.
>
> Great. Barring objections, I'll plan on committing this shortly.
Thanks to everybody for catching and investigating
On Thu, Apr 27, 2023 at 09:47:33PM +0300, David Steele wrote:
> That seems to work. The errors are now gone.
Great. Barring objections, I'll plan on committing this shortly.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
On 4/27/23 21:43, Nathan Bossart wrote:
I suspect the problem is that GUCArrayDelete() is using the wrong Datum:
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9dd624b3ae..ee9f87e7f2 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@
I suspect the problem is that GUCArrayDelete() is using the wrong Datum:
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9dd624b3ae..ee9f87e7f2 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -6496,7 +6496,7 @@
On Thu, Apr 27, 2023 at 2:17 PM Peter Geoghegan wrote:
> On Thu, Apr 27, 2023 at 11:04 AM Robert Haas wrote:
> > I think I may pursue a different approach to the problem that led me
> > to think about this, at least for the moment. But I'm still curious
> > about the general question: if
On 4/27/23 21:16, Tom Lane wrote:
David Steele writes:
Seems plausible. This can be reproduced by cloning [1] into contrib and
running `make check`. I can work out another test case but it may not
end up being simpler.
[1] https://github.com/pgaudit/pgaudit/tree/dev-pg16-ci
I tried to
On Thu, Apr 27, 2023 at 11:17 AM Peter Geoghegan wrote:
> I'm asking this (at least in part) because it affects the answer. Lots
> of stuff that GIN does that seems like it would be particularly tricky
> to integrate with a system catalog is non-essential. It could be (and
> sometimes is)
On Thu, Apr 27, 2023 at 11:04 AM Robert Haas wrote:
> I think I may pursue a different approach to the problem that led me
> to think about this, at least for the moment. But I'm still curious
> about the general question: if somebody showed up with a well-written
> patch that added a GIN index
David Steele writes:
> Seems plausible. This can be reproduced by cloning [1] into contrib and
> running `make check`. I can work out another test case but it may not
> end up being simpler.
> [1] https://github.com/pgaudit/pgaudit/tree/dev-pg16-ci
I tried to replicate this per that recipe,
Hi,
Today, I found myself wondering whether we could add a non-btree
index, and in particular a GIN index, to a system catalog if we so
desired. Currently, after initdb, we only create tables and btree
indexes, but I'm not sure if there is any good reason why we couldn't
do something else. One
On Fri, Sep 23, 2022 at 3:39 PM Jacob Champion wrote:
> Here's a newly rebased v5. (They're all zipped now, which I probably
> should have done a while back, sorry.)
To keep this current, v7 is rebased over latest, without the pluggable
authentication patches. This doesn't yet address the
On 4/27/23 19:13, Tom Lane wrote:
David Steele writes:
I have been updating pgAudit for PG16 and ran into the following issue
in the regression tests:
\connect - user1
WARNING: permission denied to set parameter "pgaudit.log_level"
This happens after switching back and forth a few times
Hi,
On 2023-04-26 21:53:16 +0300, Melih Mutlu wrote:
> Robert Haas , 26 Nis 2023 Çar, 15:34 tarihinde şunu
> yazdı:
>
> > On Wed, Apr 26, 2023 at 5:47 AM Kyotaro Horiguchi
> > wrote:
> > > 3. When should we call pgstat_report_stats on the startup process?
> > >
> > > During recovery, I think we
David Steele writes:
> I have been updating pgAudit for PG16 and ran into the following issue
> in the regression tests:
> \connect - user1
> WARNING: permission denied to set parameter "pgaudit.log_level"
> This happens after switching back and forth a few times between the
> current user
Thanks for the review!
On Wed, Apr 26, 2023 at 10:22 PM Kyotaro Horiguchi
wrote:
>
> At Wed, 26 Apr 2023 17:08:14 -0400, Melanie Plageman
> wrote in
> > On Mon, Apr 24, 2023 at 9:29 PM Melanie Plageman
> > wrote:
> > > I've yet to cook up a client backend test case (e.g. with COPY). I've
> >
Hackers,
I have been updating pgAudit for PG16 and ran into the following issue
in the regression tests:
\connect - user1
WARNING: permission denied to set parameter "pgaudit.log_level"
This happens after switching back and forth a few times between the
current user when the regression
On Thu, Apr 27, 2023 at 8:55 AM Daniel Gustafsson wrote:
>
> > On 27 Apr 2023, at 14:10, Masahiko Sawada wrote:
> >
> > On Thu, Apr 27, 2023 at 6:30 PM John Naylor
> > wrote:
> >>
> >>
> >> On Fri, Apr 7, 2023 at 6:08 AM Daniel Gustafsson wrote:
> >>>
> >>> I had another read-through and
> On 27 Apr 2023, at 16:06, Masahiko Sawada wrote:
> On Fri, Apr 21, 2023 at 12:02 PM John Naylor
> wrote:
>> ...that call to background_psql doesn't look like other ones that have "key
>> => value". Is there something I'm missing?
>
> Thanks for reporting. I think that the patch needs to be
On Fri, Apr 21, 2023 at 12:02 PM John Naylor
wrote:
>
> I agree having the new functions in the tree is useful. I also tried running
> the TAP tests in v2, but 001 and 002 fail to run:
>
> Odd number of elements in hash assignment at [...]/Cluster.pm line 2010.
> Can't locate object method
On Thu, Apr 27, 2023 at 4:07 PM Drouvot, Bertrand
wrote:
>
> On 4/27/23 11:53 AM, Amit Kapila wrote:
> > On Thu, Apr 27, 2023 at 2:16 PM Drouvot, Bertrand
> > wrote:
> >>
> >> On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
> >>> Hi hackers,
> >>>
> >>> In 035_standby_logical_decoding.pl, I think
> On 27 Apr 2023, at 14:10, Masahiko Sawada wrote:
>
> On Thu, Apr 27, 2023 at 6:30 PM John Naylor
> wrote:
>>
>>
>> On Fri, Apr 7, 2023 at 6:08 AM Daniel Gustafsson wrote:
>>>
>>> I had another read-through and test-through of this version, and have
>>> applied
>>> it with some minor
On Tue, Apr 25, 2023 at 9:55 AM Kyotaro Horiguchi
wrote:
>
> Rebased.
>
> I fixed some code comments and commit messages. I fixed the wrong
> arrangement of some changes among patches. Most importantly, I fixed
> the a bug based on a wrong assumption that init-fork is not resides on
> shared
Hi John,
Thanks for your review. Here's v2 attached.
> -partition keys
> -32
> -can be increased by recompiling
> PostgreSQL
> + partition keys
> + 32
> + can be increased by recompiling
> PostgreSQL
>
> Spurious whitespace.
Hopefully fixed, I've tried to align with
On Wed, Apr 26, 2023 at 8:29 AM Daniel Gustafsson wrote:
> Pushed, but without the comment extension as I felt the existing comment aptly
> discussed the codepath. Thanks!
Woopsie. Thanks to both of you.
--
Robert Haas
EDB: http://www.enterprisedb.com
Jeff Davis wrote:
> Attached are a few small patches:
>
> 0001: don't convert C to en-US-u-va-posix
> 0002: handle locale C the same regardless of the provider, as you
> suggest above
> 0003: make LOCALE (or --locale) apply to everything including ICU
Testing this briefly I
On Thu, Apr 27, 2023 at 6:30 PM John Naylor
wrote:
>
>
> On Fri, Apr 7, 2023 at 6:08 AM Daniel Gustafsson wrote:
> >
> > I had another read-through and test-through of this version, and have
> > applied
> > it with some minor changes to comments and whitespace. Thanks for the quick
> >
Peter Eisentraut wrote:
> COLLATE UNICODE
>
> instead of
>
> COLLATE "und-x-icu"
>
> or whatever it is, is pretty useful.
>
> So, attached is a small patch to add this.
This collation has an empty pg_collation.collversion column, instead
of being set to the same value as
Hello,
Anton Kirilov a écrit :
On 25/04/2023 15:23, Denis Laxalde wrote:
This sounds like a useful addition to me. I've played a bit with it in
Psycopg and it works fine.
Thank you very much for reviewing my patch! I have attached a new
version of it that addresses your comments and that has
On 4/27/23 11:54 AM, Amit Kapila wrote:
On Thu, Apr 27, 2023 at 1:05 PM Drouvot, Bertrand
wrote:
On 4/27/23 5:37 AM, Amit Kapila wrote:
On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
wrote:
+When in recovery, the default value of target_lsn is $node->lsn('replay')
+instead. This is
On Mon, Apr 24, 2023 at 01:06:24PM -0400, Mat Arye wrote:
> Hi All,
>
> I've done upgrade maintenance for multiple extensions now (TimescaleDB
> core, Promscale) and I think the original suggestion (wildcard filenames
> with control-file switch to enable) here is a good one.
Thanks for your
Hi,
I think I should open a new thread related to TOAST pointer refactoring
based on Pluggable TOAST, COPY and looping in retrieving new TOAST
value OID issues.
On Wed, Apr 26, 2023 at 4:00 PM Aleksander Alekseev <
aleksan...@timescale.com> wrote:
> Hi Nikita,
>
> > The External TOAST pointer
Hi!
Widening of a TOAST pointer is possible if we keep backward compatibility
with
old-fashioned TOAST tables - I mean differ 'long' and 'short' TOAST
pointers and
process them accordingly on insert and delete cases, and vacuum with logical
replication. It is not very difficult, however it takes
Hi,
On 4/27/23 11:53 AM, Amit Kapila wrote:
On Thu, Apr 27, 2023 at 2:16 PM Drouvot, Bertrand
wrote:
On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
Hi hackers,
In 035_standby_logical_decoding.pl, I think that the check in the following test
case should be performed on the standby node,
On Thu, Apr 27, 2023 at 1:05 PM Drouvot, Bertrand
wrote:
>
> On 4/27/23 5:37 AM, Amit Kapila wrote:
> > On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
> > wrote:
> >
> > +When in recovery, the default value of target_lsn is $node->lsn('replay')
> > +instead. This is needed when the publisher
On Thu, Apr 27, 2023 at 2:16 PM Drouvot, Bertrand
wrote:
>
> On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
> > Hi hackers,
> >
> > In 035_standby_logical_decoding.pl, I think that the check in the following
> > test
> > case should be performed on the standby node, instead of the primary node,
>
On Thu, Apr 27, 2023 4:47 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
> > Hi hackers,
> >
> > In 035_standby_logical_decoding.pl, I think that the check in the following
> > test
> > case should be performed on the standby node, instead of the primary
> On 27 Apr 2023, at 11:29, John Naylor wrote:
> On Fri, Apr 7, 2023 at 6:08 AM Daniel Gustafsson wrote:
> > I had another read-through and test-through of this version, and have
> > applied
> > it with some minor changes to comments and whitespace. Thanks for the quick
> > turnaround times
On Fri, Apr 7, 2023 at 6:08 AM Daniel Gustafsson wrote:
>
> I had another read-through and test-through of this version, and have
applied
> it with some minor changes to comments and whitespace. Thanks for the
quick
> turnaround times on reviews in this thread!
- VacuumFailsafeActive =
Hi,
On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
Hi hackers,
In 035_standby_logical_decoding.pl, I think that the check in the following test
case should be performed on the standby node, instead of the primary node, as
the slot is created on the standby node.
Oh right, the current test is
Hi hackers,
In 035_standby_logical_decoding.pl, I think that the check in the following test
case should be performed on the standby node, instead of the primary node, as
the slot is created on the standby node. The test currently passes because it
only checks the return value of psql. It might
Dear Julien,
Thank you for updating the patch! Followings are my comments.
01. documentation
In this page steps to upgrade server with pg_upgrade is aligned. Should we write
down about subscriber? IIUC, it is sufficient to just add to "Run pg_upgrade",
like "Apart from streaming replication
Hi,
On 4/27/23 5:37 AM, Amit Kapila wrote:
On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
wrote:
+When in recovery, the default value of target_lsn is $node->lsn('replay')
+instead. This is needed when the publisher passed to
wait_for_subscription_sync()
+is a standby node.
I think this
On Sun, Apr 23, 2023 at 11:30 AM Richard Guo wrote:
> On Sat, Apr 22, 2023 at 11:21 PM Tom Lane wrote:
>> Hmm. I don't entirely understand why the existing stop-at-nulls logic
>> in nodeMergejoin.c didn't fix this for you. Maybe somebody has broken
>> that? See the commentary for
On Thu, Apr 27, 2023 at 11:24:52AM +0530, Bharath Rupireddy wrote:
> IMO, +1 for HEAD/PG16 and +0.5 for backpatching as it may not be so
> critical to backpatch all the way down. What may happen without this
> patch is that the output file isn't fsync-ed upon SIGINT/SIGTERM.
> Well, is it a
On Wed, Apr 26, 2023 at 08:36:44PM +0200, Drouvot, Bertrand wrote:
> Please find attached V5 addressing the previous comments except
> the "ordering" one (need to look deeper at this).
I was putting my hands into that, and I see now what you mean here..
Among the nine types of wait events, Lock,
66 matches
Mail list logo
