Re:

2024-05-09 Thread zaidagilist
On Thu, May 9, 2024 at 2:50 PM Rajan Pandey wrote: > > Hi everyone, I just installed Postgres and pg_tle extension as I was looking > to contribute to pg_tle. > > Somehow, I am unable to update the shared_preload_libraries. It feels like > ALTER has happened but the SPL value is not updated: >>

Re: Set appropriate processing mode for auxiliary processes.

2024-05-09 Thread Xing Guo
On Thu, May 9, 2024 at 11:19 PM Tom Lane wrote: > > Heikki Linnakangas writes: > > At first I was sure this was introduced by my refactorings in v17, but > > in fact it's been like this forever. I agree that InitProcessing makes > > much more sense. The ProcessingMode variable is initialized to

RE: Improving the latch handling between logical replication launcher and worker processes.

2024-05-09 Thread Hayato Kuroda (Fujitsu)
Dear Vignesh, Thanks for raising idea! > a) Introduce a new latch to handle worker attach and exit. Just to confirm - there are three wait events for launchers, so I feel we may be able to create latches per wait event. Is there a reason to introduce "a" latch? > b) Add a new GUC

Re: Weird test mixup

2024-05-09 Thread Michael Paquier
On Thu, May 09, 2024 at 04:39:00PM -0700, Noah Misch wrote: Thanks for the feedback. > The return-bool approach sounds fine. Up to you whether to do in this patch, > else I'll do it when I add the test. I see no reason to not change the signature of the routine now if we know that we're going

Re: SQL:2011 application time

2024-05-09 Thread Matthias van de Meent
Hi, I haven't really been following this thread, but after playing around a bit with the feature I feel there are new gaps in error messages. I also think there are gaps in the functionality regarding the (lack of) support for CREATE UNIQUE INDEX, and attaching these indexes to constraints. pg=#

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

2024-05-09 Thread Tom Lane
Alexander Korotkov writes: > The revised patchset is attached. I applied cosmetical changes. I'm > going to push it if no objections. Is this really suitable material to be pushing post-feature-freeze? It doesn't look like it's fixing any new-in-v17 issues. regards,

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

2024-05-09 Thread Alexander Korotkov
On Wed, May 1, 2024 at 5:26 AM Alexander Korotkov wrote: > On Wed, May 1, 2024 at 5:24 AM Noah Misch wrote: > > On Thu, Apr 25, 2024 at 04:59:54PM +0400, Pavel Borisov wrote: > > > 0001: Optimize speed by avoiding heap visibility checking for different > > > non-deduplicated index tuples as

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 08:40:00PM +0200, Álvaro Herrera wrote: > On 2024-May-09, Bruce Momjian wrote: > > > However, I don't see it mentioned as a release note item in the commit > > message or mentioned in our docs. I suppose the release note text would > > be: > > > > Removing a PRIMARY

Re: Weird test mixup

2024-05-09 Thread Noah Misch
On Thu, May 09, 2024 at 04:40:43PM +0900, Michael Paquier wrote: > So I like your suggestion. This version closes the race window > between the shmem exit detach in backend A and a concurrent backend B > running a point local to A so as B will never run the local point of > A. However, it can

Re: open items

2024-05-09 Thread Michael Paquier
On Thu, May 09, 2024 at 03:28:13PM -0400, Robert Haas wrote: > Just a few reminders about the open items list at > https://wiki.postgresql.org/wiki/PostgreSQL_17_Open_Items -- Thanks for summarizing the situation. > * Race condition with local injection point detach. Discussion is ongoing. I

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Dagfinn Ilmari Mannsåker
Andres Freund writes: > Hi, > > On 2024-05-09 20:53:27 +0100, Dagfinn Ilmari Mannsåker wrote: >> Andres Freund writes: >> > On 2024-05-09 20:12:38 +0100, Dagfinn Ilmari Mannsåker wrote: >> >> Attached is a patch which adds a check-docs target for meson, which >> >> takes 0.3s on my laptop. >>

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Fri, May 10, 2024 at 08:05:43AM +1200, Thomas Munro wrote: > On Thu, May 9, 2024 at 4:04 PM Bruce Momjian wrote: > > I welcome feedback. For some reason it was an easier job than usual. > > > 2024-01-25 [820b5af73] jit: Require at least LLVM 10. > > > Require LLVM version 10 or later (Peter

Re: PERIOD foreign key feature

2024-05-09 Thread Bruce Momjian
On Wed, May 8, 2024 at 08:47:45PM -0700, Paul Jungwirth wrote: > On 5/8/24 07:44, Bruce Momjian wrote: > > On Wed, May 8, 2024 at 02:29:34PM +0200, Peter Eisentraut wrote: > > > > Yes, David is correct here on all points. I like his suggestion to > > > > clarify the language here also. If you

Re: partitioning and identity column

2024-05-09 Thread Ashutosh Bapat
Thanks a lot Peter. On Wed, May 8, 2024 at 2:34 AM Peter Eisentraut wrote: > On 30.04.24 12:59, Ashutosh Bapat wrote: > > PFA patch which fixes all the three problems. > > I have committed this patch. Thanks all. > -- Best Wishes, Ashutosh Bapat

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread David G. Johnston
On Thu, May 9, 2024 at 1:16 PM Andres Freund wrote: > Hi, > > On 2024-05-09 09:23:37 -0700, David G. Johnston wrote: > > This needs updating: > > https://www.postgresql.org/docs/current/docguide-build-meson.html > > You mean it should have a syntax target? Or that something else is out of >

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Andres Freund
Hi, On 2024-05-09 20:53:27 +0100, Dagfinn Ilmari Mannsåker wrote: > Andres Freund writes: > > On 2024-05-09 20:12:38 +0100, Dagfinn Ilmari Mannsåker wrote: > >> Attached is a patch which adds a check-docs target for meson, which > >> takes 0.3s on my laptop. > >> +checkdocs =

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Andres Freund
Hi, On 2024-05-09 09:23:37 -0700, David G. Johnston wrote: > This needs updating: > https://www.postgresql.org/docs/current/docguide-build-meson.html You mean it should have a syntax target? Or that something else is out of date? > Also, as a sanity check, running that command takes my system

Re: First draft of PG 17 release notes

2024-05-09 Thread Thomas Munro
On Thu, May 9, 2024 at 4:04 PM Bruce Momjian wrote: > I welcome feedback. For some reason it was an easier job than usual. > 2024-01-25 [820b5af73] jit: Require at least LLVM 10. > Require LLVM version 10 or later (Peter Eisentraut) Peter reviewed, I authored, and I think you intend to list

Re: cataloguing NOT NULL constraints

2024-05-09 Thread Robert Haas
On Wed, May 8, 2024 at 4:42 PM Alvaro Herrera wrote: > I spent a long time trying to think how to fix this, and I had despaired > wanting to write that I would need to revert the whole NOT NULL business > for pg17 -- but that was until I realized that we don't actually need > this NOT NULL NO

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-09 Thread Daniel Gustafsson
> On 9 May 2024, at 21:34, Nathan Bossart wrote: > > On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote: >> +1. Could there be an argument in favor of a backpatch? This is a >> performance improvement, but one could also side that the addition of >> sync support in pg_dump[all]

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Dagfinn Ilmari Mannsåker
Andres Freund writes: > Hi, > > On 2024-05-09 20:12:38 +0100, Dagfinn Ilmari Mannsåker wrote: >> Attached is a patch which adds a check-docs target for meson, which >> takes 0.3s on my laptop. > > Nice. > > >> +checkdocs = custom_target('check-docs', >> + input: 'postgres.sgml', >> + output:

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread David G. Johnston
On Thu, May 9, 2024 at 12:12 PM Dagfinn Ilmari Mannsåker wrote: > "David G. Johnston" writes: > > > I've been using "ninja html" which isn't shown here. > > The /devel/ version has a link to the full list of doc targets: > > >

Re: request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
On Thu, 9 May 2024 at 15:39, Robert Haas wrote: > On Thu, May 9, 2024 at 3:33 PM Dave Cramer wrote: > > On Thu, 9 May 2024 at 15:19, Robert Haas wrote: > >> On Thu, May 9, 2024 at 3:14 PM Andres Freund > wrote: > >> > ISTM that you could just as well query the information you'd like > after >

Re: open items

2024-05-09 Thread Robert Haas
On Thu, May 9, 2024 at 3:38 PM Dagfinn Ilmari Mannsåker wrote: > Robert Haas writes: > > * Register ALPN protocol id with IANA. From the mailing list thread, > > it is abundantly clear that IANA is in no hurry to finish dealing with > > what seems to be a completely pro forma request from our

Re: request for database identifier in the startup packet

2024-05-09 Thread Robert Haas
On Thu, May 9, 2024 at 3:33 PM Dave Cramer wrote: > On Thu, 9 May 2024 at 15:19, Robert Haas wrote: >> On Thu, May 9, 2024 at 3:14 PM Andres Freund wrote: >> > ISTM that you could just as well query the information you'd like after >> > connecting. And that's going to be a lot more flexible

Re: Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-05-09 Thread Tom Lane
"Ryo Matsumura (Fujitsu)" writes: > It is indefinite what PGTYPEStimestamp_from_asc() returns in error. > The following is written in document(36.6.8. Special Constants of pgtypeslib): > A value of type timestamp representing an invalid time stamp. > This is returned by the function

Re: open items

2024-05-09 Thread Dagfinn Ilmari Mannsåker
Robert Haas writes: > * Register ALPN protocol id with IANA. From the mailing list thread, > it is abundantly clear that IANA is in no hurry to finish dealing with > what seems to be a completely pro forma request from our end. I think > we just have to be patient. This appears to have been

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Andres Freund
Hi, On 2024-05-09 20:12:38 +0100, Dagfinn Ilmari Mannsåker wrote: > Attached is a patch which adds a check-docs target for meson, which > takes 0.3s on my laptop. Nice. > +checkdocs = custom_target('check-docs', > + input: 'postgres.sgml', > + output: 'check-docs', > + depfile:

Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall

2024-05-09 Thread Nathan Bossart
On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote: > +1. Could there be an argument in favor of a backpatch? This is a > performance improvement, but one could also side that the addition of > sync support in pg_dump[all] has made that a regression that we'd > better fix because

Re: request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
On Thu, 9 May 2024 at 15:19, Robert Haas wrote: > On Thu, May 9, 2024 at 3:14 PM Andres Freund wrote: > > ISTM that you could just as well query the information you'd like after > > connecting. And that's going to be a lot more flexible than having to > have > > precisely the right information

open items

2024-05-09 Thread Robert Haas
Hi, Just a few reminders about the open items list at https://wiki.postgresql.org/wiki/PostgreSQL_17_Open_Items -- - Please don't add issues to this list unless they are the result of development done during this release cycle. This is not a general-purpose bug tracker. - The owner of an item

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Tomas Vondra
On 5/9/24 17:51, Matthias van de Meent wrote: > On Thu, 9 May 2024 at 15:13, Tomas Vondra > wrote: >> Let me explain the relevant part of the patch, and how I understand the >> improvement suggested by Matthias. The patch does the work in three phases: >> >> >> 1) Worker gets data from table,

Re: request for database identifier in the startup packet

2024-05-09 Thread Robert Haas
On Thu, May 9, 2024 at 3:14 PM Andres Freund wrote: > ISTM that you could just as well query the information you'd like after > connecting. And that's going to be a lot more flexible than having to have > precisely the right information in the startup message, and most clients not > needing it.

Re: request for database identifier in the startup packet

2024-05-09 Thread Andres Freund
Hi, On 2024-05-09 14:20:49 -0400, Dave Cramer wrote: > On Thu, 9 May 2024 at 12:22, Robert Haas wrote: > > On Thu, May 9, 2024 at 8:06 AM Dave Cramer wrote: > > > The JDBC driver is currently keeping a per connection cache of types in > > the driver. We are seeing cases where the number of

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Dagfinn Ilmari Mannsåker
"David G. Johnston" writes: > $subject > > Make has one: > https://www.postgresql.org/docs/current/docguide-build.html#DOCGUIDE-BUILD-SYNTAX-CHECK > > This needs updating: > https://www.postgresql.org/docs/current/docguide-build-meson.html > > I've been using "ninja html" which isn't shown here.

Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-05-09 Thread Ryo Matsumura (Fujitsu)
Hi hackers, I detected two problems about ECPG. I show my opinion. Please comment. If it's correct, I will prepare a patch. Thank you. 1. It is indefinite what PGTYPEStimestamp_from_asc() returns in error. The following is written in document(36.6.8. Special Constants of pgtypeslib): A value

Re: First draft of PG 17 release notes

2024-05-09 Thread Álvaro Herrera
On 2024-May-09, Bruce Momjian wrote: > However, I don't see it mentioned as a release note item in the commit > message or mentioned in our docs. I suppose the release note text would > be: > > Removing a PRIMARY KEY will remove the NOT NULL column specification > > Previously the

Re: request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
Dave Cramer On Thu, 9 May 2024 at 12:22, Robert Haas wrote: > On Thu, May 9, 2024 at 8:06 AM Dave Cramer wrote: > > The JDBC driver is currently keeping a per connection cache of types in > the driver. We are seeing cases where the number of columns is quite high. > In one case Prevent

Re: [PATCH] json_lex_string: don't overread on bad UTF8

2024-05-09 Thread Jacob Champion
On Wed, May 8, 2024 at 9:27 PM Michael Paquier wrote: > This is a bit mitigated by the fact that d6607016c738 is recent, but > this is incorrect since v13 so backpatched down to that. Thank you! --Jacob

Re: Support tid range scan in parallel?

2024-05-09 Thread Cary Huang
> I've not looked at the patch, but please add it to the July CF. I'll > try and look in more detail then. Thanks David, I have added this patch on July commitfest under the server feature category. I understand that the regression tests for parallel ctid range scan is a bit lacking now. It

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Dagfinn Ilmari Mannsåker
"David G. Johnston" writes: > $subject > > Make has one: > https://www.postgresql.org/docs/current/docguide-build.html#DOCGUIDE-BUILD-SYNTAX-CHECK > > This needs updating: > https://www.postgresql.org/docs/current/docguide-build-meson.html > > I've been using "ninja html" which isn't shown here.

Re: Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread Tom Lane
"David G. Johnston" writes: > I've been using "ninja html" which isn't shown here. Also, as a sanity > check, running that command takes my system 1 minute. Any idea what > percentile that falls into? On my no-longer-shiny-new workstation, "make" in doc/src/sgml (which builds just the HTML

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 12:10:11PM -0400, Andrew Dunstan wrote: > > On 2024-05-09 Th 00:03, Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > > It

Re: CREATE DATABASE with filesystem cloning

2024-05-09 Thread Robert Haas
On Wed, May 8, 2024 at 10:34 AM Nazir Bilal Yavuz wrote: > > I'm not so sure about the GUC name. On the one hand, it feels like > > createdb should be spelled out as create_database, but on the other > > hand, the GUC name is quite long already. Then again, why would we > > make this specific to

Is there an undocumented Syntax Check in Meson?

2024-05-09 Thread David G. Johnston
$subject Make has one: https://www.postgresql.org/docs/current/docguide-build.html#DOCGUIDE-BUILD-SYNTAX-CHECK This needs updating: https://www.postgresql.org/docs/current/docguide-build-meson.html I've been using "ninja html" which isn't shown here. Also, as a sanity check, running that

Re: request for database identifier in the startup packet

2024-05-09 Thread Robert Haas
On Thu, May 9, 2024 at 8:06 AM Dave Cramer wrote: > The JDBC driver is currently keeping a per connection cache of types in the > driver. We are seeing cases where the number of columns is quite high. In one > case Prevent fetchFieldMetaData() from being run when unnecessary. · Issue > #3241 ·

Re: First draft of PG 17 release notes

2024-05-09 Thread Andrew Dunstan
On 2024-05-09 Th 00:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: https://momjian.us/pgsql_docs/release-17.html It will be improved until the final release. The item count is 188, which is similar to recent

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Matthias van de Meent
On Thu, 9 May 2024 at 15:13, Tomas Vondra wrote: > Let me explain the relevant part of the patch, and how I understand the > improvement suggested by Matthias. The patch does the work in three phases: > > > 1) Worker gets data from table, split that into index items and add > those into a

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 11:26:44PM +0800, jian he wrote: > On Thu, May 9, 2024 at 11:12 PM Bruce Momjian wrote: > > > > On Thu, May 9, 2024 at 07:49:55PM +0800, jian he wrote: > > > On Thu, May 9, 2024 at 6:53 PM jian he > > > wrote: > > > > > > > > On Thu, May 9, 2024 at 12:04 PM Bruce

Re: First draft of PG 17 release notes

2024-05-09 Thread br...@momjian.us
On Thu, May 9, 2024 at 11:03:39AM +, Hans Buschmann wrote: > Some findings > > > 1. > > >>Remove adminpack contrib extension (Daniel Gustafsson) > > >>This was used by non-end-of-life pgAdmin III. > > > Perhaps you mean now-end-of-life (s/non/now/) Yes, fixed to "now end-of-life" > 2. >

Re: First draft of PG 17 release notes

2024-05-09 Thread jian he
On Thu, May 9, 2024 at 11:12 PM Bruce Momjian wrote: > > On Thu, May 9, 2024 at 07:49:55PM +0800, jian he wrote: > > On Thu, May 9, 2024 at 6:53 PM jian he wrote: > > > > > > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release

Re: Set appropriate processing mode for auxiliary processes.

2024-05-09 Thread Tom Lane
Heikki Linnakangas writes: > At first I was sure this was introduced by my refactorings in v17, but > in fact it's been like this forever. I agree that InitProcessing makes > much more sense. The ProcessingMode variable is initialized to > InitProcessing, so I think we can simply remove that

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 07:49:55PM +0800, jian he wrote: > On Thu, May 9, 2024 at 6:53 PM jian he wrote: > > > > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > I have committed the first draft of the PG 17 release notes; you can > > > see the results here: > > > > > >

Re: Set appropriate processing mode for auxiliary processes.

2024-05-09 Thread Xing Guo
Sorry, forget to add an assertion to guard our codes in my previous patch. From 4f2d70fb27e3ff23b8572c5e679c791daa1f6665 Mon Sep 17 00:00:00 2001 From: Xing Guo Date: Thu, 9 May 2024 20:57:48 +0800 Subject: [PATCH v3] Remove redundant SetProcessingMode(InitProcessing) calls. After several

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 06:57:01PM +0800, jian he wrote: > > << > > Allow ALTER OPERATOR to set more optimization attributes (Tommy Pavlicek) > > This is useful for extensions. > > << > > sorry, I mean > << > Allow the creation of hash indexes on ltree columns (Tommy Pavlicek) > This also

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 06:53:30PM +0800, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > > > > * Add function

Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.

2024-05-09 Thread Tom Lane
Richard Guo writes: > I also think it seems better to do bms_copy in separate steps, not only > because this keeps consistent with the existing code in > remove_rel_from_restrictinfo, but also because we need to do > bms_del_member twice for each lefthand/righthand relid set. Yeah. Of course,

Re: New GUC autovacuum_max_threshold ?

2024-05-09 Thread Robert Haas
On Wed, May 8, 2024 at 1:30 PM Imseih (AWS), Sami wrote: > There is also an alternative of making this GUC -1 by default, which > means it has not effect and any value larger will be used in the threshold > calculation of autovacuunm. A user will have to be careful not to set it too > low, > but

Re: Set appropriate processing mode for auxiliary processes.

2024-05-09 Thread Xing Guo
On Thu, May 9, 2024 at 10:13 PM Heikki Linnakangas wrote: > > On 09/05/2024 16:12, Xing Guo wrote: > > Hi hackers, > > > > After several refactoring iterations, auxiliary processes are no > > longer initialized from the bootstrapper. I think using the > > InitProcessing mode for initializing

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 11:31:17AM +0100, Dagfinn Ilmari Mannsåker wrote: > Dagfinn Ilmari Mannsåker writes: > > > Bruce Momjian writes: > > > >> I have committed the first draft of the PG 17 release notes; you can > >> see the results here: > >> > >>

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 11:22:06AM +0100, Dagfinn Ilmari Mannsåker wrote: > Bruce Momjian writes: > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > > My name is listed twice in the

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 06:00:24PM +0800, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > > > > another

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Tomas Vondra
On 5/2/24 20:22, Tomas Vondra wrote: >> >>> For some of the opclasses it can regress (like the jsonb_path_ops). I >>> don't think that's a major issue. Or more precisely, I'm not surprised >>> by it. It'd be nice to be able to disable the parallel builds in these >>> cases somehow, but I haven't

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 12:18:44PM +0300, Aleksander Alekseev wrote: > Hi, > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > > > > It will be improved until the final release. The

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 02:37:57PM +0800, Richard Guo wrote: > > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes;  you can > see the results here: > >         https://momjian.us/pgsql_docs/release-17.html > > >

Re: Set appropriate processing mode for auxiliary processes.

2024-05-09 Thread Heikki Linnakangas
On 09/05/2024 16:12, Xing Guo wrote: Hi hackers, After several refactoring iterations, auxiliary processes are no longer initialized from the bootstrapper. I think using the InitProcessing mode for initializing auxiliary processes is more appropriate. At first I was sure this was introduced

Re: request for database identifier in the startup packet

2024-05-09 Thread David G. Johnston
On Thursday, May 9, 2024, Dave Cramer wrote: > Greetings, > > The JDBC driver is currently keeping a per connection cache of types in > the driver. We are seeing cases where the number of columns is quite high. > In one case Prevent fetchFieldMetaData() from being run when unnecessary. > · Issue

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 02:17:12PM +0900, Masahiko Sawada wrote: > Hi, > > On Thu, May 9, 2024 at 1:03 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html >

Re:

2024-05-09 Thread Tom Lane
Rajan Pandey writes: >> test=# ALTER SYSTEM SET shared_preload_libraries TO 'pg_tle'; >> ALTER SYSTEM >> test=# SELECT pg_reload_conf(); >> pg_reload_conf >> >> t >> (1 row) Changing shared_preload_libraries requires a postmaster restart, not just config reload. The postmaster

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 04:53:38AM +, Bertrand Drouvot wrote: > Hi, > > On Thu, May 09, 2024 at 12:03:50AM -0400, Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Tomas Vondra
On 5/9/24 11:44, Andy Fan wrote: > > Hello Tomas, > 2) v20240502-0002-Use-mergesort-in-the-leader-process.patch The approach implemented by 0001 works, but there's a little bit of issue - if there are many distinct keys (e.g. for trigrams that can happen very easily),

Set appropriate processing mode for auxiliary processes.

2024-05-09 Thread Xing Guo
Hi hackers, After several refactoring iterations, auxiliary processes are no longer initialized from the bootstrapper. I think using the InitProcessing mode for initializing auxiliary processes is more appropriate. Best Regards, Xing From 50fb1ccc7259e0ce8512dee236cbfe11635c15fc Mon Sep 17

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 04:52:14PM +1200, David Rowley wrote: > On Thu, 9 May 2024 at 16:47, Muhammad Ikram wrote: > > A minor formatting issue in the start below. Bullet is not required here. > > This is a placeholder for the highlight features of v17 will go. > Bruce tends not to decide what

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 09:47:34AM +0500, Muhammad Ikram wrote: > Hi Bruce, > > A minor formatting issue in the start below. Bullet is not required here. > > > E.1.1. Overview  > > PostgreSQL 17 contains many new features and enhancements, including: > > • > > The above items and other

Re: First draft of PG 17 release notes

2024-05-09 Thread Bruce Momjian
On Thu, May 9, 2024 at 04:44:47PM +1200, David Rowley wrote: > On Thu, 9 May 2024 at 16:04, Bruce Momjian wrote: > > I welcome feedback. For some reason it was an easier job than usual. > > Thanks for working on that. > > > +2023-11-02 [cac169d68] Increase DEFAULT_FDW_TUPLE_COST from 0.01 to

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

2024-05-09 Thread Michail Nikolaev
Hello, Matthias and others! Realized new horizon was applied only during validation phase (once index is marked as ready). Now it applied if index is not marked as valid yet. Updated version in attach. -- > I think the best way for this to work

Re: Avoid orphaned objects dependencies, take 3

2024-05-09 Thread Bertrand Drouvot
Hi, On Tue, Apr 30, 2024 at 08:00:00PM +0300, Alexander Lakhin wrote: > Hi Bertrand, > > But I've discovered yet another possibility to get a broken dependency. Thanks for the testing and the report! > Please try this script: > res=0 > numclients=20 > for ((i=1;i<=100;i++)); do > for

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Tomas Vondra
On 5/9/24 12:14, Andy Fan wrote: > > Tomas Vondra writes: > >> 3) v20240502-0003-Remove-the-explicit-pg_qsort-in-workers.patch >> >> In 0002 the workers still do an explicit qsort() on the TID list before >> writing the data into the shared tuplesort. But we can do better - the >> workers can

request for database identifier in the startup packet

2024-05-09 Thread Dave Cramer
Greetings, The JDBC driver is currently keeping a per connection cache of types in the driver. We are seeing cases where the number of columns is quite high. In one case Prevent fetchFieldMetaData() from being run when unnecessary. · Issue #3241 · pgjdbc/pgjdbc (github.com)

Re: First draft of PG 17 release notes

2024-05-09 Thread jian he
On Thu, May 9, 2024 at 6:53 PM jian he wrote: > > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html < Add columns to pg_stats to

Re: First draft of PG 17 release notes

2024-05-09 Thread Hans Buschmann
Some findings 1. >>Remove adminpack contrib extension (Daniel Gustafsson) >>This was used by non-end-of-life pgAdmin III. Perhaps you mean now-end-of-life (s/non/now/) 2. >>All specification of partitioned table access methods (Justin Pryzby, Soumyadeep Chakraborty, Michael Paquier)

Re: First draft of PG 17 release notes

2024-05-09 Thread jian he
> << > Allow ALTER OPERATOR to set more optimization attributes (Tommy Pavlicek) > This is useful for extensions. > << sorry, I mean << Allow the creation of hash indexes on ltree columns (Tommy Pavlicek) This also enables hash join and hash aggregation on ltree columns. << better description

Re: First draft of PG 17 release notes

2024-05-09 Thread jian he
On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > * Add function pg_buffercache_evict() to allow shared buffer eviction (Palak

Re: First draft of PG 17 release notes

2024-05-09 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > Bruce Momjian writes: > >> I have committed the first draft of the PG 17 release notes; you can >> see the results here: >> >> https://momjian.us/pgsql_docs/release-17.html > > My name is listed twice in the "Improve psql tab completion" item. You can

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Andy Fan
Tomas Vondra writes: > 3) v20240502-0003-Remove-the-explicit-pg_qsort-in-workers.patch > > In 0002 the workers still do an explicit qsort() on the TID list before > writing the data into the shared tuplesort. But we can do better - the > workers can do a merge sort too. To help with this, we

Re: First draft of PG 17 release notes

2024-05-09 Thread Dagfinn Ilmari Mannsåker
Bruce Momjian writes: > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html My name is listed twice in the "Improve psql tab completion" item. - ilmari

Re: Parallel CREATE INDEX for GIN indexes

2024-05-09 Thread Andy Fan
Hello Tomas, >>> 2) v20240502-0002-Use-mergesort-in-the-leader-process.patch >>> >>> The approach implemented by 0001 works, but there's a little bit of >>> issue - if there are many distinct keys (e.g. for trigrams that can >>> happen very easily), the workers will hit the memory limit with

Re: First draft of PG 17 release notes

2024-05-09 Thread jian he
On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > another potential incompatibilities issue: ALTER TABLE DROP PRIMARY KEY see:

Re:

2024-05-09 Thread Kashif Zeeshan
Hi On Thu, May 9, 2024 at 2:50 PM Rajan Pandey wrote: > Hi everyone, I just installed Postgres and pg_tle extension as I was > looking to contribute to pg_tle. > > Somehow, I am unable to update the shared_preload_libraries. It feels like > ALTER has happened but the SPL value is not updated:

[no subject]

2024-05-09 Thread Rajan Pandey
Hi everyone, I just installed Postgres and pg_tle extension as I was looking to contribute to pg_tle. Somehow, I am unable to update the shared_preload_libraries. It feels like ALTER has happened but the SPL value is not updated: > test=# show shared_preload_libraries; >

consider -Wmissing-variable-declarations

2024-05-09 Thread Peter Eisentraut
In [0] I had noticed that we have no automated verification that global variables are declared in header files. (For global functions, we have this through -Wmissing-prototypes.) As I mentioned there, I discovered the Clang compiler option -Wmissing-variable-declarations, which does exactly

Re: First draft of PG 17 release notes

2024-05-09 Thread Aleksander Alekseev
Hi, > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > > It will be improved until the final release. The item count is 188, > which is similar to recent releases: Thanks for working on

RE: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-05-09 Thread Hayato Kuroda (Fujitsu)
Dear Peter, > > == > Commit message > > 1. > A detailed commit message is needed to describe the purpose and > details of this patch. Added. > == > doc/src/sgml/ref/alter_subscription.sgml > > 2. CREATE SUBSCRIPTION > > Shouldn't there be an entry for "force_alter" parameter in the

RE: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-05-09 Thread Hayato Kuroda (Fujitsu)
Dear Peter, > Commit Message > > 1. > The patch needs a commit message to describe the purpose and highlight > any limitations and other details. Added. > == > doc/src/sgml/ref/alter_subscription.sgml > > 2. > + > + > + The two_phase parameter can only be altered when > the > +

RE: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-05-09 Thread Hayato Kuroda (Fujitsu)
Dear Peter, > == > Commit message > > 1. > IIUC there is quite a lot of subtlety and details about why the slot > option needs to be changed only when altering "true" to "false", but > not when altering "false" to "true". > > It also should explain why PreventInTransactionBlock is only

RE: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-05-09 Thread Hayato Kuroda (Fujitsu)
Dear Peter, Thanks for reviewing! The patch will be posted in the upcoming post. > == > src/backend/access/transam/twophase.c > > 1. IsTwoPhaseTransactionGidForSubid > > +/* > + * IsTwoPhaseTransactionGidForSubid > + * Check whether the given GID is formed by TwoPhaseTransactionGid. > + */

Re: Weird test mixup

2024-05-09 Thread Michael Paquier
On Thu, May 09, 2024 at 01:47:45PM +0900, Michael Paquier wrote: > That sounds fine to do that at the end.. I'm not sure how large this > chunk area added to each InjectionPointEntry should be, though. 128B > stored in each InjectionPointEntry would be more than enough I guess? > Or more like

Re: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-05-09 Thread Peter Smith
Hi, Here are some review comments for patch v7-0004 == Commit message 1. A detailed commit message is needed to describe the purpose and details of this patch. == doc/src/sgml/ref/alter_subscription.sgml 2. CREATE SUBSCRIPTION Shouldn't there be an entry for "force_alter" parameter in

Re: First draft of PG 17 release notes

2024-05-09 Thread Richard Guo
On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html Thanks for working on that. For this item: > Allow the optimizer to improve CTE

Re: Slow catchup of 2PC (twophase) transactions on replica in LR

2024-05-09 Thread Peter Smith
Hi, Here are some review comments for the patch v7-0003. == Commit Message 1. The patch needs a commit message to describe the purpose and highlight any limitations and other details. == doc/src/sgml/ref/alter_subscription.sgml 2. + + + The two_phase parameter can only be

  1   2   >