On Thu, Feb 22, 2024 at 11:36 AM Kyotaro Horiguchi
wrote:
>
> At Wed, 21 Feb 2024 14:57:42 +0530, Amit Kapila
> wrote in
> > On Tue, Feb 20, 2024 at 3:21 PM shveta malik wrote:
> > >
> > > okay, attached v2 patch with changed error msgs and double quotes
> > > around logical.
> > >
> >
> >
On Thu, Feb 22, 2024 at 11:10 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 22 Feb 2024 10:51:07 +0530, Amit Kapila
> wrote in
> > > Do you think some additional tests for the rest of the messages are
> > > worth the trouble?
> > >
> >
> > We have discussed this during development and didn't find it
At Thu, 22 Feb 2024 10:51:07 +0530, Amit Kapila wrote
in
> > Do you think some additional tests for the rest of the messages are
> > worth the trouble?
> >
>
> We have discussed this during development and didn't find it worth
> adding tests for all misconfigured parameters. However, in the
On Thu, Feb 22, 2024 at 6:16 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 22 Feb 2024 09:36:43 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > Yes, I'm happy with all of the changes. The proposed patch appears to
> > cover all instances related to slotsync.c, and it looks fine to
> > me. Thanks!
>
>
At Thu, 22 Feb 2024 09:36:43 +0900 (JST), Kyotaro Horiguchi
wrote in
> Yes, I'm happy with all of the changes. The proposed patch appears to
> cover all instances related to slotsync.c, and it looks fine to
> me. Thanks!
I'd like to raise another potential issue outside the patch. The patch
At Wed, 21 Feb 2024 14:57:42 +0530, Amit Kapila wrote
in
> On Tue, Feb 20, 2024 at 3:21 PM shveta malik wrote:
> >
> > okay, attached v2 patch with changed error msgs and double quotes
> > around logical.
> >
>
> Horiguchi-San, does this address all your concerns related to
> translation with
On Tue, Feb 20, 2024 at 3:21 PM shveta malik wrote:
>
> okay, attached v2 patch with changed error msgs and double quotes
> around logical.
>
Horiguchi-San, does this address all your concerns related to
translation with these new messages?
--
With Regards,
Amit Kapila.
On Tue, Feb 20, 2024 at 2:13 PM Amit Kapila wrote:
>
> I would prefer the changed ones as those clearly explain the problem
> without additional information.
okay, attached v2 patch with changed error msgs and double quotes
around logical.
thanks
Shveta
On Mon, Feb 19, 2024 at 11:26 AM shveta malik wrote:
>
> On Mon, Feb 19, 2024 at 11:10 AM Amit Kapila wrote:
> >
> > On Thu, Feb 15, 2024 at 11:49 AM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik
> > > wrote in
> > > >
> > > > +1 on changing the
On Mon, Feb 19, 2024 at 11:10 AM Amit Kapila wrote:
>
> On Thu, Feb 15, 2024 at 11:49 AM Kyotaro Horiguchi
> wrote:
> >
> > At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik
> > wrote in
> > >
> > > +1 on changing the msg(s) suggested way. Please find the patch for the
> > > same. It also
On Thu, Feb 15, 2024 at 11:49 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik
> wrote in
> >
> > +1 on changing the msg(s) suggested way. Please find the patch for the
> > same. It also removes double quotes around the variable names
>
> Thanks for the
At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik wrote
in
> On Thu, Feb 15, 2024 at 8:26 AM Amit Kapila wrote:
> >
> > On Wed, Feb 14, 2024 at 7:51 PM Euler Taveira wrote:
> > >
> > > On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
> > >
> > > Now, I am less clear about whether to quote
On Thu, Feb 15, 2024 at 8:26 AM Amit Kapila wrote:
>
> On Wed, Feb 14, 2024 at 7:51 PM Euler Taveira wrote:
> >
> > On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
> >
> > Now, I am less clear about whether to quote "logical" or not in the
> > above message. Do you have any suggestions?
> >
On Wed, Feb 14, 2024 at 7:51 PM Euler Taveira wrote:
>
> On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
>
> Now, I am less clear about whether to quote "logical" or not in the
> above message. Do you have any suggestions?
>
>
> The possible confusion comes from the fact that the sentence
On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
> Now, I am less clear about whether to quote "logical" or not in the
> above message. Do you have any suggestions?
The possible confusion comes from the fact that the sentence contains "must be"
in the middle of a comparison expression. For
On Wed, Feb 14, 2024 at 12:57 PM Kyotaro Horiguchi
wrote:
>
> A recent commit added the following message:
>
> > "wal_level" must be >= logical.
>
> The use of the term "logical" here is a bit confusing, as it's unclear
> whether it's meant to be a natural language word or a token. (I
> believe
On Wed, Feb 14, 2024 at 1:04 PM Kyotaro Horiguchi
wrote:
>
> Just after this, I found another inconsistency regarding quotation.
>
> > 'dbname' must be specified in "%s".
>
> The use of single quotes doesn't seem to comply with our standard.
>
Agreed, I think we have two choices here one is to
On Wed, Feb 14, 2024 at 1:04 PM Kyotaro Horiguchi
wrote:
>
> At Wed, 14 Feb 2024 16:26:52 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > > "wal_level" must be >= logical.
> ..
> > > wal_level must be set to "replica" or "logical" at server start.
> ..
> > I suggest making the quoting policy
At Wed, 14 Feb 2024 16:26:52 +0900 (JST), Kyotaro Horiguchi
wrote in
> > "wal_level" must be >= logical.
..
> > wal_level must be set to "replica" or "logical" at server start.
..
> I suggest making the quoting policy consistent.
Just after this, I found another inconsistency regarding
A recent commit added the following message:
> "wal_level" must be >= logical.
The use of the term "logical" here is a bit confusing, as it's unclear
whether it's meant to be a natural language word or a token. (I
believe it to be a token.)
On the contrary, we already have the following
20 matches
Mail list logo
