Re: First draft of PG 17 release notes

2024-05-23 Thread Bruce Momjian
On Thu, May 23, 2024 at 11:11:10PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Thu, May 23, 2024 at 02:27:07PM +1200, David Rowley wrote: > >> I also don't agree these should be left to "Source code" section. I > >> feel that section is best suited for extension authors who might care >

Re: First draft of PG 17 release notes

2024-05-23 Thread Tom Lane
Bruce Momjian writes: > On Thu, May 23, 2024 at 02:27:07PM +1200, David Rowley wrote: >> I also don't agree these should be left to "Source code" section. I >> feel that section is best suited for extension authors who might care >> about some internal API change. I'm talking of stuff that makes

Re: First draft of PG 17 release notes

2024-05-23 Thread Bruce Momjian
On Thu, May 23, 2024 at 02:27:07PM +1200, David Rowley wrote: > On Thu, 23 May 2024 at 14:01, Bruce Momjian wrote: > > > > On Thu, May 23, 2024 at 01:34:10PM +1200, David Rowley wrote: > > > What is the best way to communicate this stuff so it's easily > > > identifiable when you parse the commit

Re: First draft of PG 17 release notes

2024-05-23 Thread Peter Geoghegan
On Wed, May 22, 2024 at 6:50 PM Bruce Momjian wrote: > Agreed, patch applied, thanks. The item for my commit 5bf748b8 currently reads: "Allow btree indexes to more efficiently find array matches" I think that this isn't likely to mean much to most users. It seems like it'd be a lot clearer if

Re: First draft of PG 17 release notes

2024-05-23 Thread Marcos Pegoraro
- Rename SLRU columns in system view pg_stat_slru (Alvaro Herrera) The column names accepted by pg_stat_slru_rest() are also changed. Is pg_stat_slru_rest() correct ?

Re: First draft of PG 17 release notes

2024-05-23 Thread Jeff Davis
On Wed, 2024-05-22 at 18:39 -0400, Bruce Momjian wrote: > On Mon, May 20, 2024 at 11:48:09AM -0700, Jeff Davis wrote: > > On Sat, 2024-05-18 at 17:51 -0400, Bruce Momjian wrote: > > > Okay, I went with the attached applied patch.  Adjustments? > > > > I think it should have more emphasis on the

Re: First draft of PG 17 release notes

2024-05-23 Thread Alvaro Herrera
Hello, Regarding this item : Allow the SLRU cache sizes to be configured (Andrey Borodin, Dilip Kumar) : : The new server variables are commit_timestamp_buffers, : multixact_member_buffers, multixact_offset_buffers, notify_buffers, : serializable_buffers, subtransaction_buffers, and

Re: First draft of PG 17 release notes

2024-05-22 Thread David Rowley
On Thu, 23 May 2024 at 14:01, Bruce Momjian wrote: > > On Thu, May 23, 2024 at 01:34:10PM +1200, David Rowley wrote: > > What is the best way to communicate this stuff so it's easily > > identifiable when you parse the commit messages? > > This is why I think we need an "Internal Performance"

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Thu, May 23, 2024 at 01:34:10PM +1200, David Rowley wrote: > On Thu, 23 May 2024 at 10:04, Bruce Momjian wrote: > > You might have seen in this thread, I do record commits that speed up > > workloads that are user-visible, or specifically make new workloads > > possible. I assume that covers

Re: First draft of PG 17 release notes

2024-05-22 Thread David Rowley
On Thu, 23 May 2024 at 10:04, Bruce Momjian wrote: > You might have seen in this thread, I do record commits that speed up > workloads that are user-visible, or specifically make new workloads > possible. I assume that covers the items above, though I have to > determine this from the commit

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Wed, May 22, 2024 at 09:25:41PM +0900, torikoshia wrote: > Thanks for working on this as always. > > > Allow pg_stat_reset_shared("slru") to clear SLRU statistics (Atsushi > Torikoshi) > > > Considering someone may copy and paste this, 'slru' is better than "slru", > isn't it? > I also

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Wed, May 22, 2024 at 11:29:06AM +0900, Masahiko Sawada wrote: > I found a typo: > > s/pg_statstatement/pg_stat_statement/ > > I've attached a patch to fix it. Agreed, applied, thanks. -- Bruce Momjian https://momjian.us EDB

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 11:20:02AM +0900, Amit Langote wrote: > Thanks Bruce for working on this as always. > > Failed to notice when I read the notes before: > > > > Add SQL/JSON constructor functions JSON(), JSON_SCALAR(), and > JSON_SERIALIZE() (Amit Langote) > > > > Should be: > > >

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Mon, May 20, 2024 at 11:48:09AM -0700, Jeff Davis wrote: > On Sat, 2024-05-18 at 17:51 -0400, Bruce Momjian wrote: > > Okay, I went with the attached applied patch.  Adjustments? > > I think it should have more emphasis on the actual new feature: a > platform-independent builtin collation

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 09:40:28AM -0700, Andres Freund wrote: > Hi, > > On 2024-05-18 11:13:54 -0400, Bruce Momjian wrote: > > Please see the email I just posted. There are three goals we have to > > adjust for: > > > > 1. short release notes so they are readable > > 2. giving people credit

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 02:26:15PM -0400, Melanie Plageman wrote: > In Postgres development, we break larger projects into smaller ones > and then those smaller projects into multiple individual commits. Each > commit needs to stand alone and each subproject needs to have a > defensible benefit.

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 01:50:58PM -0400, Robert Haas wrote: > On Tue, May 21, 2024 at 12:27 PM Andres Freund wrote: > > To me that's the "General Performance" section. If somebody reading the > > release notes doesn't care about performance, they can just skip that > > section > > ([1]). I

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 09:51:09AM -0700, Andres Freund wrote: > Hi, > > On 2024-05-21 09:27:20 -0700, Andres Freund wrote: > > Also, the release notes are also not just important to users. I often go > > back > > and look in the release notes to see when some some important change was > >

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 09:27:20AM -0700, Andres Freund wrote: > On 2024-05-18 10:59:47 -0400, Bruce Momjian wrote: > > I agree the impact of performance improvements are often greater than > > the average release note item. However, if people expect Postgres to be > > faster, is it important for

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Mon, May 20, 2024 at 02:47:28PM -0400, Melanie Plageman wrote: > On Mon, May 20, 2024 at 9:37 AM Bruce Momjian wrote: > > > > On Mon, May 20, 2024 at 01:23:02PM +0700, John Naylor wrote: > > > Hi Bruce, thanks for doing this again! > > > > > > I'm a bit late to this discussion -- there's been

Re: First draft of PG 17 release notes

2024-05-22 Thread Alvaro Herrera
On 2024-May-21, Andres Freund wrote: > Which reminds me: Eventually I'd like to add links to the most important > commits related to release note entries. We already do much of the work of > building that list of commits for each entry. That'd allow a reader to find > more details if interested.

Re: First draft of PG 17 release notes

2024-05-22 Thread torikoshia
On 2024-05-09 13:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: https://momjian.us/pgsql_docs/release-17.html It will be improved until the final release. The item count is 188, which is similar to recent releases

Re: First draft of PG 17 release notes

2024-05-21 Thread Masahiko Sawada
Hi, On Thu, May 9, 2024 at 1:03 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > > It will be improved until the final release. The item

Re: First draft of PG 17 release notes

2024-05-21 Thread Robert Haas
On Tue, May 21, 2024 at 2:26 PM Melanie Plageman wrote: > For the vacuum WAL volume reduction, there were a bunch of smaller > projects throughout the last development year that I worked on that > were committed by different people and with different individual > benefits. Some changes caused

Re: First draft of PG 17 release notes

2024-05-21 Thread Melanie Plageman
On Tue, May 21, 2024 at 1:51 PM Robert Haas wrote: > > On Tue, May 21, 2024 at 12:27 PM Andres Freund wrote: > > To me that's the "General Performance" section. If somebody reading the > > release notes doesn't care about performance, they can just skip that > > section > > ([1]). I don't see

Re: First draft of PG 17 release notes

2024-05-21 Thread Robert Haas
On Tue, May 21, 2024 at 12:27 PM Andres Freund wrote: > To me that's the "General Performance" section. If somebody reading the > release notes doesn't care about performance, they can just skip that section > ([1]). I don't see why we wouldn't want to include the same level of detail > as for

Re: First draft of PG 17 release notes

2024-05-21 Thread Peter Geoghegan
On Tue, May 21, 2024 at 12:27 PM Andres Freund wrote: > > I agree the impact of performance improvements are often greater than > > the average release note item. However, if people expect Postgres to be > > faster, is it important for them to know _why_ it is faster? > > Yes, it very often is.

Re: First draft of PG 17 release notes

2024-05-21 Thread Andres Freund
Hi, On 2024-05-21 09:27:20 -0700, Andres Freund wrote: > Also, the release notes are also not just important to users. I often go back > and look in the release notes to see when some some important change was made, > because sometimes it's harder to find it in the git log, due to sheer > volume.

Re: First draft of PG 17 release notes

2024-05-21 Thread Andres Freund
Hi, On 2024-05-18 11:13:54 -0400, Bruce Momjian wrote: > Please see the email I just posted. There are three goals we have to > adjust for: > > 1. short release notes so they are readable > 2. giving people credit for performance improvements > 3. showing people Postgres cares about

Re: First draft of PG 17 release notes

2024-05-21 Thread Andres Freund
Hi, On 2024-05-18 10:59:47 -0400, Bruce Momjian wrote: > On Wed, May 15, 2024 at 08:48:02PM -0700, Andres Freund wrote: > > +many. > > > > We're having this debate every release. I think the ongoing reticence to > > note > > performance improvements in the release notes is hurting Postgres. > >

Re: First draft of PG 17 release notes

2024-05-20 Thread Amit Langote
On Thu, May 9, 2024 at 1:04 PM Bruce Momjian wrote: > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > > It will be improved until the final release. The item count is 188,

Re: First draft of PG 17 release notes

2024-05-20 Thread Jeff Davis
On Sat, 2024-05-18 at 17:51 -0400, Bruce Momjian wrote: > Okay, I went with the attached applied patch.  Adjustments? I think it should have more emphasis on the actual new feature: a platform-independent builtin collation provider and the C.UTF-8 locale. The user can look at the documentation

Re: First draft of PG 17 release notes

2024-05-20 Thread Melanie Plageman
On Mon, May 20, 2024 at 9:37 AM Bruce Momjian wrote: > > On Mon, May 20, 2024 at 01:23:02PM +0700, John Naylor wrote: > > Hi Bruce, thanks for doing this again! > > > > I'm a bit late to this discussion -- there's been a bit of churn in > > the vacuum items, and some streams got crossed along the

Re: First draft of PG 17 release notes

2024-05-20 Thread Bruce Momjian
On Mon, May 20, 2024 at 02:35:37PM -0400, Melanie Plageman wrote: > On Sat, May 18, 2024 at 11:13 AM Bruce Momjian wrote: > > Please see the email I just posted. There are three goals we have to > > adjust for: > > > > 1. short release notes so they are readable > > 2. giving people credit for

Re: First draft of PG 17 release notes

2024-05-20 Thread Melanie Plageman
On Sat, May 18, 2024 at 11:13 AM Bruce Momjian wrote: > > On Thu, May 16, 2024 at 09:09:11AM -0400, Melanie Plageman wrote: > > On Wed, May 15, 2024 at 11:48 PM Andres Freund wrote: > > > > > > On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > > > > I disagree with this. IMO the impact of

Re: First draft of PG 17 release notes

2024-05-20 Thread Bruce Momjian
On Mon, May 20, 2024 at 01:23:02PM +0700, John Naylor wrote: > Hi Bruce, thanks for doing this again! > > I'm a bit late to this discussion -- there's been a bit of churn in > the vacuum items, and some streams got crossed along the way. I've > attached an attempt to rectify this. Agreed, patch

Re: First draft of PG 17 release notes

2024-05-20 Thread John Naylor
Hi Bruce, thanks for doing this again! I'm a bit late to this discussion -- there's been a bit of churn in the vacuum items, and some streams got crossed along the way. I've attached an attempt to rectify this. diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml index

Re: First draft of PG 17 release notes

2024-05-19 Thread Bruce Momjian
On Sun, May 19, 2024 at 03:53:38PM +1200, David Rowley wrote: > On Sun, 19 May 2024 at 02:40, Bruce Momjian wrote: > > > > On Thu, May 16, 2024 at 03:35:17PM +1200, David Rowley wrote: > > > "Additionally, vacuum no longer silently imposes a 1GB tuple reference > > > limit even when

Re: First draft of PG 17 release notes

2024-05-18 Thread David Rowley
On Sun, 19 May 2024 at 02:40, Bruce Momjian wrote: > > On Thu, May 16, 2024 at 03:35:17PM +1200, David Rowley wrote: > > "Additionally, vacuum no longer silently imposes a 1GB tuple reference > > limit even when maintenance_work_mem or autovacuum_work_mem are set to > > higher values" > Slightly

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Fri, May 17, 2024 at 01:30:03PM -0700, Jeff Davis wrote: > On Thu, 2024-05-09 at 00:03 -0400, Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes;  you can > > see the results here: > > > > https://momjian.us

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Fri, May 17, 2024 at 09:22:59PM +0800, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momj

Re: First draft of PG 17 release notes

2024-05-18 Thread Andrew Dunstan
On 2024-05-18 Sa 12:50, Bruce Momjian wrote: On Thu, May 16, 2024 at 11:50:20AM -0400, Andrew Dunstan wrote: Maybe "Introduce an incremental JSON parser" would have been a better headline. Well, this gets into a level of detail that is beyond the average reader. I think at that level

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Thu, May 16, 2024 at 11:50:20AM -0400, Andrew Dunstan wrote: > > Maybe "Introduce an incremental JSON parser" would have been a better > > > headline. > > Well, this gets into a level of detail that is beyond the average > > reader. I think at that level people will need to read the git logs

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Thu, May 16, 2024 at 04:29:38PM +0800, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_doc

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Thu, May 16, 2024 at 09:09:11AM -0400, Melanie Plageman wrote: > On Wed, May 15, 2024 at 11:48 PM Andres Freund wrote: > > > > On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > > > I disagree with this. IMO the impact of the Sawada/Naylor change is > > > likely to be enormous for people

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Wed, May 15, 2024 at 08:48:02PM -0700, Andres Freund wrote: > Hi, > > On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > > I disagree with this. IMO the impact of the Sawada/Naylor change is > > likely to be enormous for people with large tables and large numbers of > > tuples to clean up

Re: First draft of PG 17 release notes

2024-05-18 Thread Bruce Momjian
On Thu, May 16, 2024 at 03:35:17PM +1200, David Rowley wrote: > On Thu, 16 May 2024 at 14:48, Bruce Momjian wrote: > > > > On Wed, May 15, 2024 at 09:13:14AM -0400, Melanie Plageman wrote: > > > Also +1 on the Sawada/Naylor change being on the highlight section of > > > the release (as David

Re: First draft of PG 17 release notes

2024-05-17 Thread Jeff Davis
On Thu, 2024-05-09 at 00:03 -0400, Bruce Momjian wrote: > I have committed the first draft of the PG 17 release notes;  you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html For this item: Create a "builtin" collation provid

Re: First draft of PG 17 release notes

2024-05-17 Thread Daniel Verite
Bruce Momjian wrote: > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html About the changes in collations: Create a "builtin" collation provider similar to l

Re: First draft of PG 17 release notes

2024-05-17 Thread jian he
On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > > It will be improved until the final release. The item

Re: First draft of PG 17 release notes

2024-05-16 Thread Andrew Dunstan
On 2024-05-14 Tu 20:39, Bruce Momjian wrote: On Sat, May 11, 2024 at 03:32:55PM -0400, Andrew Dunstan wrote: On 2024-05-09 Th 00:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: https://momjian.us/pgsql_docs/release

Re: First draft of PG 17 release notes

2024-05-16 Thread Peter Geoghegan
On Wed, May 15, 2024 at 11:48 PM Andres Freund wrote: > On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > > I disagree with this. IMO the impact of the Sawada/Naylor change is > > likely to be enormous for people with large tables and large numbers of > > tuples to clean up (I know we've had

Re: First draft of PG 17 release notes

2024-05-16 Thread Melanie Plageman
On Wed, May 15, 2024 at 11:48 PM Andres Freund wrote: > > On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > > I disagree with this. IMO the impact of the Sawada/Naylor change is > > likely to be enormous for people with large tables and large numbers of > > tuples to clean up (I know we've

Re: First draft of PG 17 release notes

2024-05-16 Thread Joe Conway
On 5/15/24 23:48, Andres Freund wrote: On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: I disagree with this. IMO the impact of the Sawada/Naylor change is likely to be enormous for people with large tables and large numbers of tuples to clean up (I know we've had a number of customers in

Re: First draft of PG 17 release notes

2024-05-16 Thread Jelte Fennema-Nio
On Thu, 16 May 2024 at 05:48, Andres Freund wrote: > We're having this debate every release. I think the ongoing reticence to note > performance improvements in the release notes is hurting Postgres. > > For one, performance improvements are one of the prime reason users > upgrade. Without them

Re: First draft of PG 17 release notes

2024-05-16 Thread jian he
On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > >> Add jsonpath methods to convert JSON values to diff

Re: First draft of PG 17 release notes

2024-05-15 Thread Andres Freund
Hi, On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > I disagree with this. IMO the impact of the Sawada/Naylor change is > likely to be enormous for people with large tables and large numbers of > tuples to clean up (I know we've had a number of customers in this > situation, I can't

Re: First draft of PG 17 release notes

2024-05-15 Thread David Rowley
On Thu, 16 May 2024 at 14:48, Bruce Momjian wrote: > > On Wed, May 15, 2024 at 09:13:14AM -0400, Melanie Plageman wrote: > > Also +1 on the Sawada/Naylor change being on the highlight section of > > the release (as David suggested upthread). > > Agreed, I went with the attached applied patch.

Re: First draft of PG 17 release notes

2024-05-15 Thread Bruce Momjian
On Thu, May 16, 2024 at 10:39:18AM +0800, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_doc

Re: First draft of PG 17 release notes

2024-05-15 Thread David G. Johnston
On Wednesday, May 15, 2024, jian he wrote: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-

Re: First draft of PG 17 release notes

2024-05-15 Thread Bruce Momjian
On Wed, May 15, 2024 at 09:13:14AM -0400, Melanie Plageman wrote: > I think this wording and organization makes sense. I hadn't thought of > using "traffic" to describe this, but I like it. > > Also +1 on the Sawada/Naylor change being on the highlight section of > the release (as David suggested

Re: First draft of PG 17 release notes

2024-05-15 Thread jian he
On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html > >> Add local I/O block read/write timing statistics columns

Re: First draft of PG 17 release notes

2024-05-15 Thread Amit Kapila
On Wed, May 15, 2024 at 7:36 AM Bruce Momjian wrote: > > On Wed, May 15, 2024 at 02:03:32PM +1200, David Rowley wrote: > > On Wed, 15 May 2024 at 13:00, Bruce Momjian wrote: > > > > > > On Tue, May 14, 2024 at 03:39:26PM -0400, Melanie Plageman wrote: > > > > "Reduce system calls by

Re: First draft of PG 17 release notes

2024-05-15 Thread Melanie Plageman
On Wed, May 15, 2024 at 4:38 AM Alvaro Herrera wrote: > > On 2024-May-14, Bruce Momjian wrote: > > > On Tue, May 14, 2024 at 03:39:26PM -0400, Melanie Plageman wrote: > > > > I think that we need to more clearly point out the implications of the > > > feature added by Sawada-san (and reviewed by

Re: First draft of PG 17 release notes

2024-05-15 Thread David Rowley
On Wed, 15 May 2024 at 20:38, Alvaro Herrera wrote: > > On 2024-May-14, Bruce Momjian wrote: > > I don't think users really care about these details, just that it is > > faster so they will not be surprised if there is a change. I was > > purposely vague to group multiple commits into the single

Re: First draft of PG 17 release notes

2024-05-15 Thread Alvaro Herrera
On 2024-May-14, Bruce Momjian wrote: > On Tue, May 14, 2024 at 03:39:26PM -0400, Melanie Plageman wrote: > > I think that we need to more clearly point out the implications of the > > feature added by Sawada-san (and reviewed by John) in 667e65aac35497. > > Vacuum no longer uses a fixed amount

Re: First draft of PG 17 release notes

2024-05-14 Thread David Rowley
On Wed, 15 May 2024 at 14:06, Bruce Momjian wrote: > I can use your wording, but how much prefetching to we enable now? I believe the read stream API is used for Seq Scan, ANALYZE and pg_prewarm(). fadvise() is used when the next buffer that's required is not in shared buffers on any build that

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Wed, May 15, 2024 at 10:10:28AM +0900, Masahiko Sawada wrote: > > I looked at that item and I don't have a generic "make logical > > replication apply faster" item to merge it into, and many > > subtransactions seemed like enough of an edge-case that I didn't think > > mentioning it make sense.

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Wed, May 15, 2024 at 02:03:32PM +1200, David Rowley wrote: > On Wed, 15 May 2024 at 13:00, Bruce Momjian wrote: > > > > On Tue, May 14, 2024 at 03:39:26PM -0400, Melanie Plageman wrote: > > > "Reduce system calls by automatically merging reads up to > > > io_combine_limit" > > > > Uh, as I

Re: First draft of PG 17 release notes

2024-05-14 Thread David Rowley
On Wed, 15 May 2024 at 13:00, Bruce Momjian wrote: > > On Tue, May 14, 2024 at 03:39:26PM -0400, Melanie Plageman wrote: > > "Reduce system calls by automatically merging reads up to io_combine_limit" > > Uh, as I understand it, the reduced number of system calls is not the > value of the

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Tue, May 14, 2024 at 10:22:35AM +0800, Tender Wang wrote: > > > jian he 于2024年5月9日周四 18:00写道: > > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes;  you can &

Re: First draft of PG 17 release notes

2024-05-14 Thread Masahiko Sawada
On Thu, May 9, 2024 at 10:48 PM Bruce Momjian wrote: > > On Thu, May 9, 2024 at 02:17:12PM +0900, Masahiko Sawada wrote: > > Hi, > > > > > Also, please consider the following item: > > > > - Improve eviction algorithm in ReorderBuffer using max-heap for many > > subtransactions (5bec1d6bc) > > I

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Tue, May 14, 2024 at 03:39:26PM -0400, Melanie Plageman wrote: > On Thu, May 9, 2024 at 12:04 AM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsq

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Tue, May 14, 2024 at 02:58:41PM +0100, Pantelis Theodosiou wrote: > On Thu, May 9, 2024 at 5:03 AM Bruce Momjian wrote > > > > > > I welcome feedback. For some reason it was an easier job than usual. > > This looks better if "more case" -> "more cases" : > > Allow query nodes to be run in

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Tue, May 14, 2024 at 02:20:24PM +0200, Jelte Fennema-Nio wrote: > On Tue, 14 May 2024 at 02:56, Bruce Momjian wrote: > > > > On Sat, May 11, 2024 at 10:24:39AM -0400, Joe Conway wrote: > > > On 5/11/24 09:57, Jelte Fennema-Nio wrote: > > > > The buffering change improved performance up to ~40%

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Tue, May 14, 2024 at 01:34:56PM +0300, Elena Indrupskaya wrote: > Being a technical writer, I attached a small patch that fixes minor language > stuff. You are absolutely correct. Patch applied, thanks. -- Bruce Momjian https://momjian.us EDB

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Sat, May 11, 2024 at 03:32:55PM -0400, Andrew Dunstan wrote: > > On 2024-05-09 Th 00:03, Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian

Re: First draft of PG 17 release notes

2024-05-14 Thread Bruce Momjian
On Tue, May 14, 2024 at 10:32:14AM +0800, Andy Fan wrote: > Bruce Momjian writes: > > It was unclear from the commit message exactly what user-visible > > optimization this allowed. Do you have details? > > Yes, It allows the query like "SELECT * FROM t1 WHERE t1.a in (SELECT a > FROM t2 WHERE

Re: First draft of PG 17 release notes

2024-05-14 Thread Melanie Plageman
On Thu, May 9, 2024 at 12:04 AM Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html I had two comments: I think the read stream item: &quo

Re: First draft of PG 17 release notes

2024-05-14 Thread Pantelis Theodosiou
On Thu, May 9, 2024 at 5:03 AM Bruce Momjian wrote > > > I welcome feedback. For some reason it was an easier job than usual. This looks better if "more case" -> "more cases" : > Allow query nodes to be run in parallel in more case (Tom Lane)

Re: First draft of PG 17 release notes

2024-05-14 Thread Jelte Fennema-Nio
On Tue, 14 May 2024 at 02:56, Bruce Momjian wrote: > > On Sat, May 11, 2024 at 10:24:39AM -0400, Joe Conway wrote: > > On 5/11/24 09:57, Jelte Fennema-Nio wrote: > > > The buffering change improved performance up to ~40% in some of the > > > benchmarks. The case it improves mostly is COPY of

Re: First draft of PG 17 release notes

2024-05-14 Thread Elena Indrupskaya
Hi everybody, Being a technical writer, I attached a small patch that fixes minor language stuff. Thank you. Elena Indrupskaya Postgres Professional Company Moscow, Russia On 09.05.2024 07:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can

Re: First draft of PG 17 release notes

2024-05-13 Thread Andy Fan
Bruce Momjian writes: > On Sat, May 11, 2024 at 01:27:25PM +0800, Andy Fan wrote: >> >> Hello Bruce, >> >> > I have committed the first draft of the PG 17 release notes; you can >> > see the results here: >> > >> >https

Re: First draft of PG 17 release notes

2024-05-13 Thread Tender Wang
jian he 于2024年5月9日周四 18:00写道: > On Thu, May 9, 2024 at 12:04 PM Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > >

Re: First draft of PG 17 release notes

2024-05-13 Thread Bruce Momjian
On Sat, May 11, 2024 at 01:27:25PM +0800, Andy Fan wrote: > > Hello Bruce, > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html > > Thank you for wor

Re: First draft of PG 17 release notes

2024-05-13 Thread Bruce Momjian
On Sat, May 11, 2024 at 10:24:39AM -0400, Joe Conway wrote: > On 5/11/24 09:57, Jelte Fennema-Nio wrote: > > On Fri, 10 May 2024 at 23:31, Tom Lane wrote: > > > > > > Bruce Momjian writes: > > > > I looked at both of these. In both cases I didn't see why the user > > > > would need to know

Re: First draft of PG 17 release notes

2024-05-13 Thread Bruce Momjian
On Fri, May 10, 2024 at 05:31:33PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, May 10, 2024 at 06:50:54PM +0200, Jelte Fennema-Nio wrote: > >> There are two commits that I think would benefit from being listed > >> (but maybe they are already listed and I somehow missed them, or

Re: First draft of PG 17 release notes

2024-05-13 Thread Bharath Rupireddy
On Fri, May 10, 2024 at 7:20 PM Bruce Momjian wrote: > > > Thanks a lot for this work Bruce! It looks like commit > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=91f2cae7a4e664e9c0472b364c7db29d755ab151 > > is missing from daft release notes. Just curious to know if it's >

Re: First draft of PG 17 release notes

2024-05-11 Thread Andrew Dunstan
On 2024-05-09 Th 00:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: https://momjian.us/pgsql_docs/release-17.html It will be improved until the final release. The item count is 188, which is similar to recent

Re: First draft of PG 17 release notes

2024-05-11 Thread Joe Conway
On 5/11/24 09:57, Jelte Fennema-Nio wrote: On Fri, 10 May 2024 at 23:31, Tom Lane wrote: Bruce Momjian writes: > I looked at both of these. In both cases I didn't see why the user > would need to know these changes were made: I agree that the buffering change is not likely interesting,

Re: First draft of PG 17 release notes

2024-05-11 Thread Jelte Fennema-Nio
On Fri, 10 May 2024 at 23:31, Tom Lane wrote: > > Bruce Momjian writes: > > I looked at both of these. In both cases I didn't see why the user > > would need to know these changes were made: > > I agree that the buffering change is not likely interesting, but > the fact that you can now

Re: First draft of PG 17 release notes

2024-05-10 Thread David Rowley
On Sat, 11 May 2024 at 17:32, Andy Fan wrote: > Do you think we need to add the following 2 items? > > - 9f133763961e280d8ba692bcad0b061b861e9138 this is an optimizer > transform improvement. I think this should be in the release notes. Suggest: * Allow correlated IN subqueries to be

Re: First draft of PG 17 release notes

2024-05-10 Thread Andy Fan
Hello Bruce, > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html Thank you for working on this! > I welcome feedback. For some reason it was an easier job than usual. Do yo

Re: First draft of PG 17 release notes

2024-05-10 Thread Bruce Momjian
On Fri, May 10, 2024 at 05:31:33PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, May 10, 2024 at 06:50:54PM +0200, Jelte Fennema-Nio wrote: > >> There are two commits that I think would benefit from being listed > >> (but maybe they are already listed and I somehow missed them, or

Re: First draft of PG 17 release notes

2024-05-10 Thread Tom Lane
Bruce Momjian writes: > On Fri, May 10, 2024 at 06:50:54PM +0200, Jelte Fennema-Nio wrote: >> There are two commits that I think would benefit from being listed >> (but maybe they are already listed and I somehow missed them, or they >> are left out on purpose for some reason): > I looked at

Re: First draft of PG 17 release notes

2024-05-10 Thread Bruce Momjian
On Fri, May 10, 2024 at 06:50:54PM +0200, Jelte Fennema-Nio wrote: > On Thu, 9 May 2024 at 06:04, Bruce Momjian wrote: > > > > I have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsq

Re: First draft of PG 17 release notes

2024-05-10 Thread Maiquel Grassi
Mhd Enviado desde Outlook para Android<https://aka.ms/AAb9ysg> From: Bruce Momjian Sent: Friday, May 10, 2024 4:47:04 PM To: Daniel Verite Cc: PostgreSQL-development Subject: Re: First draft of PG 17 release notes On Fri, May 10, 2024 at 06:29:11PM

Re: First draft of PG 17 release notes

2024-05-10 Thread Bruce Momjian
On Fri, May 10, 2024 at 06:29:11PM +0200, Daniel Verite wrote: > Bruce Momjian wrote: > > > have committed the first draft of the PG 17 release notes; you can > > see the results here: > > > > https://momjian.us/pgsql_docs/release-17.html >

Re: First draft of PG 17 release notes

2024-05-10 Thread Jelte Fennema-Nio
On Thu, 9 May 2024 at 06:04, Bruce Momjian wrote: > > I have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html Great work! There are two commits that I think would benefit from being li

Re: First draft of PG 17 release notes

2024-05-10 Thread Daniel Verite
Bruce Momjian wrote: > have committed the first draft of the PG 17 release notes; you can > see the results here: > > https://momjian.us/pgsql_docs/release-17.html In the psql items, I'd suggest mentioning https://git.postgresql.org/gitweb/?p=postgresql.git;a=comm

  1   2   >