Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-07-19 Thread Nathan Bossart
On Fri, Jun 30, 2023 at 11:25:57AM -0700, Nathan Bossart wrote: > I think these patches are in decent shape, so I'd like to commit them soon, > but I will wait at least a couple more weeks in case anyone has additional > feedback. Committed. -- Nathan Bossart Amazon Web Services:

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-06-30 Thread Nathan Bossart
On Mon, May 15, 2023 at 12:36:51PM -0700, Nathan Bossart wrote: > On Tue, Apr 25, 2023 at 03:18:44PM +0900, Michael Paquier wrote: >> FWIW, I agree to hold on this stuff for v17~ once it opens for >> business. There is no urgency here. > > There's still some time before we'll be able to commit

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-05-16 Thread Nathan Bossart
On Tue, May 16, 2023 at 03:28:17PM +0900, Michael Paquier wrote: > Hmm. This is older than the oldest version we have to support for > pg_upgrade and co. Would it be worth switching clusterdb to use the > parenthesized grammar, adding on the way a test for this new grammar > flavor without a

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-05-16 Thread Michael Paquier
On Mon, May 15, 2023 at 12:36:51PM -0700, Nathan Bossart wrote: > There's still some time before we'll be able to commit any of these, but > here is an attempt at addressing all the feedback thus far. - The parenthesized syntax was added in - PostgreSQL 9.0; the unparenthesized - syntax is

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-05-15 Thread Nathan Bossart
On Tue, Apr 25, 2023 at 03:18:44PM +0900, Michael Paquier wrote: > On Mon, Apr 24, 2023 at 09:52:21AM -0700, Nathan Bossart wrote: >> I think this can wait for v17, but if there's a strong argument for doing >> some of this sooner, we can reevaluate. > > FWIW, I agree to hold on this stuff for

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-25 Thread Michael Paquier
On Mon, Apr 24, 2023 at 09:52:21AM -0700, Nathan Bossart wrote: > I think this can wait for v17, but if there's a strong argument for doing > some of this sooner, we can reevaluate. FWIW, I agree to hold on this stuff for v17~ once it opens for business. There is no urgency here. -- Michael

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-24 Thread Nathan Bossart
On Sat, Apr 22, 2023 at 10:38:58AM -0400, Melanie Plageman wrote: > If you are planning to wait and commit the change to support CLUSTER > (VERBOSE) until July, then you can consolidate the two and say before > v17. If you plan to commit it before then (making it available in v16), > I would move

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-22 Thread Melanie Plageman
On Fri, Apr 21, 2023 at 09:44:51PM -0700, Nathan Bossart wrote: > I've attached two patches. 0001 adds a parenthesized CLUSTER syntax that > doesn't require a table name. 0002 is your patch with a couple of small > adjustments. > > On Fri, Apr 21, 2023 at 07:29:59PM -0400, Melanie Plageman

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-21 Thread Nathan Bossart
I've attached two patches. 0001 adds a parenthesized CLUSTER syntax that doesn't require a table name. 0002 is your patch with a couple of small adjustments. On Fri, Apr 21, 2023 at 07:29:59PM -0400, Melanie Plageman wrote: > Attached v2 includes changes for CLUSTER syntax docs. I wasn't quite

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-21 Thread Nathan Bossart
On Fri, Apr 21, 2023 at 07:29:59PM -0400, Melanie Plageman wrote: > Attached v2 includes changes for CLUSTER syntax docs. I wasn't quite > sure that we can move down CLUSTER [VERBOSE] syntax to the compatibility > section since CLUSTER (VERBOSE) doesn't work. This seems like it should > work

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-21 Thread Melanie Plageman
On Fri, Apr 21, 2023 at 6:55 PM Nathan Bossart wrote: > > On Fri, Apr 21, 2023 at 06:29:16PM -0400, Melanie Plageman wrote: > > Over in [2], it was suggested that moving the un-parenthesized syntax to > > the "Compatibility" section of their respective docs pages would be > > okay. Patch

Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-21 Thread Nathan Bossart
On Fri, Apr 21, 2023 at 06:29:16PM -0400, Melanie Plageman wrote: > Over in [2], it was suggested that moving the un-parenthesized syntax to > the "Compatibility" section of their respective docs pages would be > okay. Patch attached. I think that's reasonable. > I left out CLUSTER since that

Move un-parenthesized syntax docs to "compatibility" for few SQL commands

2023-04-21 Thread Melanie Plageman
Hi, I find the inclusion of the un-parenthesized syntax for VACUUM, ANALYZE, and EXPLAIN in the docs makes it harder to understand the preferred, parenthesized syntax (see [1] as an example). Over in [2], it was suggested that moving the un-parenthesized syntax to the "Compatibility" section of