On Tue, Apr 25, 2023 at 09:24:58PM +0530, Bharath Rupireddy wrote:
> It looks like this patch attached upthread at [1] isn't in yet,
> meaning WAIT_EVENT_SLRU_FLUSH_SYNC stays unused. IMO, it's worth
> pushing it to the PG16 branch. It will help add a wait event for SLRU
> page flushes. Thoughts?
On Fri, Mar 24, 2023 at 12:00 PM Bharath Rupireddy
wrote:
>
> On Fri, Mar 24, 2023 at 3:31 AM Thomas Munro wrote:
> >
> > On Thu, Mar 23, 2023 at 8:10 PM Bharath Rupireddy
> > wrote:
> > > Yeah, commit [1] removed the last trace of it. I wonder if we can add
> > > a WAIT_EVENT_SLRU_FLUSH_SYNC
On Fri, Mar 24, 2023 at 3:31 AM Thomas Munro wrote:
>
> On Thu, Mar 23, 2023 at 8:10 PM Bharath Rupireddy
> wrote:
> > Yeah, commit [1] removed the last trace of it. I wonder if we can add
> > a WAIT_EVENT_SLRU_FLUSH_SYNC wait event in SlruSyncFileTag(), similar
> > to mdsyncfiletag. This way,
Hi,
On 3/23/23 11:00 PM, Thomas Munro wrote:
I think if we want proper automation here we
should look into a way to define wait events in a central file similar
to what we do for src/backend/storage/lmgr/lwlocknames.txt. It could
give the enum name, the display name, and the documentation
On Thu, Mar 23, 2023 at 8:10 PM Bharath Rupireddy
wrote:
> Yeah, commit [1] removed the last trace of it. I wonder if we can add
> a WAIT_EVENT_SLRU_FLUSH_SYNC wait event in SlruSyncFileTag(), similar
> to mdsyncfiletag. This way, we would have covered all sync_syncfiletag
> fsyncs with wait
On Thu, Mar 23, 2023 at 7:43 AM Thomas Munro wrote:
>
> Hi,
>
> Commit dee663f7 made WAIT_EVENT_SLRU_FLUSH_SYNC redundant, so here's a
> patch to remove it.
Yeah, commit [1] removed the last trace of it. I wonder if we can add
a WAIT_EVENT_SLRU_FLUSH_SYNC wait event in SlruSyncFileTag(), similar
+1300
Subject: [PATCH] Remove orphaned wait event.
Commit dee663f7 made WAIT_EVENT_SLRU_FLUSH_SYNC redundant.
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 7ab4424bf1..45259efd0f 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -14