Hi,
Here are some review comments for the patch v3-0001.
I don't think v3 addressed any of my previous review comments for
patches v1 and v2. [1][2]
So the comments below are limited only to the new code (i.e. the v3
versus v2 differences). Meanwhile, all my previous review comments may
still
On Thu, 23 May 2024 at 09:19, Shubham Khanna
wrote:
>
> > Dear Shubham,
> >
> > Thanks for creating a patch! Here are high-level comments.
>
> > 1.
> > Please document the feature. If it is hard to describe, we should change
> > the API.
>
> I have added the feature in the document.
>
> > 4.
> >
Dear Shubham,
Thanks for updating the patch! I checked your patches briefly. Here are my
comments.
01. API
Since the option for test_decoding is enabled by default, I think it should be
renamed.
E.g., "skip-generated-columns" or something.
02. ddl.sql
```
+-- check include-generated-columns
> Dear Shubham,
>
> Thanks for creating a patch! Here are high-level comments.
> 1.
> Please document the feature. If it is hard to describe, we should change the
> API.
I have added the feature in the document.
> 4.
> Regarding the test_decoding plugin, it has already been able to decode the
On 08.05.24 09:13, Shubham Khanna wrote:
The attached patch has the changes to support capturing generated
column data using ‘pgoutput’ and’ test_decoding’ plugin. Now if the
‘include_generated_columns’ option is specified, the generated column
information and generated column data also will be
Hi,
AFAICT this v2-0001 patch differences from v1 is mostly about adding
the new CREATE SUBSCRIPTION option. Specifically, I don't think it is
addressing any of my previous review comments for patch v1. [1]. So
these comments below are limited only to the new option code; All my
previous review
On Mon, 20 May 2024 at 13:49, Masahiko Sawada wrote:
>
> Hi,
>
> On Wed, May 8, 2024 at 4:14 PM Shubham Khanna
> wrote:
> >
> > On Wed, May 8, 2024 at 11:39 AM Rajendra Kumar Dangwal
> > wrote:
> > >
> > > Hi PG Hackers.
> > >
> > > We are interested in enhancing the functionality of the
Hi,
On Wed, May 8, 2024 at 4:14 PM Shubham Khanna
wrote:
>
> On Wed, May 8, 2024 at 11:39 AM Rajendra Kumar Dangwal
> wrote:
> >
> > Hi PG Hackers.
> >
> > We are interested in enhancing the functionality of the pgoutput plugin by
> > adding support for generated columns.
> > Could you please
Hi Kuroda-san,
Thanks for reviewing the patch. I have fixed some of the comments
> 2.
> Currently, the option is implemented as streaming option. Are there any
> reasons
> to choose the way? Another approach is to implement as slot option, like
> failover
> and temporary.
I think the current
Here are some review comments for the patch v1-0001.
==
GENERAL
G.1. Use consistent names
It seems to add unnecessary complications by having different names
for all the new options, fields and API parameters.
e.g. sometimes 'include_generated_columns'
e.g. sometimes
Dear Shubham,
Thanks for creating a patch! Here are high-level comments.
1.
Please document the feature. If it is hard to describe, we should change the
API.
2.
Currently, the option is implemented as streaming option. Are there any reasons
to choose the way? Another approach is to implement
On Wed, May 8, 2024 at 11:39 AM Rajendra Kumar Dangwal
wrote:
>
> Hi PG Hackers.
>
> We are interested in enhancing the functionality of the pgoutput plugin by
> adding support for generated columns.
> Could you please guide us on the necessary steps to achieve this?
> Additionally, do you have
Hi PG Hackers.
We are interested in enhancing the functionality of the pgoutput plugin by
adding support for generated columns.
Could you please guide us on the necessary steps to achieve this? Additionally,
do you have a platform for tracking such feature requests? Any insights or
assistance
Thanks Euler,
Greatly appreciate your inputs.
> Should pgoutput provide a complete row? Probably. If it is an option that
> defaults to false and doesn't impact performance.
Yes, it would be great if this feature can be implemented.
> The logical replication design decides to compute the
On Tue, Aug 1, 2023, at 3:47 AM, Rajendra Kumar Dangwal wrote:
> With decoderbufs and wal2json the connector is able to capture the generated
> column `full_name` in above example. But with pgoutput the generated column
> was not captured.
wal2json materializes the generated columns before
Hi PG Users.
We are using Debezium to capture the CDC events into Kafka.
With decoderbufs and wal2json plugins the connector is able to capture the
generated columns in the table but not with pgoutput plugin.
We tested with the following example:
CREATE TABLE employees (
id SERIAL PRIMARY
16 matches
Mail list logo
