Re: automating RangeTblEntry node support

2024-03-22 Thread Peter Eisentraut
On 21.03.24 10:51, Andrew Dunstan wrote: At this point, I'm not too stressed about pressing forward with these last two patches.  We can look at them again perhaps if we make progress on a more compact node output format.  When I started this thread, I had a lot of

Re: automating RangeTblEntry node support

2024-03-21 Thread Andrew Dunstan
On Mon, Mar 11, 2024 at 5:29 AM Peter Eisentraut wrote: > On 20.02.24 08:57, Peter Eisentraut wrote: > > On 18.02.24 00:06, Matthias van de Meent wrote: > >> I'm not sure that the cleanup which is done when changing a RTE's > >> rtekind is also complete enough for this purpose. > >> Things like

Re: automating RangeTblEntry node support

2024-03-11 Thread Peter Eisentraut
On 20.02.24 08:57, Peter Eisentraut wrote: On 18.02.24 00:06, Matthias van de Meent wrote: I'm not sure that the cleanup which is done when changing a RTE's rtekind is also complete enough for this purpose. Things like inline_cte_walker change the node->rtekind, which could leave residual junk

Re: automating RangeTblEntry node support

2024-02-19 Thread Peter Eisentraut
On 18.02.24 00:06, Matthias van de Meent wrote: I'm not sure that the cleanup which is done when changing a RTE's rtekind is also complete enough for this purpose. Things like inline_cte_walker change the node->rtekind, which could leave residual junk data in fields that are currently dropped

Re: automating RangeTblEntry node support

2024-02-17 Thread Matthias van de Meent
On Fri, 16 Feb 2024 at 21:36, Paul Jungwirth wrote: > > On 1/15/24 02:37, Peter Eisentraut wrote: > > In this updated patch set, I have also added the treatment of the > > Constraint type. (I also noted > > that the manual read/write functions for the Constraint type are > > out-of-sync again,

Re: automating RangeTblEntry node support

2024-02-16 Thread Paul Jungwirth
On 1/15/24 02:37, Peter Eisentraut wrote: In this updated patch set, I have also added the treatment of the Constraint type.  (I also noted that the manual read/write functions for the Constraint type are out-of-sync again, so simplifying this would be really helpful.)  I have also added commit

Re: automating RangeTblEntry node support

2024-01-15 Thread Peter Eisentraut
On 06.12.23 21:02, Peter Eisentraut wrote: I have been looking into what it would take to get rid of the custom_read_write and custom_query_jumble for the RangeTblEntry node type.  This is one of the larger and more complex exceptions left. (Similar considerations would also apply to the

Re: automating RangeTblEntry node support

2023-12-06 Thread Matthias van de Meent
On Wed, 6 Dec 2023 at 21:02, Peter Eisentraut wrote: > > I have been looking into what it would take to get rid of the > custom_read_write and custom_query_jumble for the RangeTblEntry node > type. This is one of the larger and more complex exceptions left. > [...] > Now one could probably

automating RangeTblEntry node support

2023-12-06 Thread Peter Eisentraut
I have been looking into what it would take to get rid of the custom_read_write and custom_query_jumble for the RangeTblEntry node type. This is one of the larger and more complex exceptions left. (Similar considerations would also apply to the Constraint node type.) Allegedly, only certain