Re: Fix typos and inconsistencies for v16

On Tue, May 02, 2023 at 12:26:31PM +0900, Michael Paquier wrote: > On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote: >> 4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since >> 5da14938f; maybe this change should be backpatched > > Yes, we'd better backpatch that.

Re: Fix typos and inconsistencies for v16

On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote: > Please look at the following two bunches for v14+ and v13+ (split to ease > back-patching if needed). Having processed them, I've reached the state that > could be considered "clean" ([2], [3]); at least I don't see how to detect

Re: Fix typos and inconsistencies for v16

Hi David, 21.04.2023 01:49, David Rowley wrote: On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote: please look at the similar list for v15+ (596b5af1d..HEAD). I've now pushed most of these but didn't include the following ones: Thank you! 3. BufFileOpenShared -> BufFileOpenFileSet //

Re: Fix typos and inconsistencies for v16

On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote: > please look at the similar list for v15+ (596b5af1d..HEAD). I've now pushed most of these but didn't include the following ones: > 3. BufFileOpenShared -> BufFileOpenFileSet // see dcac5e7ac Maybe I need to spend longer, but I just didn't

Re: Fix typos and inconsistencies for v16

Justin Pryzby writes: > On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote: >> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote: >>> and s/evade/avoid/ >> I didn't touch this. You'll need to provide more justification for why >> you think it's more correct than what's there. > I'd

Re: Fix typos and inconsistencies for v16

Hi Justin and David, 18.04.2023 01:10, Justin Pryzby wrote: Well done. Thank you for reviewing! On Mon, Apr 17, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote: Hello hackers, Please consider fixing the following unique words/identifiers introduced in v16: Note that your patches are

Re: Fix typos and inconsistencies for v16

On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote: > On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote: > > > - * USER SET values are appliciable only for PGC_USERSET > > > parameters. We > > > + * USER SET values are applicable only for PGC_USERSET > > >

Re: Fix typos and inconsistencies for v16

David Rowley writes: > On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote: >> Also, maybe OID_MAX should be removed from src/include/postgres_ext.h as >> it's unused since eb8312a22. > I didn't touch this. It seems like it could be useful for extensions > and client apps even if it's not

Re: Fix typos and inconsistencies for v16

On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote: > > - * USER SET values are appliciable only for PGC_USERSET > > parameters. We > > + * USER SET values are applicable only for PGC_USERSET > > parameters. We > >* use InvalidOid as role in order to

Re: Fix typos and inconsistencies for v16

On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote: > Please consider fixing the following unique words/identifiers introduced in > v16: Thanks, I've pushed all of these apart from the following 2. > 45. tar_set_error -- remove (obsolete since ebfb814f7) > 46. test_tranche_name -- remove

Re: Fix typos and inconsistencies for v16

On Mon, Apr 17, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote: > Hello hackers, > > Please consider fixing the following unique words/identifiers introduced in > v16: Well done. Note that your patches are overlapping: 3 --- a/src/backend/utils/misc/guc.c 2 ---

Fix typos and inconsistencies for v16

Hello hackers, Please consider fixing the following unique words/identifiers introduced in v16: 1. addresess -> addresses 2. adminstrator -> administrator // the same typo found in src/backend/po/id.po, but perhaps it should be fixed via pgsql-translators 3. appeneded -> appended 4.

Re: pgsql: Fix typos and bump catversion.

On 11/19/22 17:24, Tom Lane wrote: Andres Freund writes: On 2022-11-19 17:10:57 -0500, Joe Conway wrote: Rishu Bagga pointed out to me offlist that this catversion bump seems flawed: /* mmddN */ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO

Re: pgsql: Fix typos and bump catversion.

Andres Freund writes: > On 2022-11-19 17:10:57 -0500, Joe Conway wrote: >> Rishu Bagga pointed out to me offlist that this catversion bump seems >> flawed: >> /* mmddN */ >> -#define CATALOG_VERSION_NO 202211121 >> +#define CATALOG_VERSION_NO 202211821 >> I think

Re: pgsql: Fix typos and bump catversion.

Hi, On 2022-11-19 17:10:57 -0500, Joe Conway wrote: > Rishu Bagga pointed out to me offlist that this catversion bump seems > flawed: > > diff --git a/src/include/catalog/catversion.h > b/src/include/catalog/catversion.h > index >

Re: pgsql: Fix typos and bump catversion.

On 11/18/22 16:18, Robert Haas wrote: Fix typos and bump catversion. Typos reported by Álvaro Herrera and Erik Rijkers. Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was inadvertently omitted. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

Re: Fix typos in code comments

On Sat, Sep 24, 2022 at 4:00 AM Justin Pryzby wrote: > > On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote: > > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote: > > > Good catch. There is a similar typo in doc, runtime.sgml. > > > ```using TLS protocols enabled by by

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote: > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote: > > Good catch. There is a similar typo in doc, runtime.sgml. > > ```using TLS protocols enabled by by setting the parameter``` > > That one should be backpatched to v15.

Re: Fix typos in code comments

On Mon, 19 Sept 2022 at 23:10, Justin Pryzby wrote: > Find below some others. Thanks. Pushed. David

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 02:44:12AM +, houzj.f...@fujitsu.com wrote: > While working on some other patches, I found serval typos(duplicate words and > incorrect function name reference) in the code comments. Here is a small patch > to fix them. Thanks. On Mon, Sep 19, 2022 at 11:05:24AM

Re: Fix typos in code comments

Hi On Sep 19, 2022, 10:57 +0800, Amit Kapila , wrote: > On Mon, Sep 19, 2022 at 8:14 AM houzj.f...@fujitsu.com > wrote: > > > > While working on some other patches, I found serval typos(duplicate words > > and > > incorrect function name reference) in the code comments. Here is a small > >

Re: Fix typos in code comments

On Mon, Sep 19, 2022 at 8:14 AM houzj.f...@fujitsu.com wrote: > > While working on some other patches, I found serval typos(duplicate words and > incorrect function name reference) in the code comments. Here is a small patch > to fix them. > Thanks, the patch looks good to me. I'll push this.

Fix typos in code comments

Hi, While working on some other patches, I found serval typos(duplicate words and incorrect function name reference) in the code comments. Here is a small patch to fix them. Best regards, Hou zhijie 0001-fix-typos.patch Description: 0001-fix-typos.patch

Re: fix typos

On Tue, Aug 16, 2022 at 8:48 AM John Naylor wrote: > > On Fri, Aug 12, 2022 at 8:55 PM Tom Lane wrote: > > > > John Naylor writes: > > > This is really a straw-man proposal, since I'm not volunteering to do > > > the work, or suggest anybody else should do the same. That being the > > > case,

Re: fix typos

On Fri, Aug 12, 2022 at 8:55 PM Tom Lane wrote: > > John Naylor writes: > > This is really a straw-man proposal, since I'm not volunteering to do > > the work, or suggest anybody else should do the same. That being the > > case, it seems we should just go ahead with Justin's patch for > >

Re: fix typos

John Naylor writes: > This is really a straw-man proposal, since I'm not volunteering to do > the work, or suggest anybody else should do the same. That being the > case, it seems we should just go ahead with Justin's patch for > consistency. Possibly we could also change the messages to say

Re: fix typos

On Fri, Aug 12, 2022, at 3:59 AM, John Naylor wrote: > This is really a straw-man proposal, since I'm not volunteering to do > the work, or suggest anybody else should do the same. That being the > case, it seems we should just go ahead with Justin's patch for > consistency. Possibly we could also

Re: fix typos

I wrote: > On Thu, Aug 4, 2022 at 8:41 PM Tom Lane wrote: > > > > John Naylor writes: > > > > RepOriginId is a typedef for uint16, so this can't print the wrong answer, > > > but it is inconsistent with other uses. So it seems we don't need to > > > backpatch this one? > > > > Um ... if it's

Re: fix typos

On Thu, Aug 4, 2022 at 8:41 PM Tom Lane wrote: > > John Naylor writes: > > RepOriginId is a typedef for uint16, so this can't print the wrong answer, > > but it is inconsistent with other uses. So it seems we don't need to > > backpatch this one? > > Um ... if it's int16, then it can't be an

Re: fix typos

John Naylor writes: > On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote: > ereport(ERROR, > (errcode(ERRCODE_OBJECT_IN_USE), > - errmsg("could not drop replication origin with OID %d, in use by PID %d", > + errmsg("could not drop replication origin with OID %u, in use by PID %d", >

Re: fix typos

On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote: > > On Mon, Aug 01, 2022 at 08:04:54PM +0200, Erik Rijkers wrote: > > Recent typos... > > LGTM, thanks. > > Here are some others I've been sitting on, mostly in .c files. I pushed Robert's suggestion, then pushed the rest of Erik's changes and

Re: fix typos

On Wed, Aug 3, 2022 at 11:41 PM Robert Haas wrote: > > I think that it's talking about this (documented) syntax: > > ALTER ROUTINE name [ ( [ [ argmode ] [ argname ] argtype [, ...] ] ) ] > [ NO ] DEPENDS ON EXTENSION extension_name > > So the change from "depends" to "depend" here is

Re: fix typos

On Tue, Aug 2, 2022 at 4:32 AM Erik Rijkers wrote: > > The part of the sentence inside parentheses is not clear to me, before > > or after the patch: > > > > Dropping an extension causes its component objects, and other > > explicitly > > dependent routines (see , > > - the depends on

Re: fix typos

Op 02-08-2022 om 07:28 schreef John Naylor: On Tue, Aug 2, 2022 at 1:05 AM Erik Rijkers > wrote: > > Recent typos... The part of the sentence inside parentheses is not clear to me, before or after the patch:     Dropping an extension causes its component objects,

Re: fix typos

On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote: > > Here are some others I've been sitting on, mostly in .c files. 0002: weird since c91560defc57f89f7e88632ea14ae77b5cec78ee It was weird long before that, maybe we should instead change most of those tabs in the top comment to single space,

Re: fix typos

On Tue, Aug 2, 2022 at 1:05 AM Erik Rijkers wrote: > > Recent typos... The part of the sentence inside parentheses is not clear to me, before or after the patch: Dropping an extension causes its component objects, and other explicitly dependent routines (see , - the depends on

Re: fix typos

On Mon, Aug 01, 2022 at 08:04:54PM +0200, Erik Rijkers wrote: > Recent typos... LGTM, thanks. Here are some others I've been sitting on, mostly in .c files. -- Justin >From 19f320438476aff2773440447f167d06051a0a47 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Tue, 5 Jul 2022 14:12:26

fix typos

Recent typos... --- ./doc/src/sgml/ref/drop_extension.sgml.orig 2022-08-01 19:38:18.249729884 +0200 +++ ./doc/src/sgml/ref/drop_extension.sgml 2022-08-01 19:40:33.312359069 +0200 @@ -32,7 +32,7 @@ DROP EXTENSION removes extensions from the database. Dropping an extension causes its

Re: fix typos in storing statistics in shared memory

On Mon, May 23, 2022 at 10:22:36AM -0700, Nathan Bossart wrote: > On Mon, May 23, 2022 at 10:46:22PM +0900, torikoshia wrote: >> It seems like there are some duplications of 'the' in pgstat.c and >> pgstat_internal.h. >> Attaching a tiny patch to fix them. > > LGTM Thanks Torikoshi-san, fixed.

Re: fix typos in storing statistics in shared memory

On Mon, May 23, 2022 at 10:46:22PM +0900, torikoshia wrote: > It seems like there are some duplications of 'the' in pgstat.c and > pgstat_internal.h. > Attaching a tiny patch to fix them. LGTM -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

fix typos in storing statistics in shared memory

Hi, It seems like there are some duplications of 'the' in pgstat.c and pgstat_internal.h. Attaching a tiny patch to fix them. -- Regards, -- Atsushi Torikoshi NTT DATA CORPORATIONFrom fabf3bc5da8e5ebd4f600b6ba762d4413cbdcd6b Mon Sep 17 00:00:00 2001 From: Atsushi Torikoshi Date: Mon, 23 May

Re: Fix typos - "an" instead of "a"

On Thu, Dec 9, 2021 at 5:22 PM Michael Paquier wrote: > > On Wed, Dec 08, 2021 at 05:47:39PM -0700, David G. Johnston wrote: > > Yeah, I was treating the leading dash as being silent...the syntax dash(es) > > for single and multi-character arguments seems unimportant to read aloud in > > the

Re: Fix typos - "an" instead of "a"

On Wed, Dec 08, 2021 at 05:47:39PM -0700, David G. Johnston wrote: > Yeah, I was treating the leading dash as being silent...the syntax dash(es) > for single and multi-character arguments seems unimportant to read aloud in > the general sense. If one does read them then yes, "a" is correct. >

Re: Fix typos - "an" instead of "a"

On Wed, Dec 8, 2021 at 5:32 PM Greg Nancarrow wrote: > On Thu, Dec 9, 2021 at 11:25 AM David G. Johnston > wrote: > > > >> - # safe: cross compilers may not add the suffix if given an `-o' > >> + # safe: cross compilers may not add the suffix if given a `-o' > >> # argument, so we may

Re: Fix typos - "an" instead of "a"

On Thu, Dec 9, 2021 at 11:12 AM Michael Paquier wrote: > > On Thu, Dec 09, 2021 at 07:30:48AM +1100, Peter Smith wrote: > > Some regex exposed a bunch of typos scattered across PG comments and docs. > > > > They are all of the "uses-an-instead-of-a" (or vice versa) variety. > > > > PSA a small

Re: Fix typos - "an" instead of "a"

On Thu, Dec 9, 2021 at 11:25 AM David G. Johnston wrote: > >> - # safe: cross compilers may not add the suffix if given an `-o' >> + # safe: cross compilers may not add the suffix if given a `-o' >> # argument, so we may need to know it at that point already. >> On this one, I think that

Re: Fix typos - "an" instead of "a"

On Wed, Dec 8, 2021 at 5:12 PM Michael Paquier wrote: > On Thu, Dec 09, 2021 at 07:30:48AM +1100, Peter Smith wrote: > > - # safe: cross compilers may not add the suffix if given an `-o' > + # safe: cross compilers may not add the suffix if given a `-o' > # argument, so we may need to

Re: Fix typos - "an" instead of "a"

On Thu, Dec 09, 2021 at 07:30:48AM +1100, Peter Smith wrote: > Some regex exposed a bunch of typos scattered across PG comments and docs. > > They are all of the "uses-an-instead-of-a" (or vice versa) variety. > > PSA a small patch to fix them. Good catches. - # safe: cross compilers may not

Fix typos - "an" instead of "a"

Hi. Some regex exposed a bunch of typos scattered across PG comments and docs. They are all of the "uses-an-instead-of-a" (or vice versa) variety. PSA a small patch to fix them. -- Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Fix-typos-for-an-versus-a.patch Descripti

Re: Fix typos

On Mon, Nov 29, 2021 at 01:01:55AM +, qianglj.f...@fujitsu.com wrote: > I found several typos in comments and README. See patch attached. Thanks, fixed. -- Michael signature.asc Description: PGP signature

Fix typos

Hi, I found several typos in comments and README. See patch attached. Best regards, Lingjie Qiang 0001-fix-typos.patch Description: 0001-fix-typos.patch

Re: Fix typos in commments (3x repeated lettters)

> On 27 Oct 2021, at 22:34, Peter Smith wrote: > > PSA a smalll patch to fix some typos (acccidental 3x repeated > lettters) in code commments. Applied, thanks. -- Daniel Gustafsson https://vmware.com/

Fix typos in commments (3x repeated lettters)

PSA a smalll patch to fix some typos (acccidental 3x repeated lettters) in code commments. -- Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Fix-PG-comment-typos.patch Description: Binary data

Re: Fix typos in reorderbuffer.c

On Thu, Oct 8, 2020 at 2:40 PM Masahiko Sawada wrote: > > On Thu, 8 Oct 2020 at 17:37, Amit Kapila wrote: > > > > > So, I feel the > > comments should be accordingly updated. > > +1 for this change. > Thanks, I have pushed this and along with it pushed a typo-fix in logical.c. -- With

Re: Fix typos in reorderbuffer.c

On Thu, 8 Oct 2020 at 17:37, Amit Kapila wrote: > > @@ -1432,7 +1432,7 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb, > ReorderBufferTXN *txn) > ReorderBufferCleanupTXN(rb, subtxn); > } > > - /* cleanup changes in the toplevel txn */ > + /* cleanup changes in the txn */ >

Fix typos in reorderbuffer.c

ctions are recursive and will clean the changes for both the top-level transaction and subtransactions. So, I feel the comments should be accordingly updated. -- With Regards, Amit Kapila. v1-0001-Fix-typos-in-reorderbuffer.c.patch Description: Binary data

Re: Fix typos and inconsistencies for HEAD (take 11)

On Tue, Aug 20, 2019 at 04:47:41PM -0400, Alvaro Herrera wrote: > Yeah, Alexander proposed change is correct. I just pushed it. Thanks, Alvaro. -- Michael signature.asc Description: PGP signature

Re: Fix typos and inconsistencies for HEAD (take 11)

On 2019-Aug-19, Michael Paquier wrote: > On Mon, Aug 19, 2019 at 07:04:04AM +0300, Alexander Lakhin wrote: > > 11.23 TupleLockUpdate -> LockTupleNoKeyExclusive > > Not sure about this one, so discarded for now. Alvaro? Yeah, Alexander proposed change is correct. I just pushed it. > > 11.33

Re: Fix typos and inconsistencies for HEAD (take 11)

On Mon, Aug 19, 2019 at 04:22:44PM +0900, Michael Paquier wrote: > On Mon, Aug 19, 2019 at 07:04:04AM +0300, Alexander Lakhin wrote: >> 11.57 PASSBYVALUE -> PASSEDBYVALUE > > Will fix this one separately and back-patch. No need to, actually, as the error comes from 7bdc655. -- Michael

Re: Fix typos and inconsistencies for HEAD (take 11)

On Mon, Aug 19, 2019 at 07:04:04AM +0300, Alexander Lakhin wrote: > 11.23 TupleLockUpdate -> LockTupleNoKeyExclusive Not sure about this one, so discarded for now. Alvaro? > 11.25 typstore -> tupstore This one is cute. It actually does not cause a compilation failure as

Fix typos and inconsistencies for HEAD (take 11)

Hello hackers, Please consider fixing the last group (for now) of typos and inconsistencies in the tree: 11.1 peforming -> performing 11.2 table_freeze_age -> freeze_table_age 11.3 TableInfoData -> TableDataInfo 11.4 TableStatus -> PgStat_TableStatus 11.5 TAG_VALID -> BM_TAG_VALID 11.6

Re: Fix typos and inconsistencies for HEAD (take 10)

On Sun, Aug 11, 2019 at 11:00:00AM +0300, Alexander Lakhin wrote: > 10.44. serendipitiously -> serendipitously I didn't know that this even was a word: https://www.thefreedictionary.com/serendipitously But it seems to come from Horace Walpole. > 10.50. sigsetmask -> pgsigsetmask It should be

Re: Fix typos and inconsistencies for HEAD (take 10)

Hello hackers, Please consider fixing the next heap of typos and inconsistencies in the tree: 10.1. query_txt -> query text 10.2. quote_object_names -> quote_object_name 10.3. ragetypes_typanalyze.c -> rangetypes_typanalyze.c 10.4. RAISE_EXCEPTION -> ERRCODE_RAISE_EXCEPTION 10.5. rb_lower ->

Re: Fix typos and inconsistencies for HEAD (take 9)

05.08.2019 8:40, Michael Paquier wrote: > On Mon, Aug 05, 2019 at 06:44:46AM +0300, Alexander Lakhin wrote: >> I believe that all the fixes in doc/ should be back-patched too. If it's >> not too late, I can produce such patches for the nearest releases. > I think that's unfortunately a bit too

Re: Fix typos and inconsistencies for HEAD (take 9)

On Mon, Aug 05, 2019 at 06:44:46AM +0300, Alexander Lakhin wrote: > I believe that all the fixes in doc/ should be back-patched too. If it's > not too late, I can produce such patches for the nearest releases. I think that's unfortunately a bit too late for this release. Those things have been

Re: Fix typos and inconsistencies for HEAD (take 9)

On Mon, Aug 05, 2019 at 12:15:21PM +0900, Michael Paquier wrote: > On Mon, Aug 05, 2019 at 12:33:34AM +0300, Alexander Lakhin wrote: >> 9.41. OWNER_TO -> OWNER TO > > This one needs a back-patch. I'll fix that separately. Done separately as of 05ba837, and back-patched down to 9.6 as this has

Re: Fix typos and inconsistencies for HEAD (take 9)

Hello Michael, 05.08.2019 6:15, Michael Paquier wrote: >> 9.41. OWNER_TO -> OWNER TO > This one needs a back-patch. I'll fix that separately. > I believe that all the fixes in doc/ should be back-patched too. If it's not too late, I can produce such patches for the nearest releases. >> 9.75.

Re: Fix typos and inconsistencies for HEAD (take 9)

On Mon, Aug 05, 2019 at 12:33:34AM +0300, Alexander Lakhin wrote: > 9.1. NAMESPACE_SQLXML -> remove (not used since the introduction in > 355e05ab) Looks important to keep as a matter of documentation. > 9.12. not_point -> is_point (a contradiction with the check and a > comment, appeared in

Fix typos and inconsistencies for HEAD (take 9)

Hello hackers, Please consider fixing the next truss of typos and inconsistencies in the tree: 9.1. NAMESPACE_SQLXML -> remove (not used since the introduction in 355e05ab) 9.2. NBXLOG_H -> NBTXLOG_H 9.3. NEWPAGE -> XLOG_FPI (orphaned since 54685338) 9.4. newXlogId, newXlogSeg -> newXlogSegNo

Re: Fix typos

On Fri, Aug 2, 2019 at 12:11 AM Michael Paquier wrote: > On Thu, Aug 01, 2019 at 11:01:59PM -0400, Alvaro Herrera wrote: > > I think slight variations don't really detract from the value of the > > product, and consider the odd variation a reminder of the diversity of > > the project. I don't

Re: Fix typos

On Thu, Aug 1, 2019 at 10:18 PM Tom Lane wrote: > It's British vs. American spelling. For the most part, Postgres > follows American spelling, but there's the odd Briticism here and > there. Thanks for the explanation. I thought that might be the case but didn't find any other usages of

Re: Fix typos

On Thu, Aug 01, 2019 at 11:01:59PM -0400, Alvaro Herrera wrote: > I think slight variations don't really detract from the value of the > product, and consider the odd variation a reminder of the diversity of > the project. I don't suggest that we purposefully introduce spelling > variations, or

Re: Fix typos

On 2019-Aug-01, Tom Lane wrote: > It's British vs. American spelling. For the most part, Postgres > follows American spelling, but there's the odd Briticism here and > there. I'm not sure whether it's worth trying to standardize. > I think the most recent opinion on this was Munro's: > >

Re: Fix typos

Michael Paquier writes: > On Thu, Aug 01, 2019 at 08:24:17AM -0400, Sehrope Sarkuni wrote: >> Attached fixes some typos for "serialise" => "serialize" and "materialise" >> => "materialize". > These don't seem to be typos: > https://en.wiktionary.org/wiki/materialise >

Re: Fix typos

On Thu, Aug 01, 2019 at 08:24:17AM -0400, Sehrope Sarkuni wrote: > Attached fixes some typos for "serialise" => "serialize" and "materialise" > => "materialize". These don't seem to be typos: https://en.wiktionary.org/wiki/materialise https://en.wiktionary.org/wiki/serialise -- Michael

Fix typos

2001 From: Sehrope Sarkuni Date: Thu, 1 Aug 2019 08:00:23 -0400 Subject: [PATCH] Fix typos --- contrib/xml2/xpath.c| 2 +- src/backend/access/transam/README | 4 ++-- src/backend/storage/buffer/bufmgr.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: Fix typos and inconsistencies for HEAD (take 8)

On Sun, Jul 28, 2019 at 07:44:44AM +0300, Alexander Lakhin wrote: > 8.3. lag_with_offset_and_default, * -> > window_lag_with_offset_and_default, window_* (in windowfuncs.c) The intention here is to refer to the SQL-visible names. > In passing, I found a legacy script, FAQ2txt, that should be

Fix typos and inconsistencies for HEAD (take 8)

Hello hackers, Please consider fixing the next set of typos and inconsistencies in the tree: 8.1. LABORT -> LIKE_ABORT 8.2. LagTrackerWriter -> LagTrackerWrite 8.3. lag_with_offset_and_default, * -> window_lag_with_offset_and_default, window_* (in windowfuncs.c) 8.4. language-name ->

Re: Fix typos and inconsistencies for HEAD (take 7)

Hello Tom, 22.07.2019 7:14, Tom Lane wrote: >> Fixing both places sounds adapted to me. An alternative we could use >> here is just to say something like that: >> The effective resolution is only 1/HZ, which can be configured with >> kernel parameter (see man 7 time), and is 4 milliseconds by >>

Re: Fix typos and inconsistencies for HEAD (take 7)

Hello Michael, 22.07.2019 4:05, Michael Paquier wrote: >> Also, I found e-mail headers in optimizer/plan/README not relevant, so I >> propose to remove them. > Not sure about that part. I agree that the proposed fix is not complete, but just raises the demand for a subsequent fix. If you don't

Re: Fix typos and inconsistencies for HEAD (take 7)

Michael Paquier writes: > On Sun, Jul 21, 2019 at 08:28:53AM +0300, Alexander Lakhin wrote: >> And another finding is related to the sleep effective resolution. `man 7 >> time` says "Since kernel 2.6.13, the HZ value is a kernel configuration  >> parameter  and  can  be 100, 250 (the default)

Re: Fix typos and inconsistencies for HEAD (take 7)

On Sun, Jul 21, 2019 at 08:28:53AM +0300, Alexander Lakhin wrote: > Please consider fixing the next pack of typos and inconsistencies in the > tree: Thanks, all those things look fine. I have noticed one mistake. > 7.44. json_plperl -> jsonb_plperlu The path was incorrect here. > Also, I

Re: Fix typos and inconsistencies for HEAD (take 7)

Alexander Lakhin writes: > Also, I found e-mail headers in optimizer/plan/README not relevant, so I > propose to remove them. FWIW, I think they're highly relevant, because they put a date on that text. I've not gone through that README lately, but I wouldn't be surprised if it's largely

Fix typos and inconsistencies for HEAD (take 7)

Hello hackers, Please consider fixing the next pack of typos and inconsistencies in the tree: 7.1. h04m05s06 -> h04mm05s06 (in fact it's broken since 6af04882, but h04mm05s06.789 still accepted) 7.2. hasbucketcleanup -> hashbucketcleanup 7.3. _hashm_spare -> hashm_spares 7.4. hashtbl -> hash

Re: Fix typos and inconsistencies for HEAD (take 6)

On Sun, Jul 14, 2019 at 08:24:01AM +0300, Alexander Lakhin wrote: > 6.10. fildes -> fd Not sure that this one was worth bothering. And the rest looks correct after review, so applied! Thanks! > As a side note, while looking at dt_common.c (fixing 6.47), I've got a > feeling that the datetktbl

Fix typos and inconsistencies for HEAD (take 6)

Hello hackers, Please consider fixing the next batch of typos and inconsistencies in the tree: 6.1. FADVISE_WILLNEED -> POSIX_FADV_WILLNEED 6.2. failOK -> missing_ok 6.3. failOnerror -> failOnSignal 6.4. fakebits -> remove (irrelevant since introduction in 945543d9) 6.5. FastPathGetLockEntry ->

Re: Fix typos and inconsistencies for HEAD (take 5)

On Sun, Jul 07, 2019 at 08:03:01AM +0300, Alexander Lakhin wrote: > 5.8. dictlexize -> thesaurus_lexize There could be other dictionaries. > 5.9. regression.diffsregression.planregress/inh -> regression.diffs > planregress/diffs.inh I am wondering if we should not just nuke that... For now I

Fix typos and inconsistencies for HEAD (take 5)

Hello hackers, Please consider fixing the next cluster of typos and inconsistencies in the tree: 5.1. datetkntbl -> datetktbl 5.2. datminxmid -> datminmxid 5.3. DatumGetP -> DatumGetPointer 5.4. ECPG_COMPILE, DECPG_COMPILE -> remove (orphaned since 328d235) 5.5. defer_cleanup_age ->

Re: Fix typos and inconsistencies for HEAD

On Sun, Jun 30, 2019 at 04:06:47PM +0300, Alexander Lakhin wrote: > 4.33. close_ - > closept_ This one is incorrect as it refers to the various close_* routines below. > 4.36. combinedproj -> remove (orphaned after 69c3936a) This looks intentional? > I've split proposed patch to make the fixes

Fix typos and inconsistencies for HEAD

Hello hackers, Please consider fixing the next bunch of typos and inconsistencies in the tree: 4.1. AccesShareLock -> AccessShareLock 4.2. AdjustTimestampForTypemod -> AdjustTimestampForTypmod 4.3. AExprConst -> AexprConst 4.4. AlterExtensionOwner_oid - remove (orphaned after 994c36e0) 4.5.

Re: Fix typos and inconsistencies for v11+

On Mon, Jun 17, 2019 at 10:32:13AM +0300, Alexander Lakhin wrote: > Then I will go deeper for v10 and beyond. If older versions are not > going to be fixed, I will prepare patches only for the master branch. When it comes to fixing typos in in anything which is not directly user-visible like the

Re: Fix typos and inconsistencies for v11+

17.06.2019 10:16, Michael Paquier wrote: > On Sat, Jun 15, 2019 at 06:00:00PM +0300, Alexander Lakhin wrote: >> Two summary patches for REL_11_STABLE and master are attached. > Thanks. I have committed to HEAD most of the inconsistencies you have > pointed out. Thank you, Michael. Then I will go

Re: Fix typos and inconsistencies for v11+

On Sat, Jun 15, 2019 at 06:00:00PM +0300, Alexander Lakhin wrote: > Two summary patches for REL_11_STABLE and master are attached. Thanks. I have committed to HEAD most of the inconsistencies you have pointed out. -- Michael signature.asc Description: PGP signature

Fix typos and inconsistencies for v11+

Hello hackers, Please consider fixing the following typos and inconsistencies living in the source code starting from v11: 3.1 add_placeholders_to_child_joinrel -> remove (orphaned after 7cfdc770) 3.2 AttachIndexInfo -> IndexAttachInfo (an internal inconsistency) 3.3 BlockRecordInfo ->

Re: Fix typos for v12

On Sun, May 26, 2019 at 06:43:41PM +0300, Alexander Lakhin wrote: > 26.05.2019 16:49, Amit Kapila wrote: > > This occurred to me as well while reviewing, but I thought typo fixes > > should be fine. Anyway, I have excluded those before pushing. So, if > > we want to fix these, then maybe one has

Re: Fix typos for v12

26.05.2019 16:49, Amit Kapila wrote: > This occurred to me as well while reviewing, but I thought typo fixes > should be fine. Anyway, I have excluded those before pushing. So, if > we want to fix these, then maybe one has to first get this fixed in > upstream first and then take from there. >

Re: Fix typos for v12

On Sat, May 25, 2019 at 8:36 PM Tom Lane wrote: > > Amit Kapila writes: > > I have taken one pass over it and all fixes seem to be correct and got > > introduced in v12. I will re-verify them once again and then commit > > your patch if I don't found any problem. In the meantime, if anyone > >

Re: Fix typos for v12

Amit Kapila writes: > I have taken one pass over it and all fixes seem to be correct and got > introduced in v12. I will re-verify them once again and then commit > your patch if I don't found any problem. In the meantime, if anyone > else wants to look at it, that would be great. FWIW, I'd

Re: Fix typos for v12

On Sat, May 25, 2019 at 4:23 PM Alexander Lakhin wrote: > > Hello Amit, > > 25.05.2019 13:42, Amit Kapila wrote: > > I think it is good to fix these. I haven't verified all but I can > > review them. Isn't it better to fix them as one patch instead of > > multiple patches? > > If a single patch

Re: Fix typos for v12

Hello Amit, 25.05.2019 13:42, Amit Kapila wrote: > I think it is good to fix these. I haven't verified all but I can > review them. Isn't it better to fix them as one patch instead of > multiple patches? If a single patch is more convenient, then here it is. I thought that separate patches

  1   2   >