Re: [HACKERS] State of support for back PG branches

2005-09-27 Thread Michael Paesold
Tom Lane wrote: To my mind the main rationale for continuing to support 7.2 is that it was the last pre-schema release, and so people whose apps haven't yet been fixed to cope with schemas will be on their own once we drop it. While each release has some portability gotchas, I don't think there

Re: [HACKERS] State of support for back PG branches

2005-09-27 Thread Steve Atkins
On Mon, Sep 26, 2005 at 09:54:46PM -0700, Joshua D. Drake wrote: [ raised eyebrow... ] Has bizgres obtained a crystal ball from somewhere? There is *no* way anyone could provide you anything that has any legitimate claim on the name PG 8.2 three months from now. I **think** what he

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane Sent: 27 September 2005 01:13 To: Peter Eisentraut Cc: pgsql-hackers@postgresql.org Subject: [HACKERS] Making pgxs builds work with a relocated installation The other open issue in

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Magnus Hagander
The other open issue in this area was that on Windows, pg_config needs to return space-free path names to avoid breaking the makefiles. It was suggested that this could be handled by passing pg_config's result path names through GetShortPathName() on that platform. That sounds

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Dave Page
-Original Message- From: Magnus Hagander [mailto:[EMAIL PROTECTED] Sent: 27 September 2005 08:58 To: Dave Page; Tom Lane; Peter Eisentraut Cc: pgsql-hackers@postgresql.org Subject: RE: [HACKERS] Making pgxs builds work with a relocated installation The other open issue in

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Dave Page
-Original Message- From: Magnus Hagander [mailto:[EMAIL PROTECTED] Sent: 27 September 2005 09:19 To: Dave Page; Tom Lane; Peter Eisentraut Cc: pgsql-hackers@postgresql.org Subject: RE: [HACKERS] Making pgxs builds work with a relocated installation If it's disabled, then

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Magnus Hagander
The other open issue in this area was that on Windows, pg_config needs to return space-free path names to avoid breaking the makefiles. It was suggested that this could be handled by passing pg_config's result path names through GetShortPathName() on that platform.

[HACKERS] Strange, very strange

2005-09-27 Thread Andrey Repko
Hello pgsql-hackers, Two tables t1 and t2. t2 has fk (no action) to t1. Two triggers on t1 before delete, delete all fk on t2, and on t2 after delete update t1. When we do delete on t1, we have situation when at t1 updates record that deleting. Of course logic is not correct, but...

[HACKERS] prepared queries in plperl

2005-09-27 Thread Dmitry Karasik
Hello, I've posted before a patch that enables prepared queries in plperl, and now, after a while, as it seems working as expected, I'd like to ask if it would be a reasonable thing to commit in into -devel? The patch against the latest cvs is at http://www.karasik.eu.org/misc/plperl.diff . The

Re: [HACKERS] prepared queries in plperl

2005-09-27 Thread Andrew Dunstan
Dmitry Karasik said: Hello, I've posted before a patch that enables prepared queries in plperl, and now, after a while, as it seems working as expected, I'd like to ask if it would be a reasonable thing to commit in into -devel? The patch against the latest cvs is at

Re: [HACKERS] unchecked malloc

2005-09-27 Thread Sibtay Abbas
This dicussion reminds me of a possible memory leak in plpgsql's code. In case you are interested in it; in pl_comp.c, plpgsql_build_variable takes a pointer to a PLpgSQL_type structure, which is always a malloc'ed instance(since we always use plpgsql_build_datatype function). The switch

Re: [HACKERS] Database file compatability

2005-09-27 Thread Jeffrey W. Baker
On Mon, 2005-09-26 at 17:27 -0500, Jim C. Nasby wrote: If a database is created with a 64 bit version of initdb, would a 32bit backend be able to talk to it? Likewise, would a backend compiled by a different compiler be able to? If there was some kind of incompatability, would the backend

Re: [HACKERS] PostgreSQL overall design

2005-09-27 Thread Jonah H. Harris
Were you looking for a call graph?On 9/27/05, Abhijit Menon-Sen [EMAIL PROTECTED] wrote: At 2005-09-27 15:20:05 +0530, [EMAIL PROTECTED] wrote: Can anyone please tell/point me where I can get the postgresql system layout (I've an interest to contribute).

Re: [HACKERS] Questions about proper newline handling in psql output

2005-09-27 Thread Peter Eisentraut
Am Sonntag, 25. September 2005 22:45 schrieb Martijn van Oosterhout: 1. To be able to control the spacing, psql now has to be very careful about its output. eg \r is printed as \r, ascii control characters are output as \x00 style and other control chars as \u. This is a change from

Re: [HACKERS] State of support for back PG branches

2005-09-27 Thread Chris Browne
[EMAIL PROTECTED] (Steve Atkins) writes: We started our upgrade from 7.2 to 7.4 about 20 months ago and finished it about 10 months ago, skipping 7.3 entirely. We did similar; there was only one system deployed in a timeframe where 7.3 was relevant, and the big systems skipped over 7.3 much as

Re: [HACKERS] PostgreSQL overall design

2005-09-27 Thread Andrew Dunstan
[ -performance removed ] Gnanavel S wrote: Need a clarification in copydir.c file of src/port directory, In the following snippet the destination directory is created first then the source directory is read. Suppose if I don't have permission to read the source, even then the

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Bruce Momjian
Magnus Hagander wrote: Changes --- Win32 signal handling patch (Magnus) Unless someone else steps up to doing this one, please remove it from the list. I will not have time to dig into this patch before 8.1. OK, what should the TODO item be? -- Bruce Momjian

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Peter Eisentraut
Am Dienstag, 27. September 2005 02:12 schrieb Tom Lane: What I propose we do about this is change the path setup section of Makefile.global to look like (for each path variable) ifdef PGXS pkglibdir = $(shell pg_config --pkglibdir) else # existing code to set up pkglibdir endif That looks

Re: [HACKERS] Questions about proper newline handling in psql output

2005-09-27 Thread Martijn van Oosterhout
On Tue, Sep 27, 2005 at 03:02:29PM +0200, Peter Eisentraut wrote: I don't think this is necessary. If you put control characters into your text, then you clearly don't care about aligned output, so you don't get any. About \r, I think that needs to be figured into the alignment

Re: [HACKERS] Questions about proper newline handling in psql output

2005-09-27 Thread Martijn van Oosterhout
On Tue, Sep 27, 2005 at 12:12:15AM -, Greg Sabino Mullane wrote: 4. Some system output like pg_views has really really long strings, would it be acceptable to change the output there to add newlines at various places to make it output nicer with this change? I'd say no, until you

Re: [HACKERS] [PERFORM] PostgreSQL overall design

2005-09-27 Thread Bruce Momjian
Have you read the developers FAQ? --- Gnanavel S wrote: Hi All, Can anyone please tell/point me where I can get the postgresql system layout (I've an interest to contribute). I would also like to know the files

Re: [HACKERS] prepared queries in plperl

2005-09-27 Thread Dmitry Karasik
Andrew We need to examine the names being used on our spi functions - I'm Andrew not sure there is sufficient consistency about them. Yes, but I'd rather wish the patch committed before that, because otherwise I would be forced to rework the code again, after the namespace is finally

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Am Dienstag, 27. September 2005 02:12 schrieb Tom Lane: Not all of the path variables set up in Makefile.global are currently available from pg_config; the missing ones are prefix exec_prefix sbindir mandir localedir libexecdir datadir

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Magnus Hagander
Changes --- Win32 signal handling patch (Magnus) Unless someone else steps up to doing this one, please remove it from the list. I will not have time to dig into this patch before 8.1. OK, what should the TODO item be? A link to the mail should be there, I guess (it's

Re: [HACKERS] Vacuum questions...

2005-09-27 Thread Gaetano Mendola
Gaetano Mendola wrote: Alvaro Herrera wrote: On Mon, Sep 26, 2005 at 05:41:24PM +0200, Gaetano Mendola wrote: Joshua D. Drake wrote: Autovacuum is integrated into the backend for 8.1 Can I set the autovacuum parameter per table instead of per engine ? Yes. Reading the 8.1 release note I

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Bruce Momjian
Magnus Hagander wrote: Changes --- Win32 signal handling patch (Magnus) Unless someone else steps up to doing this one, please remove it from the list. I will not have time to dig into this patch before 8.1. OK, what should the TODO item be? A link to the mail

Re: [HACKERS] Database file compatability

2005-09-27 Thread Jim C. Nasby
On Mon, Sep 26, 2005 at 07:05:28PM -0400, Tom Lane wrote: Qingqing Zhou [EMAIL PROTECTED] writes: Jim C. Nasby [EMAIL PROTECTED] wrote If a database is created with a 64 bit version of initdb, would a 32bit backend be able to talk to it? Likewise, would a backend compiled by a different

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Peter Eisentraut
Tom Lane wrote: pgxs.mk itself requires access to datadir and docdir, so I don't see how you can maintain that those aren't necessary. The only reason it doesn't also reference mandir and localedir is that none of our current contrib modules have any man pages or locale support, Well, I

Re: [HACKERS] State of support for back PG branches

2005-09-27 Thread Josh Berkus
Steve, The only crystal ball involved is the assumption that if bizgres has Neat Stuff(tm) that would be of widespread use in it's development tree at that point then the odds are good that it, or something functionally equivalent to it, will appear in the 8.2 development tree. It certainly

Re: [HACKERS] [BUGS] BUG #1883: Renaming a schema leaves inconsistent

2005-09-27 Thread Bruce Momjian
With the following errors caused by ALTER SCHEMA RENAME, I recommend we remove this feature for 8.1 and revisit it for 8.2. I would just remove the grammar construct for it and the documentation. To fix this, we would need to redesign the way we store DEFAULT sequence assignments, and I don't

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Bruce Momjian
The open items list has been reduced nicely: PostgreSQL 8.1 Open Items = Current version at http://candle.pha.pa.us/cgi-bin/pgopenitems or from http://www.postgresql.org/developer/beta. Changes --- fix

Re: [HACKERS] [PERFORM] A Better External Sort?

2005-09-27 Thread Jeffrey W. Baker
On Tue, 2005-09-27 at 13:15 -0400, Ron Peacetree wrote: That Btree can be used to generate a physical reordering of the data in one pass, but that's the weakest use for it. The more powerful uses involve allowing the Btree to persist and using it for more efficient re-searches or combining

[HACKERS] Install pg_regress script to support PGXS?

2005-09-27 Thread Tom Lane
While testing the recent pgxs patch, I noticed that you can build and install contrib with PGXS: cd contrib gmake USE_PGXS=1 all gmake USE_PGXS=1 install It seems that it ought to work to run installcheck too: gmake USE_PGXS=1 installcheck but this does not quite

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Using GetShortPathName() will break on any system that has disabled short filename generatino, which IIRC is a recommended best practice both for performance and for security in legacy apps. I don't know what it does, but probably it will just return

Re: [HACKERS] PostgreSQL overall design

2005-09-27 Thread Abhijit Menon-Sen
At 2005-09-27 15:20:05 +0530, [EMAIL PROTECTED] wrote: Can anyone please tell/point me where I can get the postgresql system layout (I've an interest to contribute). http://www.postgresql.org/developer/coding And, in particular: http://www.postgresql.org/docs/faqs.FAQ_DEV.html -- ams

Re: [HACKERS] [PERFORM] A Better External Sort?

2005-09-27 Thread Ron Peacetree
From: Dann Corbit [EMAIL PROTECTED] Sent: Sep 26, 2005 5:13 PM To: Ron Peacetree [EMAIL PROTECTED], pgsql-hackers@postgresql.org, pgsql-performance@postgresql.org Subject: RE: [HACKERS] [PERFORM] A Better External Sort? I think that the btrees are going to be O(n*log(n)) in construction

[HACKERS] PostgreSQL overall design

2005-09-27 Thread Gnanavel S
Hi All, Can anyone please tell/point me where I can get the postgresql system layout (I've an interest to contribute). I would also like to know the files involved for performing each task ( for eg when doing a select operation what is exactly happening in postgres along with the files). I was

Re: [HACKERS] [PERFORM] A Better External Sort?

2005-09-27 Thread Ron Peacetree
SECOND ATTEMPT AT POST. Web mailer appears to have eaten first one. I apologize in advance if anyone gets two versions of this post. =r From: Tom Lane [EMAIL PROTECTED] Sent: Sep 26, 2005 9:42 PM Subject: Re: [HACKERS] [PERFORM] A Better External Sort? So far, you've blithely assumed that you

Re: [HACKERS] [PERFORM] A Better External Sort?

2005-09-27 Thread Jonah H. Harris
Ron, Again, if you feel strongly enough about the theory to argue it, I recommend that you spend your time constructively; create an implemenation of it. Citing academics is cool and all, but code speaks louder than theory in this case. As Tom mentioned, this has to be portable. Making

[HACKERS] effective SELECT from child tables

2005-09-27 Thread Ilia Kantor
Let table A be inherited by A1, A2, A3. How to select from A records where actual relations are A1, A2 ? I found a way somewhere, it sounds like SELECT   WHERE tableoid IN (a1.oid, a2.oid), but tableoid checks actually do seq scan. Like: SELECT * FROM sometable WHERE tableoid

Re: [HACKERS] effective SELECT from child tables

2005-09-27 Thread Josh Berkus
Ilia, Maybe new constraint_exclusion staff could help to exclude non-matching tables from inheritance query ? Yes, that's exactly what it's for. Your testing is welcome. Download 8.1 and try it today. -- --Josh Josh Berkus Aglio Database Solutions San Francisco

Re: [HACKERS] [BUGS] BUG #1883: Renaming a schema leaves inconsistent

2005-09-27 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: With the following errors caused by ALTER SCHEMA RENAME, I recommend we remove this feature for 8.1 and revisit it for 8.2. It's a mistake to blame ALTER SCHEMA RENAME for this problem, as you can cause it equally well by renaming the sequence

Re: [HACKERS] effective SELECT from child tables

2005-09-27 Thread Tom Lane
Ilia Kantor [EMAIL PROTECTED] writes: Let table A be inherited by A1, A2, A3. How to select from A records where actual relations are A1, A2 ? Why not just select directly from the child tables? I can't get excited about optimizing the case you propose. regards, tom

Re: [HACKERS] Vacuum questions...

2005-09-27 Thread Jan Wieck
On 9/24/2005 8:17 PM, Jim C. Nasby wrote: Would it be difficult to vacuum as part of a dump? The reasoning behind this is that you have to read the table to do the dump anyway, I think aside from what's been said so far, it would be rather difficult anyway. pg_dump relies on MVCC and

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Peter Eisentraut
Bruce Momjian wrote: bump major library version number? Were there any incompatible interface changes? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Have you searched our list archives?

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian wrote: bump major library version number? Were there any incompatible interface changes? No, I don't _think_ so, but we have been bitten by this before, not because of API change but because of use of libpgport functions called by libpq in one release

Re: [HACKERS] [BUGS] BUG #1883: Renaming a schema leaves inconsistent

2005-09-27 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: With the following errors caused by ALTER SCHEMA RENAME, I recommend we remove this feature for 8.1 and revisit it for 8.2. It's a mistake to blame ALTER SCHEMA RENAME for this problem, as you can cause it equally well by

Re: [HACKERS] [PERFORM] A Better External Sort?

2005-09-27 Thread Josh Berkus
Ron, I've somehow missed part of this thread, which is a shame since this is an area of primary concern for me. Your suggested algorithm seems to be designed to relieve I/O load by making more use of the CPU. (if I followed it correctly). However, that's not PostgreSQL's problem;

Re: [HACKERS] Re-run query on automatic reconnect

2005-09-27 Thread Jim C. Nasby
On Mon, Sep 26, 2005 at 02:52:02PM -0600, Michael Fuhr wrote: On Mon, Sep 26, 2005 at 01:23:03PM -0500, Jim C. Nasby wrote: Is there any particular reason why psql doesn't re-run a query that failed due to disconnect from the server after re-connecting? I've thought maybe it's because it

Re: [HACKERS] Gerbil build farm failure

2005-09-27 Thread Jim C. Nasby
On Mon, Sep 26, 2005 at 06:58:16PM -0400, Tom Lane wrote: Michael Fuhr [EMAIL PROTECTED] writes: Gerbil's looking better lately: http://pgbuildfarm.org/cgi-bin/show_history.pl?nm=gerbilbr=REL8_0_STABLE Yeah. We've been poking at it off-list, and it seems that the problem was a local

Re: [HACKERS] \d on database with a lot of tables is slow

2005-09-27 Thread Jim C. Nasby
On Mon, Sep 26, 2005 at 03:00:44PM -0400, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: I have a client with a database that contains 4000 relations according to vacuum verbose, and \d in psql is painfully slow. In particular... It's presumably mostly in the pg_table_is_visible()

Re: [HACKERS] \d on database with a lot of tables is slow

2005-09-27 Thread Tom Lane
Jim C. Nasby [EMAIL PROTECTED] writes: On Mon, Sep 26, 2005 at 03:00:44PM -0400, Tom Lane wrote: It's presumably mostly in the pg_table_is_visible() calls. Not sure if we can do much to speed those up, but: how many schemas in your search path? What's the distribution of pg_class entries

Re: [HACKERS] Vacuum questions...

2005-09-27 Thread Jim C. Nasby
On Tue, Sep 27, 2005 at 02:47:46PM -0400, Jan Wieck wrote: On 9/24/2005 8:17 PM, Jim C. Nasby wrote: Would it be difficult to vacuum as part of a dump? The reasoning behind this is that you have to read the table to do the dump anyway, I think aside from what's been said so far, it would

Re: [HACKERS] Vacuum questions...

2005-09-27 Thread Tom Lane
Jim C. Nasby [EMAIL PROTECTED] writes: AFAIK, this should allow both to run in seperate transactions. ... and pretty much destroy any synchronization between the two scans, which was sort of the point wasn't it? regards, tom lane ---(end of

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: fix ALTER SCHEMA RENAME for sequence dependency, or remove feature I've posted a proposed patch to fix this. The patch requires an initdb (to add new sequence functions), so if we do that we may as well also fix the 32/64bit risk mentioned here:

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Marc G. Fournier
On Tue, 27 Sep 2005, Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: fix ALTER SCHEMA RENAME for sequence dependency, or remove feature I've posted a proposed patch to fix this. The patch requires an initdb (to add new sequence functions), so if we do that we may as well also

Re: [HACKERS] State of support for back PG branches

2005-09-27 Thread Marc G. Fournier
On Mon, 26 Sep 2005, Josh Berkus wrote: Tom, Or, as you say, we could take the viewpoint that there are commercial companies willing to take on the burden of supporting back releases, and the development community ought not spend its limited resources on doing that. I'm hesitant to push that

Re: [HACKERS] \d on database with a lot of tables is slow

2005-09-27 Thread Jim C. Nasby
On Tue, Sep 27, 2005 at 06:53:13PM -0400, Tom Lane wrote: Also, do you have any idea on the 'Did not find relation named table-thats-there' error? table-thats-there isn't a temp table, and I don't believe they're even using temp tables, so I don't think that's the issue. Uh, what's the

Re: [HACKERS] Vacuum questions...

2005-09-27 Thread Jim C. Nasby
On Tue, Sep 27, 2005 at 07:12:21PM -0400, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: AFAIK, this should allow both to run in seperate transactions. ... and pretty much destroy any synchronization between the two scans, which was sort of the point wasn't it? Aren't there ways to

Re: [HACKERS] Open items list for 8.1

2005-09-27 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: fix ALTER SCHEMA RENAME for sequence dependency, or remove feature I've posted a proposed patch to fix this. The patch requires an initdb (to add new sequence functions), so if we do that we may as well also fix the 32/64bit

Re: [HACKERS] Database file compatability

2005-09-27 Thread Qingqing Zhou
Jim C. Nasby [EMAIL PROTECTED] wrote Yeah. It might be worth adding MAX_ALIGNOF to the set of configuration data stored in pg_control, just to be sure you couldn't shoot yourself in the foot that way. PLEASE. :) I am coming up with a patch of it. I think all ALIGNOF macros should be

Re: [HACKERS] Database file compatability

2005-09-27 Thread Tom Lane
Qingqing Zhou [EMAIL PROTECTED] writes: I think all ALIGNOF macros should be checked. There are no platforms for which ALIGNOF_SHORT is different from 2. I don't think there are any platforms we care about where ALIGNOF_INT is different from 4. The cases of interest are ALIGNOF_DOUBLE,

Re: [HACKERS] State of support for back PG branches

2005-09-27 Thread Chris Browne
[EMAIL PROTECTED] (Marc G. Fournier) writes: On Mon, 26 Sep 2005, Josh Berkus wrote: Tom, Or, as you say, we could take the viewpoint that there are commercial companies willing to take on the burden of supporting back releases, and the development community ought not spend its limited

[HACKERS] enhanced pgbench

2005-09-27 Thread Tatsuo Ishii
Hi all, We have enhanced pgbench so that it accepts a series of SQL commands in a file(see attached patches against 8.0.3). This would make it possible to test various sets of SQL commands. In the file it is allowed to use a meta command. Currently only \setrandom meta command is allowed, which

Re: [HACKERS] Making pgxs builds work with a relocated installation

2005-09-27 Thread Peter Eisentraut
Tom Lane wrote: Yuck. Anyone have another idea on coping with space-containing pathnames? Switch to scons. You heard it here first! -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9'