-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Wed, Apr 16, 2008 at 2:17 AM, Joshua D. Drake wrote:
On Tue, 15 Apr 2008 12:12:24 -0400
Alvaro Herrera wrote:
Tom Lane wrote:
I tend to just fix this stuff while committing, rather than lecture
the submitters about it, but it
On Apr 14, 2008, at 4:15 PM, Bruce Momjian wrote:
If you don't want an issue to get forgotten, then make a TODO
entry for
it. But the purpose of commit fest is to make sure we deal with
things
that can be dealt with in a timely fashion. It's not going to cause
solutions to unsolved
Hi,
The idea that we fix stylistic issues on the fly is not sustainable.
We should offer help and mentorship to new patch submitters in all
areas (including stylistic) but they should do the work. It is the only
way we will mold them to submit patches in the proper way.
I agree.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Tue, Apr 15, 2008 at 10:57:37AM -0400, Merlin Moncure wrote:
On Tue, Apr 15, 2008 at 10:48 AM, [EMAIL PROTECTED] wrote:
On Tue, Apr 15, 2008 at 09:48:37AM -0400, Merlin Moncure wrote:
On Tue, Apr 15, 2008 at 9:36 AM, Alvaro Herrera
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
- -BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Sat, Mar 29, 2008 at 5:40 AM, Brendan Jurd wrote:
On 29/03/2008, Tom Lane wrote:
I intentionally didn't touch xml.c, nor anyplace that is not dealing
in text, even if it happens to be
NikhilS wrote:
Hi,
The idea that we fix stylistic issues on the fly is not
sustainable.
We should offer help and mentorship to new patch submitters in
all areas (including stylistic) but they should do the work. It
is the only way we will mold them to submit patches in the proper
Heikki Linnakangas napsal(a):
Zdenek Kotala wrote:
Heikki Linnakangas napsal(a):
I would suggest starting with putting some serious effort into
pg_migrator. This page layout conversion is actually pretty trivial
compared to all that, and even more so if you can get the page layout
conversion
Tom Lane wrote:
Stephen Denne [EMAIL PROTECTED] writes:
From: Tom Lane [mailto:[EMAIL PROTECTED]
As for 2) and 3), can't you look into the pg_settings view?
pg_settings view doesn't contain custom variables created on the
fly,
Really? [ pokes around ... ] Hm, you're right, because
Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
I think if we want pg_terminate_backend, we have to do it the
way that was originally discussed: have it issue SIGTERM and fix
whatever needs to be fixed in the SIGTERM code path.
Well, with no movement
Tom Lane wrote:
I'm willing to enable a SIGTERM-based pg_terminate_backend for 8.4
if there is some reasonable amount of testing done during this
development cycle to try to expose any problems. If no one is willing
to do any such testing, then as far as I'm concerned there is no
market for
Notice that :
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=r
and
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=d
do not provide same result (3 results by date, 1 by rank) even if only the
sorting is changed.
--
Cédric Villemain
Administrateur de Base de Données
Cel: +33
Tom Lane wrote:
ISTM that we must fix the bgwriter so that ForgetDatabaseFsyncRequests
causes PendingUnlinkEntrys for the doomed DB to be thrown away too.
This should prevent the unlink-live-data scenario, I think.
Even then, concurrent deletion attempts are probably possible (since
Oleg Bartunov wrote:
On Tue, 15 Apr 2008, Magnus Hagander wrote:
I didn't do anything, but possibly it got fixed by a different
upgrade at some point, and the recrawling of the sites.
Magnus, we have parser for indexing pgdocs, do you need it ?
Yes, please!
//Magnus
--
Sent via
Cédric Villemain wrote:
Notice that :
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=r
and
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=d
do not provide same result (3 results by date, 1 by rank) even if
only the sorting is changed.
Actually, I get 5 and 7, in the
Le Wednesday 16 April 2008, Magnus Hagander a écrit :
Cédric Villemain wrote:
Notice that :
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=r
and
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=d
do not provide same result (3 results by date, 1 by rank) even if
Cédric Villemain wrote:
Le Wednesday 16 April 2008, Magnus Hagander a écrit :
Cédric Villemain wrote:
Notice that :
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=r
and
http://search.postgresql.org/search?q=tom+lanem=1l=d=1s=d
do not provide same result (3 results
On Tue, 2008-04-08 at 20:41 -0400, Tom Lane wrote:
So I'm of the opinion that there's no good reason to change either our
code or our docs. The standard-incompatibility is with BEGIN, not
SET TRANSACTION, and it's already documented.
That's a good case. Patch withdrawn.
--
Simon Riggs
On Tue, 2008-04-08 at 09:16 +0200, Albe Laurenz wrote:
Heikki Linnakangas wrote:
Albe Laurenz wrote:
Moreover, if Shutdown == SmartShutdown, new connections won't be accepted,
and nobody can connect and call pg_stop_backup().
So even if I'd add a check for
(pmState == PM_WAIT_BACKENDS)
I wonder if this would help to clean up the equivalence class hacks in
Greg's ordered append patch?
Tom Lane wrote:
I've been thinking about how to improve the planner's poor handling of
variables in outer-join situations. Here are some past examples for
motivation:
Tom Lane [EMAIL PROTECTED] writes:
ISTM that there will be more cases like this in future, so we need a
general solution anyway. I propose the following sort of code structure
for these situations:
on_shmem_exit(cleanup_routine, arg);
PG_TRY();
{
... do
[EMAIL PROTECTED] wrote:
I expect you intend to get at least the hooks in, right?
[...]
libpqtypes was designed to handle this with our without hooking. (the
'hooking' debate was mainly about exactly how libpq and libpqtypes was
going to be separated).
libpqtypes had a superclassing
Gregory Stark [EMAIL PROTECTED] writes:
Or weakly -- an assert in CHECK_FOR_INTERRUPTS
oops, that's irrelevant of course.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's 24x7 Postgres support!
--
Sent via pgsql-hackers mailing list
Magnus Hagander wrote:
Tom Lane wrote:
Magnus Hagander [EMAIL PROTECTED] writes:
Shouldn't be too hard to do, but I keep thinking it'd be cleaner to
just not do the redefine when building libpq. It means we'd add a
define like BUILDING_LIBPQ or something to the libpq Makefile, and
Hi,
I'm working on the bachelor thesis. The goal of the work will be to
implement collation at database level based on POSIX locales and make
foundations for further national language support development. User will
be able to set collation when creating database or change collation of
Radek Strnad [EMAIL PROTECTED] writes:
The problem with POSIX locales is that you never know what
locales user have got installed. I've discovered that some linux distros
don't even have other than UTF-8 based locales.
On Debian you're even deeper in it. The user can configure which locales
Simon Riggs [EMAIL PROTECTED] writes:
Personally, I think smart shutdown could be even smarter. It should
kick off unwanted sessions, such as an idle pgAdmin session - maybe a
rule like anything that has been idle for 30 seconds.
That's not a bad idea in itself but I don't think it's
Andrew Dunstan wrote:
Magnus Hagander wrote:
Tom Lane wrote:
Magnus Hagander [EMAIL PROTECTED] writes:
Shouldn't be too hard to do, but I keep thinking it'd be cleaner
to just not do the redefine when building libpq. It means we'd
add a define like BUILDING_LIBPQ or
Magnus Hagander [EMAIL PROTECTED] writes:
I think pg_indent has to be made a lot more portable and easy to use
before that can happen :-) I've run it once or twice on linux machines,
and it comes out with huge changes compared to what Bruce gets on his
machine.
Yeah, I've had no luck with it
On Wed, Apr 16, 2008 at 1:07 PM, Magnus Hagander [EMAIL PROTECTED] wrote:
I think pg_indent has to be made a lot more portable and easy to use
before that can happen :-) I've run it once or twice on linux machines,
and it comes out with huge changes compared to what Bruce gets on his
Magnus Hagander wrote:
Here's a patch, which I'll apply unless there's an objection.
Seems a reasonable step for now, yeah - we can add BUILDING_LIBPQ
sometime in the future if we need it.
However, you patch needs to set the define in the MSVC build as well,
to make sure that the
Magnus Hagander [EMAIL PROTECTED] writes:
Tom Lane wrote:
Really? [ pokes around ... ] Hm, you're right, because
add_placeholder_variable() sets the GUC_NO_SHOW_ALL flag, and in this
usage it'll never be cleared. I wonder if we should change that.
The whole thing is a bit of an abuse of
Heikki Linnakangas [EMAIL PROTECTED] writes:
Florian suggested a scheme where the xid and epoch is embedded in the
filename, but that's unnecessarily complex. We could just make
relfilenode a 64-bit integer. 2^64 should be enough for everyone.
Doesn't fix the problem unless DB and TS OIDs
Gregory Stark [EMAIL PROTECTED] writes:
Tom Lane [EMAIL PROTECTED] writes:
ISTM that there will be more cases like this in future, so we need a
general solution anyway. I propose the following sort of code structure
for these situations:
[We would also have to block SIGTERM around the
Tom Lane wrote:
Magnus Hagander [EMAIL PROTECTED] writes:
Tom Lane wrote:
Really? [ pokes around ... ] Hm, you're right, because
add_placeholder_variable() sets the GUC_NO_SHOW_ALL flag, and in this
usage it'll never be cleared. I wonder if we should change that.
The whole thing is a bit
Tom Lane [EMAIL PROTECTED] writes:
[We would also have to block SIGTERM around the second cancel_shmem_exit and
cleanup_routine, no? Or if it's idempotent (actually, wouldn't it have to
be?)
run them in the reverse order.]
No, we wouldn't, because a SIGTERM can only actually fire at a
Magnus Hagander [EMAIL PROTECTED] writes:
Andrew Dunstan wrote:
I think a simple approach is all we need for now - not even sure we
need an ifeq() section in the makefile.
Here's a patch, which I'll apply unless there's an objection.
Seems a reasonable step for now, yeah - we can add
Tom Lane wrote:
Heikki Linnakangas [EMAIL PROTECTED] writes:
Florian suggested a scheme where the xid and epoch is embedded in the
filename, but that's unnecessarily complex. We could just make
relfilenode a 64-bit integer. 2^64 should be enough for everyone.
Doesn't fix the problem unless
Heikki Linnakangas [EMAIL PROTECTED] writes:
I wonder if this would help to clean up the equivalence class hacks in
Greg's ordered append patch?
Pretty hard to say at this early stage, but the more I think about it
the more I like the idea of never using the same Var to represent two
values
Tom Lane [EMAIL PROTECTED] writes:
Gregory Stark [EMAIL PROTECTED] writes:
Tom Lane [EMAIL PROTECTED] writes:
No, we wouldn't, because a SIGTERM can only actually fire at a
CHECK_FOR_INTERRUPTS() call. You'd just need to be sure there wasn't
one in the cleanup code.
Wait, huh? In that
Gregory Stark [EMAIL PROTECTED] writes:
Tom Lane [EMAIL PROTECTED] writes:
No, we wouldn't, because a SIGTERM can only actually fire at a
CHECK_FOR_INTERRUPTS() call. You'd just need to be sure there wasn't
one in the cleanup code.
Wait, huh? In that case I don't see what advantage any of
Brendan Jurd [EMAIL PROTECTED] writes:
If we don't want to meddle with xmltype/bytea/VarChar at all, we'll
have to revert those changes, and I'll have to seriously scale back
the cleanup patch I was about to post.
Still not sure where we stand on the above. To cast, or not to cast?
I dunno.
Tom Lane wrote:
Brendan Jurd [EMAIL PROTECTED] writes:
If we don't want to meddle with xmltype/bytea/VarChar at all, we'll
have to revert those changes, and I'll have to seriously scale back
the cleanup patch I was about to post.
Still not sure where we stand on the above. To
Gregory Stark [EMAIL PROTECTED] writes:
No, I meant the earlier patch which you rejected with the flag in MyProc. I
realize there were other issues but the initial concern was that it wouldn't
respond promptly because it would wait for CHECK_FOR_INTERRUPTS.
No, that's not the concern in the
Tom Lane [EMAIL PROTECTED] writes:
Heikki Linnakangas [EMAIL PROTECTED] writes:
I wonder if this would help to clean up the equivalence class hacks in
Greg's ordered append patch?
Pretty hard to say at this early stage,
I've started to have some doubts myself about stuffing all these
I have just installed the rpm found at:
http://www.postgresql.org/ftp/binary/v8.2.7/linux/rpms/redhat/rhel-4-i386/
and the status option generates an error:
$ /etc/init.d/postgresql status
pidof: invalid options on command line!
pidof: invalid options on command line!
-p is stopped
I was
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
I am starting to think we need to analyze the source code rather than
testing, because of what we are testing for.
I was thinking about that a bit more, in connection with trying to
verbalize why I don't like your patch ;-)
The
Brendan Jurd wrote:
The idea that we fix stylistic issues on the fly is not sustainable.
We should offer help and mentorship to new patch submitters in all
areas (including stylistic) but they should do the work. It is the only
way we will mold them to submit patches in the proper way.
Magnus Hagander wrote:
And I think adopting surrounding naming, commeting, coding conventions
should come naturally as it can aide in copy-pasting too :)
I think pg_indent has to be made a lot more portable and easy to use
before that can happen :-) I've run it once or twice on linux
Magnus Hagander [EMAIL PROTECTED] writes:
Tom Lane wrote:
I'm willing to enable a SIGTERM-based pg_terminate_backend for 8.4
if there is some reasonable amount of testing done during this
development cycle to try to expose any problems.
If someone can come up with an automated script to do
[EMAIL PROTECTED] (Tom Lane) writes:
Magnus Hagander [EMAIL PROTECTED] writes:
I think pg_indent has to be made a lot more portable and easy to use
before that can happen :-) I've run it once or twice on linux machines,
and it comes out with huge changes compared to what Bruce gets on his
Tom Lane wrote:
Magnus Hagander [EMAIL PROTECTED] writes:
Tom Lane wrote:
I'm willing to enable a SIGTERM-based pg_terminate_backend for 8.4
if there is some reasonable amount of testing done during this
development cycle to try to expose any problems.
If someone can come up with an
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
The closest thing I can think of to an automated test is to run repeated
sets of the parallel regression tests, and each time SIGTERM a randomly
chosen backend at a randomly chosen time. Then see if anything funny
Yep, that was my
Chris Browne [EMAIL PROTECTED] writes:
[EMAIL PROTECTED] (Tom Lane) writes:
Every so often there are discussions of going over to GNU indent
instead. Presumably that would solve the portability problem.
The last time we tried it (which was a long time ago) it seemed
to have too many bugs and
On Wed, 16 Apr 2008 12:36:50 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
If the patch submitters hasn't read the developers' FAQ, we assume
they are not interested in improving the style of their patch.
I think that point is fairly flawed in consideration. I know for a fact
that I
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
The closest thing I can think of to an automated test is to run repeated
sets of the parallel regression tests, and each time SIGTERM a randomly
chosen backend at a randomly chosen time. Then see if anything funny
[EMAIL PROTECTED] (Bruce Momjian) writes:
Magnus Hagander wrote:
And I think adopting surrounding naming, commeting, coding conventions
should come naturally as it can aide in copy-pasting too :)
I think pg_indent has to be made a lot more portable and easy to use
before that can happen
Added to TODO:
* Implement the non-threaded Avahi service discovery protocol
http://archives.postgresql.org/pgsql-hackers/2008-02/msg00939.php
http://archives.postgresql.org/pgsql-patches/2008-02/msg00097.php
http://archives.postgresql.org/pgsql-hackers/2008-03/msg01211.php
Chris Browne wrote:
[EMAIL PROTECTED] (Bruce Momjian) writes:
Magnus Hagander wrote:
And I think adopting surrounding naming, commeting, coding conventions
should come naturally as it can aide in copy-pasting too :)
I think pg_indent has to be made a lot more portable and easy to use
Chris Browne wrote:
[EMAIL PROTECTED] (Tom Lane) writes:
Magnus Hagander [EMAIL PROTECTED] writes:
I think pg_indent has to be made a lot more portable and easy to use
before that can happen :-) I've run it once or twice on linux machines,
and it comes out with huge changes compared to
On Tue, 11 Mar 2008 11:07:27 -0700
Joshua D. Drake [EMAIL PROTECTED] wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Tue, 11 Mar 2008 10:46:23 -0700
Joshua D. Drake [EMAIL PROTECTED] wrote:
And the -c version :) (thanks bruce)
Joshua D. Drake
What is the feedback on this
Joshua D. Drake wrote:
What is the feedback on this patch? Is there anything I need to do to
get it into the next commit fest?
Please add it to the commitfest wiki page.
http://wiki.postgresql.org/wiki/CommitFest:May
--
Alvaro Herrera
On Wed, 16 Apr 2008 13:36:50 -0400
Alvaro Herrera [EMAIL PROTECTED] wrote:
Joshua D. Drake wrote:
What is the feedback on this patch? Is there anything I need to do
to get it into the next commit fest?
Please add it to the commitfest wiki page.
Hello,
Could someone break out exactly what the process is now for
submitting a patch? Last month I sent a patch for pg_dump which never
got feedback (at least on thread). I just asked and alvaro asked me to
add it to the commitfest page. Which I have done but I think we need to
known all the
Bruce Momjian wrote:
Chris Browne wrote:
Would it be a terrible idea to...
- Draw the indent code from NetBSD into src/tools/pgindent
- Build it _in place_ inside the code tree (e.g. - don't assume
it will get installed in /usr/local/bin)
- Thus have the ability to run it in
Joshua D. Drake wrote:
Hello,
Could someone break out exactly what the process is now for
submitting a patch? Last month I sent a patch for pg_dump which never
got feedback (at least on thread). I just asked and alvaro asked me to
add it to the commitfest page. Which I have done but I think
On Wed, 16 Apr 2008 13:59:50 -0400
Andrew Dunstan [EMAIL PROTECTED] wrote:
If you posted it last month then it was too late for the commit-fest
that started on March 1, IIRC, so the fact that you didn't get
feedback is hardly surprising - a commit-fest is like a
mini-feature-freeze.
O.k.
Joshua D. Drake wrote:
What is the feedback on this patch? Is there anything I need to do to
get it into the next commit fest?
Yes, go add it to the wiki page ;-):
http://wiki.postgresql.org/wiki/CommitFest:May
I agree that we should do that, but the thread on -hackers (Autovacuum
vs
On Wed, 16 Apr 2008 21:04:17 +0300
Heikki Linnakangas [EMAIL PROTECTED] wrote:
To quote Tom:
I think we need to be careful to distinguish three situations:
* statement_timeout during pg_dump
* statement_timeout during pg_restore
* statement_timeout during psql reading a pg_dump script
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 13:59:50 -0400
Andrew Dunstan [EMAIL PROTECTED] wrote:
If you posted it last month then it was too late for the commit-fest
that started on March 1, IIRC, so the fact that you didn't get
feedback is hardly surprising - a commit-fest is like
On Wed, 16 Apr 2008 14:10:30 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 13:59:50 -0400
Andrew Dunstan [EMAIL PROTECTED] wrote:
If you posted it last month then it was too late for the
commit-fest that started on March 1, IIRC,
Bruce Momjian wrote:
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 14:10:30 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 13:59:50 -0400
Andrew Dunstan [EMAIL PROTECTED] wrote:
If you posted it last month then it was
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 21:04:17 +0300
Heikki Linnakangas [EMAIL PROTECTED] wrote:
To quote Tom:
I think we need to be careful to distinguish three situations:
* statement_timeout during pg_dump
* statement_timeout during pg_restore
* statement_timeout during psql reading a
On Wed, 16 Apr 2008 14:13:53 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
I review it and apply or reply to the author. The wiki had
started being updated after your submission so this is a
transitionary phase.
Wait... apply where? The wiki? or to the tree?
Apply to CVS.
On Wed, 16 Apr 2008 21:20:17 +0300
Heikki Linnakangas [EMAIL PROTECTED] wrote:
My patch addresses all three, unless I am misunderstanding your
meaning. The patch does the following:
After connection with pg_dump it executes set statement_timeout = 0;
This fixed the pg_dump timeout
Andrew Dunstan wrote:
If you posted it last month then it was too late for the
commit-fest that started on March 1, IIRC, so the fact that you
didn't get feedback is hardly surprising - a commit-fest is like a
mini-feature-freeze.
O.k. then what happens at that point? It
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 14:10:30 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 13:59:50 -0400
Andrew Dunstan [EMAIL PROTECTED] wrote:
If you posted it last month then it was too late for the
commit-fest
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 14:13:53 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
I review it and apply or reply to the author. The wiki had
started being updated after your submission so this is a
transitionary phase.
Wait... apply where? The wiki? or
Bruce Momjian wrote:
Frankly, I am getting pretty tired of people complaining about what I am
doing. Perhaps I should just stop and let everyone else deal with
things. I have lots of things I would rather be doing.
This is one of the reasons I didn't want to add wiki maintenance to my
I wrote:
I realized that we failed to plug all the gaps of this type,
because relcache.c contains *internal* cache load/reload operations
that aren't protected. In particular the LOAD_CRIT_INDEX macro
calls invoke relcache load on indexes that aren't locked. So they'd
be at risk from a
Joshua D. Drake wrote:
On Wed, 16 Apr 2008 13:59:50 -0400
Andrew Dunstan [EMAIL PROTECTED] wrote:
If you posted it last month then it was too late for the commit-fest
that started on March 1, IIRC, so the fact that you didn't get
feedback is hardly surprising - a commit-fest is like a
On Wed, 16 Apr 2008 14:24:34 -0400 (EDT)
Bruce Momjian [EMAIL PROTECTED] wrote:
If you are going to review the patch and apply or reply to the
author, at one point is it supposed to be on the wiki?
I have no idea. If not dealt with, it will be on my web page once the
next commit fest
Andrew Dunstan wrote:
BTW, I don't see why the wiki can't pick up patches that were submitted
before it started.
Of course it can. This one wasn't added initially because I didn't see it.
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company
I've analysed various flavours of MERGE command to understand and
propose what we should use for PostgreSQL.
The results aren't what you'd expect from a quick flick through the
standard, so lets look at my main concerns:
1. The simplest syntax is for SQL:2003. The syntax for DB2, SQL Server
and
Peter Eisentraut wrote:
Am Dienstag, 15. April 2008 schrieb Zdenek Kotala:
JavaDB and Firebird community use Jira
Jira had already been rejected many years ago because it is not open source.
Jira is also tremendously slow. Not a good system when an individual
has to move quickly
Andrew Dunstan wrote:
Bruce Momjian wrote:
Frankly, I am getting pretty tired of people complaining about what I am
doing. Perhaps I should just stop and let everyone else deal with
things. I have lots of things I would rather be doing.
This is one of the reasons I didn't want to
[EMAIL PROTECTED] (Bruce Momjian) writes:
Chris Browne wrote:
[EMAIL PROTECTED] (Bruce Momjian) writes:
Magnus Hagander wrote:
And I think adopting surrounding naming, commeting, coding conventions
should come naturally as it can aide in copy-pasting too :)
I think pg_indent has to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thu, Apr 17, 2008 at 5:17 AM, Bruce Momjian
wrote:
Andrew Dunstan wrote:
Bruce Momjian wrote:
This is one of the reasons I didn't want to add wiki maintenance to my
already full workload. Instead I am having to field complaints.
Tom Lane wrote:
Actually ... what if the same DB OID and relfilenode get re-made before
the checkpoint? Then we'd be unlinking live data. This is improbable
but hardly less so than the scenario the PendingUnlinkEntry code was
put in to prevent.
ISTM that we must fix the bgwriter so that
On Wed, Apr 16, 2008 at 3:47 PM, Brendan Jurd [EMAIL PROTECTED] wrote:
On Thu, Apr 17, 2008 at 5:17 AM, Bruce Momjian
Andrew Dunstan wrote:
Bruce Momjian wrote:
This is one of the reasons I didn't want to add wiki maintenance to my
already full workload. Instead I am
Chris Browne wrote:
Would it be a terrible idea to...
- Draw the indent code from NetBSD into src/tools/pgindent
- Build it _in place_ inside the code tree (e.g. - don't assume
it will get installed in /usr/local/bin)
- Thus have the ability to run it in place?
Yes, but it
Brendan Jurd wrote:
OK. FYI, what would be really nice would be for someone to review and
apply the patch or give the author feedback so we could avoid adding it
to the wiki at all.
Bruce,
Yes, that would be nice! But not likely in practice, unless your
patch happens to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thu, Apr 17, 2008 at 6:03 AM, Merlin Moncure wrote:
One small point here. I've been mostly following this discussion on
this particular topic but have absolutely no idea what, if anything,
to do on the wiki in terms of submitting patch.
On Thu, 17 Apr 2008 06:19:49 +1000
Brendan Jurd [EMAIL PROTECTED] wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thu, Apr 17, 2008 at 6:03 AM, Merlin Moncure wrote:
One small point here. I've been mostly following this discussion
on this particular topic but have absolutely
Merlin Moncure wrote:
I've been mostly following this discussion on
this particular topic but have absolutely no idea what, if anything,
to do on the wiki in terms of submitting patch.
I think the short answer right now to this and to Joshua's original
question is: to submit a patch do
Hi,
I notice that while doing bulk-loads that any errors detected by the
backend arn't noticed by libpq until right at the end. Is this
intentional? Looking at the code we have this comment in putCopyData:
/*
* Process any NOTICE or NOTIFY messages that might be pending in the
* input
Martijn,
* Martijn van Oosterhout ([EMAIL PROTECTED]) wrote:
Is there anything that can be done? I've tried putting in
PQconsumeInput in places but it doesn't appear to help.
I certainly hope something can be done, I've noticed this exact same
issue myself and it's very annoying. I've
Chris Browne [EMAIL PROTECTED] writes:
Would it be a terrible idea to...
- Draw the indent code from NetBSD into src/tools/pgindent
I am not real eager to become maintainers of our own indent fork, which
is what you propose. (Just for starters, what will we have to do to
make it run on
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thu, Apr 17, 2008 at 1:16 AM, Tom Lane wrote:
Brendan Jurd writes:
If we don't want to meddle with xmltype/bytea/VarChar at all, we'll
have to revert those changes, and I'll have to seriously scale back
the cleanup patch I was about to
Martijn van Oosterhout [EMAIL PROTECTED] writes:
I notice that while doing bulk-loads that any errors detected by the
backend arn't noticed by libpq until right at the end. Is this
intentional?
I dunno about intentional, but the API exposed by libpq for COPY
doesn't really permit any other
Tom Lane wrote:
The main problem I see with pgindent early and often is that it only
works well if everyone is using exactly the same pgindent code (and
exactly the same typedef list). Otherwise you just get buried in
useless whitespace diffs.
It's bad enough that Bruce whacks around his
1 - 100 of 132 matches
Mail list logo
