Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Dimitri Fontaine
Hi, Le 2 juil. 09 à 22:20, Kevin Grittner a écrit : Here's the Makefile contents: You could compare to this: http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/backports/uuid-ossp/Makefile?rev=1.1.1.1content-type=text/x-cvsweb-markup SHLIB_LINK = -lpoppler -L/usr/local/lib SHLIB_LINK +=

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Peter Eisentraut
On Friday 03 July 2009 05:16:41 Robert Haas wrote: On Thu, Jul 2, 2009 at 3:42 PM, Zdenek Kotalazdenek.kot...@sun.com wrote: Josh Berkus píše v st 01. 07. 2009 v 17:21 -0700: Folks, There's been a lot of discussion/argument around how to handle the last commitfest, but there seems to be

[HACKERS] Provide support for multiplexing SIGUSR1 signal

2009-07-03 Thread Fujii Masao
Hi, http://archives.postgresql.org/pgsql-hackers/2009-07/msg00191.php In line with Robert's suggestion, I submit the signal multiplexing patch as self-contained one. This patch provides support for multiplexing SIGUSR1 signal. The upcoming synchronous replication patch needs a signal, but we've

[HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-03 Thread Fujii Masao
Hi, http://archives.postgresql.org/pgsql-hackers/2009-07/msg00191.php In line with Robert's suggestion, I submit non-blocking pqcomm patch as a self-contained one. This patch provides support for non-blocking communication between a frontend and a backend. The upcoming synchronous replication

[HACKERS] tsvector extraction patch

2009-07-03 Thread Hans-Juergen Schoenig -- PostgreSQL
hello, this patch has not made it through yesterday, so i am trying to send it again. i made a small patch which i found useful for my personal tasks. it would be nice to see this in 8.5. if not core then maybe contrib. it transforms a tsvector to table format which is really nice for text

Re: [HACKERS] tsvector extraction patch

2009-07-03 Thread Hans-Juergen Schoenig -- PostgreSQL
Hans-Juergen Schoenig -- PostgreSQL wrote: hello, this patch has not made it through yesterday, so i am trying to send it again. i made a small patch which i found useful for my personal tasks. it would be nice to see this in 8.5. if not core then maybe contrib. it transforms a tsvector to

Re: [HACKERS] 8.5 development schedule

2009-07-03 Thread Heikki Linnakangas
Robert Haas wrote: What I've seen of Heikki's work thus far has led me to believe that his reasons for rejecting the patch were good ones, but I don't specifically what they were. It would be helpful, I think, to reiterate them or repost links to the relevant messages in the archives; it

Re: [HACKERS] bug in Google translate snippet

2009-07-03 Thread Jan Urbański
Alvaro Herrera wrote: Andrew Dunstan wrote: Alvaro Herrera wrote: Hi, I was having a look at this snippet: http://wiki.postgresql.org/wiki/Google_Translate and it turns out that it doesn't work if the result contains non-ASCII chars. Does anybody know how to fix it? alvherre=# select

Re: [HACKERS] GRANT ON ALL IN schema

2009-07-03 Thread Petr Jelinek
Petr Jelinek wrote: So, here is the first version of the patch. Attached is v2 with slightly improved code, nothing has changed feature-wise. -- Regards Petr Jelinek (PJMODOS) diff --git a/doc/src/sgml/ref/grant.sgml b/doc/src/sgml/ref/grant.sgml index bf963b8..7ddbd25 100644 ***

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Brendan Jurd dire...@gmail.com writes: Please let us know if you encounter any problems with withe app, or have suggestions for improvement. It looks like every patch and comment is timestamped ... but with yesterday (the time of data import, I suppose). This is much worse than useless. If

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
On suggestions for improvement: I need to be able to bookmark the commitfest summary list (whichever page is equivalent to the old wiki page). The current URL seems to be http://commitfest.postgresql.org/action/commitfest_view?id=2 which is both opaque as can be and not looking like it's intended

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
I tried the New Patch Comment feature. It's absolutely horrid. I get a page showing a comment type button, one line for Message-ID, and one line for Content. No explanation of what those are, and no visibility any more of the patch I'm trying to comment on. I have no idea what I'm supposed to

Re: [HACKERS] bug in Google translate snippet

2009-07-03 Thread Jan Urbański
Alvaro Herrera wrote: Andrew Dunstan wrote: Alvaro Herrera wrote: Hi, I was having a look at this snippet: http://wiki.postgresql.org/wiki/Google_Translate and it turns out that it doesn't work if the result contains non-ASCII chars. Does anybody know how to fix it? alvherre=# select

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: On suggestions for improvement: I need to be able to bookmark the commitfest summary list (whichever page is equivalent to the old wiki page).  The current URL seems to be

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 10:40 AM, Tom Lanet...@sss.pgh.pa.us wrote: I tried the New Patch Comment feature.  It's absolutely horrid. I get a page showing a comment type button, one line for Message-ID, and one line for Content.  No explanation of what those are, and no visibility any more of the

Re: [HACKERS] [PATCH] SE-PostgreSQL Updates rev.2096

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 1:18 AM, KaiGai Koheikai...@kaigai.gr.jp wrote: OK, I'll re-organize my patch set. Please wait for a few days. Note that your patch will need to include docs and regression test updates, and those things need to be coherent with the rest of the patch. You can't submit a

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Heikki Linnakangas
Robert Haas wrote: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: On suggestions for improvement: I need to be able to bookmark the commitfest summary list (whichever page is equivalent to the old wiki page). The current URL seems to be

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: The current URL seems to be http://commitfest.postgresql.org/action/commitfest_view?id=2 which is both opaque as can be and not looking like it's intended to be stable over the long

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 10:40 AM, Tom Lanet...@sss.pgh.pa.us wrote: I tried the New Patch Comment feature.  It's absolutely horrid. I get a page showing a comment type button, one line for Message-ID, and one line for Content.  No explanation of what

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 11:46 AM, Heikki Linnakangasheikki.linnakan...@enterprisedb.com wrote: Robert Haas wrote: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: On suggestions for improvement: I need to be able to bookmark the commitfest summary list (whichever page is

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Also, the recommendation to specify prefix here is redundant and error-prone. It can get the correct prefix from pg_config. Again, see my email just posted about using pg_migrator in a multi-pg_config-binary environment. What's your

Re: [HACKERS] 8.5 development schedule

2009-07-03 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Robert Haas wrote: What I've seen of Heikki's work thus far has led me to believe that his reasons for rejecting the patch were good ones, but I don't specifically what they were. It would be helpful, I think, to reiterate them

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Also, the recommendation to specify prefix here is redundant and error-prone. It can get the correct prefix from pg_config. Again, see my email just posted about using pg_migrator in a multi-pg_config-binary

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: (Although actually, if that pg_config isn't in your path, the installed pg_migrator won't be either. It might be better to just say fix things so that the new installation's executables are first in your PATH, and be done with it.) I

Re: [HACKERS] single bit integer (TINYINT) revisited for 8.5

2009-07-03 Thread Robert Treat
On Thursday 02 July 2009 12:40:49 Simon Riggs wrote: On Wed, 2009-07-01 at 11:19 -0400, Caleb Cushing wrote: A couple of times I've been told you don't need tinyint, use boolean which is not true, several projects I've worked on I've needed and integer field that supports number within a

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-03 Thread Zdenek Kotala
Tom Lane píše v čt 02. 07. 2009 v 13:13 -0400: Actually, most of the buildfarm members show which flex version they are running in the configure output. A quick look shows that of the 45 members that have reported on HEAD in the past 2 days, 22 are running 2.5.4, which is a lot higher

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Treat
On Friday 03 July 2009 11:50:29 Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: The current URL seems to be http://commitfest.postgresql.org/action/commitfest_view?id=2 which is both opaque as can be and not

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Joshua D. Drake
On Fri, 2009-07-03 at 14:06 -0400, Robert Treat wrote: On Friday 03 July 2009 11:50:29 Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: The current URL seems to be

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: (Although actually, if that pg_config isn't in your path, the installed pg_migrator won't be either. It might be better to just say fix things so that the new installation's executables are first in your PATH, and

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Kevin Grittner
I cleaned up the poppler build situation, and all looks good except: Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: PG_CPPFLAGS =-I/usr/include/poppler -shared -fpic It doesn't seem appropriate to put -shared or -fpic into PG_CPPFLAGS. If you need

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Alvaro Herrera
Bruce Momjian wrote: I am happy to remove the USE_PGXS from the Makefile, but it seems all the other extensions require that so I want to be consistent. Consistency here is pointless. IIRC the dual method is used in contrib because people did not trust the PGXS stuff enough to rip the

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 11:50 AM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: The current URL seems to be http://commitfest.postgresql.org/action/commitfest_view?id=2 which is both opaque as can

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Leaving off -shared was OK, but when I left off -fpic, I got this: /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../x86_64-suse-linux/bin/ld: poppler_compat.o: relocation R_X86_64_32 against `a local symbol' can not be used when making a

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 2:10 PM, Joshua D. Drakej...@commandprompt.com wrote: O.k. I am probably blowing something out of the water here but do we need yet another domain? Because it's installed on a different VM and I don't want to move it just to make the URL look different? ...Robert --

Re: [HACKERS] 8.5 development schedule

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 1:16 PM, Tom Lanet...@sss.pgh.pa.us wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Robert Haas wrote: What I've seen of Heikki's work thus far has led me to believe that his reasons for rejecting the patch were good ones, but I don't specifically

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: What do you get? sed 's,MODULE_PATHNAME,$libdir/adminpack,g' adminpack.sql.in adminpack.sql gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -g -fpic

Re: [HACKERS] Have \d show child tables that inherit from the specified parent

2009-07-03 Thread Peter Eisentraut
On Sunday 10 May 2009 03:05:48 dam...@dalibo.info wrote: Here's a second version. Main changes are : * Child tables are sorted by name * \d only shows the number of child tables * \d+ shows the full list Committed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Andrew Chernow
Robert Treat wrote: On Friday 03 July 2009 11:50:29 Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 10:35 AM, Tom Lanet...@sss.pgh.pa.us wrote: The current URL seems to be http://commitfest.postgresql.org/action/commitfest_view?id=2 which is both opaque as can

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: What do you get? More to the point, here's what I get when I use PGXS with my pdf code. sed 's,MODULE_PATHNAME,$libdir/pdftotext,g' pdftotext.sql.in pdftotext.sql gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:00 PM, Andrew Chernowa...@esilo.com wrote: The current URL seems to be http://commitfest.postgresql.org/action/commitfest_view?id=2 which is both opaque as can be and not looking like it's intended to be stable over the long term. I'm not sure why you would think

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Dimitri Fontaine
Hi, Le 3 juil. 09 à 20:44, Robert Haas a écrit : - Adding stable links with mnemonic names for the open, in progress, and most recently closed commitfests. May I suggest something looking about like: http://commitfest.postgresql.org/current http://commitfest.postgresql.org/open

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: What does pg_config report for the various FLAGS variables? CPPFLAGS = -D_GNU_SOURCE -I/usr/include/libxml2 CFLAGS = -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Since the gcc line has it, it must be the g++ line that's the problem? Hmm, try adding CXXFLAGS = $(CFLAGS) Although in general we don't try very hard to support C++ code inside the backend. regards, tom lane

Re: [HACKERS] SQL state in log_line_prefix

2009-07-03 Thread Peter Eisentraut
On Sunday 10 May 2009 15:32:26 Guillaume Smet wrote: I attached a patch which allows to add the SQL state code into the log_line_prefix. I used %e (as in error) as %s is already used. Committed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Andrew Chernow
I *am* using some kind of key. Specifically, in integer derived from a serial column. It's just as stable as 16 random bytes displayed in hex, but a lot shorter and easier to remember, if you're the sort of person who likes to remember URLs. :-) Wasn't aware of exately what you were doing.

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Zdenek Kotala
Peter Eisentraut píše v pá 03. 07. 2009 v 09:19 +0300: On Friday 03 July 2009 05:16:41 Robert Haas wrote: On Thu, Jul 2, 2009 at 3:42 PM, Zdenek Kotalazdenek.kot...@sun.com wrote: Josh Berkus píše v st 01. 07. 2009 v 17:21 -0700: Folks, There's been a lot of discussion/argument

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Consistency here is pointless. IIRC the dual method is used in contrib because people did not trust the PGXS stuff enough to rip the original Make code out; or maybe because people did not want PGXS to become the default build method, but they

Re: [HACKERS] PGXS problem with pdftotext

2009-07-03 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Hmm, try adding CXXFLAGS = $(CFLAGS) Thanks, that worked; I don't need to specify -fpic in my file if I put the above line in. Although in general we don't try very hard to support C++ code inside the backend. I try to avoid it when possible.

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Zdenek Kotala
Robert Haas píše v čt 02. 07. 2009 v 22:16 -0400: On Thu, Jul 2, 2009 at 3:42 PM, Zdenek Kotalazdenek.kot...@sun.com wrote: Also, how would we handle changes by committers, who don't always go through the CommitFest process? I think that all head patches should go to through a new tool for

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:08 PM, Dimitri Fontainedfonta...@hi-media.com wrote: Your software seems to be better than a wiki, but its potential users are expressing needs and bikescheding. I think you'd better accept both kind of changes as long as it's not making your life much harder than you'd

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:15 PM, Andrew Chernowa...@esilo.com wrote: I *am* using some kind of key.  Specifically, in integer derived from a serial column.  It's just as stable as 16 random bytes displayed in hex, but a lot shorter and easier to remember, if you're the sort of person who likes

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Backing up for a moment to ten thousand feet here, I posted a link to this web app on May 26th. I received several comments on it, all of them positive, including some constructive feedback from you which I took to heart. It is now July 1st, and I am

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Bruce Momjian
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Consistency here is pointless. IIRC the dual method is used in contrib because people did not trust the PGXS stuff enough to rip the original Make code out; or maybe because people did not want PGXS to become the default

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:27 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Backing up for a moment to ten thousand feet here, I posted a link to this web app on May 26th.  I received several comments on it, all of them positive, including some constructive

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: I think it IS newest at the bottom, and I agree that that is how it should be. It seems to be inconsistent. Probably because everything wound up with the same date, the order is probably more-or-less random. What are the chances that the date or

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Robert Haas robertmh...@gmail.com wrote: I think it IS newest at the bottom, and I agree that that is how it should be. It seems to be inconsistent. Probably because everything wound up with the same date, the order is probably

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Currently, it seems that most or all of the entries are links to archived messages. Scraping the date from the underlying message would be the best thing. Just for purposes of conversion, or as a long-term behavior? -Kevin -- Sent via pgsql-hackers

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Kevin Grittner
Dickson S. Guedes lis...@guedesoft.net wrote: pgcommitfest tables sctructure [1]? [1] http://git.postgresql.org/gitweb?p=pgcommitfest.git;a=blob;f=etc/table.sql;h=c60a298c863ef3e88dcfd16572781d2b435ca629;hb=HEAD On minor quibble with this schema: I believe that session.login_time

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: Currently, it seems that most or all of the entries are links to archived messages. Scraping the date from the underlying message would be the best thing. Just for purposes of conversion, or as a

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: And please make Delete Patch into a button instead of a link. Only if there's some kind of confirmation ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Peter Eisentraut
On Friday 03 July 2009 07:57:35 Robert Haas wrote: We're still hacking on a few other details of the formatting and interface, but you might want to cruise over and have a look. One thing that I noticed it that it takes too many clicks in general to make a set of changes. When I look at a

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Joshua D. Drake
On Fri, 2009-07-03 at 16:54 -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: And please make Delete Patch into a button instead of a link. Only if there's some kind of confirmation ... Should we actually delete patches? I get removing them from the list but it seems there

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:22 PM, Zdenek Kotalazdenek.kot...@sun.com wrote: Robert Haas píše v čt 02. 07. 2009 v 22:16 -0400: On Thu, Jul 2, 2009 at 3:42 PM, Zdenek Kotalazdenek.kot...@sun.com wrote: Also, how would we handle changes by committers, who don't always go through the CommitFest

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 5:49 PM, Joshua D. Drakej...@commandprompt.com wrote: On Fri, 2009-07-03 at 16:54 -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: And please make Delete Patch into a button instead of a link. Only if there's some kind of confirmation ... Should we

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Joshua D. Drake
On Fri, 2009-07-03 at 17:57 -0400, Robert Haas wrote: I guess I'm not really seeing why that particular thing should be a button rather than a link. It would mess up the formatting for no obvious benefit. Not arguing one way or the other, a button says, I am about to perform X. A link

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 6:19 PM, Joshua D. Drakej...@commandprompt.com wrote: On Fri, 2009-07-03 at 17:57 -0400, Robert Haas wrote: I guess I'm not really seeing why that particular thing should be a button rather than a link.  It would mess up the formatting for no obvious benefit. Not

Re: [HACKERS] SQL state in log_line_prefix

2009-07-03 Thread Guillaume Smet
On Fri, Jul 3, 2009 at 9:14 PM, Peter Eisentrautpete...@gmx.net wrote: On Sunday 10 May 2009 15:32:26 Guillaume Smet wrote: I attached a patch which allows to add the SQL state code into the log_line_prefix. I used %e (as in error) as %s is already used. Committed. Thanks Peter. --

Re: [HACKERS] pg_migrator mention in documentation

2009-07-03 Thread Joe Conway
Bruce Momjian wrote: Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Consistency here is pointless. IIRC the dual method is used in contrib because people did not trust the PGXS stuff enough to rip the original Make code out; or maybe because people did not want PGXS to

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Ron Mayer
Josh Berkus wrote: Folks,...the first CF on July 15th. Would it make the CommitFest easier if there were an additional column which indicates what CVS-version of Postgres the patch cleanly applies to? Perhaps a patch submitter could indicate the CVS date/time with which he developed the

Re: [HACKERS] First CommitFest: July 15th

2009-07-03 Thread Andrew Dunstan
Ron Mayer wrote: Josh Berkus wrote: Folks,...the first CF on July 15th. Would it make the CommitFest easier if there were an additional column which indicates what CVS-version of Postgres the patch cleanly applies to? Perhaps a patch submitter could indicate the CVS date/time with which he

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:40 PM, Robert Haasrobertmh...@gmail.com wrote: I accept the need for and am willing to make the following changes: - Changing the patch comment field from type text to type textarea and integrating it into the patch view page to provide context. - Adding a note to the

Re: [HACKERS] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 4:43 PM, Peter Eisentrautpete...@gmx.net wrote: On Friday 03 July 2009 07:57:35 Robert Haas wrote: We're still hacking on a few other details of the formatting and interface, but you might want to cruise over and have a look. One thing that I noticed it that it takes

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Robert Haas
On Fri, Jul 3, 2009 at 4:00 PM, Tom Lanet...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Robert Haas robertmh...@gmail.com wrote: I think it IS newest at the bottom, and I agree that that is how it should be. It seems to be inconsistent.  Probably because

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Brendan Jurd
2009/7/4 Robert Haas robertmh...@gmail.com: On Fri, Jul 3, 2009 at 4:00 PM, Tom Lanet...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: What are the chances that the date or timestamp of the corresponding wiki modification could be put onto the patch and comment

[HACKERS] Round-Robin Reviewers Needed

2009-07-03 Thread Robert Haas
All, We are very much in need of round-robin reviewers for the next CommitFest. If you're wondering whether you are qualified to be a round-robin reviewer, the answer is almost certainly yes. In fact, there's a good chance that the answer is yes even if you are pretty sure you aren't qualified.

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Jul 3, 2009 at 4:00 PM, Tom Lanet...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: It seems to be inconsistent.  Probably because everything wound up with the same date, the order is probably more-or-less random.

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-03 Thread Brendan Jurd
2009/7/4 Tom Lane t...@sss.pgh.pa.us: No, what we're complaining about is the ordering of comments for a single patch. Now moot, since I've successfully pulled the dates for all comments with a message-id from the archives, and updated the database accordingly. Cheers, BJ -- Sent via