Re: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-01-25 Thread Leonardo F
Rule it out. Note you should be looking at pg_am.amcanorder, not hardwiring knowledge of particular index types. Sorry, I replied ok too fast... I can look at pg_am.amcanorder, but I would still need the ScanKey to be used by tuplesort; and I can't find any other way of doing it than

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Simon Riggs
On Mon, 2010-01-25 at 09:52 +0200, Heikki Linnakangas wrote: Simon Riggs wrote: On Sat, 2010-01-23 at 21:40 +, Greg Stark wrote: On Sat, Jan 23, 2010 at 8:28 PM, Simon Riggs si...@2ndquadrant.com wrote: What is your proposed way of handling buffer pin deadlocks? That will be

Re: [HACKERS] default_language

2010-01-25 Thread Simon Riggs
On Mon, 2010-01-25 at 09:08 +0200, Peter Eisentraut wrote: On sön, 2010-01-24 at 20:32 +, Simon Riggs wrote: Why do we have a parameter called default_do_language when we don't have a parameter called default_language? According to the SQL standard, the default language for CREATE

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Heikki Linnakangas
Simon Riggs wrote: On Mon, 2010-01-25 at 09:52 +0200, Heikki Linnakangas wrote: Would this simple scheme work: When the startup process has waited for a short while (ie deadlock_timeout), it sends the signal please check if you're holding a pin on buffer X to all backends. When a backend

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Heikki Linnakangas
Heikki Linnakangas wrote: Simon Riggs wrote: On Mon, 2010-01-25 at 09:52 +0200, Heikki Linnakangas wrote: Would this simple scheme work: When the startup process has waited for a short while (ie deadlock_timeout), it sends the signal please check if you're holding a pin on buffer X to all

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Simon Riggs
On Mon, 2010-01-25 at 10:59 +0200, Heikki Linnakangas wrote: Heikki Linnakangas wrote: Simon Riggs wrote: On Mon, 2010-01-25 at 09:52 +0200, Heikki Linnakangas wrote: Would this simple scheme work: When the startup process has waited for a short while (ie deadlock_timeout), it sends

Re: [HACKERS] Streaming replication and a disk full in primary

2010-01-25 Thread Fujii Masao
Thanks for the review! And, sorry for the delay. On Thu, Jan 21, 2010 at 11:10 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I don't think we should do the check XLogWrite(). There's really no reason to kill the standby connections before the next checkpoint, when the old

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Peter Eisentraut
On sön, 2010-01-24 at 21:29 -0800, Scott Bailey wrote: I think listagg or string_agg would be the most appropriate names. Oh and before Oracle had wm_concat, Tom Kyte wrote a function called stragg that was pretty popular. Well, xmlagg - concatenates values to form xml datum array_agg -

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Pavel Stehule
2010/1/25 Peter Eisentraut pete...@gmx.net: On sön, 2010-01-24 at 21:29 -0800, Scott Bailey wrote: I think listagg or string_agg would be the most appropriate names. Oh and before Oracle had wm_concat, Tom Kyte wrote a function called stragg that was pretty popular. Well, xmlagg -

Re: [HACKERS] pg_listener entries deleted under heavy NOTIFY load only on Windows

2010-01-25 Thread Craig Ringer
On 23/01/2010 5:30 AM, Radu Ilie wrote: On a Windows server under heavy load of NOTIFY events, entries in pg_listener table for some events are deleted. It is like UNLISTEN was called. This has been reported on -general, then -bugs, now -hackers, and seems to just get ignored. The poster has

Re: [HACKERS] quoting psql varible as identifier

2010-01-25 Thread Pavel Stehule
Hello I hope, so this version is more readable and more clean. I removed some not necessary checks. regards Pavel 2010/1/22 Robert Haas robertmh...@gmail.com: On Fri, Jan 22, 2010 at 7:19 AM, Pavel Stehule pavel.steh...@gmail.com wrote: here is new variant. Add scan_state flag valid and

Re: [HACKERS] pg_listener entries deleted under heavy NOTIFY load only on Windows

2010-01-25 Thread Stefan Kaltenbrunner
Craig Ringer wrote: On 23/01/2010 5:30 AM, Radu Ilie wrote: On a Windows server under heavy load of NOTIFY events, entries in pg_listener table for some events are deleted. It is like UNLISTEN was called. This has been reported on -general, then -bugs, now -hackers, and seems to just get

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: 2010/1/25 Peter Eisentraut pete...@gmx.net: xmlagg - concatenates values to form xml datum array_agg - concatenates values to form array datum ??? - concatenates values to form string datum So it's pretty clear that listagg does not fit into

[HACKERS] Fwd: Questions about connection clean-up and invalid page header

2010-01-25 Thread Greg Stark
Given this thread on pgsql-general I wonder if we should have something like 1 in every 1,000 CHECK_FOR_INTERRUPTS check if the client socket is still open. This has come up in the past and the concern was that syscalls would be way too slow to put in critical loops but perhaps if it's only done

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Pavel Stehule
2010/1/25 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: 2010/1/25 Peter Eisentraut pete...@gmx.net: xmlagg - concatenates values to form xml datum array_agg - concatenates values to form array datum ??? - concatenates values to form string datum So it's pretty

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Heikki Linnakangas
Simon Riggs wrote: It's clearly a lower priority than other code based upon feedback from the Hot Standby user group. What's the the Hot Standby user group? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Simon Riggs
On Mon, 2010-01-25 at 16:22 +0200, Heikki Linnakangas wrote: Simon Riggs wrote: It's clearly a lower priority than other code based upon feedback from the Hot Standby user group. What's the the Hot Standby user group? A group of people who have an interest in using Hot Standby, as

Re: [HACKERS] default_language

2010-01-25 Thread Robert Haas
On Mon, Jan 25, 2010 at 3:55 AM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-01-25 at 09:08 +0200, Peter Eisentraut wrote: On sön, 2010-01-24 at 20:32 +, Simon Riggs wrote: Why do we have a parameter called default_do_language when we don't have a parameter called

Re: [HACKERS] default_language

2010-01-25 Thread Simon Riggs
On Mon, 2010-01-25 at 09:30 -0500, Robert Haas wrote: +1 for removing default_do_language, too. +1 for removing default_do_language OR adding default_language. I prefer a hard-wired default of PLpgSQL, so a missing language statement on a DO block is always interpreted the same. -- Simon

Re: [HACKERS] default_language

2010-01-25 Thread Bernd Helmle
--On 25. Januar 2010 09:30:56 -0500 Robert Haas robertmh...@gmail.com wrote: This will turn into another setting like search_path and standard_conforming_strings that can break working code if the actual value doesn't match the anticipated value. I can't figure out why someone would want

Re: [HACKERS] pg_listener entries deleted under heavy NOTIFY load only on Windows

2010-01-25 Thread Magnus Hagander
On Monday, January 25, 2010, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: Craig Ringer wrote: On 23/01/2010 5:30 AM, Radu Ilie wrote: On a Windows server under heavy load of NOTIFY events, entries in pg_listener table for some events are deleted. It is like UNLISTEN was called.

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Pavel Stehule
2010/1/25 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: 2010/1/25 Peter Eisentraut pete...@gmx.net: xmlagg - concatenates values to form xml datum array_agg - concatenates values to form array datum ??? - concatenates values to form string datum So it's pretty

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Pavel Stehule
2010/1/24 Tom Lane t...@sss.pgh.pa.us: Simon Riggs si...@2ndquadrant.com writes: On Fri, 2010-01-22 at 11:14 -0800, David E.Wheeler wrote: No performance issues ISTM that this class of function is inherently dangerous performance wise. * It looks incredibly easy to construct enormous

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Cédric Villemain
2010/1/25 Baron Schwartz ba...@xaprb.com: Hi Cédric, On Sun, Jan 24, 2010 at 5:11 PM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 'psql --help mysql' (or 'psql --tips mysql' ) might be good to call a special helper : I don't see the point to introduce that kind of things when

[HACKERS] problem with CVS on pgfoundry

2010-01-25 Thread Pavel Stehule
Hello I can't to create module on pgfoundry. It is probably access denied problem. Can somebody help me with this? [pa...@nemesis pstcoll]$ cvs -d :ext:ok...@cvs.pgfoundry.org:/cvsroot/pstcollection import pstcoll no-vendor initial-release Password: Cannot access /cvsroot/pstcollection/CVSROOT

Re: [HACKERS] Syntax supplements for SET options

2010-01-25 Thread Robert Haas
On Sun, Jan 24, 2010 at 9:16 PM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: I found a couple of incomplete syntax when I was adjusting psql automatic tab completion for HEAD. So, I'm slightly confused about whether you want to fix tab completion or behavior, but... 1. We cannot

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-25 Thread Robert Haas
2010/1/25 KaiGai Kohei kai...@ak.jp.nec.com: Or, are you saying to test diamond-inheritance cases? Please go back and read the test case that I already proposed. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Miscellaneous changes to plperl [PATCH]

2010-01-25 Thread Tim Bunce
On Sat, Jan 23, 2010 at 06:40:03PM -0700, Alex Hunsaker wrote: On Sat, Jan 23, 2010 at 16:16, Tim Bunce tim.bu...@pobox.com wrote: On Fri, Jan 22, 2010 at 08:59:10PM -0700, Alex Hunsaker wrote: On Thu, Jan 14, 2010 at 09:07, Tim Bunce tim.bu...@pobox.com wrote: I'd vote for use warnings; as

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Alastair Bell Turner
If this option is designed to help people's transition - basically to get to them before they've got to most of the manual - having to turn it on will be pointless. It needs to be active by default. A way to avoid it being a default option in psql may be setting an alias as part of package

Re: [HACKERS] Miscellaneous changes to plperl [PATCH]

2010-01-25 Thread Andrew Dunstan
Tim Bunce wrote: FYI I've an updated patch ready but I'll wait till the commitfest has got 'closer' as there's a fair chance a further update will be needed anyway to make a patch that applies cleanly. I want to deal with this today or tomorrow, so don't sit on it, please. cheers

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-25 Thread Bernd Helmle
--On 25. Januar 2010 11:39:21 +0900 KaiGai Kohei kai...@ak.jp.nec.com wrote: (echo CREATE TABLE t (a int); for i in `seq 0 9`; do echo CREATE TABLE s$i (b int) INHERITS(t); for j in `seq 0 9`; do echo CREATE TABLE v$i$j (c int) INHERITS(s$i); for k in `seq 0 9`;

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Aidan Van Dyk
* Alastair Bell Turner thebellh...@gmail.com [100125 11:07]: If this option is designed to help people's transition - basically to get to them before they've got to most of the manual - having to turn it on will be pointless. It needs to be active by default. A way to avoid it being a default

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Andrew Dunstan
Alastair Bell Turner wrote: If this option is designed to help people's transition - basically to get to them before they've got to most of the manual - having to turn it on will be pointless. It needs to be active by default. My problem with this whole idea is that it seems to be very

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Alastair Bell Turner
On Mon, Jan 25, 2010 at 6:14 PM, Andrew Dunstan and...@dunslane.net wrote: My problem with this whole idea is that it seems to be very MySQL-specific. Why aren't we providing help for users migrating from Oracle, Sybase, Informix, Ingres, DB2, SQLServer and Firebird, to name but a few? And if

[HACKERS] A Plea to Patchers

2010-01-25 Thread David Fetter
Folks, When sending a patch, please frame and describe it with a simple declarative sentence, or at most a short paragraph. If English is not your preferred language, I can edit what you send. In extreme cases, I can get it translated. For examples of this kind of clear message, please refer

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Robert Haas
On Mon, Jan 25, 2010 at 11:14 AM, Andrew Dunstan and...@dunslane.net wrote: Alastair Bell Turner wrote: If this option is designed to help people's transition - basically to get to them before they've got to most of the manual - having to turn it on will be pointless. It needs to be active by

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Ross J. Reedstrom
On Mon, Jan 25, 2010 at 06:06:53PM +0200, Alastair Bell Turner wrote: .. without having to add a switch to their command lines. It's not going to have anything to say to experienced psql users anyway so it would probably not bug anyone enough to turn it off. I would so use this feature going

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-25 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: It might be better to try a test case with lighter-weight objects, say 5 million simple functions. A dump of that quickly settled into running a series of these: SELECT proretset, prosrc, probin, pg_catalog.pg_get_function_arguments(oid) AS funcargs,

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Ross J. Reedstrom
On Mon, Jan 25, 2010 at 10:49:55AM -0600, Ross J. Reedstrom wrote: On Mon, Jan 25, 2010 at 06:06:53PM +0200, Alastair Bell Turner wrote: .. without having to add a switch to their command lines. It's not going to have anything to say to experienced psql users anyway so it would probably

Re: [HACKERS] commit fests

2010-01-25 Thread Greg Smith
Kevin Grittner wrote: Other posts have suggested that review fests might be helpful in this period. Again, it sounds to me, from other posts on this thread, as though the primary risk is that people working on the release could see something they couldn't resist getting drawn into -- taking

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Greg Smith
Ross J. Reedstrom wrote: So a quick mapping of most-needed commands, and a pointer to the docs for the full ramifications and subtle differences seems to fit the existing documentation module. And that's been done at least twice already:

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Bruce Momjian
Ross J. Reedstrom wrote: On Mon, Jan 25, 2010 at 06:06:53PM +0200, Alastair Bell Turner wrote: .. without having to add a switch to their command lines. It's not going to have anything to say to experienced psql users anyway so it would probably not bug anyone enough to turn it off. I

Re: [HACKERS] commit fests

2010-01-25 Thread Kevin Grittner
Greg Smith g...@2ndquadrant.com wrote: Kevin Grittner wrote: Other posts have suggested that review fests might be helpful in this period. Again, it sounds to me, from other posts on this thread, as though the primary risk is that people working on the release could see something they

[HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Selena Deckelmann
Hi! I poked around a little at pg_standby because of some 'cp: file does not exist' errors that were cropping up as pg_standby searched around for .history files. I added a stat that still outputs debugging information but now we don't get cp failures, and then added a 'progress' mode. It was a

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Baron Schwartz
Hi Robert, On Mon, Jan 25, 2010 at 11:41 AM, Robert Haas robertmh...@gmail.com wrote: Maybe instead of (or in addition to) providing MySQL-specific help, we should find a way to emphasize the \d and \d table commands, Right, it's like cd and ls at the shell prompt. It's like walking into a

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-25 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: It might be better to try a test case with lighter-weight objects, say 5 million simple functions. Said dump ran in about 45 minutes with no obvious stalls or problems. The 2.2 GB database dumped to a 1.1 GB text file, which was a little bit of a

Re: [HACKERS] ECPG patch 4.1, out-of-scope cursor support in native mode

2010-01-25 Thread Michael Meskes
On Sun, Jan 24, 2010 at 07:25:24PM +0100, Boszormenyi Zoltan wrote: The problem that popped up first was that adjust_informix() didn't properly deal with structs, remember? I tried some Yes, that's what made me wondering. i.e. IIRC in some cases adjust_informix() was bypassed and the

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Robert Haas
On Mon, Jan 25, 2010 at 1:05 PM, Baron Schwartz ba...@xaprb.com wrote: Hi Robert, On Mon, Jan 25, 2010 at 11:41 AM, Robert Haas robertmh...@gmail.com wrote: Maybe instead of (or in addition to) providing MySQL-specific help, we should find a way to emphasize the \d and \d table commands,

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-25 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: It might be better to try a test case with lighter-weight objects, say 5 million simple functions. Said dump ran in about 45 minutes with no obvious stalls or problems. The 2.2 GB database dumped to a

Re: [HACKERS] Fwd: Questions about connection clean-up and invalid page header

2010-01-25 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: Given this thread on pgsql-general I wonder if we should have something like 1 in every 1,000 CHECK_FOR_INTERRUPTS check if the client socket is still open. ... and do what? If so, why? regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] Syntax supplements for SET options

2010-01-25 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I don't think we can change this because ALTER COLUMN SET STATISTICS is not new in 8.5. We added (and then removed) ALTER COLUMN SET STATISTICS DISTINCT, but that's not the same thing. What we COULD do is add a column option called statistics_target

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Josh Berkus
On 1/25/10 9:45 AM, Selena Deckelmann wrote: Hi! I poked around a little at pg_standby because of some 'cp: file does not exist' errors that were cropping up as pg_standby searched around for .history files. I added a stat that still outputs debugging information but now we don't get cp

Re: [HACKERS] problem with CVS on pgfoundry

2010-01-25 Thread Josh Berkus
On 1/25/10 7:47 AM, Pavel Stehule wrote: Hello I can't to create module on pgfoundry. It is probably access denied problem. Can somebody help me with this? [pa...@nemesis pstcoll]$ cvs -d :ext:ok...@cvs.pgfoundry.org:/cvsroot/pstcollection import pstcoll no-vendor initial-release

Re: [HACKERS] commit fests

2010-01-25 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Issues that are discussed and resolved in that forum will very possibly get brought up again on -hackers and reach a different conclusion the second time around. Now if people are OK with that, maybe it's OK I would expect that. Heck, people get

Re: [HACKERS] problem with CVS on pgfoundry

2010-01-25 Thread Magnus Hagander
2010/1/25 Josh Berkus j...@agliodbs.com: On 1/25/10 7:47 AM, Pavel Stehule wrote: Hello I can't to create module on pgfoundry. It is probably access denied problem. Can somebody help me with this?  [pa...@nemesis pstcoll]$ cvs -d :ext:ok...@cvs.pgfoundry.org:/cvsroot/pstcollection import  

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-25 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Did you happen to notice anything about pg_dump's memory consumption? Not directly, but I was running 'vmstat 1' throughout. Cache space dropped about 2.1 GB while it was running and popped back up to the previous level at the end. -Kevin -- Sent via

Re: [HACKERS] MySQL-ism help patch for psql

2010-01-25 Thread Josh Berkus
My problem with this whole idea is that it seems to be very MySQL-specific. Why aren't we providing help for users migrating from Oracle, Sybase, Informix, Ingres, DB2, SQLServer and Firebird, to name but a few? And if we turn all those on by default, we'll have a pretty horrible banner when

Re: [HACKERS] Re: pgsql: In HS, Startup process sets SIGALRM when waiting for buffer pin.

2010-01-25 Thread Josh Berkus
A group of people who have an interest in using Hot Standby, as advertised on postgresql.org and Weekly News. There are pg users who won't be using HS/SR? ;-) --Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-25 Thread Josh Berkus
All, Please rename this thread. I think that several people to whom it's relevant aren't replying to it because of the deceptive name. Thanks. --Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] ECPG patch 4.1, out-of-scope cursor support in native mode

2010-01-25 Thread Boszormenyi Zoltan
Michael Meskes írta: On Sun, Jan 24, 2010 at 07:25:24PM +0100, Boszormenyi Zoltan wrote: The problem that popped up first was that adjust_informix() didn't properly deal with structs, remember? I tried some Yes, that's what made me wondering. i.e. IIRC in some cases

Re: [HACKERS] handling contrib directories as modules not shared libraries

2010-01-25 Thread Josh Berkus
On 1/23/10 5:00 PM, Brook Milligan wrote: It seems that src/Makefile.shlib has special cases for several directories that build loadable modules rather than shared libraries. The contrib/adminpack is one of the special cases, but none of the other contrib directories are. As a result, they

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-25 Thread Joshua D. Drake
On Mon, 2010-01-25 at 10:50 -0800, Josh Berkus wrote: All, Please rename this thread. I think that several people to whom it's relevant aren't replying to it because of the deceptive name. Thanks. Except that it is. This thread was about whether or not, Mammoth would be considered to be

Re: [HACKERS] ECPG patch 4.1, out-of-scope cursor support in native mode

2010-01-25 Thread Michael Meskes
On Mon, Jan 25, 2010 at 07:52:05PM +0100, Boszormenyi Zoltan wrote: But considering all the above, we might not need the new compat_informix/struct.pgc regression test. I think it was tested already in e.g. preproc/array_of_struct.pgc and preproc/type.pgc and the new feature (if accepted) is a

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-25 Thread Kevin Grittner
Kevin Grittner kevin.gritt...@wicourts.gov wrote: Tom Lane t...@sss.pgh.pa.us wrote: Did you happen to notice anything about pg_dump's memory consumption? Not directly, but I was running 'vmstat 1' throughout. Cache space dropped about 2.1 GB while it was running and popped back up to

Re: [HACKERS] plpython3 perf

2010-01-25 Thread Joshua D. Drake
On Wed, 2010-01-20 at 19:32 -0700, James William Pye wrote: Apologies ahead of time for the lack pretty graphs. =) I used two different builds/installations of PG to test as the PL names conflict. Both were compiled with the following CFLAGS(pg_config output): -O2 -Wall

Re: [HACKERS] ECPG patch 4.1, out-of-scope cursor support in native mode

2010-01-25 Thread Boszormenyi Zoltan
Michael Meskes írta: On Mon, Jan 25, 2010 at 07:52:05PM +0100, Boszormenyi Zoltan wrote: But considering all the above, we might not need the new compat_informix/struct.pgc regression test. I think it was tested already in e.g. preproc/array_of_struct.pgc and preproc/type.pgc and the new

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread David E. Wheeler
On Jan 25, 2010, at 2:09 AM, Peter Eisentraut wrote: xmlagg - concatenates values to form xml datum array_agg - concatenates values to form array datum ??? - concatenates values to form string datum concat_agg(). David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread David E. Wheeler
On Jan 25, 2010, at 6:12 AM, Pavel Stehule wrote: I am not happy, I thing so we do bigger chaos then it is. But it hasn't progress. So I agree with name string_agg. In this case isn't a problem rename this function if somebody would. Could you not use CREATE AGGREGATE to create an alias named

Re: [HACKERS] Miscellaneous changes to plperl [PATCH]

2010-01-25 Thread Tim Bunce
On Mon, Jan 25, 2010 at 11:09:12AM -0500, Andrew Dunstan wrote: Tim Bunce wrote: FYI I've an updated patch ready but I'll wait till the commitfest has got 'closer' as there's a fair chance a further update will be needed anyway to make a patch that applies cleanly. I want to deal with

Re: [HACKERS] Largeobject Access Controls (r2460)

2010-01-25 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Kevin Grittner kevin.gritt...@wicourts.gov wrote: Tom Lane t...@sss.pgh.pa.us wrote: Did you happen to notice anything about pg_dump's memory consumption? I took a closer look, and there's some bad news, I think. The above numbers were

[HACKERS] C function accepting/returning cstring vs. text

2010-01-25 Thread Ivan Sergio Borgonovo
I'm having a hard time trying to understand how everything should be done in C extensions. Now I'm trying to understand how and when I should accept/return cstring vs text and if and how I should take care of any encoding. I'm trying to output the content of a tsvector as a set of record pos,

Re: [HACKERS] Review: Typed Table

2010-01-25 Thread Peter Eisentraut
On tis, 2010-01-19 at 01:01 +0900, Hitoshi Harada wrote: I reviewed this patch today. Thank you for this very thorough and helpful review. Comments below and a new patch attached. * in namespace.c I didn't see why this file has been changed. case 0:

Re: [HACKERS] Package namespace and Safe init cleanup for plperl [PATCH]

2010-01-25 Thread Tim Bunce
On Fri, Jan 15, 2010 at 04:02:02AM +, Tim Bunce wrote: This is the final plperl patch in the series from me. Changes in this patch: - Moved internal functions out of main:: namespace into PostgreSQL::InServer and PostgreSQL::InServer::safe - Restructured Safe compartment setup

Re: [HACKERS] Review: listagg aggregate

2010-01-25 Thread Robert Haas
On Mon, Jan 25, 2010 at 2:27 PM, David E. Wheeler da...@kineticode.com wrote: On Jan 25, 2010, at 2:09 AM, Peter Eisentraut wrote: xmlagg - concatenates values to form xml datum array_agg - concatenates values to form array datum ??? - concatenates values to form string datum concat_agg().

[HACKERS] default pg_hba.conf tabulation

2010-01-25 Thread Peter Eisentraut
When editing pg_hba.conf, I often instinctively try to use tabs, only to be slightly annoyed because that barely doesn't work out relative to the default entries, because those are aligned at column 0, 8, 20, 32, 54: # TYPE DATABASEUSERCIDR-ADDRESS METHOD hostall

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-25 Thread Greg Smith
Joshua D. Drake wrote: My suggestion would be to start a new thread entirely. And mine would be to drop this whole topic altogether until after the CommitFest is over, and instead focus on the replication features already committed that need work before beta can even start. Only reason

Re: [HACKERS] Review: Patch: Allow substring/replace() to get/set bit values

2010-01-25 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Leonardo F wrote: New version of the patch, let me know if I can fix/change something else. All issues addressed, with one tiny nit-pick -- the get_bit and set_bit methods are not part of the SQL standard. I took the liberty of removing

Re: [HACKERS] default pg_hba.conf tabulation

2010-01-25 Thread Magnus Hagander
2010/1/25 Peter Eisentraut pete...@gmx.net: When editing pg_hba.conf, I often instinctively try to use tabs, only to be slightly annoyed because that barely doesn't work out relative to the default entries, because those are aligned at column 0, 8, 20, 32, 54: # TYPE  DATABASE    USER        

Re: [HACKERS] RADIUS authentication

2010-01-25 Thread Magnus Hagander
2010/1/25 KaiGai Kohei kai...@ak.jp.nec.com: (2010/01/24 23:29), Magnus Hagander wrote: There is one more option here - use OpenSSL if available. It has functions for secure random number generations (http://www.openssl.org/docs/crypto/RAND_bytes.html).  That seems easy enough when OpenSSL is

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Greg Smith
Josh Berkus wrote: We discussed this issue at LCA where I encountered these bogus error messages when I was doing the demo of HS. I consider Selena's patch to be a bug-fix for beta of 9.0, not a feature. Currently the database reports a lot of false error messages when running in standby mode,

Re: [HACKERS] default pg_hba.conf tabulation

2010-01-25 Thread Josh Berkus
On 1/25/10 1:24 PM, Magnus Hagander wrote: 2010/1/25 Peter Eisentraut pete...@gmx.net: When editing pg_hba.conf, I often instinctively try to use tabs, only to be slightly annoyed because that barely doesn't work out relative to the default entries, because those are aligned at column 0, 8,

[HACKERS] Possible changes to pg_restore

2010-01-25 Thread hywel
Greg Sabino Mullane recently shared a script to split schema-only dump files into a table creation file and a trigger/index/constraint file, for restore performance reasons. (http://blog.endpoint.com/2010/01/splitting-postgres-pgdump-into-pre-and.html) Would it be possible and worthwhile to add

Re: [HACKERS] commit fests

2010-01-25 Thread Robert Haas
On Mon, Jan 25, 2010 at 12:01 PM, Greg Smith g...@2ndquadrant.com wrote: I think it's completely reasonable to say that someone could organize pgsql-rrreviewers (as an initial working area, maybe another list eventually) for periodic ReviewFest during periods where those patches won't be

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Selena Deckelmann
Hi! On Mon, Jan 25, 2010 at 1:34 PM, Greg Smith g...@2ndquadrant.com wrote: Josh Berkus wrote: We discussed this issue at LCA where I encountered these bogus error messages when I was doing the demo of HS.  I consider Selena's patch to be a bug-fix for beta of 9.0, not a feature.  Currently

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Greg Smith
Selena Deckelmann wrote: I can scan through the code tonight and look for other cases where this might be an issue. The main thing I'm looking for is to distinguish between harmful and non-harmful errors. Where I think this is going toward is where every line that comes out of this program

Re: [HACKERS] default pg_hba.conf tabulation

2010-01-25 Thread Bruce Momjian
Josh Berkus wrote: On 1/25/10 1:24 PM, Magnus Hagander wrote: 2010/1/25 Peter Eisentraut pete...@gmx.net: When editing pg_hba.conf, I often instinctively try to use tabs, only to be slightly annoyed because that barely doesn't work out relative to the default entries, because those are

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-25 Thread Kevin Grittner
Ivan Sergio Borgonovo m...@webthatworks.it wrote: The README files might be a good place to start, then browse code. Is there any part of the code from where I could learn about: - memory allocation for both cstring and text src/backend/utils/mmgr/README - example of returning text

Re: [HACKERS] Patch: libpq new connect function (PQconnectParams)

2010-01-25 Thread Joe Conway
I'm reviewing the patch posted here: http://archives.postgresql.org/pgsql-hackers/2010-01/msg01579.php for this commitfest item: https://commitfest.postgresql.org/action/patch_view?id=259 Patch attached - a few minor changes: - 1) Updated to apply cleanly

Re: [HACKERS] Patch: libpq new connect function (PQconnectParams)

2010-01-25 Thread Guillaume Lelarge
Le 26/01/2010 00:04, Joe Conway a écrit : I'm reviewing the patch posted here: http://archives.postgresql.org/pgsql-hackers/2010-01/msg01579.php for this commitfest item: https://commitfest.postgresql.org/action/patch_view?id=259 First, thanks for reviewing my patch. Patch attached -

Re: [HACKERS] RADIUS authentication

2010-01-25 Thread KaiGai Kohei
(2010/01/26 6:30), Magnus Hagander wrote: 2010/1/25 KaiGai Koheikai...@ak.jp.nec.com: (2010/01/24 23:29), Magnus Hagander wrote: There is one more option here - use OpenSSL if available. It has functions for secure random number generations

Re: [HACKERS] Possible changes to pg_restore

2010-01-25 Thread Tom Lane
hy...@hmallett.co.uk writes: Would it be possible and worthwhile to add functionality to pg_restore so that with one switch triggers/indexes/constraints could be ignored, and with another switch only triggers/indexes/constraints would be restored? You should probably go back and look at the

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Simon Riggs
On Mon, 2010-01-25 at 16:34 -0500, Greg Smith wrote: Josh Berkus wrote: We discussed this issue at LCA where I encountered these bogus error messages when I was doing the demo of HS. I consider Selena's patch to be a bug-fix for beta of 9.0, not a feature. Currently the database reports

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Tom Lane
Greg Smith g...@2ndquadrant.com writes: [ Greg and Selena discuss filing some rough edges off pg_standby ] Maybe I'm missing something, but I thought pg_standby would be mostly dead once SR hits the streets. Is it worth spending lots of time on? The ideas all sound good, I'm just wondering if

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Josh Berkus
On 1/25/10 4:09 PM, Tom Lane wrote: Greg Smith g...@2ndquadrant.com writes: [ Greg and Selena discuss filing some rough edges off pg_standby ] Maybe I'm missing something, but I thought pg_standby would be mostly dead once SR hits the streets. Is it worth spending lots of time on? The

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Greg Smith
Tom Lane wrote: Maybe I'm missing something, but I thought pg_standby would be mostly dead once SR hits the streets. Is it worth spending lots of time on? I have to do the work I outlined regardless, to support installs on earlier versions (luckily there's few backport issues for this

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-25 Thread KaiGai Kohei
(2010/01/26 1:11), Bernd Helmle wrote: --On 25. Januar 2010 11:39:21 +0900 KaiGai Kohei kai...@ak.jp.nec.com wrote: (echo CREATE TABLE t (a int); for i in `seq 0 9`; do echo CREATE TABLE s$i (b int) INHERITS(t); for j in `seq 0 9`; do echo CREATE TABLE v$i$j (c int) INHERITS(s$i);

Re: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-01-25 Thread Tom Lane
Leonardo F m_li...@yahoo.it writes: Rule it out. Note you should be looking at pg_am.amcanorder, not hardwiring knowledge of particular index types. I can look at pg_am.amcanorder, but I would still need the ScanKey to be used by tuplesort; and I can't find any other way of doing it than

Re: [HACKERS] default_language

2010-01-25 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Mon, 2010-01-25 at 09:30 -0500, Robert Haas wrote: +1 for removing default_do_language, too. +1 for removing default_do_language OR adding default_language. I prefer a hard-wired default of PLpgSQL, so a missing language statement on a DO block

Re: [HACKERS] Possible changes to pg_restore

2010-01-25 Thread Andrew Dunstan
Tom Lane wrote: hy...@hmallett.co.uk writes: Would it be possible and worthwhile to add functionality to pg_restore so that with one switch triggers/indexes/constraints could be ignored, and with another switch only triggers/indexes/constraints would be restored? You should probably

Re: [HACKERS] Dividing progress/debug information in pg_standby, and stat before copy

2010-01-25 Thread Fujii Masao
On Tue, Jan 26, 2010 at 9:08 AM, Simon Riggs si...@2ndquadrant.com wrote: Just committed a fix: the server no longer requests 01.history at start of archive recovery. Good. And I think that writeTimeLineHistory() should also skip the request of 01.history. Here is the patch to

  1   2   >