On Thu, Feb 10, 2011 at 08:36, Marko Tiikkaja
marko.tiikk...@cs.helsinki.fi wrote:
One issue might be in pg_locks
Robert suggested not doing this for 9.1, and I don't have anything against
that.
Agreed.
Updated patch attached.
Looks good to commit. I note a few minor issues for committer:
On Thu, Feb 10, 2011 at 2:56 AM, Radosław Smogura
rsmog...@softperience.eu wrote:
Merlin Moncure mmonc...@gmail.com Thursday 10 February 2011 08:48:26
On Sat, Feb 5, 2011 at 4:59 PM, Radosław Smogura
Since there is basically zero difference in how *varchar* is handled
in the database for the
[Cc: trimmed]
On Wed, Feb 09, 2011 at 01:45:11PM -0500, Robert Haas wrote:
A few other ones that could use more reviewers include:
key locks
I'll take a look at this one.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On 02/10/2011 01:04 AM, Gurjeet Singh wrote:
This commit refers to www.mingw64.org http://www.mingw64.org which
does not exist.
Oops. URL (and name) fixed.
thanks.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On Mon, Feb 7, 2011 at 04:10, Stephen Frost sfr...@snowman.net wrote:
Yeah, doesn't seem to work for me (missing '/bin/collateindex.pl',
apparently..).
You might need yum install openjade stylesheets or similar packages
and re-configure.
Ok, I've cleaned up that part of the documentation to
* Chris Browne:
The RangeType-based equivalent is the following:
rangetest@localhost- explain analyze select * from some_data where
'[2010-01-01,2010-02-01)'::daterange @ whensit;
QUERY PLAN
On 09.02.2011 17:58, Kevin Grittner wrote:
Dan Portsd...@csail.mit.edu wrote:
I think for SerializableXidHash we should probably just initially
allocate it at its maximum size. Then it'll match the PredXact
list which is allocated in full upfront, and there's no risk of
being able to allocate
On 10/02/11 01:26, Steve Singer wrote:
On 11-02-09 05:22 PM, Peter Eisentraut wrote:
On tis, 2011-02-08 at 00:32 -0500, Steve Singer wrote:
Is it necessarily a good idea that an explicit subtransaction disables
the implicit sub-subtransactions? It might be conceivable that you'd
still want
On 02/10/2011 05:09 AM, Heikki Linnakangas wrote:
On 09.02.2011 17:58, Kevin Grittner wrote:
Dan Portsd...@csail.mit.edu wrote:
I think for SerializableXidHash we should probably just initially
allocate it at its maximum size. Then it'll match the PredXact
list which is allocated in full
Currently, tab-completing :variable names in psql does not work at the
beginning of the line. Fix this by moving the code block before the
empty buffer case.
(I have several sql macros in my .psqlrc like :relsize that prints
table sizes in a nicely formatted way, being able to type :tab would
be
On Thu, Feb 10, 2011 at 07:04, Gurjeet Singh singh.gurj...@gmail.com wrote:
This commit refers to www.mingw64.org which does not exist.
Andrew fixed this alreayd.
Also, clicking on the gitweb link below (from GMail), opens the browser
window with an address where ';' are replaced with %3B ,
On ons, 2011-02-09 at 08:00 -0800, David Fetter wrote:
On Wed, Feb 09, 2011 at 01:17:06PM +, Bruce Momjian wrote:
Remove more SGML tabs.
Perhaps we should see about putting something in .git/hooks/pre-commit
so people can focus on more substantive matters.
Is there some kind of
On Thu, Feb 10, 2011 at 03:20, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Feb 9, 2011 at 7:02 PM, Magnus Hagander mag...@hagander.net wrote:
On Thu, Feb 3, 2011 at 11:19, Magnus Hagander mag...@hagander.net wrote:
On Wed, Feb 2, 2011 at 18:00, Magnus Hagander mag...@hagander.net wrote:
On Thu, Feb 10, 2011 at 06:56:15PM +0900, Itagaki Takahiro wrote:
On Mon, Feb 7, 2011 at 04:10, Stephen Frost sfr...@snowman.net wrote:
I agree that it's logically good design, but we could not accept it
as long as it breaks tools in the real world...
If it does, I think it's pretty clear
In cleaning up the streaming part of pg_basebackup, I came across this
gem I copied from elsewherE:
/*
* We have to use postgres.h not postgres_fe.h here, because there's so much
* backend-only stuff in the XLOG include files we need. But we need a
* frontend-ish environment otherwise. Hence
On Thu, Feb 10, 2011 at 6:27 AM, Noah Misch n...@leadboat.com wrote:
FWIW, a 330 byte boot_val doesn't seem like a big deal to me. If it were over
_POSIX2_LINE_MAX (2048), that might be another matter.
I don't think it's entirely stupid to worry about this completely
screwing up the output of
On Tue, Feb 8, 2011 at 3:52 AM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
I needed something to test the FDW API patch with, and didn't want to get
involved in the COPY API changes, and also wanted to have something that
needs real connection management and can push down
On Thu, Feb 10, 2011 at 19:37, Christoph Berg c...@df7cb.de wrote:
Currently, tab-completing :variable names in psql does not work at the
beginning of the line. Fix this by moving the code block before the
empty buffer case.
Seems reasonable to me.
--
Itagaki Takahiro
--
Sent via
On Feb 9, 2011, at 9:28 PM, Alex Hunsaker wrote:
On Wed, Feb 9, 2011 at 08:24, Alexey Klyukin al...@commandprompt.com wrote:
What was actually broken in encode_array_literal support of composite types
(it converted perl hashes to the literal composite-type constants, expanding
nested
On Thu, Feb 10, 2011 at 5:46 AM, Magnus Hagander mag...@hagander.net wrote:
On Thu, Feb 10, 2011 at 07:04, Gurjeet Singh singh.gurj...@gmail.com wrote:
This commit refers to www.mingw64.org which does not exist.
Andrew fixed this alreayd.
Also, clicking on the gitweb link below (from GMail),
On Thu, Feb 10, 2011 at 14:22, Robert Haas robertmh...@gmail.com wrote:
On Thu, Feb 10, 2011 at 5:46 AM, Magnus Hagander mag...@hagander.net wrote:
On Thu, Feb 10, 2011 at 07:04, Gurjeet Singh singh.gurj...@gmail.com wrote:
This commit refers to www.mingw64.org which does not exist.
Andrew
On Sun, Feb 6, 2011 at 08:17, Greg Smith g...@2ndquadrant.com wrote:
Tomas Vondra wrote:
Because when I create a database, the field is
NULL - that's true. But once I connect to the database, the stats are
updated and the field is set (thanks to the logic in pgstat.c).
OK--so it does what
On Thu, Feb 10, 2011 at 8:38 AM, Magnus Hagander mag...@hagander.net wrote:
On Thu, Feb 10, 2011 at 14:22, Robert Haas robertmh...@gmail.com wrote:
On Thu, Feb 10, 2011 at 5:46 AM, Magnus Hagander mag...@hagander.net wrote:
On Thu, Feb 10, 2011 at 07:04, Gurjeet Singh singh.gurj...@gmail.com
On Tue, Feb 8, 2011 at 05:24, Robert Haas robertmh...@gmail.com wrote:
On Wed, Jan 19, 2011 at 1:01 AM, Fujii Masao masao.fu...@gmail.com wrote:
On Thu, Jan 13, 2011 at 9:08 PM, Fujii Masao masao.fu...@gmail.com wrote:
I did s/failover/promote. Here is the updated patch.
I rebased the patch
Excerpts from Peter Eisentraut's message of jue feb 10 07:58:16 -0300 2011:
One thing I was thinking of was that we could add a global make
maintainer-check target (a name I picked up from other projects) which
would run various source code sanity checks. Besides the SGML tabs
issue, my
On Thu, Feb 10, 2011 at 15:25, Magnus Hagander mag...@hagander.net wrote:
On Tue, Feb 8, 2011 at 05:24, Robert Haas robertmh...@gmail.com wrote:
On Wed, Jan 19, 2011 at 1:01 AM, Fujii Masao masao.fu...@gmail.com wrote:
On Thu, Jan 13, 2011 at 9:08 PM, Fujii Masao masao.fu...@gmail.com wrote:
I
On Wed, February 9, 2011 09:35, Jeff Davis wrote:
Updated patch.
Thanks!
I just wanted to mention that this latest patch doesn't quite apply as-is,
because of catversion
changes.
I've removed the change to catversion.h (18 lines, starting at 4985) from the
patch file; then it
applies
On Tue, Feb 8, 2011 at 7:58 PM, Jeff Davis pg...@j-davis.com wrote:
On the flip side, if we don't provide review to WIP patches during the
3rd commitfest, how do we expect to get anything close to committable on
the 1st commitfest of the next cycle?
I'm not sure exactly what you're going for
On Tue, Feb 1, 2011 at 1:33 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut pete...@gmx.net wrote:
On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
However if I connect with a line in pg_hba that matches on an IP
network then my
On Wed, Feb 9, 2011 at 1:45 PM, Robert Haas robertmh...@gmail.com wrote:
A few other ones that could use more reviewers include:
I've just corrected the status of a few patches in the CommitFest
application. In particular, I set the following back to Needs Review.
SQL/MED - postgresql_fdw
On Tue, Feb 8, 2011 at 10:54 PM, Joachim Wieland j...@mcknight.de wrote:
On Tue, Feb 8, 2011 at 8:31 PM, Itagaki Takahiro
itagaki.takah...@gmail.com wrote:
On Tue, Feb 8, 2011 at 13:34, Robert Haas robertmh...@gmail.com wrote:
So how close are we to having a committable version of this?
On 11-02-10 10:13 AM, Robert Haas wrote:
On Tue, Feb 1, 2011 at 1:33 PM, Robert Haasrobertmh...@gmail.com wrote:
On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentrautpete...@gmx.net wrote:
On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
However if I connect with a line in pg_hba that
Hi,
I am an MSc student in the department of Informatics and
Telecommunications of the University of Athens and as part of my
thesis I am examining a new path/plan cost model for DB optimizers. I
have successfully changed the optimizer of PostgreSQL in order to
implement this model, but
On Thu, Feb 10, 2011 at 10:22 AM, Steve Singer ssinger...@sympatico.ca wrote:
On 11-02-10 10:13 AM, Robert Haas wrote:
On Tue, Feb 1, 2011 at 1:33 PM, Robert Haasrobertmh...@gmail.com wrote:
On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentrautpete...@gmx.net wrote:
On tis, 2011-01-18 at 19:24
On 11-02-10 10:32 AM, Robert Haas wrote:
I was assuming those changes were sufficiently trivial that they could
be made at commit-time, especially if Peter is committing it himself.
Of course if he'd like a re-review, he can always post an updated
patch, but I just thought that was overly
Robert Haas robertmh...@gmail.com writes:
On Tue, Feb 8, 2011 at 9:48 PM, Tom Lane t...@sss.pgh.pa.us wrote:
In contrast, ALTER EXTENSION ADD doesn't presuppose that you couldn't
add the object to multiple extensions; and it has a natural inverse,
ALTER EXTENSION DROP. I am not necessarily
On Thu, Feb 10, 2011 at 10:41 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Tue, Feb 8, 2011 at 9:48 PM, Tom Lane t...@sss.pgh.pa.us wrote:
In contrast, ALTER EXTENSION ADD doesn't presuppose that you couldn't
add the object to multiple extensions; and it
Tom Lane t...@sss.pgh.pa.us writes:
Actually, it occurs to me that the need for ALTER EXTENSION DROP could
be upon us sooner than we think. The cases where an extension upgrade
script would need that are
(1) you want to remove some deprecated piece of the extension's API;
(2) you want to
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
Tom Lane t...@sss.pgh.pa.us writes:
Actually, it occurs to me that the need for ALTER EXTENSION DROP could
be upon us sooner than we think. The cases where an extension upgrade
script would need that are
(1) you want to remove some deprecated
=?ISO-8859-7?B?yNzt7/Ig0OHw4fDd9PHv9Q==?= tha...@di.uoa.gr writes:
I am an MSc student in the department of Informatics and
Telecommunications of the University of Athens and as part of my
thesis I am examining a new path/plan cost model for DB optimizers. I
have successfully changed the
Tom Lane t...@sss.pgh.pa.us writes:
That would be rejected because you're not allowed to drop an individual
member object of an extension. (And no, I don't want to have a kluge in
dependency.c that makes that test work differently when
creating_extension.)
Fair enough, all the more as soon
Erik Rijkers e...@xs4all.nl writes:
On Wed, February 9, 2011 09:35, Jeff Davis wrote:
Updated patch.
I just wanted to mention that this latest patch doesn't quite apply as-is,
because of catversion changes.
Just a note: standard practice is for submitted patches to *not* touch
catversion.h.
On Thu, 2011-02-10 at 12:04 -0500, Tom Lane wrote:
Erik Rijkers e...@xs4all.nl writes:
On Wed, February 9, 2011 09:35, Jeff Davis wrote:
Updated patch.
I just wanted to mention that this latest patch doesn't quite apply as-is,
because of catversion changes.
Just a note: standard
On tor, 2011-02-10 at 09:28 -0800, Jeff Davis wrote:
I originally put it there so that I wouldn't mix up data directories
with a patch I'm reviewing, but I agree that it seems easier this way.
FWIW, I disagree with Tom and do recommend putting the catversion change
in the patch.
--
Sent via
On Wed, Feb 9, 2011 at 2:09 AM, Jeff Davis pg...@j-davis.com wrote:
That's how arrays do it: there's a special Expr node that represents an
array expression. Maybe the same thing could be used for range types,
but I fear that there may be some grammar conflicts. I doubt we'd want
to fully
On Thu, 2011-02-10 at 15:38 +0100, Erik Rijkers wrote:
I've removed the change to catversion.h (18 lines, starting at 4985) from the
patch file; then it
applies cleanly.
I should mention that the last patch changed the representation to be
more compact. So, if you have any existing test data
On 10.02.2011 20:01, Peter Eisentraut wrote:
On tor, 2011-02-10 at 09:28 -0800, Jeff Davis wrote:
I originally put it there so that I wouldn't mix up data directories
with a patch I'm reviewing, but I agree that it seems easier this way.
FWIW, I disagree with Tom and do recommend putting the
On Thu, 2011-02-10 at 09:46 -0500, Robert Haas wrote:
On Tue, Feb 8, 2011 at 7:58 PM, Jeff Davis pg...@j-davis.com wrote:
On the flip side, if we don't provide review to WIP patches during the
3rd commitfest, how do we expect to get anything close to committable on
the 1st commitfest of the
I spent some time reviewing this thread. I think the major point that's
not received adequate discussion is this: the design assumes that there's
just one current version of any extension, and that's not good enough.
David Fetter was trying to make that point upthread but didn't seem to
convince
On Thu, Feb 10, 2011 at 1:23 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
On 10.02.2011 20:01, Peter Eisentraut wrote:
On tor, 2011-02-10 at 09:28 -0800, Jeff Davis wrote:
I originally put it there so that I wouldn't mix up data directories
with a patch I'm reviewing,
On Thu, Feb 10, 2011 at 12:58:16PM +0200, Peter Eisentraut wrote:
On ons, 2011-02-09 at 08:00 -0800, David Fetter wrote:
On Wed, Feb 09, 2011 at 01:17:06PM +, Bruce Momjian wrote:
Remove more SGML tabs.
Perhaps we should see about putting something in .git/hooks/pre-commit
so
On Thu, 2011-02-10 at 13:07 -0500, Robert Haas wrote:
According to our documentation[1], RANGE is reserved in SQL:2008 and
SQL:2003, which makes it more imaginable to reserve it than it would
be otherwise.
Oh, interesting.
I believe that in a previous email you mentioned that
you were
On Thu, Feb 10, 2011 at 1:41 PM, Jeff Davis pg...@j-davis.com wrote:
This might solve the constructor problem nicely if we could do things
like:
RANGE[10,20)
But I have a feeling that will either cause a bizarre problem with the
grammar, or someone will think it's not very SQL-like.
I think
On Feb 10, 2011, at 10:26 AM, Tom Lane wrote:
1. Choose the newest available version.
2. Let the control file specify which version is the default.
I think I prefer #2 because it avoids needing a rule for comparing
version identifiers, and it caters to the possibility that the
You basically need the variable, the entry in the appropriate array in
guc.c, and some documentation (at least if you'd like anyone else to
ever use the code). Try looking at some past patches that added GUCs
similar to yours.
For completeness, it would also be good to add rows to the
On Thu, Feb 10, 2011 at 1:26 PM, Tom Lane t...@sss.pgh.pa.us wrote:
requires, relocatable and schema: These are problematic, because it's not
out of the question that someone might want to change these properties
from one version to another. But as things are currently set up, we must
know
2011/2/10 Josh Berkus j...@agliodbs.com:
You basically need the variable, the entry in the appropriate array in
guc.c, and some documentation (at least if you'd like anyone else to
ever use the code). Try looking at some past patches that added GUCs
similar to yours.
For completeness, it
On 08.02.2011 20:53, Robert Haas wrote:
That having been said, there is at least one part of this patch which
looks to be in pretty good shape and seems independently useful
regardless of what happens to the rest of it, and that is the code
that sends replies from the standby back to the
This might solve the constructor problem nicely if we could do things
like:
RANGE[10,20)
But I have a feeling that will either cause a bizarre problem with the
grammar, or someone will think it's not very SQL-like.
It will certainly mess up syntax highlighting and matching bracket
On tor, 2011-02-10 at 10:40 -0800, David Fetter wrote:
I think all such checks belong in .git/hooks/pre-commit, and need to
be as cross-platform as needed for committers. Would a *n*x-based
version do for a start?
I think as a matter of principle, the only things that belongs into git
hooks
Florian Pflug f...@phlo.org writes:
This might solve the constructor problem nicely if we could do things
like:
RANGE[10,20)
But I have a feeling that will either cause a bizarre problem with the
grammar, or someone will think it's not very SQL-like.
It will certainly mess up syntax
On sön, 2011-02-06 at 20:44 +0100, Jan Urbański wrote:
On 27/01/11 23:24, Jan Urbański wrote:
On 11/01/11 12:20, Jan Urbański wrote:
On 11/01/11 01:27, Tom Lane wrote:
Hannu Krosing ha...@2ndquadrant.com writes:
On 10.1.2011 17:20, Jan Urbański wrote:
I changed that patch to use Perl
David E. Wheeler da...@kineticode.com writes:
+1. I assume there will be some way to build versioned shared object
libraries too, then?
I'm not really addressing that in this proposal. You could imagine
supporting all the extension versions in one .so, or you could have one
per version
Josh Berkus j...@agliodbs.com writes:
You basically need the variable, the entry in the appropriate array in
guc.c, and some documentation (at least if you'd like anyone else to
ever use the code). Try looking at some past patches that added GUCs
similar to yours.
For completeness, it would
On Feb 10, 2011, at 11:31 AM, Tom Lane wrote:
I'm not really addressing that in this proposal. You could imagine
supporting all the extension versions in one .so, or you could have one
per version (meaning the upgrade scripts would have to CREATE OR REPLACE
all the C functions to re-point
On Feb 10, 2011, at 10:41 AM, Jeff Davis wrote:
This might solve the constructor problem nicely if we could do things
like:
RANGE[10,20)
But I have a feeling that will either cause a bizarre problem with the
grammar, or someone will think it's not very SQL-like.
I like it a lot better than
On 02/10/2011 08:15 AM, Alexey Klyukin wrote:
On Feb 9, 2011, at 9:28 PM, Alex Hunsaker wrote:
On Wed, Feb 9, 2011 at 08:24, Alexey Klyukinal...@commandprompt.com wrote:
What was actually broken in encode_array_literal support of composite types
(it converted perl hashes to the literal
Robert Haas robertmh...@gmail.com writes:
On Thu, Feb 10, 2011 at 1:26 PM, Tom Lane t...@sss.pgh.pa.us wrote:
requires, relocatable and schema: These are problematic, because it's not
out of the question that someone might want to change these properties
from one version to another. But as
On Feb 10, 2011, at 11:21 AM, Tom Lane wrote:
It will certainly mess up syntax highlighting and matching bracket detection
in pretty much all text editors...
Yeah. It's a cute-looking notation but surely it will cause many more
problems than it's worth. I agree with Robert's suggestion of
David E. Wheeler da...@kineticode.com writes:
On Feb 10, 2011, at 11:31 AM, Tom Lane wrote:
I don't see how that affects my point? You can spell 1.0 as 0.1
and 1.1 as 0.2 if you like that kind of numbering, but I don't
see that that has any real impact. At the end of the day an author is
On Thu, Feb 10, 2011 at 2:42 PM, Tom Lane t...@sss.pgh.pa.us wrote:
General opinion around Red Hat is relocatable RPMs don't work. But
pushing a set of functions from one schema to another is a very much
narrower problem than what an RPM has to deal with, so I'm not convinced
that the analogy
On Thu, Feb 10, 2011 at 3:02 PM, Tom Lane t...@sss.pgh.pa.us wrote:
David E. Wheeler da...@kineticode.com writes:
On Feb 10, 2011, at 11:31 AM, Tom Lane wrote:
I don't see how that affects my point? You can spell 1.0 as 0.1
and 1.1 as 0.2 if you like that kind of numbering, but I don't
see
On 10/02/11 20:24, Peter Eisentraut wrote:
On sön, 2011-02-06 at 20:44 +0100, Jan Urbański wrote:
On 27/01/11 23:24, Jan Urbański wrote:
On 11/01/11 12:20, Jan Urbański wrote:
On 11/01/11 01:27, Tom Lane wrote:
Hannu Krosing ha...@2ndquadrant.com writes:
On 10.1.2011 17:20, Jan Urbański
Robert Haas robertmh...@gmail.com writes:
Now, if you want to argue that moving an extension after the fact (ALTER
EXTENSION SET SCHEMA) is so dangerous as to be useless, I wouldn't
argue very hard. Do you want to propose ripping that out? But
relocating at first install doesn't seem
On Thu, Feb 10, 2011 at 3:33 PM, Dimitri Fontaine
dimi...@2ndquadrant.fr wrote:
Robert Haas robertmh...@gmail.com writes:
Now, if you want to argue that moving an extension after the fact (ALTER
EXTENSION SET SCHEMA) is so dangerous as to be useless, I wouldn't
argue very hard. Do you want to
On Feb 10, 2011, at 12:02 PM, Tom Lane wrote:
Oh, I see, you're just saying that it's not unlikely somebody could find
himself with dozens of minor releases all being supported. Yeah, he'd
then really need to provide shortcut upgrade scripts, and
building/maintaining those would be a pain.
On Feb 10, 2011, at 12:07 PM, Robert Haas wrote:
You don't need them to be sortable. You just need them to be
comparable, and equality seems like a plenty good enough comparison
rule. You can compute the shortest chain of upgrade scripts that can
take you from the current version to the
Robert Haas robertmh...@gmail.com writes:
On Thu, Feb 10, 2011 at 2:42 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Now, if you want to argue that moving an extension after the fact (ALTER
EXTENSION SET SCHEMA) is so dangerous as to be useless, I wouldn't
argue very hard. Do you want to propose
On Thu, Feb 10, 2011 at 3:46 PM, David E. Wheeler da...@kineticode.com wrote:
On Feb 10, 2011, at 12:07 PM, Robert Haas wrote:
You don't need them to be sortable. You just need them to be
comparable, and equality seems like a plenty good enough comparison
rule. You can compute the shortest
Robert Haas robertmh...@gmail.com writes:
On Thu, Feb 10, 2011 at 3:02 PM, Tom Lane t...@sss.pgh.pa.us wrote:
The design as I sketched it didn't need to make any assumptions at all
about the meaning of the version identifiers. But if you were willing
to assume that the identifiers are
Hi,
Tom Lane t...@sss.pgh.pa.us writes:
I spent some time reviewing this thread. I think the major point that's
Thanks for doing that, we badly needed someone without an horse in this
race to do that and finish the design.
So I believe that it'd be a good idea if it were possible for an
Robert Haas robertmh...@gmail.com writes:
No, you have to get *those other module authors* to make *their*
extensions not relocatable so that you can depend on them.
Just tell me exactly in which world an extension's author is setting up
the dependencies in the 'required' property and yet fails
On Thu, Feb 10, 2011 at 3:58 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Thu, Feb 10, 2011 at 3:02 PM, Tom Lane t...@sss.pgh.pa.us wrote:
The design as I sketched it didn't need to make any assumptions at all
about the meaning of the version identifiers.
Tom Lane t...@sss.pgh.pa.us writes:
I don't think it's appropriate to hold extensions to a
higher standard than we do loose objects --- especially when it takes
superuser privileges to break things by moving an extension but not to
break them by moving loose objects.
FWIW, +1.
Regards,
--
On Thu, Feb 10, 2011 at 4:14 PM, Dimitri Fontaine
dimi...@2ndquadrant.fr wrote:
Robert Haas robertmh...@gmail.com writes:
No, you have to get *those other module authors* to make *their*
extensions not relocatable so that you can depend on them.
Just tell me exactly in which world an
Robert Haas robertmh...@gmail.com writes:
On Thu, Feb 10, 2011 at 3:58 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Hmm. The problem with that is that once there are large numbers of
intermediate versions, the number of potential paths grows
exponentially.
It's certainly not exponential i.e.
On Thu, Feb 10, 2011 at 3:52 PM, Tom Lane t...@sss.pgh.pa.us wrote:
The real issue is what happens when you want to install
extension A, which depends on extensions B, C, and D, and B, C, and D
are all in non-standard locations. Does that have any chance of
working under the system we're
On 02/08/2011 08:37 PM, Andrew Dunstan wrote:
On 02/07/2011 11:30 PM, Robert Haas wrote:
On Tue, Dec 28, 2010 at 9:23 PM, Karl Lehenbauer
karllehenba...@gmail.com wrote:
On Dec 28, 2010, at 7:29 PM, Tom Lane wrote:
This patch appears to be changing a whole lot of stuff that in fact
On Feb 10, 2011, at 1:22 PM, Tom Lane wrote:
Well, okay, let's go with that plan then. If we don't need to assume
anything more than equality of version names being meaningful, I think
chaining update scripts automatically should solve most of the
complaints here. People who really want to
On 11-02-10 03:13 PM, Jan Urbański wrote:
On 10/02/11 20:24, Peter Eisentraut wrote:
Here is the rest of my review.
Submission Review
---
Patch applies cleanly.
Documentation is still outstanding but Jan has promised it soon.
Usability Review
---
We don't
On Feb 10, 2011, at 9:44 PM, Andrew Dunstan wrote:
On 02/10/2011 08:15 AM, Alexey Klyukin wrote:
On Feb 9, 2011, at 9:28 PM, Alex Hunsaker wrote:
On Wed, Feb 9, 2011 at 08:24, Alexey Klyukinal...@commandprompt.com
wrote:
What was actually broken in encode_array_literal support of
Robert Haas robertmh...@gmail.com writes:
Well, the difference is that loose objects are just on my system,
whereas extensions are supposed to work on anybody's system. I'm not
clear that it's possible to write an extension that depends on a
relocatable extension in a sensible way. If it is,
David E. Wheeler da...@kineticode.com writes:
Yes, I think that this is a great solution. I only have to create on
upgrade script for each release, and I don't have to worry about
concatenating anything or be required to change my versioning
algorithm.
You still have to make sure that the C
Robert Haas robertmh...@gmail.com writes:
On Thu, Feb 10, 2011 at 3:52 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Again, it's not really any different from the case where the dependent
objects are loose rather than members of an extension.
Well, the difference is that loose objects are just on my
On Feb 10, 2011, at 1:38 PM, Tom Lane wrote:
I don't deny that there are risks here. But I think the value of being
able to move an extension when it is safe outweighs the difficulty that
sometimes it isn't safe. I think we can leave making it safer as a
topic for future investigation.
On Thu, Feb 10, 2011 at 9:38 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Well, the difference is that loose objects are just on my system,
whereas extensions are supposed to work on anybody's system. I'm not
clear that it's possible to write an extension that depends on a
relocatable extension in
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
David E. Wheeler da...@kineticode.com writes:
Yes, I think that this is a great solution. I only have to create on
upgrade script for each release, and I don't have to worry about
concatenating anything or be required to change my versioning
On Thu, Feb 10, 2011 at 09:16:09PM +0200, Peter Eisentraut wrote:
On tor, 2011-02-10 at 10:40 -0800, David Fetter wrote:
I think all such checks belong in .git/hooks/pre-commit, and need
to be as cross-platform as needed for committers. Would a
*n*x-based version do for a start?
I think
On Thu, Feb 10, 2011 at 11:29:43AM -0300, Alvaro Herrera wrote:
Excerpts from Peter Eisentraut's message of jue feb 10 07:58:16 -0300 2011:
One thing I was thinking of was that we could add a global make
maintainer-check target (a name I picked up from other projects)
which would run
Excerpts from Pavel Stehule's message of sáb ene 29 16:56:40 -0300 2011:
2011/1/29 Tom Lane t...@sss.pgh.pa.us:
The less crocky way to do that is to use SPI_palloc() for something that
should be allocated in the outer context.
I understand. Is there some way, where I can use a
1 - 100 of 135 matches
Mail list logo
