Re: [HACKERS] Disabled features on Hot Standby

2012-01-14 Thread Simon Riggs
On Sat, Jan 14, 2012 at 1:02 AM, Noah Misch n...@leadboat.com wrote: Also, what happens if an all-visible bit gets set on the standby through some other mechanism - e.g. restored from an FPI or XLOG_HEAP_NEWPAGE?  I'm not sure whether we ever do an FPI of the visibility map page itself, but

Re: [HACKERS] Disabled features on Hot Standby

2012-01-14 Thread Simon Riggs
On Sat, Jan 14, 2012 at 5:42 AM, Robert Haas robertmh...@gmail.com wrote: Other than that, it seems like we might be converging on a workable solution: if hot_standby_feedback=off, disable index-only scans for snapshots taken during recovery; if hot_standby_feedback=on, generate recovery

Re: [HACKERS] Measuring relation free space

2012-01-14 Thread Jaime Casanova
On Thu, Dec 15, 2011 at 4:11 PM, Noah Misch n...@leadboat.com wrote: On Sun, Nov 06, 2011 at 10:20:49PM +0100, Bernd Helmle wrote: --On 6. November 2011 01:08:11 -0200 Greg Smith g...@2ndquadrant.com wrote: Attached patch adds a new function to the pageinspect extension for measuring total

Re: [HACKERS] Multithread Query Planner

2012-01-14 Thread Frederico
This means it's possible use threads? Att, Fred Enviado via iPad Em 13/01/2012, às 20:47, Dimitri Fontaine dimi...@2ndquadrant.fr escreveu: Christopher Browne cbbro...@gmail.com writes: Yes, don't try to use threads.

Re: [HACKERS] Concurrent CREATE TABLE/DROP SCHEMA leaves inconsistent leftovers

2012-01-14 Thread Hitoshi Harada
On Fri, Jan 13, 2012 at 2:05 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 29, 2011 at 10:10 AM, Robert Haas robertmh...@gmail.com wrote: I have plans to try to improve this, but it's one of those things that I care about more than the people who write the checks do, so it hasn't

Re: [HACKERS] Concurrent CREATE TABLE/DROP SCHEMA leaves inconsistent leftovers

2012-01-14 Thread Hitoshi Harada
On Sat, Jan 14, 2012 at 2:25 AM, Hitoshi Harada umi.tan...@gmail.com wrote: On Fri, Jan 13, 2012 at 2:05 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 29, 2011 at 10:10 AM, Robert Haas robertmh...@gmail.com wrote: I have plans to try to improve this, but it's one of those things

Re: [HACKERS] Command Triggers

2012-01-14 Thread Dimitri Fontaine
Andres Freund and...@anarazel.de writes: If you target C coded triggers then all you need to do is provide a pointer to the Node *parsetree, I would think. What else? Yes. Being able to turn that into a statement again is still valuable imo. That part of the WIP code is still in the patch,

Re: [HACKERS] Disabled features on Hot Standby

2012-01-14 Thread Noah Misch
On Sat, Jan 14, 2012 at 08:08:29AM +, Simon Riggs wrote: On Sat, Jan 14, 2012 at 1:02 AM, Noah Misch n...@leadboat.com wrote: However, CLUSTER/VACUUM FULL already remove tuples still-visible to standby snapshots without provoking a recovery conflict. ?(Again only with

Re: [HACKERS] Measuring relation free space

2012-01-14 Thread Noah Misch
On Sat, Jan 14, 2012 at 04:41:57AM -0500, Jaime Casanova wrote: pgstattuple and relation_free_space are very close in all the numbers except for 2 indexes pgbench_branches_pkey and pgbench_tellers_pkey; after a VACUUM FULL and a REINDEX (and the difference persistence) i checked

Re: [HACKERS] Disabled features on Hot Standby

2012-01-14 Thread Simon Riggs
On Sat, Jan 14, 2012 at 11:17 AM, Noah Misch n...@leadboat.com wrote: On Sat, Jan 14, 2012 at 08:08:29AM +, Simon Riggs wrote: On Sat, Jan 14, 2012 at 1:02 AM, Noah Misch n...@leadboat.com wrote: However, CLUSTER/VACUUM FULL already remove tuples still-visible to standby snapshots

Re: [HACKERS] Disabled features on Hot Standby

2012-01-14 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: With the exception of EXPLAIN support which I think is merely an oversight, all of those issues, including the problems in Hot Standby mode, remain because nobody knows exactly what we ought to do to fix them. When somebody figures it out, I predict

Re: [HACKERS] Multithread Query Planner

2012-01-14 Thread Dimitri Fontaine
Frederico zepf...@gmail.com writes: This means it's possible use threads? The short answer is “no”. -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] psql NUL record and field separator

2012-01-14 Thread Peter Eisentraut
Inspired by this question http://stackoverflow.com/questions/6857265 I have implemented a way to set the psql record and field separators to a zero byte (ASCII NUL character). This can be very useful in shell scripts to have an unambiguous separator. Other GNU tools such as find, grep, sort,

[HACKERS] pg_statistic, lack of documentation

2012-01-14 Thread Sergey Konoplev
Hi, http://www.postgresql.org/docs/9.1/interactive/catalog-pg-statistic.html It specifies that entries are created by ANALYZE, but does not mention that if a table is empty the entry for it is not created. Probably it is worth to add to the docs. The test case is below. grayhemp@[local]:5432

Re: [HACKERS] controlling the location of server-side SSL files

2012-01-14 Thread Peter Eisentraut
On mån, 2012-01-02 at 06:32 +0200, Peter Eisentraut wrote: I think I would like to have a set of GUC parameters to control the location of the server-side SSL files. Here is the patch for this. One thing that is perhaps worth thinking about: Currently, we just ignore missing root.crt and

Re: [HACKERS] Multithread Query Planner

2012-01-14 Thread Thomas Munro
On 13 January 2012 20:14, Frederico zepf...@gmail.com wrote: I'm trying to develop a multithread planner, and some times is raised a exception of access memory. I was a bit confused about what you are trying to do -- somehow use concurrency during the planning phase, or during execution (maybe

Re: [HACKERS] xlog location arithmetic

2012-01-14 Thread Fujii Masao
On Tue, Dec 6, 2011 at 1:19 PM, Euler Taveira de Oliveira eu...@timbira.com wrote: Hi, A while ago when blogging about WAL [1], I noticed a function to deal with xlog location arithmetic is wanted. I remembered Depez [2] mentioning it and after some questions during trainings and conferences

Re: [HACKERS] xlog location arithmetic

2012-01-14 Thread Euler Taveira de Oliveira
On 14-01-2012 11:06, Fujii Masao wrote: I think that this function is very useful. Can you add the patch into CommitFest 2012-1 ? Sure. But I must adjust the patch based on the thread comments (basically, numeric output). I have a new patch but need to test it before submitting it. I'll post

Re: [HACKERS] Concurrent CREATE TABLE/DROP SCHEMA leaves inconsistent leftovers

2012-01-14 Thread Robert Haas
On Sat, Jan 14, 2012 at 5:25 AM, Hitoshi Harada umi.tan...@gmail.com wrote: The patch looks ok, though I wonder if we could have a way to release the lock on namespace much before the end of transaction. Well, that wold kind of miss the point, wouldn't it? I mean, the race is that the process

Re: [HACKERS] Disabled features on Hot Standby

2012-01-14 Thread Robert Haas
On Sat, Jan 14, 2012 at 6:44 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: With the exception of EXPLAIN support which I think is merely an oversight, all of those issues, including the problems in Hot Standby mode, remain because nobody knows

Re: [HACKERS] Command Triggers

2012-01-14 Thread Robert Haas
On Fri, Jan 13, 2012 at 5:53 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Andres Freund and...@anarazel.de writes: I personally think this is an error and those details should at least be available on the c level (e.g. some pg_command_trigger_get_plan() function, only available via C) to

[HACKERS] psql filename completion: quoting

2012-01-14 Thread Noah Misch
Occasionally, I have a SQL file destined for psql's \i command whose name contains a space. Less often, I'll have a .csv destined for \copy with the same problem. psql's filename completion does not handle these well. It completes on the literal name, but the commands will only recognize quoted

[HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-01-14 Thread Noah Misch
It has bothered me that psql's \copy ignores the ON_ERROR_ROLLBACK setting. Only SendQuery() takes note of ON_ERROR_ROLLBACK, and \copy, like all backslash commands, does not route through SendQuery(). Looking into this turned up several other weaknesses in psql's handling of COPY. For example,

[HACKERS] Patch: Allow SQL-language functions to reference parameters by parameter name

2012-01-14 Thread Matthew Draper
I just remembered to make time to advance this from WIP to proposed patch this week... and then worked out I'm rudely dropping it into the last commitfest at the last minute. :/ Anyway, my interpretation of the previous discussion is a general consensus that permitting ambiguous

Re: [HACKERS] Remembering bug #6123

2012-01-14 Thread Kevin Grittner
Tom Lane wrote: Well, the bottom line that's concerning me here is whether throwing errors is going to push anyone's application into an unfixable corner. I'm somewhat encouraged that your Circuit Courts software can adapt to it, since that's certainly one of the larger and more complex

Re: [HACKERS] [PATCH] Support for foreign keys with arrays

2012-01-14 Thread Marco Nenciarini
Hello, Il giorno dom, 11/12/2011 alle 19.45 -0500, Noah Misch ha scritto: On Sat, Dec 10, 2011 at 09:47:53AM +0100, Gabriele Bartolini wrote: So, here is a summary: --- - - | ON| ON| Action | DELETE | UPDATE |

Re: [HACKERS] [PATCH] Allow breaking out of hung connection attempts

2012-01-14 Thread Ryan Kelly
On Tue, Jan 10, 2012 at 11:29:58AM +0200, Heikki Linnakangas wrote: On 09.01.2012 15:49, Ryan Kelly wrote: On Mon, Jan 09, 2012 at 10:35:50AM +0200, Heikki Linnakangas wrote: That assumes that it's safe to longjmp out of PQconnectdbParams at any instant. It's not. I'm guessing because it

Re: [HACKERS] Measuring relation free space

2012-01-14 Thread Jaime Casanova
On Sat, Jan 14, 2012 at 6:26 AM, Noah Misch n...@leadboat.com wrote: - pgstattuple() and relation_free_space() should emit the same number, even if  that means improving pgstattuple() at the same time. yes, i just wanted to understand which one was more accurate and why... and give the

Re: [HACKERS] JSON for PG 9.2

2012-01-14 Thread Pavel Stehule
2012/1/14 Andrew Dunstan and...@dunslane.net: On 01/12/2012 10:51 AM, Andrew Dunstan wrote: On 01/12/2012 10:44 AM, Pavel Stehule wrote: 2012/1/12 Andrew Dunstanand...@dunslane.net: On 01/12/2012 09:00 AM, Joey Adams wrote: I wrote an array_to_json function during GSoC 2010:

Re: [HACKERS] Command Triggers

2012-01-14 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: But on the flip side, I think we're generally a bit more flexible about exposing things via C than through the procedural languages. So we could still expose the parsetree of the current command. I wonder if it's already possible to get that from a C

[HACKERS] lots of unused variable warnings in assert-free builds

2012-01-14 Thread Peter Eisentraut
In builds without --enable-cassert (I guess not many developers use those a lot), there are quite a few unused variable warnings. These usually hold some intermediate result that the assert checks later. I see that in some places our code already uses #ifdef USE_ASSERT_CHECKING, presumably to

Re: [HACKERS] separate initdb -A options for local and host

2012-01-14 Thread Peter Eisentraut
On lör, 2011-11-26 at 01:20 +0200, Peter Eisentraut wrote: I think it would be useful to have separate initdb -A options for local and host entries. In 9.1, we went out of our way to separate the peer and ident methods, but we have moved the confusion into the initdb -A option, where ident

Re: [HACKERS] WIP -- renaming implicit sequences

2012-01-14 Thread Thomas Munro
On 12 January 2012 00:58, Tom Lane t...@sss.pgh.pa.us wrote: Hmm ... this seems a bit inconsistent with the fact that we got rid of automatic renaming of indexes a year or three back.  Won't renaming of serials have all the same problems that caused us to give up on renaming indexes? I was

Re: [HACKERS] JSON for PG 9.2

2012-01-14 Thread Joey Adams
On Sat, Jan 14, 2012 at 3:06 PM, Andrew Dunstan and...@dunslane.net wrote: Second, what should be do when the database encoding isn't UTF8? I'm inclined to emit a \u escape for any non-ASCII character (assuming it has a unicode code point - are there any code points in the non-unicode

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-14 Thread Josh Kupershmidt
On Sun, Dec 11, 2011 at 9:52 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Hi guys,  I have added the '-n' option to pg_archivecleanup which performs a dry-run and outputs the names of the files to be removed to stdout (making possible to pass the list via pipe to another

Re: [HACKERS] JSON for PG 9.2

2012-01-14 Thread Andrew Dunstan
On 01/14/2012 06:11 PM, Joey Adams wrote: On Sat, Jan 14, 2012 at 3:06 PM, Andrew Dunstanand...@dunslane.net wrote: Second, what should be do when the database encoding isn't UTF8? I'm inclined to emit a \u escape for any non-ASCII character (assuming it has a unicode code point - are

Re: [HACKERS] JSON for PG 9.2

2012-01-14 Thread Mike Lewis
I am very interested in experimenting with functional indexes into JSON structures. I think this could be very powerful combined with full text search as well as constraints. It would allow for using postgres as an unstructured data store without sacrificing the powerful indexing features,

Re: [HACKERS] xlog location arithmetic

2012-01-14 Thread Greg Smith
On 01/14/2012 09:12 AM, Euler Taveira de Oliveira wrote: But I must adjust the patch based on the thread comments (basically, numeric output). I have a new patch but need to test it before submitting it. I'll post this weekend. It's now at

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-14 Thread Greg Smith
On 01/09/2012 09:56 PM, Greg Smith wrote: The main question still lingering about is the viability of pushing out an 9.2alpha3 at this point. That was originally scheduled for December 20th. There was a whole lot of active code whacking still in progress that week though. And as soon as

Re: [HACKERS] xlog location arithmetic

2012-01-14 Thread Gurjeet Singh
On Sat, Jan 14, 2012 at 8:18 PM, Greg Smith g...@2ndquadrant.com wrote: On 01/14/2012 09:12 AM, Euler Taveira de Oliveira wrote: But I must adjust the patch based on the thread comments (basically, numeric output). I have a new patch but need to test it before submitting it. I'll post this

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-14 Thread Greg Smith
On 01/14/2012 10:49 PM, Gurjeet Singh wrote: So lets make it easy for the patch submitter to start the process. I propose that we have a page in the CF application where people can upload/attach the patch, and the app posts the patch to -hackers and uses the post URL to create the CF entry.

Re: [HACKERS] lots of unused variable warnings in assert-free builds

2012-01-14 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: I see that in some places our code already uses #ifdef USE_ASSERT_CHECKING, presumably to hide similar issues. But in most cases using this would significantly butcher the code. I found that adding __attribute__((unused)) is cleaner. Attached is a

[HACKERS] Our poll() based WaitLatch implementation is broken

2012-01-14 Thread Peter Geoghegan
Build Postgres master, on Linux or another platform that will use the poll() implementation rather than the older select(). Send the Postmaster SIGKILL. Observe that the WAL Writer lives on, representing a denial of service as it stays attached to shared memory, busy waiting (evident from the fact