Hi,
I forgot to add documentation changes in the earlier patch. In the attached
patch, I have added documentation as well as fixed other issues you raised.
Regards,
--Asif
On Thu, Nov 22, 2012 at 10:47 PM, Asif Rehman asifr.reh...@gmail.comwrote:
Thanks for the review Pavel. I have taken care
2012-11-23 06:30 keltezéssel, Fujii Masao írta:
On Thu, Nov 22, 2012 at 10:05 PM, Boszormenyi Zoltan z...@cybertec.at wrote:
2012-11-22 12:44 keltezéssel, Magnus Hagander írta:
Also, a question was buried in the other review which is - are we OK
to remove the requiressl parameter. Both these
On Thursday, November 22, 2012 10:09 PM Fujii Masao wrote:
On Thu, Nov 22, 2012 at 9:38 PM, Amit kapila amit.kap...@huawei.com
wrote:
Patch to implement SET PERSISTENT command is attached with this mail.
Now it can be reviewed.
I got the following compile warnings:
xact.c:1847: warning:
Hello
2012/11/23 Asif Rehman asifr.reh...@gmail.com:
Hi,
I forgot to add documentation changes in the earlier patch. In the attached
patch, I have added documentation as well as fixed other issues you raised.
ok
so
* applied and compiled cleanly
* All 133 tests passed.
* there are doc
*
On Fri, Nov 23, 2012 at 6:30 AM, Fujii Masao masao.fu...@gmail.com wrote:
On Thu, Nov 22, 2012 at 10:05 PM, Boszormenyi Zoltan z...@cybertec.at wrote:
2012-11-22 12:44 keltezéssel, Magnus Hagander írta:
Also, a question was buried in the other review which is - are we OK
to remove the
Shouldn't that data be in the shared buffers if not the OS cache and hence
approximately same IO will be required?
I don't think so as the data in OS cache or PG Shared buffers doesn't have
any direct relation, OS can flush its buffers based on its scheduler
algorithm.
Let us try to see by
On 15.11.2012 17:16, Heikki Linnakangas wrote:
On 15.11.2012 16:55, Tom Lane wrote:
Heikki Linnakangashlinnakan...@vmware.com writes:
This is a fairly general issue, actually. Looking around, I can see at
least two similar cases in existing code, with BasicOpenFile, where we
will leak file
On Thu, Nov 22, 2012 at 06:09:20PM +0800, Chen Huajun wrote:
When use a struct variable whose name length is very very long such as 12KB
in .pgc source,
ecpg will core dump because of buffer overflow if precompile the .pgc file.
How on earth did you run into this? :)
I absolutely agree that
On Sat, Nov 17, 2012 at 2:48 AM, Phil Sorber p...@omniti.com wrote:
On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Nov 16, 2012 at 12:34 PM, Phil Sorber p...@omniti.com wrote:
On Thu, Nov 15, 2012 at 9:23 PM, Michael Paquier
Merlin Moncure wrote:
Kevin Grittner kevin.gritt...@wicourts.gov wrote:
Merlin Moncure mmonc...@gmail.com wrote:
Hm, I bet it's possible (although probably not easy) to deduce
volatility from the function body...maybe through the validator.
If you could do that (perhaps warning in cases
Henning,
On 11/23/2012 03:17 PM, Henning Mälzer wrote:
Can somebody help me?
Sure, but you might get better answers on the -hackers mailing list. I'm
redirecting there. The cluster-hackers one is pretty low volume and low
subscribers, I think.
Question:
What would be the loss if i cut
Jan,
Are you posting an updated patch?
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
If the bgworker developer gets really tense about this stuff (or
anything at all, really), they can create a completely new sigmask and
do sigaddset() etc. Since this is all C code, we cannot keep them from
doing anything, really; I think what
Cyril VELTER cyril.vel...@metadys.com writes:
I follow up on my previous message. Just got two more crash today very
similar to the first ones :
PANIC: could not write to log file 118, segment 237 at offset 2686976,
length 5578752: Invalid argument
STATEMENT: COMMIT
PANIC: could not
On Fri, Nov 23, 2012 at 6:56 PM, Amit Kapila amit.kap...@huawei.com wrote:
When I remove postgresql.auto.conf, SET PERSISTENT failed.
=# SET PERSISTENT synchronous_commit = 'local';
ERROR: failed to open postgresql.auto.conf file
There can be 2 ways to handle this, either we recreate the
On Thu, Nov 15, 2012 at 07:05:00PM -0800, Jeff Janes wrote:
On Wed, Nov 14, 2012 at 11:49 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Jeff Janes jeff.ja...@gmail.com writes:
On Thu, Nov 8, 2012 at 9:50 PM, Tom Lane t...@sss.pgh.pa.us wrote:
There are at least three ways we could whack that mole:
On 09.11.2012 15:28, Fujii Masao wrote:
On Fri, Nov 9, 2012 at 4:06 AM, Alvaro Herreraalvhe...@2ndquadrant.com wrote:
Fujii Masao escribió:
On Fri, Oct 19, 2012 at 10:29 PM, Fujii Masaomasao.fu...@gmail.com wrote:
However, I've forgotten to treat other three portions in
walsender.c and
Hello
2012/11/22 Dimitri Fontaine dimi...@2ndquadrant.fr:
Hi,
Thank you Pavel for reviewing my patch! :)
Pavel Stehule pavel.steh...@gmail.com writes:
* issues
** missing doc
Yes. I wanted to reach an agreement on why we need the de parsing for.
You can read the Last comment we made
Heikki Linnakangas hlinnakan...@vmware.com writes:
Committed, thanks.
Doesn't seem to have been pushed to master?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On 23.11.2012 19:55, Tom Lane wrote:
Heikki Linnakangashlinnakan...@vmware.com writes:
Committed, thanks.
Doesn't seem to have been pushed to master?
On purpose. Per commit message:
9.3 doesn't have this problem because XLogRecPtr is now a single 64-bit
integer, so XLogRecPtrIsInvalid()
On Friday, November 23, 2012 11:15 AM Pavan Deolasee wrote:
On Thu, Nov 22, 2012 at 2:05 PM, Amit Kapila amit.kap...@huawei.com wrote:
Sorry, I haven't followed this thread at all, but the numbers (43171 and
57920) in the last two runs of @mv-free-list for 32 clients look
aberrations, no ? I
On Wed, Nov 21, 2012 at 5:48 AM, Karl O. Pinc k...@meme.com wrote:
On Fri, Sep 21, 2012 at 8:54 AM, Karl O. Pinc k...@meme.com wrote:
On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote:
OT:
After looking at the code I found a number of conflicting
option combinations are not tested for or
Pavel Stehule pavel.steh...@gmail.com writes:
* some wrong in deparsing - doesn't support constraints
postgres=# alter table a add column bbbsss int check (bbbsss 0);
NOTICE: event: ddl_command_start, context: TOPLEVEL, tag: ALTER
TABLE, operation: ALTER, type: TABLE, schema: NULL, name:
On Wed, 2012-11-21 at 11:46 -0800, Jeff Janes wrote:
Using gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4), I get dozens of
warnings, all apparently coming from somewhere in the MemSet macro.
OK, reverted.
It looks like they dialed it down to a more useful volume in GCC 4.5,
but that doesn't
Alvaro Herrera wrote:
Are you posting an updated patch?
Well, there wasn't exactly a consensus on what should change, so I'll
throw some initial review comments out even though I still need to
check some things in the code and do more testing.
The patch applied cleanly, compiled without
Robert Haas escribió:
On Thu, Oct 25, 2012 at 4:25 AM, Simon Riggs si...@2ndquadrant.com wrote:
I'd put these in a separate directory to avoid annoyance. Transam is
already too large.
+1. A further advantage of that is that it means that that everything
in that new directory will be
On Thu, Nov 15, 2012 at 7:05 PM, Jeff Janes jeff.ja...@gmail.com wrote:
On Wed, Nov 14, 2012 at 11:49 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Jeff Janes jeff.ja...@gmail.com writes:
On Thu, Nov 8, 2012 at 9:50 PM, Tom Lane t...@sss.pgh.pa.us wrote:
There are at least three ways we could whack
On 23 November 2012 22:52, Alvaro Herrera alvhe...@2ndquadrant.com wrote:
./access/rmgrdesc/xact_desc.c
./access/rmgrdesc/heapdesc.c
Could we have either all underscores _ or none at all for the naming?
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development,
Alvaro Herrera alvhe...@2ndquadrant.com writes:
So incorporating these ideas, the layout now looks like this:
./commands/seq_desc.c
./commands/dbase_desc.c
./commands/tablespace_desc.c
./catalog/storage_desc.c
./utils/cache/relmap_desc.c
./access/rmgrdesc/mxact_desc.c
On Mon, Nov 19, 2012 at 12:11:26PM -0800, Jeff Janes wrote:
[ Sorry for the delay in replying.]
On Wed, Nov 14, 2012 at 3:55 PM, Bruce Momjian br...@momjian.us wrote:
On Mon, Nov 12, 2012 at 10:29:39AM -0800, Jeff Janes wrote:
Is turning off synchronous_commit enough? What about turning
On Wed, Nov 14, 2012 at 06:28:41PM -0500, Bruce Momjian wrote:
On Wed, Nov 14, 2012 at 06:15:30PM -0500, Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
On Wed, Nov 14, 2012 at 05:39:29PM -0500, Tom Lane wrote:
You would have been better off keeping the array and sorting it so you
On Friday, November 23, 2012 10:10 PM Fujii Masao wrote:
On Fri, Nov 23, 2012 at 6:56 PM, Amit Kapila amit.kap...@huawei.com wrote:
When I remove postgresql.auto.conf, SET PERSISTENT failed.
=# SET PERSISTENT synchronous_commit = 'local';
ERROR: failed to open postgresql.auto.conf file
32 matches
Mail list logo
