Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Dean Rasheed
On 8 December 2012 23:29, Tom Lane t...@sss.pgh.pa.us wrote: Dean Rasheed dean.a.rash...@gmail.com writes: Attached is a rebased patch using new OIDs. Applied after a fair amount of hacking. Awesome! Thank you very much. Regards, Dean -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Thom Brown
On 8 December 2012 23:29, Tom Lane t...@sss.pgh.pa.us wrote: Dean Rasheed dean.a.rash...@gmail.com writes: Attached is a rebased patch using new OIDs. Applied after a fair amount of hacking. One observation: There doesn't appear to be any tab-completion for view names after DML statement

Re: [HACKERS] pg_basebackup is taking backup of extra files inside a tablespace directory

2012-12-09 Thread Magnus Hagander
On Fri, Nov 30, 2012 at 8:30 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu haribabu.ko...@huawei.com wrote: I think backup should be done only files and folders present inside '/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY). Not all the

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-09 Thread Fujii Masao
On Thu, Dec 6, 2012 at 8:39 PM, Amit Kapila amit.kap...@huawei.com wrote: On Thursday, December 06, 2012 9:35 AM Kyotaro HORIGUCHI wrote: Hello, I have a problem with PostgreSQL 9.2 with Pacemaker. HA standby sometime failes to start under normal operation. Testing with a bare replication

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-09 Thread Fujii Masao
On Thu, Dec 6, 2012 at 1:04 PM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c index 993bc49..d34ab65 100644 --- a/src/backend/catalog/storage.c +++ b/src/backend/catalog/storage.c @@ -519,6 +519,12 @@

Re: [HACKERS] CommitFest #3 and upcoming schedule

2012-12-09 Thread Simon Riggs
On 16 November 2012 07:20, Greg Smith g...@2ndquadrant.com wrote: Project guidelines now ask each patch submitter to review patches of the same number and approximate complexity as they submit. If you've submitted some items to the CommitFest, please look at the open list and try to find

Re: [HACKERS] Commits 8de72b and 5457a1 (COPY FREEZE)

2012-12-09 Thread Simon Riggs
On 8 December 2012 22:18, Stephen Frost sfr...@snowman.net wrote: So the committed feature does address the visibility issue. Not hardly. It lets a user completely violate the basic rules of the overall database. The *correct* solution to this problem is to actually *fix* it, by setting it

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Tom Lane
Thom Brown t...@linux.com writes: One observation: There doesn't appear to be any tab-completion for view names after DML statement keywords in psql. Might we want to add this? Well, there is, but it only knows about INSTEAD OF trigger cases. I'm tempted to suggest that

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-12-09 Thread Simon Riggs
On 8 December 2012 15:14, Tom Lane t...@sss.pgh.pa.us wrote: Maybe the best way is to admit that we need a short-term exclusive lock for the swapping step. Which wouldn't be so bad if this is just for the toast index, since in many cases the index itself is completely empty anyway, which must

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-12-09 Thread Jan Wieck
I am aware that in the case at hand, the call to make_fn_arguments() is with the only possible candidate function, so changing COERCE_IMPLICIT to COERCE_ASSIGNMENT inside of make_fn_arguments() is correct. But I wonder if this may have any unwanted side effects for other code paths to

Re: [HACKERS] Review of Row Level Security

2012-12-09 Thread Simon Riggs
On 9 December 2012 06:21, Kohei KaiGai kai...@kaigai.gr.jp wrote: 2012/12/7 Simon Riggs si...@2ndquadrant.com: On 5 December 2012 11:16, Kohei KaiGai kai...@kaigai.gr.jp wrote: Oracle defaults to putting VPD on all event types: INSERT, UPDATE, DELETE, SELECT. ISTM we should be doing the same,

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2012-12-09 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On 8 December 2012 15:14, Tom Lane t...@sss.pgh.pa.us wrote: Or we could wait for MVCC catalog access ... If there was a published design for that, it would help believe in it more. Do you think one exists? Well, there have been discussion threads

Re: [HACKERS] Review of Row Level Security

2012-12-09 Thread Simon Riggs
On 9 December 2012 06:08, Kohei KaiGai kai...@kaigai.gr.jp wrote: 2012/12/7 Simon Riggs si...@2ndquadrant.com: On 5 December 2012 11:16, Kohei KaiGai kai...@kaigai.gr.jp wrote: * TRUNCATE works, and allows you to remove all rows of a table, even ones you can't see to run a DELETE on. Er...

Re: [HACKERS] New statistics for WAL buffer dirty writes

2012-12-09 Thread Tomas Vondra
On 29.10.2012 04:58, Satoshi Nagayasu wrote: 2012/10/24 1:12, Alvaro Herrera wrote: Satoshi Nagayasu escribi�: With this patch, walwriter process and each backend process would sum up dirty writes, and send it to the stat collector. So, the value could be saved in the stat file, and could be

Re: [HACKERS] Commits 8de72b and 5457a1 (COPY FREEZE)

2012-12-09 Thread Noah Misch
On Wed, Dec 05, 2012 at 07:43:08PM -0500, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Dec 4, 2012 at 3:38 PM, Jeff Davis pg...@j-davis.com wrote: After reading that thread, I still don't understand why it's unsafe to set HEAP_XMIN_COMMITTED in those conditions. Even if

Re: [HACKERS] CommitFest #3 and upcoming schedule

2012-12-09 Thread Tomas Vondra
On 9.12.2012 16:56, Simon Riggs wrote: On 16 November 2012 07:20, Greg Smith g...@2ndquadrant.com wrote: Project guidelines now ask each patch submitter to review patches of the same number and approximate complexity as they submit. If you've submitted some items to the CommitFest, please

Re: [HACKERS] xlogreader v3/xlogdump v2

2012-12-09 Thread Andres Freund
Hi, On 2012-12-04 18:52:13 +0100, Andres Freund wrote: At http://git.postgresql.org/gitweb/?p=users/andresfreund/postgres.git;a=shortlog;h=refs/heads/xlogreader_v3 git://git.postgresql.org/git/users/andresfreund/postgres.git you can find my attempt trying to bring the xlogreader from Heikki,

Re: [HACKERS] Unresolved error 0xC0000409 on Windows Server

2012-12-09 Thread Matthew Gerber
All, I have successfully isolated this error and created a simple SQL script to reproduce it. Just to recap - this script will cause a server crash with exception 0xC409 as described in previous emails. The crux of the problem seems to be my creation / use of the function st_transform_null.

Re: [HACKERS] logical changeset generation v3 - git repository

2012-12-09 Thread Andres Freund
On 2012-11-15 02:26:53 +0100, Andres Freund wrote: On 2012-11-15 01:27:46 +0100, Andres Freund wrote: In response to this you will soon find the 14 patches that currently implement $subject. As its not very wieldly to send around that many/big patches all the time, until the next major

[HACKERS] Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader

2012-12-09 Thread Andres Freund
On 2012-11-15 16:22:56 +0200, Heikki Linnakangas wrote: On 15.11.2012 03:17, Andres Freund wrote: Features: - streaming reading/writing - filtering - reassembly of records Reusing the ReadRecord infrastructure in situations where the code that wants to do so is not tightly integrated

Re: [HACKERS] autovacuum truncate exclusive lock round two

2012-12-09 Thread Kevin Grittner
Jan Wieck wrote: Based on the discussion and what I feel is a consensus I have created an updated patch that has no GUC at all. The hard coded parameters in include/postmaster/autovacuum.h are  AUTOVACUUM_TRUNCATE_LOCK_CHECK_INTERVAL 20 /* ms */  AUTOVACUUM_TRUNCATE_LOCK_WAIT_INTERVAL 50

Re: [HACKERS] Commits 8de72b and 5457a1 (COPY FREEZE)

2012-12-09 Thread Noah Misch
On Fri, Dec 07, 2012 at 06:51:18PM -0500, Stephen Frost wrote: * Jeff Davis (pg...@j-davis.com) wrote: Most of your concerns seem to be related to freezing, and I'm mostly interested in HEAP_XMIN_COMMITTED optimizations. So I think we're talking past each other. My concern is about this

[HACKERS] Submission Review: User control over psql error stream

2012-12-09 Thread Alastair Turner
Hi Karl, I have given the patch a quick review and read the related mails following its initial submission. I agree with that functionality along these lines is desirable. The ability to manage output from within psql at least as richly as is possible with shell redirection - and change it

Re: [HACKERS] Review of Row Level Security

2012-12-09 Thread Kohei KaiGai
2012/12/9 Simon Riggs si...@2ndquadrant.com: On 9 December 2012 06:08, Kohei KaiGai kai...@kaigai.gr.jp wrote: 2012/12/7 Simon Riggs si...@2ndquadrant.com: On 5 December 2012 11:16, Kohei KaiGai kai...@kaigai.gr.jp wrote: * TRUNCATE works, and allows you to remove all rows of a table, even

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Dean Rasheed
On 9 December 2012 16:53, Tom Lane t...@sss.pgh.pa.us wrote: Thom Brown t...@linux.com writes: One observation: There doesn't appear to be any tab-completion for view names after DML statement keywords in psql. Might we want to add this? Well, there is, but it only knows about INSTEAD OF

Re: [HACKERS] CommitFest #3 and upcoming schedule

2012-12-09 Thread Jeff Janes
On Sun, Dec 9, 2012 at 10:47 AM, Tomas Vondra t...@fuzzy.cz wrote: IMHO many of the patches that are currently marked as needs review and have no reviewers, were actually reviewed or are being discussed thoroughly on the list, but this information was not propagated to the CF page. Should

Re: [HACKERS] Submission Review: User control over psql error stream

2012-12-09 Thread Karl O. Pinc
Hi Alastair, On 12/09/2012 02:13:32 PM, Alastair Turner wrote: Hi Karl, I have given the patch a quick review and read the related mails following its initial submission. Thank you very much. - It's closed ended - there are three things about error output which affect where it's written

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Tom Lane
Dean Rasheed dean.a.rash...@gmail.com writes: It's a shame though that pg_view_is_updatable() and pg_view_is_insertable() are not really useful for identifying potentially updatable views (e.g., consider an auto-updatable view on top of a trigger-updatable view). I'm left wondering if I

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Dean Rasheed
On 9 December 2012 22:00, Tom Lane t...@sss.pgh.pa.us wrote: Dean Rasheed dean.a.rash...@gmail.com writes: It's a shame though that pg_view_is_updatable() and pg_view_is_insertable() are not really useful for identifying potentially updatable views (e.g., consider an auto-updatable view on

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Simon Riggs
On 9 December 2012 22:00, Tom Lane t...@sss.pgh.pa.us wrote: Dean Rasheed dean.a.rash...@gmail.com writes: It's a shame though that pg_view_is_updatable() and pg_view_is_insertable() are not really useful for identifying potentially updatable views (e.g., consider an auto-updatable view on

Re: [HACKERS] CommitFest #3 and upcoming schedule

2012-12-09 Thread Tomas Vondra
On 9.12.2012 22:41, Jeff Janes wrote: On Sun, Dec 9, 2012 at 10:47 AM, Tomas Vondra t...@fuzzy.cz wrote: IMHO many of the patches that are currently marked as needs review and have no reviewers, were actually reviewed or are being discussed thoroughly on the list, but this information was not

Re: [HACKERS] Proof of concept: auto updatable views [Review of Patch]

2012-12-09 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On 9 December 2012 22:00, Tom Lane t...@sss.pgh.pa.us wrote: But in any case, those functions are expensive enough that I can't see running them against every view in the DB anytime somebody hits tab. I think just allowing tab-completion to include all

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-09 Thread Kyotaro HORIGUCHI
Thank you. I think moving CheckRecoveryConsistency() after redo apply loop might cause a problem. As currently it is done before recoveryStopsHere() function, which can allow connections on HOTSTANDY. But now if due to some reason recovery pauses or stops due to above function,

Re: [HACKERS] [BUG?] lag of minRecoveryPont in archive recovery

2012-12-09 Thread Kyotaro HORIGUCHI
Hello, I think that minRecoveryPoint should be updated before the data-file changes, so XLogFlush() should be called before smgrtruncate(). No? Mmm.. As far as I saw in xact_redo_commit_internal, XLogFlush seems should be done AFTER redo substantial operation. Is it wrong? If so, I suppose

Re: [HACKERS] Submission Review: User control over psql error stream

2012-12-09 Thread Karl O. Pinc
On 12/09/2012 03:58:26 PM, Karl O. Pinc wrote: Hi Alastair, On 12/09/2012 02:13:32 PM, Alastair Turner wrote: - It's closed ended - there are three things about error output which affect where it's written to: does it go to query output, does it go somewhere else (a file or pipe),

Re: [HACKERS] CommitFest #3 and upcoming schedule

2012-12-09 Thread Amit Kapila
On Sunday, December 09, 2012 9:27 PM Simon Riggs On 16 November 2012 07:20, Greg Smith g...@2ndquadrant.com wrote: Let's bring balance to the situation through our own actions. Please review one patch now for every one you submitted. In CF-3, I am Author of 5 and Reviewer of 5 3 of my

Re: [HACKERS] [PATCH]Tablesample Submission

2012-12-09 Thread Jaime Casanova
On Sun, Nov 4, 2012 at 10:22 PM, Qi Huang huangq...@outlook.com wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is full of Postgres mails and I didn't notice the one for me, my mail box configuration problem. I am

Re: [HACKERS] [PATCH] PL/Python: Add spidata to all spiexceptions

2012-12-09 Thread Karl O. Pinc
Hi, I don't feel particularly qualified to comment, but in the interest of (hopefully) helping with the patch review process I'm going to comment anyway. (Having written this, I feel decidedly unqualified to critique so please keep this in mind when considering my comments.) On 10/31/2012

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2012-12-09 Thread Shigeru Hanada
On Sun, Dec 9, 2012 at 1:07 AM, Tomas Vondra t...@fuzzy.cz wrote: * If you're dropping a single table, it really does not matter - the difference will be like 100 ms vs. 200 ms or something like that. Did you try dropping 10,000 tables in 100 batches, as same as previous post? If so the